[GitHub] [netbeans] zimmi commented on issue #1548: [NETBEANS-1396] Missing code completion and Javadocs in maven projects with classifier

2020-01-30 Thread GitBox
zimmi commented on issue #1548: [NETBEANS-1396] Missing code completion and Javadocs in maven projects with classifier URL: https://github.com/apache/netbeans/pull/1548#issuecomment-580459534 Thank you for merging! I got a new job and didn't have much time to dedicate to this. I might

[GitHub] [netbeans] zimmi commented on issue #1548: [NETBEANS-1396] Missing code completion and Javadocs in maven projects with classifier

2019-11-21 Thread GitBox
zimmi commented on issue #1548: [NETBEANS-1396] Missing code completion and Javadocs in maven projects with classifier URL: https://github.com/apache/netbeans/pull/1548#issuecomment-557322750 Thank you for testing it again, John! There are many small things to improve, it's great to have

[GitHub] [netbeans] zimmi commented on issue #1548: [NETBEANS-1396] Missing code completion and Javadocs in maven projects with classifier

2019-11-20 Thread GitBox
zimmi commented on issue #1548: [NETBEANS-1396] Missing code completion and Javadocs in maven projects with classifier URL: https://github.com/apache/netbeans/pull/1548#issuecomment-556038161 I forgot to switch the Java Platform for the project from JDK 8 to JDK 13. As soon as I do that,

[GitHub] [netbeans] zimmi commented on issue #1548: [NETBEANS-1396] Missing code completion and Javadocs in maven projects with classifier

2019-11-18 Thread GitBox
zimmi commented on issue #1548: [NETBEANS-1396] Missing code completion and Javadocs in maven projects with classifier URL: https://github.com/apache/netbeans/pull/1548#issuecomment-554907412 You are right, sorry for that! I'll merge master in the future.

[GitHub] [netbeans] zimmi commented on issue #1548: [NETBEANS-1396] Missing code completion and Javadocs in maven projects with classifier

2019-11-17 Thread GitBox
zimmi commented on issue #1548: [NETBEANS-1396] Missing code completion and Javadocs in maven projects with classifier URL: https://github.com/apache/netbeans/pull/1548#issuecomment-554798440 @jgneff Would you mind testing it again? I rebased onto the master branch and now source

[GitHub] [netbeans] zimmi commented on issue #1548: [NETBEANS-1396] Missing code completion and Javadocs in maven projects with classifier

2019-11-15 Thread GitBox
zimmi commented on issue #1548: [NETBEANS-1396] Missing code completion and Javadocs in maven projects with classifier URL: https://github.com/apache/netbeans/pull/1548#issuecomment-554431763 Just for future reference, the algorithm doesn't work for the new [`@extLink`

[GitHub] [netbeans] zimmi commented on issue #1548: [NETBEANS-1396] Missing code completion and Javadocs in maven projects with classifier

2019-11-10 Thread GitBox
zimmi commented on issue #1548: [NETBEANS-1396] Missing code completion and Javadocs in maven projects with classifier URL: https://github.com/apache/netbeans/pull/1548#issuecomment-552179575 The point about attached Javadoc substituting missing comments in the attached Source is subtle,

[GitHub] [netbeans] zimmi commented on issue #1548: [NETBEANS-1396] Missing code completion and Javadocs in maven projects with classifier

2019-11-09 Thread GitBox
zimmi commented on issue #1548: [NETBEANS-1396] Missing code completion and Javadocs in maven projects with classifier URL: https://github.com/apache/netbeans/pull/1548#issuecomment-552133026 After some digging, here are my findings. The algorithm to find the javadoc goes as follows:

[GitHub] [netbeans] zimmi commented on issue #1548: [NETBEANS-1396] Missing code completion and Javadocs in maven projects with classifier

2019-11-08 Thread GitBox
zimmi commented on issue #1548: [NETBEANS-1396] Missing code completion and Javadocs in maven projects with classifier URL: https://github.com/apache/netbeans/pull/1548#issuecomment-551968629 @matthiasblaesing I am not sure yet, I need more time to investigate. Can I tag you when I find

[GitHub] [netbeans] zimmi commented on issue #1548: [NETBEANS-1396] Missing code completion and Javadocs in maven projects with classifier

2019-11-08 Thread GitBox
zimmi commented on issue #1548: [NETBEANS-1396] Missing code completion and Javadocs in maven projects with classifier URL: https://github.com/apache/netbeans/pull/1548#issuecomment-551479010 Thank you so much for the detailed writeup @jgneff! Those are some good test cases, I will