Chris2011 commented on issue #3: NETBEANS-59 - Document split actions
URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-421826446
I can understand your point but first, my commit message is exact that, what
the commit means. Maybe it is only a wording for sure and I
Chris2011 commented on issue #3: NETBEANS-59 - Document split actions
URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-421802077
Done.
This is an automated message from the Apache Git Service.
To respond
Chris2011 commented on issue #3: NETBEANS-59 - Document split actions
URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-421637536
Hm, ok. I thoght they will merged together. The Message too. But this should
Not be a Problem now. Now I know it and will make it better
Chris2011 commented on issue #3: NETBEANS-59 - Document split actions
URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-421619118
Got it.
This is an automated message from the Apache Git Service.
To
Chris2011 commented on issue #3: NETBEANS-59 - Document split actions
URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-421616981
It doesn't make sense to change it now to LF and amend the commit, right? Do
I have to do it again? I mean applying the patch and fix the
Chris2011 commented on issue #3: NETBEANS-59 - Document split actions
URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-421616860
Hm, I closed the file and reopened it, now it is CRLF, will fix it.
This is
Chris2011 commented on issue #3: NETBEANS-59 - Document split actions
URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-421616579
This is what I said, I already checked all files, expecially SplitAction. I
change the line endings from CRLF to Unix LF before I applied
Chris2011 commented on issue #3: NETBEANS-59 - Document split actions
URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-421601294
So now, everyhing should be fine now. I renamed the old branch, made a clean
one, updated all branches that is needed, applied the patch,
Chris2011 commented on issue #3: NETBEANS-59 - Document split actions
URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-394144054
Will try that. Thx.
This is an automated message from the Apache Git
Chris2011 commented on issue #3: NETBEANS-59 - Document split actions
URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-394090220
@junichi11 Sry, I missed the point with the header. Will fix it. Thx. Yeah
maybe I need some help with that, what is not working out. I
Chris2011 commented on issue #3: NETBEANS-59 - Document split actions
URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-394086915
@emilianbold thx for your opinion and I really know what you mean. I will be
more strict in the next PRs and will keep your opinion in mind
Chris2011 commented on issue #3: NETBEANS-59 - Document split actions
URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-393828144
But in my opinion, this shouldn't be so bad to merge it now. It is as it is,
but the concept was to make is simple and only do, what needed.
Chris2011 commented on issue #3: NETBEANS-59 - Document split actions
URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-393827803
I thought I only added that, what emi suggested. So after this, the merge
was kind of "broken" so I tried to fix it manually.
Chris2011 commented on issue #3: NETBEANS-59 - Document split actions
URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-393158077
@emilianbold can you check it again please?
This is an automated message
Chris2011 commented on issue #3: NETBEANS-59 - Document split actions
URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-391383476
I fixed most of the requested changes now.
This is an automated message
Chris2011 commented on issue #3: NETBEANS-59 - Document split actions
URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-388706086
Hm, maybe there was smth wrong with the merge :/. Sry about that. Will
change and test it later. Thx @emilianbold
Chris2011 commented on issue #3: NETBEANS-59 - Document split actions
URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-383603129
So now I tested and merged the changes from @emilianbold PR to my PR. Hope
now everything is fine.
Chris2011 commented on issue #3: NETBEANS-59 - Document split actions
URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-378494797
@emilianbold sure your approach should work too. As I said, I wanted to
refactor the code a bit too.
Chris2011 commented on issue #3: NETBEANS-59 - Document split actions
URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-378494797
@emilianbold as I understand it right, you wanted to leave the existing code
as it is, right? Only adding those 3 missing actions? When I
Chris2011 commented on issue #3: NETBEANS-59 - Document split actions
URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-378494239
The reason for changing was, I changed the code anyway so why not doing a
bit of refactoring like decouple them into separate action
Chris2011 commented on issue #3: NETBEANS-59 - Document split actions
URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-377896314
@geertjanw right. We don't see any other problems with that stuff. Maybe an
other can test it before, if someone wants it. But from our pov,
Chris2011 commented on issue #3: NETBEANS-59 - Document split actions
URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-377686391
@sdedic markiewb and me had a coding session yesterday. Big thx to him. He
helped me a lot with other stuff and with this PR. So in general
Chris2011 commented on issue #3: NETBEANS-59 - Document split actions
URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-358611545
@sdedic thx for reviewing, I will have a look later.
This is an automated
Chris2011 commented on issue #3: NETBEANS-59 - Document split actions
URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-358611486
@dtrebbien thx for the explanation, the refactoring was needed to added the
ActionIds, I tried it before I refactored the code, because that
Chris2011 commented on issue #3: NETBEANS-59 - Document split actions
URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-355777327
Can someone have a look now, please? :)
This is an automated message from
25 matches
Mail list logo
