JaroslavTulach closed pull request #501: Silly use of Boolean URL: https://github.com/apache/incubator-netbeans/pull/501
This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/maven/src/org/netbeans/modules/maven/queries/ShadePluginDetector.java b/maven/src/org/netbeans/modules/maven/queries/ShadePluginDetector.java index 4a3caae00..45c89c3b4 100644 --- a/maven/src/org/netbeans/modules/maven/queries/ShadePluginDetector.java +++ b/maven/src/org/netbeans/modules/maven/queries/ShadePluginDetector.java @@ -62,8 +62,8 @@ private boolean calculateValue() { if (PluginPropertyUtils.getPluginVersion(nbmp.getMavenProject(), Constants.GROUP_APACHE_PLUGINS, "maven-shade-plugin") == null) { return true; } - Boolean toret = Boolean.valueOf(PluginPropertyUtils.getPluginProperty(project, Constants.GROUP_APACHE_PLUGINS, "maven-shade-plugin", "shadedArtifactAttached", "shade", null)); - if (toret == Boolean.FALSE) { + boolean toret = Boolean.parseBoolean(PluginPropertyUtils.getPluginProperty(project, Constants.GROUP_APACHE_PLUGINS, "maven-shade-plugin", "shadedArtifactAttached", "shade", null)); + if (!toret) { if (pr != null) { pr.addReport(PROBLEM_REPORT); } ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists