Re: [I] Declarative hint variable seems to capture too much [netbeans]

2024-03-19 Thread via GitHub
mbien closed issue #7078: Declarative hint variable seems to capture too much URL: https://github.com/apache/netbeans/issues/7078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Declarative hint variable seems to capture too much [netbeans]

2024-02-19 Thread via GitHub
mbien commented on issue #7078: URL: https://github.com/apache/netbeans/issues/7078#issuecomment-1952730925 right I think it is two things we see here: 1) the UI code which builds the "rewrite to" string was wrong (it had multiple issues). I didn't know that at first and assumed that

Re: [I] Declarative hint variable seems to capture too much [netbeans]

2024-02-19 Thread via GitHub
lahodaj commented on issue #7078: URL: https://github.com/apache/netbeans/issues/7078#issuecomment-1952692634 When matching, the variable will be put into both `variables` and `variables2Name`, to keep other stuff (like conditions) working. I suspect we need to keep this, and this is more

Re: [I] Declarative hint variable seems to capture too much [netbeans]

2024-02-18 Thread via GitHub
mbien commented on issue #7078: URL: https://github.com/apache/netbeans/issues/7078#issuecomment-1951475729 what if the `TreePath` is correct but the `toString()` of its leaf is not? the tree of `$name` is a `VariableTree`, getName() would return the identifier. We could fix this via