mbien merged PR #7053:
URL: https://github.com/apache/netbeans/pull/7053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mbien commented on PR #7053:
URL: https://github.com/apache/netbeans/pull/7053#issuecomment-1956409705
- the two largest PRs https://github.com/apache/netbeans/pull/6960 and
https://github.com/apache/netbeans/pull/7056 are both merged
- rebased to latest master (with no conflict which
mbien commented on code in PR #7053:
URL: https://github.com/apache/netbeans/pull/7053#discussion_r1491915007
##
profiler/profiler.api/src/org/netbeans/modules/profiler/api/ProjectUtilities.java:
##
@@ -137,17 +135,9 @@ public static void
mbien commented on code in PR #7053:
URL: https://github.com/apache/netbeans/pull/7053#discussion_r1491915007
##
profiler/profiler.api/src/org/netbeans/modules/profiler/api/ProjectUtilities.java:
##
@@ -137,17 +135,9 @@ public static void
mbien commented on code in PR #7053:
URL: https://github.com/apache/netbeans/pull/7053#discussion_r1491915007
##
profiler/profiler.api/src/org/netbeans/modules/profiler/api/ProjectUtilities.java:
##
@@ -137,17 +135,9 @@ public static void
mbien commented on code in PR #7053:
URL: https://github.com/apache/netbeans/pull/7053#discussion_r1491915007
##
profiler/profiler.api/src/org/netbeans/modules/profiler/api/ProjectUtilities.java:
##
@@ -137,17 +135,9 @@ public static void
mbien commented on code in PR #7053:
URL: https://github.com/apache/netbeans/pull/7053#discussion_r1491911346
##
profiler/profiler.api/src/org/netbeans/modules/profiler/api/ProjectUtilities.java:
##
@@ -137,17 +135,9 @@ public static void
mbien commented on code in PR #7053:
URL: https://github.com/apache/netbeans/pull/7053#discussion_r1491901823
##
profiler/profiler.api/src/org/netbeans/modules/profiler/api/ProjectUtilities.java:
##
@@ -137,17 +135,9 @@ public static void
junichi11 commented on code in PR #7053:
URL: https://github.com/apache/netbeans/pull/7053#discussion_r1491865376
##
java/java.api.common/src/org/netbeans/modules/java/api/common/project/ui/LibrariesNode.java:
##
@@ -1359,7 +1359,7 @@ private FileObject[][] findSourceRoots() {
junichi11 commented on code in PR #7053:
URL: https://github.com/apache/netbeans/pull/7053#discussion_r1491864780
##
java/form/src/org/netbeans/modules/form/palette/PaletteUtils.java:
##
@@ -405,7 +405,7 @@ public static PaletteItem[] getAllItems(boolean
optimalResult) {
junichi11 commented on code in PR #7053:
URL: https://github.com/apache/netbeans/pull/7053#discussion_r1491863260
##
java/debugger.jpda/src/org/netbeans/modules/debugger/jpda/models/AbstractObjectVariable.java:
##
@@ -1021,12 +1021,11 @@ private void initFieldsOfClass (
junichi11 commented on code in PR #7053:
URL: https://github.com/apache/netbeans/pull/7053#discussion_r1491863260
##
java/debugger.jpda/src/org/netbeans/modules/debugger/jpda/models/AbstractObjectVariable.java:
##
@@ -1021,12 +1021,11 @@ private void initFieldsOfClass (
junichi11 commented on code in PR #7053:
URL: https://github.com/apache/netbeans/pull/7053#discussion_r1491862797
##
java/debugger.jpda/src/org/netbeans/modules/debugger/jpda/models/AbstractObjectVariable.java:
##
@@ -1021,12 +1021,11 @@ private void initFieldsOfClass (
junichi11 commented on code in PR #7053:
URL: https://github.com/apache/netbeans/pull/7053#discussion_r1491853427
##
profiler/profiler.ppoints/src/org/netbeans/modules/profiler/ppoints/LoadGenProfilingPoint.java:
##
@@ -218,8 +216,7 @@ protected void refresh() {
junichi11 commented on code in PR #7053:
URL: https://github.com/apache/netbeans/pull/7053#discussion_r1491851828
##
profiler/profiler.api/src/org/netbeans/modules/profiler/api/ProjectUtilities.java:
##
@@ -137,17 +135,9 @@ public static void
mbien commented on PR #7053:
URL: https://github.com/apache/netbeans/pull/7053#issuecomment-1945207149
I think a good way of reviewing cleanups like this is to let github generate
a diff patch for a commit, e.g:
mbien commented on code in PR #7053:
URL: https://github.com/apache/netbeans/pull/7053#discussion_r1490249812
##
php/php.dbgp/src/org/netbeans/modules/php/dbgp/models/ThreadsModel.java:
##
@@ -125,7 +125,7 @@ public Object[] getChildren(Object parent, int from, int to)
tmysik commented on PR #7053:
URL: https://github.com/apache/netbeans/pull/7053#issuecomment-1943734611
@mbien
Thanks a lot for doing this, Michael!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mbien commented on PR #7053:
URL: https://github.com/apache/netbeans/pull/7053#issuecomment-1943688215
@junichi11 yes saw it already, I won't merge before some of the larger
pending PRs are integrated.
--
This is an automated message from the Apache Git Service.
To respond to the
junichi11 commented on PR #7053:
URL: https://github.com/apache/netbeans/pull/7053#issuecomment-1943682919
We have the [PHP feature
branch](https://github.com/apache/netbeans/tree/php-nb22-features) for NB22.
So, please merge this after we merge the PHP feature branch. (I'm going to
merge
junichi11 commented on code in PR #7053:
URL: https://github.com/apache/netbeans/pull/7053#discussion_r1489391144
##
php/php.dbgp/src/org/netbeans/modules/php/dbgp/models/ThreadsModel.java:
##
@@ -125,7 +125,7 @@ public Object[] getChildren(Object parent, int from, int to)
mbien commented on PR #7053:
URL: https://github.com/apache/netbeans/pull/7053#issuecomment-1943609497
@junichi11 @troizet want to look through the PHP commit? (or any other
commits you are interested in)
--
This is an automated message from the Apache Git Service.
To respond to the
22 matches
Mail list logo
