[GitHub] svatoun opened a new pull request #482: Better consistency between SaveCookie presence and modified status

svatoun opened a new pull request #482: Better consistency between SaveCookie presence and modified status URL: https://github.com/apache/incubator-netbeans/pull/482 The overriden setModified() removes save cookie if the "modified" status is false. The trouble is, that if during

[GitHub] sdedic opened a new pull request #484: Allow action hiding in toolbars

sdedic opened a new pull request #484: Allow action hiding in toolbars URL: https://github.com/apache/incubator-netbeans/pull/484 The Editor already contains support for action hiding feature in popup menus. Let's enhance editor toolbars as well.

[GitHub] sdedic opened a new pull request #483: Enable creation using methods with Map parameter

sdedic opened a new pull request #483: Enable creation using methods with Map parameter URL: https://github.com/apache/incubator-netbeans/pull/483 FileSystem implementation supports methodValue attribute for methods, which take Map as a parameter, but the LayerBuilder did not.

[GitHub] JaroslavTulach closed pull request #480: [NETBEANS-410] (partial) Moving test data into the tests themselves.

JaroslavTulach closed pull request #480: [NETBEANS-410] (partial) Moving test data into the tests themselves. URL: https://github.com/apache/incubator-netbeans/pull/480 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] JaroslavTulach commented on issue #480: [NETBEANS-410] (partial) Moving test data into the tests themselves.

JaroslavTulach commented on issue #480: [NETBEANS-410] (partial) Moving test data into the tests themselves. URL: https://github.com/apache/incubator-netbeans/pull/480#issuecomment-378623691 Thanks for eliminating the disturbing files.

[GitHub] sdedic commented on a change in pull request #468: [NETBEANS-463] JDK10: illegalargexception thrown when var type used for instance variables

sdedic commented on a change in pull request #468: [NETBEANS-463] JDK10: illegalargexception thrown when var type used for instance variables URL: https://github.com/apache/incubator-netbeans/pull/468#discussion_r179230552 ## File path:

[GitHub] sdedic commented on a change in pull request #481: [NETBEANS-290] Provided support for hyperlink on dependencies.

sdedic commented on a change in pull request #481: [NETBEANS-290] Provided support for hyperlink on dependencies. URL: https://github.com/apache/incubator-netbeans/pull/481#discussion_r179225386 ## File path:

[GitHub] sdedic commented on a change in pull request #481: [NETBEANS-290] Provided support for hyperlink on dependencies.

sdedic commented on a change in pull request #481: [NETBEANS-290] Provided support for hyperlink on dependencies. URL: https://github.com/apache/incubator-netbeans/pull/481#discussion_r179224485 ## File path:

[GitHub] sdedic commented on a change in pull request #481: [NETBEANS-290] Provided support for hyperlink on dependencies.

sdedic commented on a change in pull request #481: [NETBEANS-290] Provided support for hyperlink on dependencies. URL: https://github.com/apache/incubator-netbeans/pull/481#discussion_r179224625 ## File path:

[GitHub] sdedic commented on a change in pull request #481: [NETBEANS-290] Provided support for hyperlink on dependencies.

sdedic commented on a change in pull request #481: [NETBEANS-290] Provided support for hyperlink on dependencies. URL: https://github.com/apache/incubator-netbeans/pull/481#discussion_r179225950 ## File path:

[GitHub] sdedic commented on a change in pull request #481: [NETBEANS-290] Provided support for hyperlink on dependencies.

sdedic commented on a change in pull request #481: [NETBEANS-290] Provided support for hyperlink on dependencies. URL: https://github.com/apache/incubator-netbeans/pull/481#discussion_r179223345 ## File path:

[GitHub] sdedic commented on a change in pull request #481: [NETBEANS-290] Provided support for hyperlink on dependencies.

sdedic commented on a change in pull request #481: [NETBEANS-290] Provided support for hyperlink on dependencies. URL: https://github.com/apache/incubator-netbeans/pull/481#discussion_r179223199 ## File path:

[GitHub] sdedic commented on a change in pull request #481: [NETBEANS-290] Provided support for hyperlink on dependencies.

sdedic commented on a change in pull request #481: [NETBEANS-290] Provided support for hyperlink on dependencies. URL: https://github.com/apache/incubator-netbeans/pull/481#discussion_r17909 ## File path:

[GitHub] sdedic commented on a change in pull request #481: [NETBEANS-290] Provided support for hyperlink on dependencies.

sdedic commented on a change in pull request #481: [NETBEANS-290] Provided support for hyperlink on dependencies. URL: https://github.com/apache/incubator-netbeans/pull/481#discussion_r179220278 ## File path:

[GitHub] sdedic commented on a change in pull request #481: [NETBEANS-290] Provided support for hyperlink on dependencies.

sdedic commented on a change in pull request #481: [NETBEANS-290] Provided support for hyperlink on dependencies. URL: https://github.com/apache/incubator-netbeans/pull/481#discussion_r179223916 ## File path:

[GitHub] sdedic commented on a change in pull request #481: [NETBEANS-290] Provided support for hyperlink on dependencies.

sdedic commented on a change in pull request #481: [NETBEANS-290] Provided support for hyperlink on dependencies. URL: https://github.com/apache/incubator-netbeans/pull/481#discussion_r179226023 ## File path:

[GitHub] sdedic commented on a change in pull request #481: [NETBEANS-290] Provided support for hyperlink on dependencies.

sdedic commented on a change in pull request #481: [NETBEANS-290] Provided support for hyperlink on dependencies. URL: https://github.com/apache/incubator-netbeans/pull/481#discussion_r179220656 ## File path:

[GitHub] geertjanw commented on issue #484: Allow action hiding in toolbars

geertjanw commented on issue #484: Allow action hiding in toolbars URL: https://github.com/apache/incubator-netbeans/pull/484#issuecomment-378729295 Very useful, thanks. This is an automated message from the Apache Git

[GitHub] geertjanw commented on issue #483: Enable creation using methods with Map parameter

geertjanw commented on issue #483: Enable creation using methods with Map parameter URL: https://github.com/apache/incubator-netbeans/pull/483#issuecomment-378728971 Looks good, thanks! This is an automated message from the

[GitHub] geertjanw commented on issue #485: [NETBEANS-539] Support for JDK 10 and JDK 11 classfiles.

geertjanw commented on issue #485: [NETBEANS-539] Support for JDK 10 and JDK 11 classfiles. URL: https://github.com/apache/incubator-netbeans/pull/485#issuecomment-378728685 Excellent. Merging. This is an automated message

[GitHub] geertjanw closed pull request #476: [NETBEANS-410] remove compiled source code

geertjanw closed pull request #476: [NETBEANS-410] remove compiled source code URL: https://github.com/apache/incubator-netbeans/pull/476 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] mcdonnell-john commented on a change in pull request #481: [NETBEANS-290] Provided support for hyperlink on dependencies.

mcdonnell-john commented on a change in pull request #481: [NETBEANS-290] Provided support for hyperlink on dependencies. URL: https://github.com/apache/incubator-netbeans/pull/481#discussion_r179271809 ## File path:

[GitHub] Chris2011 commented on issue #3: NETBEANS-59 - Document split actions

Chris2011 commented on issue #3: NETBEANS-59 - Document split actions URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-378494239 The reason for changing was, I changed the code anyway so why not doing a bit of refactoring like decouple them into separate action

[GitHub] Chris2011 commented on issue #3: NETBEANS-59 - Document split actions

Chris2011 commented on issue #3: NETBEANS-59 - Document split actions URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-378494797 @emilianbold as I understand it right, you wanted to leave the existing code as it is, right? Only adding those 3 missing actions? When I

[GitHub] Chris2011 commented on issue #3: NETBEANS-59 - Document split actions

Chris2011 commented on issue #3: NETBEANS-59 - Document split actions URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-378494797 @emilianbold sure your approach should work too. As I said, I wanted to refactor the code a bit too.