[GitHub] JaroslavTulach commented on a change in pull request #505: [NETBEANS-615] When nb-javac is not installed, don't let CoS run, but…

JaroslavTulach commented on a change in pull request #505: [NETBEANS-615] When nb-javac is not installed, don't let CoS run, but… URL: https://github.com/apache/incubator-netbeans/pull/505#discussion_r181956914 ## File path:

[GitHub] JaroslavTulach commented on issue #504: Skip CoS copying of class files when the target is already newer, such as from an external compilation

JaroslavTulach commented on issue #504: Skip CoS copying of class files when the target is already newer, such as from an external compilation URL: https://github.com/apache/incubator-netbeans/pull/504#issuecomment-381851991 Robustness is needed. Btw. @jlahoda provided me with a patch

[GitHub] JaroslavTulach closed pull request #501: Silly use of Boolean

JaroslavTulach closed pull request #501: Silly use of Boolean URL: https://github.com/apache/incubator-netbeans/pull/501 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] JaroslavTulach commented on issue #501: Silly use of Boolean

JaroslavTulach commented on issue #501: Silly use of Boolean URL: https://github.com/apache/incubator-netbeans/pull/501#issuecomment-381849389 Čau Jesse. The platform tests are executed by [jenkins](https://builds.apache.org/job/incubator-netbeans-linux/) builds. Nobody runs all the

[GitHub] JaroslavTulach closed pull request #499: [NETBEANS-656] Switch docs URL from netbeans.org to netbeans.apache.org.

JaroslavTulach closed pull request #499: [NETBEANS-656] Switch docs URL from netbeans.org to netbeans.apache.org. URL: https://github.com/apache/incubator-netbeans/pull/499 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] JaroslavTulach commented on a change in pull request #502: #270552: AbstractProjectClassPathImpl subtypes generally need to process Artifact.file to handle timestamped snapshots properly

JaroslavTulach commented on a change in pull request #502: #270552: AbstractProjectClassPathImpl subtypes generally need to process Artifact.file to handle timestamped snapshots properly URL: https://github.com/apache/incubator-netbeans/pull/502#discussion_r181958387 ## File path:

[GitHub] JaroslavTulach commented on a change in pull request #502: #270552: AbstractProjectClassPathImpl subtypes generally need to process Artifact.file to handle timestamped snapshots properly

JaroslavTulach commented on a change in pull request #502: #270552: AbstractProjectClassPathImpl subtypes generally need to process Artifact.file to handle timestamped snapshots properly URL: https://github.com/apache/incubator-netbeans/pull/502#discussion_r181958801 ## File path:

[GitHub] JaroslavTulach commented on a change in pull request #503: #270005: increase the default indexing sleep delay during builds to 15s, and make it configurable

JaroslavTulach commented on a change in pull request #503: #270005: increase the default indexing sleep delay during builds to 15s, and make it configurable URL: https://github.com/apache/incubator-netbeans/pull/503#discussion_r181956454 ## File path:

[GitHub] JaroslavTulach closed pull request #496: [NETBEANS-649] Missing source level 9 and 10 in a NetBeans module project

JaroslavTulach closed pull request #496: [NETBEANS-649] Missing source level 9 and 10 in a NetBeans module project URL: https://github.com/apache/incubator-netbeans/pull/496 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[GitHub] JaroslavTulach closed pull request #498: don't create moe project unless selected

JaroslavTulach closed pull request #498: don't create moe project unless selected URL: https://github.com/apache/incubator-netbeans/pull/498 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] jglick commented on issue #501: Silly use of Boolean

jglick commented on issue #501: Silly use of Boolean URL: https://github.com/apache/incubator-netbeans/pull/501#issuecomment-381607536 Note that I get five test failures in this module, but the same is true in `master`. I guess the Travis build is not yet running tests, so we need to that

[GitHub] JaroslavTulach commented on a change in pull request #500: COS Synchronization is performed at the end of initial scan.

JaroslavTulach commented on a change in pull request #500: COS Synchronization is performed at the end of initial scan. URL: https://github.com/apache/incubator-netbeans/pull/500#discussion_r181717847 ## File path:

[GitHub] JaroslavTulach commented on a change in pull request #500: COS Synchronization is performed at the end of initial scan.

JaroslavTulach commented on a change in pull request #500: COS Synchronization is performed at the end of initial scan. URL: https://github.com/apache/incubator-netbeans/pull/500#discussion_r181717798 ## File path:

[GitHub] jglick opened a new pull request #501: Silly use of Boolean

jglick opened a new pull request #501: Silly use of Boolean URL: https://github.com/apache/incubator-netbeans/pull/501 Originally posted in [bug #208411](https://netbeans.org/bugzilla/show_bug.cgi?id=208411) but never evaluated: just a minor code simplification.

[GitHub] jglick opened a new pull request #502: #270552: AbstractProjectClassPathImpl subtypes generally need to process Artifact.file to handle timestamped snapshots properly

jglick opened a new pull request #502: #270552: AbstractProjectClassPathImpl subtypes generally need to process Artifact.file to handle timestamped snapshots properly URL: https://github.com/apache/incubator-netbeans/pull/502 Submitted around a year ago as the fix for [bug

[GitHub] jlahoda commented on a change in pull request #500: COS Synchronization is performed at the end of initial scan.

jlahoda commented on a change in pull request #500: COS Synchronization is performed at the end of initial scan. URL: https://github.com/apache/incubator-netbeans/pull/500#discussion_r181871244 ## File path:

[GitHub] jlahoda commented on a change in pull request #500: COS Synchronization is performed at the end of initial scan.

jlahoda commented on a change in pull request #500: COS Synchronization is performed at the end of initial scan. URL: https://github.com/apache/incubator-netbeans/pull/500#discussion_r181870454 ## File path:

[GitHub] jlahoda opened a new pull request #505: [NETBEANS-615] When nb-javac is not installed, don't let CoS run, but…

jlahoda opened a new pull request #505: [NETBEANS-615] When nb-javac is not installed, don't let CoS run, but… URL: https://github.com/apache/incubator-netbeans/pull/505 … rather suggest installing nb-javac or disabling CoS.

[GitHub] jtulach commented on issue #498: don't create moe project unless selected

jtulach commented on issue #498: don't create moe project unless selected URL: https://github.com/apache/incubator-netbeans/pull/498#issuecomment-381838786 The change looks good to me and thanks for the test. This is an

[GitHub] junichi11 commented on issue #495: [NETBEANS-648] Cannot select "Source/Binary Format : 10" in a maven project

junichi11 commented on issue #495: [NETBEANS-648] Cannot select "Source/Binary Format : 10" in a maven project URL: https://github.com/apache/incubator-netbeans/pull/495#issuecomment-381588362 @jlahoda Could you please review it? I can be wrong something. Copied

[GitHub] eirikbakke opened a new pull request #506: [NETBEANS-673] Add support for MariaDB JDBC driver in Add Connection wizard

eirikbakke opened a new pull request #506: [NETBEANS-673] Add support for MariaDB JDBC driver in Add Connection wizard URL: https://github.com/apache/incubator-netbeans/pull/506 See https://issues.apache.org/jira/browse/NETBEANS-673