[GitHub] geertjanw closed pull request #525: [NETBEANS-734] Caught exceptions are always non-null.

geertjanw closed pull request #525: [NETBEANS-734] Caught exceptions are always non-null. URL: https://github.com/apache/incubator-netbeans/pull/525 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] geertjanw commented on issue #525: [NETBEANS-734] Caught exceptions are always non-null.

geertjanw commented on issue #525: [NETBEANS-734] Caught exceptions are always non-null. URL: https://github.com/apache/incubator-netbeans/pull/525#issuecomment-387978875 OK, merging. This is an automated message from the

[GitHub] sdedic commented on a change in pull request #507: [NETBEANS-403] Avoid scrolling to end of file if End is pressed while popup is open.

sdedic commented on a change in pull request #507: [NETBEANS-403] Avoid scrolling to end of file if End is pressed while popup is open. URL: https://github.com/apache/incubator-netbeans/pull/507#discussion_r187284421 ## File path:

[GitHub] sdedic commented on a change in pull request #507: [NETBEANS-403] Avoid scrolling to end of file if End is pressed while popup is open.

sdedic commented on a change in pull request #507: [NETBEANS-403] Avoid scrolling to end of file if End is pressed while popup is open. URL: https://github.com/apache/incubator-netbeans/pull/507#discussion_r187284421 ## File path:

[GitHub] rtaneja1 commented on a change in pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes

rtaneja1 commented on a change in pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes URL: https://github.com/apache/incubator-netbeans/pull/533#discussion_r187295717 ## File path:

[GitHub] rtaneja1 commented on a change in pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes

rtaneja1 commented on a change in pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes URL: https://github.com/apache/incubator-netbeans/pull/533#discussion_r187295671 ## File path:

[GitHub] sdedic commented on a change in pull request #519: [NETBEANS-481] JDK10-LVTI: Added new ErrorRule to fix compiler error on initialization of var type variable with array

sdedic commented on a change in pull request #519: [NETBEANS-481] JDK10-LVTI: Added new ErrorRule to fix compiler error on initialization of var type variable with array URL: https://github.com/apache/incubator-netbeans/pull/519#discussion_r187295749 ## File path:

[GitHub] geertjanw commented on issue #521: [NETBEANS-497] Fix for 'var' compound declaration error hints

geertjanw commented on issue #521: [NETBEANS-497] Fix for 'var' compound declaration error hints URL: https://github.com/apache/incubator-netbeans/pull/521#issuecomment-388024397 OK, this is approved by @sdedic. Is there any reason not to merge, any potential side effects?

[GitHub] sdedic commented on issue #528: added unbound generic type argument to Class in BeanNode and Lib

sdedic commented on issue #528: added unbound generic type argument to Class in BeanNode and Lib URL: https://github.com/apache/incubator-netbeans/pull/528#issuecomment-388024366 Don't you want to fix the other warnings in the BeanNode.java file, too :) ?

[GitHub] sdedic commented on a change in pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes

sdedic commented on a change in pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes URL: https://github.com/apache/incubator-netbeans/pull/533#discussion_r187304330 ## File path:

[GitHub] sdedic commented on a change in pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes

sdedic commented on a change in pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes URL: https://github.com/apache/incubator-netbeans/pull/533#discussion_r187303971 ## File path:

[GitHub] rtaneja1 commented on a change in pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes

rtaneja1 commented on a change in pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes URL: https://github.com/apache/incubator-netbeans/pull/533#discussion_r187325989 ## File path:

[GitHub] rtaneja1 commented on a change in pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes

rtaneja1 commented on a change in pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes URL: https://github.com/apache/incubator-netbeans/pull/533#discussion_r187326117 ## File path:

[GitHub] rtaneja1 commented on a change in pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes

rtaneja1 commented on a change in pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes URL: https://github.com/apache/incubator-netbeans/pull/533#discussion_r187326248 ## File path:

[GitHub] geertjanw commented on issue #468: nb-javac jars upgrade for NETBEANS-463 fix

geertjanw commented on issue #468: nb-javac jars upgrade for NETBEANS-463 fix URL: https://github.com/apache/incubator-netbeans/pull/468#issuecomment-387980171 Is there a reason not to merge this? This is an automated

[GitHub] geertjanw commented on issue #514: [NETBEANS-713] Have HighlightingManager properly respond to changes in excludes/includes client property.

geertjanw commented on issue #514: [NETBEANS-713] Have HighlightingManager properly respond to changes in excludes/includes client property. URL: https://github.com/apache/incubator-netbeans/pull/514#issuecomment-387979834 Any reason not to merge this? I will merge in 24 hours unless

[GitHub] geertjanw commented on issue #415: [NETBEANS-365] Allow Harness to be more Friendly

geertjanw commented on issue #415: [NETBEANS-365] Allow Harness to be more Friendly URL: https://github.com/apache/incubator-netbeans/pull/415#issuecomment-387980059 What is the status of this PR? This is an automated

[GitHub] geertjanw closed pull request #495: [NETBEANS-648] Cannot select "Source/Binary Format : 10" in a maven project

geertjanw closed pull request #495: [NETBEANS-648] Cannot select "Source/Binary Format : 10" in a maven project URL: https://github.com/apache/incubator-netbeans/pull/495 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] neilcsmith-net commented on issue #40: Trying to setup a location for updates, redirecting to the synergy VM…

neilcsmith-net commented on issue #40: Trying to setup a location for updates, redirecting to the synergy VM… URL: https://github.com/apache/incubator-netbeans-website/pull/40#issuecomment-387983211 -1 to merging yet :smile: OK, bit late. The redirect should be to https on the VM,

[GitHub] JaroslavTulach commented on issue #415: [NETBEANS-365] Allow Harness to be more Friendly

JaroslavTulach commented on issue #415: [NETBEANS-365] Allow Harness to be more Friendly URL: https://github.com/apache/incubator-netbeans/pull/415#issuecomment-387984766 I am not convinced this PR shall be merged. -1 from me. Feel free to find other +1 to overrule my opinion.

[GitHub] geertjanw commented on issue #514: [NETBEANS-713] Have HighlightingManager properly respond to changes in excludes/includes client property.

geertjanw commented on issue #514: [NETBEANS-713] Have HighlightingManager properly respond to changes in excludes/includes client property. URL: https://github.com/apache/incubator-netbeans/pull/514#issuecomment-387980860 OK, since @sdedic approved, I will merge it now.

[GitHub] geertjanw closed pull request #514: [NETBEANS-713] Have HighlightingManager properly respond to changes in excludes/includes client property.

geertjanw closed pull request #514: [NETBEANS-713] Have HighlightingManager properly respond to changes in excludes/includes client property. URL: https://github.com/apache/incubator-netbeans/pull/514 This is a PR merged from a forked repository. As GitHub hides the original diff on

[GitHub] geertjanw commented on issue #523: Avoid failure of 'ant javadoc' for modules that don't have src dir, l…

geertjanw commented on issue #523: Avoid failure of 'ant javadoc' for modules that don't have src dir, l… URL: https://github.com/apache/incubator-netbeans/pull/523#issuecomment-387979467 Nothing contentious here, simply going to merge this.

[GitHub] geertjanw commented on issue #520: [NETBEANS-317] Ensuring that jars that are augmented with OSGi metada…

geertjanw commented on issue #520: [NETBEANS-317] Ensuring that jars that are augmented with OSGi metada… URL: https://github.com/apache/incubator-netbeans/pull/520#issuecomment-387979242 Should this be merged, any objections? Does @matthiasblaesing comment need to be responded to, does

[GitHub] geertjanw closed pull request #523: Avoid failure of 'ant javadoc' for modules that don't have src dir, l…

geertjanw closed pull request #523: Avoid failure of 'ant javadoc' for modules that don't have src dir, l… URL: https://github.com/apache/incubator-netbeans/pull/523 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] geertjanw closed pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes

geertjanw closed pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes URL: https://github.com/apache/incubator-netbeans/pull/533 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] geertjanw commented on issue #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes

geertjanw commented on issue #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes URL: https://github.com/apache/incubator-netbeans/pull/533#issuecomment-388078938 Great, merging. This is an

[GitHub] eirikbakke commented on a change in pull request #507: [NETBEANS-403] Avoid scrolling to end of file if End is pressed while popup is open.

eirikbakke commented on a change in pull request #507: [NETBEANS-403] Avoid scrolling to end of file if End is pressed while popup is open. URL: https://github.com/apache/incubator-netbeans/pull/507#discussion_r187394365 ## File path:

[GitHub] matthiasblaesing opened a new pull request #542: [NETBEANS-312] Remove antlrv4 patch in CSS library

matthiasblaesing opened a new pull request #542: [NETBEANS-312] Remove antlrv4 patch in CSS library URL: https://github.com/apache/incubator-netbeans/pull/542 From the content the patch migrates the antlr v3 based CSS parser to antlr v4. As this file causes friction in review it is

[GitHub] arusinha commented on a change in pull request #519: [NETBEANS-481] JDK10-LVTI: Added new ErrorRule to fix compiler error on initialization of var type variable with array

arusinha commented on a change in pull request #519: [NETBEANS-481] JDK10-LVTI: Added new ErrorRule to fix compiler error on initialization of var type variable with array URL: https://github.com/apache/incubator-netbeans/pull/519#discussion_r187416655 ## File path:

[GitHub] arusinha commented on a change in pull request #519: [NETBEANS-481] JDK10-LVTI: Added new ErrorRule to fix compiler error on initialization of var type variable with array

arusinha commented on a change in pull request #519: [NETBEANS-481] JDK10-LVTI: Added new ErrorRule to fix compiler error on initialization of var type variable with array URL: https://github.com/apache/incubator-netbeans/pull/519#discussion_r187416303 ## File path:

[GitHub] arusinha commented on a change in pull request #519: [NETBEANS-481] JDK10-LVTI: Added new ErrorRule to fix compiler error on initialization of var type variable with array

arusinha commented on a change in pull request #519: [NETBEANS-481] JDK10-LVTI: Added new ErrorRule to fix compiler error on initialization of var type variable with array URL: https://github.com/apache/incubator-netbeans/pull/519#discussion_r187416655 ## File path:

[GitHub] arusinha commented on a change in pull request #519: [NETBEANS-481] JDK10-LVTI: Added new ErrorRule to fix compiler error on initialization of var type variable with array

arusinha commented on a change in pull request #519: [NETBEANS-481] JDK10-LVTI: Added new ErrorRule to fix compiler error on initialization of var type variable with array URL: https://github.com/apache/incubator-netbeans/pull/519#discussion_r187416303 ## File path:

[GitHub] matthiasblaesing commented on a change in pull request #537: Maven Indexing Optimizations

matthiasblaesing commented on a change in pull request #537: Maven Indexing Optimizations URL: https://github.com/apache/incubator-netbeans/pull/537#discussion_r187371338 ## File path: maven.indexer/src/org/netbeans/modules/maven/indexer/MatchWords.java ## @@ -0,0 +1,109

[GitHub] matthiasblaesing commented on a change in pull request #537: Maven Indexing Optimizations

matthiasblaesing commented on a change in pull request #537: Maven Indexing Optimizations URL: https://github.com/apache/incubator-netbeans/pull/537#discussion_r187368664 ## File path: maven.indexer/src/org/netbeans/modules/maven/indexer/ClassDependencyIndexCreator.java

[GitHub] timboudreau commented on a change in pull request #537: Maven Indexing Optimizations

timboudreau commented on a change in pull request #537: Maven Indexing Optimizations URL: https://github.com/apache/incubator-netbeans/pull/537#discussion_r187471589 ## File path: maven.indexer/src/org/netbeans/modules/maven/indexer/ClassDependencyIndexCreator.java ## @@

[GitHub] timboudreau commented on a change in pull request #537: Maven Indexing Optimizations

timboudreau commented on a change in pull request #537: Maven Indexing Optimizations URL: https://github.com/apache/incubator-netbeans/pull/537#discussion_r187471693 ## File path: maven.indexer/src/org/netbeans/modules/maven/indexer/MatchWords.java ## @@ -0,0 +1,109 @@

[GitHub] timboudreau commented on a change in pull request #537: Maven Indexing Optimizations

timboudreau commented on a change in pull request #537: Maven Indexing Optimizations URL: https://github.com/apache/incubator-netbeans/pull/537#discussion_r187472164 ## File path: maven.indexer/src/org/netbeans/modules/maven/indexer/ClassDependencyIndexCreator.java ## @@

[GitHub] timboudreau commented on a change in pull request #537: Maven Indexing Optimizations

timboudreau commented on a change in pull request #537: Maven Indexing Optimizations URL: https://github.com/apache/incubator-netbeans/pull/537#discussion_r187474638 ## File path: maven.indexer/src/org/netbeans/modules/maven/indexer/ClassDependencyIndexCreator.java ## @@

[GitHub] timboudreau commented on a change in pull request #537: Maven Indexing Optimizations

timboudreau commented on a change in pull request #537: Maven Indexing Optimizations URL: https://github.com/apache/incubator-netbeans/pull/537#discussion_r187474638 ## File path: maven.indexer/src/org/netbeans/modules/maven/indexer/ClassDependencyIndexCreator.java ## @@

[GitHub] timboudreau commented on a change in pull request #537: Maven Indexing Optimizations

timboudreau commented on a change in pull request #537: Maven Indexing Optimizations URL: https://github.com/apache/incubator-netbeans/pull/537#discussion_r187474638 ## File path: maven.indexer/src/org/netbeans/modules/maven/indexer/ClassDependencyIndexCreator.java ## @@

[GitHub] timboudreau commented on issue #537: Maven Indexing Optimizations

timboudreau commented on issue #537: Maven Indexing Optimizations URL: https://github.com/apache/incubator-netbeans/pull/537#issuecomment-388203517 Updated to remove comment and ensure stream is fully read. This is an

[GitHub] dtrebbien opened a new pull request #41: Use an HTTPS URL

dtrebbien opened a new pull request #41: Use an HTTPS URL URL: https://github.com/apache/incubator-netbeans-website/pull/41 This is an automated message from the Apache Git Service. To respond to the message, please log on