[GitHub] [netbeans] tmysik merged pull request #1423: [NETBEANS-53] Improve constructor getter setter code generation
tmysik merged pull request #1423: [NETBEANS-53] Improve constructor getter setter code generation URL: https://github.com/apache/netbeans/pull/1423 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] one-leaf opened a new pull request #1425: add gradle support org.gradle.jvmargs
one-leaf opened a new pull request #1425: add gradle support org.gradle.jvmargs URL: https://github.com/apache/netbeans/pull/1425 add read jvmargs from gradle.properties. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on a change in pull request #1423: [NETBEANS-53] Improve constructor getter setter code generation
tmysik commented on a change in pull request #1423: [NETBEANS-53] Improve
constructor getter setter code generation
URL: https://github.com/apache/netbeans/pull/1423#discussion_r313758384
##
File path:
php/php.api.phpmodule/src/org/netbeans/modules/php/api/PhpVersion.java
##
@@ -136,6 +136,39 @@ public boolean hasNamespaces() {
return namespaces;
}
+/**
+ * Check whether this version supports scalar and return type declarations.
+ *
+ * @return {@code true} if this version scalar and return type
declarations,
+ * {@code false} otherwise
+ * @since 2.67
+ */
+public boolean hasScalarAndReturnTypes() {
+return this.compareTo(PhpVersion.PHP_70) >= 0;
Review comment:
Nice solution! I was thinking about defining this method in each
`PhpVersion` item or using a boolean flag but your solution is much better!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jlahoda merged pull request #1322: Fixing java.completion tests on JDK 13.
jlahoda merged pull request #1322: Fixing java.completion tests on JDK 13. URL: https://github.com/apache/netbeans/pull/1322 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on issue #1423: [NETBEANS-53] Improve constructor getter setter code generation
junichi11 commented on issue #1423: [NETBEANS-53] Improve constructor getter setter code generation URL: https://github.com/apache/netbeans/pull/1423#issuecomment-521137816 Fixed. It's a great idea to add methods to `PhpVersion`. Thank you, Tomas! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] one-leaf closed pull request #1416: add read jvmargs from ~/.gradle/gradle.properties.
one-leaf closed pull request #1416: add read jvmargs from ~/.gradle/gradle.properties. URL: https://github.com/apache/netbeans/pull/1416 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output
junichi11 commented on a change in pull request #1402: [NETBEANS-1763]
Integrate maven failsafe output into test runner output
URL: https://github.com/apache/netbeans/pull/1402#discussion_r313817351
##
File path:
java/maven.junit/src/org/netbeans/modules/maven/junit/JUnitOutputProcessorFactory.java
##
@@ -45,7 +45,10 @@ public JUnitOutputProcessorFactory() {
@Override
public Set createProcessorsSet(Project project, RunConfig
config) {
-if (config.getGoals().contains("test") ||
config.getGoals().contains("integration-test") ||
config.getGoals().contains("surefire:test")) { //NOI18N
+if (config.getGoals().contains("test") //NOI18N
+|| config.getGoals().contains("integration-test") //NOI18N
+|| config.getGoals().contains("surefire:test")
Review comment:
Missing `// NOI18N`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ehsavoie merged pull request #1420: [NETBEANS-2975]: Schema2Beans shouldn't return 'null' for primitive types.
ehsavoie merged pull request #1420: [NETBEANS-2975]: Schema2Beans shouldn't return 'null' for primitive types. URL: https://github.com/apache/netbeans/pull/1420 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ehsavoie commented on a change in pull request #1426: [NETBEANS-2980] Fix potential NPE on ImportAnalysis2.getPackage()
ehsavoie commented on a change in pull request #1426: [NETBEANS-2980] Fix
potential NPE on ImportAnalysis2.getPackage()
URL: https://github.com/apache/netbeans/pull/1426#discussion_r313833679
##
File path:
java/java.source.base/src/org/netbeans/modules/java/source/pretty/ImportAnalysis2.java
##
@@ -390,7 +390,7 @@ private boolean checkPackagesForStarImport(String pkgName,
CodeStyle cs) {
}
private PackageElement getPackageOf(Element el) {
-while (el.getKind() != ElementKind.PACKAGE) el =
el.getEnclosingElement();
+while ((el != null) && (el.getKind() != ElementKind.PACKAGE)) el =
el.getEnclosingElement();
Review comment:
More style than anything else but shouldn't a new variable and enclosing
bracket makes the code more readable ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on issue #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output
junichi11 commented on issue #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output URL: https://github.com/apache/netbeans/pull/1402#issuecomment-521423750 @matthiasblaesing I'm not an expert of this area, but if there are steps to verify this, I would like to do it :) @jmborer Could you please take a look at this if possible (because you are the reporter as Matthias wrote)? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output
junichi11 commented on a change in pull request #1402: [NETBEANS-1763]
Integrate maven failsafe output into test runner output
URL: https://github.com/apache/netbeans/pull/1402#discussion_r314086833
##
File path:
java/maven.junit.ui/src/org/netbeans/modules/maven/junit/ui/MavenJUnitTestMethodNode.java
##
@@ -62,52 +63,71 @@ public MavenJUnitTestMethodNode(Testcase testcase, Project
project, String proje
@Override
public Action[] getActions(boolean context) {
List actions = new ArrayList();
-Action preferred = getPreferredAction();
-if (preferred != null) {
-actions.add(preferred);
-}
-FileObject testFO = getTestcaseFileObject();
-if (testFO != null){
+FileObject testFO = getTestcaseFileObject();
+if (testFO != null) {
+boolean unitTest = getTestcase().getType() == null ||
"UNIT".equals(getTestcase().getType()); // NOI18N
+boolean integrationTest =
"INTEGRATION".equals(getTestcase().getType()); // NOI18N
Project suiteProject = FileOwnerQuery.getOwner(testFO);
if (suiteProject != null) {
ActionProvider actionProvider =
suiteProject.getLookup().lookup(ActionProvider.class);
if (actionProvider != null) {
-boolean runSupported = false;
-boolean debugSupported = false;
-for (String action : actionProvider.getSupportedActions())
{
-if (!runSupported &&
action.equals(COMMAND_RUN_SINGLE_METHOD)) {
-runSupported = true;
-if (debugSupported) {
-break;
-}
-}
-if (!debugSupported &&
action.equals(COMMAND_DEBUG_SINGLE_METHOD)) {
-debugSupported = true;
-if (runSupported) {
-break;
-}
-}
-}
-
SingleMethod methodSpec = new SingleMethod(testFO,
testcase.getName());
Lookup nodeContext = Lookups.singleton(methodSpec);
-if (runSupported &&
actionProvider.isActionEnabled(COMMAND_RUN_SINGLE_METHOD,
-nodeContext)) {
-actions.add(new TestMethodNodeAction(actionProvider,
+
+for (String action : actionProvider.getSupportedActions())
{
+if (unitTest
+&& action.equals(COMMAND_RUN_SINGLE_METHOD)
+&& actionProvider.isActionEnabled(action,
nodeContext)) {
+actions.add(new
TestMethodNodeAction(actionProvider,
nodeContext,
COMMAND_RUN_SINGLE_METHOD,
Bundle.LBL_RerunTest()));
-}
-if (debugSupported &&
actionProvider.isActionEnabled(COMMAND_DEBUG_SINGLE_METHOD,
-nodeContext)) {
-actions.add(new TestMethodNodeAction(actionProvider,
+}
+if (unitTest
+&& action.equals(COMMAND_DEBUG_SINGLE_METHOD)
+&& actionProvider.isActionEnabled(action,
nodeContext)) {
+actions.add(new
TestMethodNodeAction(actionProvider,
nodeContext,
COMMAND_DEBUG_SINGLE_METHOD,
Bundle.LBL_DebugTest()));
+}
+if (integrationTest
+&& action.equals("integration-test.single")
Review comment:
Missing 4 `NOI18N`s
Maybe, should add `NOI18N` to `aName = "";` and `bName = "";`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output
junichi11 commented on a change in pull request #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output URL: https://github.com/apache/netbeans/pull/1402#discussion_r313816997 ## File path: java/maven/src/org/netbeans/modules/maven/ActionProviderImpl.java ## @@ -113,11 +113,13 @@ public static final String BUILD_WITH_DEPENDENCIES = "build-with-dependencies"; // NOI18N private final Project proj; - -// XXX introduce constant w/ CosChecker, ActionMappings, DefaultReplaceTokenProvider -public static final String RUN_MAIN = ActionProvider.COMMAND_RUN_SINGLE + ".main"; -public static final String DEBUG_MAIN = ActionProvider.COMMAND_DEBUG_SINGLE + ".main"; -public static final String PROFILE_MAIN = ActionProvider.COMMAND_PROFILE_SINGLE + ".main"; + +public static final String COMMAND_RUN_MAIN = ActionProvider.COMMAND_RUN_SINGLE + ".main"; +public static final String COMMAND_DEBUG_MAIN = ActionProvider.COMMAND_DEBUG_SINGLE + ".main"; +public static final String COMMAND_PROFILE_MAIN = ActionProvider.COMMAND_PROFILE_SINGLE + ".main"; + +public static final String COMMAND_INTEGRATION_TEST_SINGLE = "integration-test.single"; +public static final String COMMAND_DEBUG_INTEGRATION_TEST_SINGLE = "debug.integration-test.single"; Review comment: Add `// NOI18N` ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output
junichi11 commented on a change in pull request #1402: [NETBEANS-1763]
Integrate maven failsafe output into test runner output
URL: https://github.com/apache/netbeans/pull/1402#discussion_r313818963
##
File path:
java/maven.junit.ui/src/org/netbeans/modules/maven/junit/ui/MavenJUnitTestMethodNode.java
##
@@ -62,52 +63,71 @@ public MavenJUnitTestMethodNode(Testcase testcase, Project
project, String proje
@Override
public Action[] getActions(boolean context) {
List actions = new ArrayList();
-Action preferred = getPreferredAction();
-if (preferred != null) {
-actions.add(preferred);
-}
-FileObject testFO = getTestcaseFileObject();
-if (testFO != null){
+FileObject testFO = getTestcaseFileObject();
+if (testFO != null) {
+boolean unitTest = getTestcase().getType() == null ||
"UNIT".equals(getTestcase().getType());
Review comment:
Missing `// NOI18N`s?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output
junichi11 commented on a change in pull request #1402: [NETBEANS-1763]
Integrate maven failsafe output into test runner output
URL: https://github.com/apache/netbeans/pull/1402#discussion_r313818460
##
File path:
java/maven.junit.ui/src/org/netbeans/modules/maven/junit/ui/MavenJUnitTestMethodNode.java
##
@@ -62,52 +63,71 @@ public MavenJUnitTestMethodNode(Testcase testcase, Project
project, String proje
@Override
public Action[] getActions(boolean context) {
List actions = new ArrayList();
-Action preferred = getPreferredAction();
-if (preferred != null) {
-actions.add(preferred);
-}
-FileObject testFO = getTestcaseFileObject();
-if (testFO != null){
+FileObject testFO = getTestcaseFileObject();
+if (testFO != null) {
+boolean unitTest = getTestcase().getType() == null ||
"UNIT".equals(getTestcase().getType());
+boolean integrationTest =
"INTEGRATION".equals(getTestcase().getType());
Project suiteProject = FileOwnerQuery.getOwner(testFO);
if (suiteProject != null) {
ActionProvider actionProvider =
suiteProject.getLookup().lookup(ActionProvider.class);
if (actionProvider != null) {
-boolean runSupported = false;
-boolean debugSupported = false;
-for (String action : actionProvider.getSupportedActions())
{
-if (!runSupported &&
action.equals(COMMAND_RUN_SINGLE_METHOD)) {
-runSupported = true;
-if (debugSupported) {
-break;
-}
-}
-if (!debugSupported &&
action.equals(COMMAND_DEBUG_SINGLE_METHOD)) {
-debugSupported = true;
-if (runSupported) {
-break;
-}
-}
-}
-
SingleMethod methodSpec = new SingleMethod(testFO,
testcase.getName());
Lookup nodeContext = Lookups.singleton(methodSpec);
-if (runSupported &&
actionProvider.isActionEnabled(COMMAND_RUN_SINGLE_METHOD,
-nodeContext)) {
-actions.add(new TestMethodNodeAction(actionProvider,
+
+for (String action : actionProvider.getSupportedActions())
{
+if (unitTest
+&& action.equals(COMMAND_RUN_SINGLE_METHOD)
+&& actionProvider.isActionEnabled(action,
nodeContext)) {
+actions.add(new
TestMethodNodeAction(actionProvider,
nodeContext,
COMMAND_RUN_SINGLE_METHOD,
Bundle.LBL_RerunTest()));
-}
-if (debugSupported &&
actionProvider.isActionEnabled(COMMAND_DEBUG_SINGLE_METHOD,
-nodeContext)) {
-actions.add(new TestMethodNodeAction(actionProvider,
+}
+if (unitTest
+&& action.equals(COMMAND_DEBUG_SINGLE_METHOD)
+&& actionProvider.isActionEnabled(action,
nodeContext)) {
+actions.add(new
TestMethodNodeAction(actionProvider,
nodeContext,
COMMAND_DEBUG_SINGLE_METHOD,
Bundle.LBL_DebugTest()));
+}
+if (integrationTest
+&& action.equals("integration-test.single")
+&& actionProvider.isActionEnabled(action,
nodeContext)) {
+actions.add(new
TestMethodNodeAction(actionProvider,
+nodeContext,
+"integration-test.single",
Review comment:
Missing `// NOI18N`s?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output
junichi11 commented on a change in pull request #1402: [NETBEANS-1763]
Integrate maven failsafe output into test runner output
URL: https://github.com/apache/netbeans/pull/1402#discussion_r313818460
##
File path:
java/maven.junit.ui/src/org/netbeans/modules/maven/junit/ui/MavenJUnitTestMethodNode.java
##
@@ -62,52 +63,71 @@ public MavenJUnitTestMethodNode(Testcase testcase, Project
project, String proje
@Override
public Action[] getActions(boolean context) {
List actions = new ArrayList();
-Action preferred = getPreferredAction();
-if (preferred != null) {
-actions.add(preferred);
-}
-FileObject testFO = getTestcaseFileObject();
-if (testFO != null){
+FileObject testFO = getTestcaseFileObject();
+if (testFO != null) {
+boolean unitTest = getTestcase().getType() == null ||
"UNIT".equals(getTestcase().getType());
+boolean integrationTest =
"INTEGRATION".equals(getTestcase().getType());
Project suiteProject = FileOwnerQuery.getOwner(testFO);
if (suiteProject != null) {
ActionProvider actionProvider =
suiteProject.getLookup().lookup(ActionProvider.class);
if (actionProvider != null) {
-boolean runSupported = false;
-boolean debugSupported = false;
-for (String action : actionProvider.getSupportedActions())
{
-if (!runSupported &&
action.equals(COMMAND_RUN_SINGLE_METHOD)) {
-runSupported = true;
-if (debugSupported) {
-break;
-}
-}
-if (!debugSupported &&
action.equals(COMMAND_DEBUG_SINGLE_METHOD)) {
-debugSupported = true;
-if (runSupported) {
-break;
-}
-}
-}
-
SingleMethod methodSpec = new SingleMethod(testFO,
testcase.getName());
Lookup nodeContext = Lookups.singleton(methodSpec);
-if (runSupported &&
actionProvider.isActionEnabled(COMMAND_RUN_SINGLE_METHOD,
-nodeContext)) {
-actions.add(new TestMethodNodeAction(actionProvider,
+
+for (String action : actionProvider.getSupportedActions())
{
+if (unitTest
+&& action.equals(COMMAND_RUN_SINGLE_METHOD)
+&& actionProvider.isActionEnabled(action,
nodeContext)) {
+actions.add(new
TestMethodNodeAction(actionProvider,
nodeContext,
COMMAND_RUN_SINGLE_METHOD,
Bundle.LBL_RerunTest()));
-}
-if (debugSupported &&
actionProvider.isActionEnabled(COMMAND_DEBUG_SINGLE_METHOD,
-nodeContext)) {
-actions.add(new TestMethodNodeAction(actionProvider,
+}
+if (unitTest
+&& action.equals(COMMAND_DEBUG_SINGLE_METHOD)
+&& actionProvider.isActionEnabled(action,
nodeContext)) {
+actions.add(new
TestMethodNodeAction(actionProvider,
nodeContext,
COMMAND_DEBUG_SINGLE_METHOD,
Bundle.LBL_DebugTest()));
+}
+if (integrationTest
+&& action.equals("integration-test.single")
+&& actionProvider.isActionEnabled(action,
nodeContext)) {
+actions.add(new
TestMethodNodeAction(actionProvider,
+nodeContext,
+"integration-test.single",
Review comment:
Missing `// NOI18N`s?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi opened a new pull request #1426: [NETBEANS-2980] Fix potential NPE on ImportAnalysis2.getPackage()
lkishalmi opened a new pull request #1426: [NETBEANS-2980] Fix potential NPE on ImportAnalysis2.getPackage() URL: https://github.com/apache/netbeans/pull/1426 Trivial patch preventing NPE. The result of this method is already checked for null, so returning that would be fine. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi opened a new pull request #1427: [NETBEANS-1836] Applied proposed patch, not adding self to the remove selection.
lkishalmi opened a new pull request #1427: [NETBEANS-1836] Applied proposed patch, not adding self to the remove selection. URL: https://github.com/apache/netbeans/pull/1427 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on issue #1425: add gradle support org.gradle.jvmargs
junichi11 commented on issue #1425: add gradle support org.gradle.jvmargs URL: https://github.com/apache/netbeans/pull/1425#issuecomment-521197674 @one-leaf Did you read this? https://netbeans.apache.org/participate/submit-pr.html You should create a branch. Did you read @lkishalmi 's comments? https://github.com/apache/netbeans/pull/1416#pullrequestreview-273455218 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output
junichi11 commented on a change in pull request #1402: [NETBEANS-1763]
Integrate maven failsafe output into test runner output
URL: https://github.com/apache/netbeans/pull/1402#discussion_r313818042
##
File path:
java/maven.junit/src/org/netbeans/modules/maven/junit/JUnitOutputListenerProvider.java
##
@@ -244,42 +247,69 @@ static boolean isFullJavaId(String
possibleNewRunningTestClass) {
public @Override void sequenceStart(String sequenceId, OutputVisitor
visitor) {
session = null;
- // Fix for #257563 / SUREFIRE-1158, where surefire 2.19.x
- // removed the printing of the output directory. Get the directory from
- // the configuration directly or fallback to the plugin standard
- if (usingSurefire219(this.config.getMavenProject())) {
- //
http://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#reportsDirectory
- String reportsDirectory =
PluginPropertyUtils.getPluginProperty(config.getMavenProject(),
- Constants.GROUP_APACHE_PLUGINS, Constants.PLUGIN_SUREFIRE,
"reportsDirectory", "test", null); // NOI18N
- if (null == reportsDirectory) {
- // fallback to default value
- try {
- Object defaultValue =
PluginPropertyUtils.createEvaluator(config.getMavenProject())
-
.evaluate("${project.build.directory}/surefire-reports");
- if (defaultValue instanceof String) {
- reportsDirectory = (String) defaultValue;
- }
- } catch (ExpressionEvaluationException ex) {
- // NOP could not resolved default value
- }
- }
- if (null != reportsDirectory) {
- File absoluteFile = new File(reportsDirectory);
- // configuration might be "target/directory", which is relative
- // to the maven project or an absolute path
- File relativeFile = new
File(this.config.getMavenProject().getBasedir(), reportsDirectory);
- if (absoluteFile.exists() && absoluteFile.isDirectory()) {
- outputDir = absoluteFile;
- } else {
- if (relativeFile.exists() && relativeFile.isDirectory()) {
- outputDir = relativeFile;
- }
- }
- if (null != outputDir) {
- createSession(outputDir);
- }
- }
- }
+reportNameSuffix = null;
+testType = null;
+String reportsDirectory = null;
+ if (("mojo-execute#surefire:test".equals(sequenceId))) {
Review comment:
Missing `NOI18N`s?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on issue #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output
matthiasblaesing commented on issue #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output URL: https://github.com/apache/netbeans/pull/1402#issuecomment-521340176 @junichi11 thanks for looking into this - I updated the missing `NOI18N` marker and updated the commits in place. Clear to merge? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #1385: Cleanup raw class type
matthiasblaesing commented on a change in pull request #1385: Cleanup raw class
type
URL: https://github.com/apache/netbeans/pull/1385#discussion_r313995367
##
File path:
contrib/javaee.wildfly/src/org/netbeans/modules/javaee/wildfly/ide/commands/WildflyManagementAPI.java
##
@@ -119,7 +119,7 @@ static Object
createOperation(WildflyDeploymentFactory.WildFlyClassLoader cl, Ob
// ModelNode
static Object
createReadResourceOperation(WildflyDeploymentFactory.WildFlyClassLoader cl,
Object modelNode, boolean recursive)
throws ClassNotFoundException, NoSuchMethodException,
IllegalAccessException, InvocationTargetException {
-Class clazz =
cl.loadClass("org.jboss.as.controller.client.helpers.Operations"); // NOI18N
+Class clazz =
cl.loadClass("org.jboss.as.controller.client.helpers.Operations"); // NOI18N
Class modelClazz = cl.loadClass("org.jboss.dmr.ModelNode"); // NOI18N
Review comment:
This looks strange - why was line 122 changed, but 123 not? This seems to be
the case at multiple places.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on issue #1382: Fix NPE if PAC cannot be resolved
matthiasblaesing commented on issue #1382: Fix NPE if PAC cannot be resolved URL: https://github.com/apache/netbeans/pull/1382#issuecomment-521362332 I'm not sure if it would be better to retry initializing the proxy would also be a good idea, but I see, that this makes more sense then exploding with an NPE. Thank you. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #1382: Fix NPE if PAC cannot be resolved
matthiasblaesing merged pull request #1382: Fix NPE if PAC cannot be resolved URL: https://github.com/apache/netbeans/pull/1382 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] peedeeboy commented on issue #1412: [NETBEANS-2775] Fix duplicate server entries by filtering using PlatformFactory
peedeeboy commented on issue #1412: [NETBEANS-2775] Fix duplicate server entries by filtering using PlatformFactory URL: https://github.com/apache/netbeans/pull/1412#issuecomment-521364350 @neilcsmith-net @jGauravGupta just to say that I tested this by cloning a fresh copy of master, then fetching this PR and building NB from that branch. So I do think enabling Payara getting stuck on "Activating feature is unrelated to this PR itself, and as Neil's suggests is because I didn't have an ergonomics fix locally - I don't think it should hold up this PR.. ? Hope that helps :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on issue #1392: [NETBEANS-97] Don't add braces around try/synchronized blocks when reformatting
matthiasblaesing commented on issue #1392: [NETBEANS-97] Don't add braces around try/synchronized blocks when reformatting URL: https://github.com/apache/netbeans/pull/1392#issuecomment-521368152 @lbruun @sdedic could you please have a look at this and see if the concerns raised on the original PR are fixed? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
