[GitHub] [netbeans] ebresie opened a new pull request #1500: netbeans master updates as of 9/13/2019

2019-09-13 Thread GitBox
ebresie opened a new pull request #1500: netbeans master updates as of 9/13/2019 URL: https://github.com/apache/netbeans/pull/1500 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [netbeans] tiainen commented on issue #1473: [NETBEANS-2751] Register OpenJFX sample artifacts as NetBeans project…

2019-09-13 Thread GitBox
tiainen commented on issue #1473: [NETBEANS-2751] Register OpenJFX sample artifacts as NetBeans project… URL: https://github.com/apache/netbeans/pull/1473#issuecomment-531166121 It was available from maven central when I posted my message. Synchronization with search.maven.org can take up

[GitHub] [netbeans] ebresie closed pull request #1500: netbeans master updates as of 9/13/2019

2019-09-13 Thread GitBox
ebresie closed pull request #1500: netbeans master updates as of 9/13/2019 URL: https://github.com/apache/netbeans/pull/1500 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [netbeans] matthiasblaesing commented on issue #1497: [NETBEANS-3072] Use actual ImageIcons as code completion actually like.

2019-09-13 Thread GitBox
matthiasblaesing commented on issue #1497: [NETBEANS-3072] Use actual ImageIcons as code completion actually like. URL: https://github.com/apache/netbeans/pull/1497#issuecomment-531182362 I think @eirikbakke is in a better position to answer this, but my understand is, that using an

[GitHub] [netbeans] eirikbakke commented on issue #1497: [NETBEANS-3072] Use actual ImageIcons as code completion actually like.

2019-09-13 Thread GitBox
eirikbakke commented on issue #1497: [NETBEANS-3072] Use actual ImageIcons as code completion actually like. URL: https://github.com/apache/netbeans/pull/1497#issuecomment-531192084 The patch looks fine. As long as you use ImageUtilities.loadImageIcon, the resulting icon will actually

[GitHub] [netbeans] eirikbakke commented on a change in pull request #1497: [NETBEANS-3072] Use actual ImageIcons as code completion actually like.

2019-09-13 Thread GitBox
eirikbakke commented on a change in pull request #1497: [NETBEANS-3072] Use actual ImageIcons as code completion actually like. URL: https://github.com/apache/netbeans/pull/1497#discussion_r324139659 ## File path: java/java.source/src/org/netbeans/modules/java/ui/Icons.java

[GitHub] [netbeans] arusinha opened a new pull request #1499: [NETBEANS-3082]: Fixed formatting issue happening on use of Switch-Ex…

2019-09-13 Thread GitBox
arusinha opened a new pull request #1499: [NETBEANS-3082]: Fixed formatting issue happening on use of Switch-Ex… URL: https://github.com/apache/netbeans/pull/1499 …pression Jira Link: https://issues.apache.org/jira/browse/NETBEANS-3082 Suppose We have below Code Snippet

[GitHub] [netbeans] lkishalmi commented on a change in pull request #1497: [NETBEANS-3072] Use actual ImageIcons as code completion actually like.

2019-09-13 Thread GitBox
lkishalmi commented on a change in pull request #1497: [NETBEANS-3072] Use actual ImageIcons as code completion actually like. URL: https://github.com/apache/netbeans/pull/1497#discussion_r324209409 ## File path: java/java.source/src/org/netbeans/modules/java/ui/Icons.java

[GitHub] [netbeans] matthiasblaesing merged pull request #1488: Update netbeans bundled JNA library to 5.4.0

2019-09-13 Thread GitBox
matthiasblaesing merged pull request #1488: Update netbeans bundled JNA library to 5.4.0 URL: https://github.com/apache/netbeans/pull/1488 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [netbeans] matthiasblaesing commented on issue #1488: Update netbeans bundled JNA library to 5.4.0

2019-09-13 Thread GitBox
matthiasblaesing commented on issue #1488: Update netbeans bundled JNA library to 5.4.0 URL: https://github.com/apache/netbeans/pull/1488#issuecomment-531335052 I rereviewed my changes and think they are safe. If really problems creep in, I'm around to fix.

[GitHub] [netbeans] lkishalmi merged pull request #1497: [NETBEANS-3072] Use actual ImageIcons as code completion actually like.

2019-09-13 Thread GitBox
lkishalmi merged pull request #1497: [NETBEANS-3072] Use actual ImageIcons as code completion actually like. URL: https://github.com/apache/netbeans/pull/1497 This is an automated message from the Apache Git Service. To

[GitHub] [netbeans] blackleg closed pull request #1456: Improve Travis CI config

2019-09-13 Thread GitBox
blackleg closed pull request #1456: Improve Travis CI config URL: https://github.com/apache/netbeans/pull/1456 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [netbeans] arusinha merged pull request #1498: [NETBEANS-3097]:Changed font color type name for text-block(JDK-13)

2019-09-13 Thread GitBox
arusinha merged pull request #1498: [NETBEANS-3097]:Changed font color type name for text-block(JDK-13) URL: https://github.com/apache/netbeans/pull/1498 This is an automated message from the Apache Git Service. To respond

[GitHub] [netbeans] oyarzun commented on issue #1496: [NETBEANS-3095] avoid null pointer exception in SplashPainter

2019-09-13 Thread GitBox
oyarzun commented on issue #1496: [NETBEANS-3095] avoid null pointer exception in SplashPainter URL: https://github.com/apache/netbeans/pull/1496#issuecomment-531291178 Just got different NPE, with the PR. ` java.lang.NullPointerException at

[GitHub] [netbeans] junichi11 commented on a change in pull request #1501: [NETBEANS-3041] Support passing JVM Arguments to Gradle Daemon

2019-09-13 Thread GitBox
junichi11 commented on a change in pull request #1501: [NETBEANS-3041] Support passing JVM Arguments to Gradle Daemon URL: https://github.com/apache/netbeans/pull/1501#discussion_r324412418 ## File path:

[GitHub] [netbeans] lkishalmi commented on issue #1425: [NETBEANS-3041] Add gradle support org.gradle.jvmargs

2019-09-13 Thread GitBox
lkishalmi commented on issue #1425: [NETBEANS-3041] Add gradle support org.gradle.jvmargs URL: https://github.com/apache/netbeans/pull/1425#issuecomment-531351867 Closing in favor of #1501 This is an automated message from

[GitHub] [netbeans] lkishalmi closed pull request #1425: [NETBEANS-3041] Add gradle support org.gradle.jvmargs

2019-09-13 Thread GitBox
lkishalmi closed pull request #1425: [NETBEANS-3041] Add gradle support org.gradle.jvmargs URL: https://github.com/apache/netbeans/pull/1425 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [netbeans] lkishalmi opened a new pull request #1501: [NETBEANS-3041] Support passing JVM Arguments to Gradle Daemon

2019-09-13 Thread GitBox
lkishalmi opened a new pull request #1501: [NETBEANS-3041] Support passing JVM Arguments to Gradle Daemon URL: https://github.com/apache/netbeans/pull/1501 Take over #1425 as it seems to be abandoned, in order to be released in 11.2.

[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #1483: [NETBEANS-3076] Try to create unit-test with Gradle Projects

2019-09-13 Thread GitBox
matthiasblaesing commented on a change in pull request #1483: [NETBEANS-3076] Try to create unit-test with Gradle Projects URL: https://github.com/apache/netbeans/pull/1483#discussion_r324342066 ## File path:

[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #1483: [NETBEANS-3076] Try to create unit-test with Gradle Projects

2019-09-13 Thread GitBox
matthiasblaesing commented on a change in pull request #1483: [NETBEANS-3076] Try to create unit-test with Gradle Projects URL: https://github.com/apache/netbeans/pull/1483#discussion_r324339161 ## File path: groovy/gradle.java/nbproject/project.properties ## @@ -20,7

[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #1483: [NETBEANS-3076] Try to create unit-test with Gradle Projects

2019-09-13 Thread GitBox
matthiasblaesing commented on a change in pull request #1483: [NETBEANS-3076] Try to create unit-test with Gradle Projects URL: https://github.com/apache/netbeans/pull/1483#discussion_r324338781 ## File path:

[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #1483: [NETBEANS-3076] Try to create unit-test with Gradle Projects

2019-09-13 Thread GitBox
matthiasblaesing commented on a change in pull request #1483: [NETBEANS-3076] Try to create unit-test with Gradle Projects URL: https://github.com/apache/netbeans/pull/1483#discussion_r324338969 ## File path: groovy/gradle.java/nbproject/project.properties ## @@ -20,7

[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #1483: [NETBEANS-3076] Try to create unit-test with Gradle Projects

2019-09-13 Thread GitBox
matthiasblaesing commented on a change in pull request #1483: [NETBEANS-3076] Try to create unit-test with Gradle Projects URL: https://github.com/apache/netbeans/pull/1483#discussion_r324342466 ## File path:

[GitHub] [netbeans] lkishalmi commented on a change in pull request #1483: [NETBEANS-3076] Try to create unit-test with Gradle Projects

2019-09-13 Thread GitBox
lkishalmi commented on a change in pull request #1483: [NETBEANS-3076] Try to create unit-test with Gradle Projects URL: https://github.com/apache/netbeans/pull/1483#discussion_r324399724 ## File path:

[GitHub] [netbeans] lkishalmi commented on a change in pull request #1483: [NETBEANS-3076] Try to create unit-test with Gradle Projects

2019-09-13 Thread GitBox
lkishalmi commented on a change in pull request #1483: [NETBEANS-3076] Try to create unit-test with Gradle Projects URL: https://github.com/apache/netbeans/pull/1483#discussion_r324400092 ## File path: groovy/gradle.java/nbproject/project.properties ## @@ -20,7 +20,10 @@

[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #1483: [NETBEANS-3076] Try to create unit-test with Gradle Projects

2019-09-13 Thread GitBox
matthiasblaesing commented on a change in pull request #1483: [NETBEANS-3076] Try to create unit-test with Gradle Projects URL: https://github.com/apache/netbeans/pull/1483#discussion_r324371581 ## File path: groovy/gradle.java/nbproject/project.properties ## @@ -20,7

[GitHub] [netbeans] junichi11 commented on a change in pull request #1425: [NETBEANS-3041] Add gradle support org.gradle.jvmargs

2019-09-13 Thread GitBox
junichi11 commented on a change in pull request #1425: [NETBEANS-3041] Add gradle support org.gradle.jvmargs URL: https://github.com/apache/netbeans/pull/1425#discussion_r324378539 ## File path: groovy/gradle/src/org/netbeans/modules/gradle/api/execute/GradleCommandLine.java

[GitHub] [netbeans] junichi11 commented on a change in pull request #1425: [NETBEANS-3041] Add gradle support org.gradle.jvmargs

2019-09-13 Thread GitBox
junichi11 commented on a change in pull request #1425: [NETBEANS-3041] Add gradle support org.gradle.jvmargs URL: https://github.com/apache/netbeans/pull/1425#discussion_r324379456 ## File path: groovy/gradle/src/org/netbeans/modules/gradle/api/execute/GradleCommandLine.java

[GitHub] [netbeans] timboudreau commented on a change in pull request #1483: [NETBEANS-3076] Try to create unit-test with Gradle Projects

2019-09-13 Thread GitBox
timboudreau commented on a change in pull request #1483: [NETBEANS-3076] Try to create unit-test with Gradle Projects URL: https://github.com/apache/netbeans/pull/1483#discussion_r324369637 ## File path: groovy/gradle.java/nbproject/project.properties ## @@ -20,7 +20,10

[GitHub] [netbeans] junichi11 commented on a change in pull request #1425: [NETBEANS-3041] Add gradle support org.gradle.jvmargs

2019-09-13 Thread GitBox
junichi11 commented on a change in pull request #1425: [NETBEANS-3041] Add gradle support org.gradle.jvmargs URL: https://github.com/apache/netbeans/pull/1425#discussion_r324379456 ## File path: groovy/gradle/src/org/netbeans/modules/gradle/api/execute/GradleCommandLine.java

[GitHub] [netbeans] junichi11 commented on a change in pull request #1501: [NETBEANS-3041] Support passing JVM Arguments to Gradle Daemon

2019-09-13 Thread GitBox
junichi11 commented on a change in pull request #1501: [NETBEANS-3041] Support passing JVM Arguments to Gradle Daemon URL: https://github.com/apache/netbeans/pull/1501#discussion_r324380010 ## File path:

[GitHub] [netbeans] junichi11 commented on a change in pull request #1425: [NETBEANS-3041] Add gradle support org.gradle.jvmargs

2019-09-13 Thread GitBox
junichi11 commented on a change in pull request #1425: [NETBEANS-3041] Add gradle support org.gradle.jvmargs URL: https://github.com/apache/netbeans/pull/1425#discussion_r324378539 ## File path: groovy/gradle/src/org/netbeans/modules/gradle/api/execute/GradleCommandLine.java

[GitHub] [netbeans] junichi11 commented on a change in pull request #1425: [NETBEANS-3041] Add gradle support org.gradle.jvmargs

2019-09-13 Thread GitBox
junichi11 commented on a change in pull request #1425: [NETBEANS-3041] Add gradle support org.gradle.jvmargs URL: https://github.com/apache/netbeans/pull/1425#discussion_r324379332 ## File path: groovy/gradle/src/org/netbeans/modules/gradle/api/execute/GradleCommandLine.java

[GitHub] [netbeans] junichi11 commented on issue #1501: [NETBEANS-3041] Support passing JVM Arguments to Gradle Daemon

2019-09-13 Thread GitBox
junichi11 commented on issue #1501: [NETBEANS-3041] Support passing JVM Arguments to Gradle Daemon URL: https://github.com/apache/netbeans/pull/1501#issuecomment-531403165 @junichi11 I'm not familiar with this area but just left a few comments. Thanks.

[GitHub] [netbeans] junichi11 edited a comment on issue #1501: [NETBEANS-3041] Support passing JVM Arguments to Gradle Daemon

2019-09-13 Thread GitBox
junichi11 edited a comment on issue #1501: [NETBEANS-3041] Support passing JVM Arguments to Gradle Daemon URL: https://github.com/apache/netbeans/pull/1501#issuecomment-531403165 @lkishalmi I'm not familiar with this area but just left a few comments. Thanks.

[GitHub] [netbeans] lkishalmi opened a new pull request #1497: [NETBEANS-3072] Use actual ImageIcons as code completion actually like.

2019-09-13 Thread GitBox
lkishalmi opened a new pull request #1497: [NETBEANS-3072] Use actual ImageIcons as code completion actually like. URL: https://github.com/apache/netbeans/pull/1497 Most probably the regression was caused by [NETBEANS-2614](https://issues.apache.org/jira/browse/NETBEANS-2614). This is

[GitHub] [netbeans] tiainen commented on issue #1473: [NETBEANS-2751] Register OpenJFX sample artifacts as NetBeans project…

2019-09-13 Thread GitBox
tiainen commented on issue #1473: [NETBEANS-2751] Register OpenJFX sample artifacts as NetBeans project… URL: https://github.com/apache/netbeans/pull/1473#issuecomment-531137068 We've just released version 0.0.3 which updates to the latest release of OpenJFX 13.

[GitHub] [netbeans] geertjanw commented on issue #1473: [NETBEANS-2751] Register OpenJFX sample artifacts as NetBeans project…

2019-09-13 Thread GitBox
geertjanw commented on issue #1473: [NETBEANS-2751] Register OpenJFX sample artifacts as NetBeans project… URL: https://github.com/apache/netbeans/pull/1473#issuecomment-531138242 Thanks for the info! This is an automated

[GitHub] [netbeans] geertjanw commented on issue #1473: [NETBEANS-2751] Register OpenJFX sample artifacts as NetBeans project…

2019-09-13 Thread GitBox
geertjanw commented on issue #1473: [NETBEANS-2751] Register OpenJFX sample artifacts as NetBeans project… URL: https://github.com/apache/netbeans/pull/1473#issuecomment-531138590 But I don't see it here: https://mvnrepository.com/artifact/org.openjfx/javafx-archetype-simple That's

[GitHub] [netbeans] matthiasblaesing edited a comment on issue #1473: [NETBEANS-2751] Register OpenJFX sample artifacts as NetBeans project…

2019-09-13 Thread GitBox
matthiasblaesing edited a comment on issue #1473: [NETBEANS-2751] Register OpenJFX sample artifacts as NetBeans project… URL: https://github.com/apache/netbeans/pull/1473#issuecomment-531149178 I'm looking on maven central (the default maven repository):