[GitHub] [netbeans] junichi11 commented on issue #1496: [NETBEANS-3095] avoid null pointer exception in SplashPainter

2019-09-14 Thread GitBox
junichi11 commented on issue #1496: [NETBEANS-3095] avoid null pointer exception in SplashPainter URL: https://github.com/apache/netbeans/pull/1496#issuecomment-531476536 @eirikbakke Could you please have a look at this?

[GitHub] [netbeans] junichi11 commented on a change in pull request #1496: [NETBEANS-3095] avoid null pointer exception in SplashPainter

2019-09-14 Thread GitBox
junichi11 commented on a change in pull request #1496: [NETBEANS-3095] avoid null pointer exception in SplashPainter URL: https://github.com/apache/netbeans/pull/1496#discussion_r324423270 ## File path: platform/core.startup/src/org/netbeans/core/startup/Splash.java ## @@

[GitHub] [netbeans] geertjanw closed pull request #1473: [NETBEANS-2751] Register OpenJFX sample artifacts as NetBeans project…

2019-09-14 Thread GitBox
geertjanw closed pull request #1473: [NETBEANS-2751] Register OpenJFX sample artifacts as NetBeans project… URL: https://github.com/apache/netbeans/pull/1473 This is an automated message from the Apache Git Service. To

[GitHub] [netbeans] geertjanw commented on issue #1473: [NETBEANS-2751] Register OpenJFX sample artifacts as NetBeans project…

2019-09-14 Thread GitBox
geertjanw commented on issue #1473: [NETBEANS-2751] Register OpenJFX sample artifacts as NetBeans project… URL: https://github.com/apache/netbeans/pull/1473#issuecomment-531504014 Closing this one. Pushing a new one with a different and more complete solution.

[GitHub] [netbeans] neilcsmith-net commented on issue #1502: Custom select clusters installer

2019-09-14 Thread GitBox
neilcsmith-net commented on issue #1502: Custom select clusters installer URL: https://github.com/apache/netbeans/pull/1502#issuecomment-531504059 11.1 has a lot of commits that are not meant to go in master though. This is

[GitHub] [netbeans] geertjanw merged pull request #1491: [NETBEANS-2953] Fix for NPE after pressing 'DTDs and XML Schemas' men…

2019-09-14 Thread GitBox
geertjanw merged pull request #1491: [NETBEANS-2953] Fix for NPE after pressing 'DTDs and XML Schemas' men… URL: https://github.com/apache/netbeans/pull/1491 This is an automated message from the Apache Git Service. To

[GitHub] [netbeans] geertjanw commented on issue #1491: [NETBEANS-2953] Fix for NPE after pressing 'DTDs and XML Schemas' men…

2019-09-14 Thread GitBox
geertjanw commented on issue #1491: [NETBEANS-2953] Fix for NPE after pressing 'DTDs and XML Schemas' men… URL: https://github.com/apache/netbeans/pull/1491#issuecomment-531507853 Thanks, merging. This is an automated

[GitHub] [netbeans] geertjanw commented on issue #1477: [NETBEANS-2788] The link provided for downloading Groovy is obsolete

2019-09-14 Thread GitBox
geertjanw commented on issue #1477: [NETBEANS-2788] The link provided for downloading Groovy is obsolete URL: https://github.com/apache/netbeans/pull/1477#issuecomment-531507922 Is this ready to merge, all comments completed?

[GitHub] [netbeans] rtaneja1 opened a new pull request #1505: Install subsets

2019-09-14 Thread GitBox
rtaneja1 opened a new pull request #1505: Install subsets URL: https://github.com/apache/netbeans/pull/1505 Enabled Customize panel in installer wizards to select the cluster to install. Currently support Javase, Javaee, HTML/JS,PHP Test installers are shared here:

[GitHub] [netbeans] geertjanw commented on issue #1503: [NETBEANS-2751] OpenJFX Samples

2019-09-14 Thread GitBox
geertjanw commented on issue #1503: [NETBEANS-2751] OpenJFX Samples URL: https://github.com/apache/netbeans/pull/1503#issuecomment-531504531 This should go into 11.2, hope my adding the nb11.2 label helps to achieve that.

[GitHub] [netbeans] oyarzun commented on a change in pull request #1496: [NETBEANS-3095] avoid null pointer exception in SplashPainter

2019-09-14 Thread GitBox
oyarzun commented on a change in pull request #1496: [NETBEANS-3095] avoid null pointer exception in SplashPainter URL: https://github.com/apache/netbeans/pull/1496#discussion_r324435218 ## File path: platform/core.startup/src/org/netbeans/core/startup/Splash.java ## @@

[GitHub] [netbeans] geertjanw commented on issue #1499: [NETBEANS-3082]: Fixed formatting issue happening on use of Switch-Ex…

2019-09-14 Thread GitBox
geertjanw commented on issue #1499: [NETBEANS-3082]: Fixed formatting issue happening on use of Switch-Ex… URL: https://github.com/apache/netbeans/pull/1499#issuecomment-531507709 Thanks, merging. This is an automated

[GitHub] [netbeans] geertjanw merged pull request #1499: [NETBEANS-3082]: Fixed formatting issue happening on use of Switch-Ex…

2019-09-14 Thread GitBox
geertjanw merged pull request #1499: [NETBEANS-3082]: Fixed formatting issue happening on use of Switch-Ex… URL: https://github.com/apache/netbeans/pull/1499 This is an automated message from the Apache Git Service. To

[GitHub] [netbeans] geertjanw commented on issue #1487: [NETBEANS-3078]:Provided Error Hint to turn on Preview Features in An…

2019-09-14 Thread GitBox
geertjanw commented on issue #1487: [NETBEANS-3078]:Provided Error Hint to turn on Preview Features in An… URL: https://github.com/apache/netbeans/pull/1487#issuecomment-531507782 Great, very useful, merging, This is an

[GitHub] [netbeans] geertjanw merged pull request #1487: [NETBEANS-3078]:Provided Error Hint to turn on Preview Features in An…

2019-09-14 Thread GitBox
geertjanw merged pull request #1487: [NETBEANS-3078]:Provided Error Hint to turn on Preview Features in An… URL: https://github.com/apache/netbeans/pull/1487 This is an automated message from the Apache Git Service. To

[GitHub] [netbeans] geertjanw commented on issue #1503: [NETBEANS-2751] OpenJFX Samples

2019-09-14 Thread GitBox
geertjanw commented on issue #1503: [NETBEANS-2751] OpenJFX Samples URL: https://github.com/apache/netbeans/pull/1503#issuecomment-531513664 Also thanks for liking and approving it. This is an automated message from the

[GitHub] [netbeans] neilcsmith-net commented on issue #1502: Custom select clusters installer

2019-09-14 Thread GitBox
neilcsmith-net commented on issue #1502: Custom select clusters installer URL: https://github.com/apache/netbeans/pull/1502#issuecomment-531499351 This looks like it was based off the 11.1 release branch rather than master?

[GitHub] [netbeans] rtaneja1 commented on issue #1502: Custom select clusters installer

2019-09-14 Thread GitBox
rtaneja1 commented on issue #1502: Custom select clusters installer URL: https://github.com/apache/netbeans/pull/1502#issuecomment-531499689 I started work on branch off release 11.1, but this only includes installers related files.

[GitHub] [netbeans] geertjanw commented on issue #1431: Fixing java.source.base tests when running with nb-javac

2019-09-14 Thread GitBox
geertjanw commented on issue #1431: Fixing java.source.base tests when running with nb-javac URL: https://github.com/apache/netbeans/pull/1431#issuecomment-531507984 Please merge when ready, @jlahoda. This is an automated

[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #1503: [NETBEANS-2751] OpenJFX Samples

2019-09-14 Thread GitBox
matthiasblaesing commented on a change in pull request #1503: [NETBEANS-2751] OpenJFX Samples URL: https://github.com/apache/netbeans/pull/1503#discussion_r324437904 ## File path: javafx/javafx2.samples/src/org/netbeans/modules/javafx2/samples/resources/layer.xml ## @@

[GitHub] [netbeans] lbruun opened a new pull request #1504: [NETBEANS-3094] NBI cleaner process must attempt to remove read-only files too

2019-09-14 Thread GitBox
lbruun opened a new pull request #1504: [NETBEANS-3094] NBI cleaner process must attempt to remove read-only files too URL: https://github.com/apache/netbeans/pull/1504 Currently the NBI cleaner process fails to attempt files/folders if they have the read-only attribute set. With this

[GitHub] [netbeans] rtaneja1 opened a new pull request #1502: Custom select clusters installer

2019-09-14 Thread GitBox
rtaneja1 opened a new pull request #1502: Custom select clusters installer URL: https://github.com/apache/netbeans/pull/1502 Enabled Customize panel in installer wizards to select the cluster to install. Support Javase, Javaee, HTML/JS,PHP

[GitHub] [netbeans] rtaneja1 closed pull request #1502: Custom select clusters installer

2019-09-14 Thread GitBox
rtaneja1 closed pull request #1502: Custom select clusters installer URL: https://github.com/apache/netbeans/pull/1502 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [netbeans] lkishalmi merged pull request #1483: [NETBEANS-3076] Try to create unit-test with Gradle Projects

2019-09-14 Thread GitBox
lkishalmi merged pull request #1483: [NETBEANS-3076] Try to create unit-test with Gradle Projects URL: https://github.com/apache/netbeans/pull/1483 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [netbeans] geertjanw commented on issue #1503: [NETBEANS-2751] OpenJFX Samples

2019-09-14 Thread GitBox
geertjanw commented on issue #1503: [NETBEANS-2751] OpenJFX Samples URL: https://github.com/apache/netbeans/pull/1503#issuecomment-531504345 https://user-images.githubusercontent.com/5309985/64912519-ea405f00-d730-11e9-816a-651a1579b0ef.png;> That's the new structure in the Samples

[GitHub] [netbeans] geertjanw opened a new pull request #1503: [NETBEANS-2751] OpenJFX Samples

2019-09-14 Thread GitBox
geertjanw opened a new pull request #1503: [NETBEANS-2751] OpenJFX Samples URL: https://github.com/apache/netbeans/pull/1503 This does the following: - Integrates the OpenJFX Gluon samples correctly, using their new 0.0.3 release. - Restructures the Samples category in the New

[GitHub] [netbeans] geertjanw commented on issue #1503: [NETBEANS-2751] OpenJFX Samples

2019-09-14 Thread GitBox
geertjanw commented on issue #1503: [NETBEANS-2751] OpenJFX Samples URL: https://github.com/apache/netbeans/pull/1503#issuecomment-531513601 Thanks, fixed. This is an automated message from the Apache Git Service. To respond

[GitHub] [netbeans] junichi11 commented on issue #1496: [NETBEANS-3095] avoid null pointer exception in SplashPainter

2019-09-14 Thread GitBox
junichi11 commented on issue #1496: [NETBEANS-3095] avoid null pointer exception in SplashPainter URL: https://github.com/apache/netbeans/pull/1496#issuecomment-531522004 @oyarzun Thank you! @eirikbakke Thank you for your review!

[GitHub] [netbeans] lkishalmi merged pull request #1501: [NETBEANS-3041] Support passing JVM Arguments to Gradle Daemon

2019-09-14 Thread GitBox
lkishalmi merged pull request #1501: [NETBEANS-3041] Support passing JVM Arguments to Gradle Daemon URL: https://github.com/apache/netbeans/pull/1501 This is an automated message from the Apache Git Service. To respond to

[GitHub] [netbeans] eirikbakke commented on a change in pull request #1496: [NETBEANS-3095] avoid null pointer exception in SplashPainter

2019-09-14 Thread GitBox
eirikbakke commented on a change in pull request #1496: [NETBEANS-3095] avoid null pointer exception in SplashPainter URL: https://github.com/apache/netbeans/pull/1496#discussion_r324437438 ## File path: platform/core.startup/src/org/netbeans/core/startup/Splash.java ##

[GitHub] [netbeans] eirikbakke commented on a change in pull request #1496: [NETBEANS-3095] avoid null pointer exception in SplashPainter

2019-09-14 Thread GitBox
eirikbakke commented on a change in pull request #1496: [NETBEANS-3095] avoid null pointer exception in SplashPainter URL: https://github.com/apache/netbeans/pull/1496#discussion_r324437425 ## File path: platform/core.startup/src/org/netbeans/core/startup/Splash.java ##

[GitHub] [netbeans] eirikbakke commented on a change in pull request #1496: [NETBEANS-3095] avoid null pointer exception in SplashPainter

2019-09-14 Thread GitBox
eirikbakke commented on a change in pull request #1496: [NETBEANS-3095] avoid null pointer exception in SplashPainter URL: https://github.com/apache/netbeans/pull/1496#discussion_r324437404 ## File path: platform/core.startup/src/org/netbeans/core/startup/Splash.java ##

[GitHub] [netbeans] geertjanw merged pull request #1503: [NETBEANS-2751] OpenJFX Samples

2019-09-14 Thread GitBox
geertjanw merged pull request #1503: [NETBEANS-2751] OpenJFX Samples URL: https://github.com/apache/netbeans/pull/1503 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [netbeans] geertjanw commented on issue #1503: [NETBEANS-2751] OpenJFX Samples

2019-09-14 Thread GitBox
geertjanw commented on issue #1503: [NETBEANS-2751] OpenJFX Samples URL: https://github.com/apache/netbeans/pull/1503#issuecomment-531536293 I don’t think this is a fundamental change, just a little bit of reorganization, i.e., a lot of debate and discussion is not needed for this one