[GitHub] jlahoda opened a new pull request #523: Avoid failure of 'ant javadoc' for modules that don't have src dir, l…

2018-04-27 Thread GitBox
jlahoda opened a new pull request #523: Avoid failure of 'ant javadoc' for modules that don't have src dir, l… URL: https://github.com/apache/incubator-netbeans/pull/523 …ike c.google.guava or net.java.html This is an

[GitHub] Chris2011 commented on issue #481: [NETBEANS-290] Provided support for hyperlink on dependencies.

2018-04-27 Thread GitBox
Chris2011 commented on issue #481: [NETBEANS-290] Provided support for hyperlink on dependencies. URL: https://github.com/apache/incubator-netbeans/pull/481#issuecomment-385029936 Is this helpfull or do you need more info? I have spring-boot framework. This is one little part of my pom

[GitHub] mcdonnell-john commented on issue #481: [NETBEANS-290] Provided support for hyperlink on dependencies.

2018-04-27 Thread GitBox
mcdonnell-john commented on issue #481: [NETBEANS-290] Provided support for hyperlink on dependencies. URL: https://github.com/apache/incubator-netbeans/pull/481#issuecomment-384989512 @Chris2011 Yes, I made sure that the NPE wouldn't get thrown again in this scenario.

[GitHub] JaroslavTulach closed pull request #522: Fix @PropertyEditorRegistration to work with inner classes

2018-04-27 Thread GitBox
JaroslavTulach closed pull request #522: Fix @PropertyEditorRegistration to work with inner classes URL: https://github.com/apache/incubator-netbeans/pull/522 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] sdedic commented on issue #522: Fix @PropertyEditorRegistration to work with inner classes

2018-04-27 Thread GitBox
sdedic commented on issue #522: Fix @PropertyEditorRegistration to work with inner classes URL: https://github.com/apache/incubator-netbeans/pull/522#issuecomment-384929313 Best practices should be followed ... test added.

[GitHub] sdedic opened a new pull request #522: Fix @PropertyEditorRegistration to work with inner classes

2018-04-27 Thread GitBox
sdedic opened a new pull request #522: Fix @PropertyEditorRegistration to work with inner classes URL: https://github.com/apache/incubator-netbeans/pull/522 I found out that when `targetType` is an inner class, the generated layer registration uses `.` as delimiter between outer and inner

[GitHub] emilianbold commented on issue #518: [NETBEANS-342] Enable G1's String Deduplication

2018-04-27 Thread GitBox
emilianbold commented on issue #518: [NETBEANS-342] Enable G1's String Deduplication URL: https://github.com/apache/incubator-netbeans/pull/518#issuecomment-384886846 Ah, here it is: https://docs.oracle.com/javase/8/docs/technotes/tools/unix/java.html > -client > Selects the

[GitHub] emilianbold commented on issue #518: [NETBEANS-342] Enable G1's String Deduplication

2018-04-27 Thread GitBox
emilianbold commented on issue #518: [NETBEANS-342] Enable G1's String Deduplication URL: https://github.com/apache/incubator-netbeans/pull/518#issuecomment-384886086 String Deduplication sounds good to me. Could you post a link about the -client flag? I just can't google any page about