[GitHub] [netbeans] junichi11 commented on issue #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output

2019-08-14 Thread GitBox
junichi11 commented on issue #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output URL: https://github.com/apache/netbeans/pull/1402#issuecomment-521423750 @matthiasblaesing I'm not an expert of this area, but if there are steps to verify this, I would like to do

[GitHub] [netbeans] junichi11 commented on a change in pull request #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output

2019-08-14 Thread GitBox
junichi11 commented on a change in pull request #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output URL: https://github.com/apache/netbeans/pull/1402#discussion_r314086833 ## File path:

[GitHub] [netbeans] matthiasblaesing commented on issue #1392: [NETBEANS-97] Don't add braces around try/synchronized blocks when reformatting

2019-08-14 Thread GitBox
matthiasblaesing commented on issue #1392: [NETBEANS-97] Don't add braces around try/synchronized blocks when reformatting URL: https://github.com/apache/netbeans/pull/1392#issuecomment-521368152 @lbruun @sdedic could you please have a look at this and see if the concerns raised on the

[GitHub] [netbeans] peedeeboy commented on issue #1412: [NETBEANS-2775] Fix duplicate server entries by filtering using PlatformFactory

2019-08-14 Thread GitBox
peedeeboy commented on issue #1412: [NETBEANS-2775] Fix duplicate server entries by filtering using PlatformFactory URL: https://github.com/apache/netbeans/pull/1412#issuecomment-521364350 @neilcsmith-net @jGauravGupta just to say that I tested this by cloning a fresh copy of master, then

[GitHub] [netbeans] matthiasblaesing merged pull request #1382: Fix NPE if PAC cannot be resolved

2019-08-14 Thread GitBox
matthiasblaesing merged pull request #1382: Fix NPE if PAC cannot be resolved URL: https://github.com/apache/netbeans/pull/1382 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [netbeans] matthiasblaesing commented on issue #1382: Fix NPE if PAC cannot be resolved

2019-08-14 Thread GitBox
matthiasblaesing commented on issue #1382: Fix NPE if PAC cannot be resolved URL: https://github.com/apache/netbeans/pull/1382#issuecomment-521362332 I'm not sure if it would be better to retry initializing the proxy would also be a good idea, but I see, that this makes more sense then

[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #1385: Cleanup raw class type

2019-08-14 Thread GitBox
matthiasblaesing commented on a change in pull request #1385: Cleanup raw class type URL: https://github.com/apache/netbeans/pull/1385#discussion_r313995367 ## File path: contrib/javaee.wildfly/src/org/netbeans/modules/javaee/wildfly/ide/commands/WildflyManagementAPI.java

[GitHub] [netbeans] matthiasblaesing commented on issue #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output

2019-08-14 Thread GitBox
matthiasblaesing commented on issue #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output URL: https://github.com/apache/netbeans/pull/1402#issuecomment-521340176 @junichi11 thanks for looking into this - I updated the missing `NOI18N` marker and updated the

[GitHub] [netbeans] ehsavoie commented on a change in pull request #1426: [NETBEANS-2980] Fix potential NPE on ImportAnalysis2.getPackage()

2019-08-14 Thread GitBox
ehsavoie commented on a change in pull request #1426: [NETBEANS-2980] Fix potential NPE on ImportAnalysis2.getPackage() URL: https://github.com/apache/netbeans/pull/1426#discussion_r313833679 ## File path:

[GitHub] [netbeans] ehsavoie merged pull request #1420: [NETBEANS-2975]: Schema2Beans shouldn't return 'null' for primitive types.

2019-08-14 Thread GitBox
ehsavoie merged pull request #1420: [NETBEANS-2975]: Schema2Beans shouldn't return 'null' for primitive types. URL: https://github.com/apache/netbeans/pull/1420 This is an automated message from the Apache Git Service. To

[GitHub] [netbeans] junichi11 commented on a change in pull request #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output

2019-08-14 Thread GitBox
junichi11 commented on a change in pull request #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output URL: https://github.com/apache/netbeans/pull/1402#discussion_r313818963 ## File path:

[GitHub] [netbeans] junichi11 commented on a change in pull request #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output

2019-08-14 Thread GitBox
junichi11 commented on a change in pull request #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output URL: https://github.com/apache/netbeans/pull/1402#discussion_r313818460 ## File path:

[GitHub] [netbeans] junichi11 commented on a change in pull request #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output

2019-08-14 Thread GitBox
junichi11 commented on a change in pull request #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output URL: https://github.com/apache/netbeans/pull/1402#discussion_r313818460 ## File path:

[GitHub] [netbeans] junichi11 commented on a change in pull request #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output

2019-08-14 Thread GitBox
junichi11 commented on a change in pull request #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output URL: https://github.com/apache/netbeans/pull/1402#discussion_r313818042 ## File path:

[GitHub] [netbeans] junichi11 commented on a change in pull request #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output

2019-08-14 Thread GitBox
junichi11 commented on a change in pull request #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output URL: https://github.com/apache/netbeans/pull/1402#discussion_r313817351 ## File path:

[GitHub] [netbeans] junichi11 commented on a change in pull request #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output

2019-08-14 Thread GitBox
junichi11 commented on a change in pull request #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output URL: https://github.com/apache/netbeans/pull/1402#discussion_r313816997 ## File path: java/maven/src/org/netbeans/modules/maven/ActionProviderImpl.java

[GitHub] [netbeans] junichi11 commented on issue #1425: add gradle support org.gradle.jvmargs

2019-08-14 Thread GitBox
junichi11 commented on issue #1425: add gradle support org.gradle.jvmargs URL: https://github.com/apache/netbeans/pull/1425#issuecomment-521197674 @one-leaf Did you read this? https://netbeans.apache.org/participate/submit-pr.html You should create a branch. Did you read @lkishalmi

[GitHub] [netbeans] lkishalmi opened a new pull request #1427: [NETBEANS-1836] Applied proposed patch, not adding self to the remove selection.

2019-08-14 Thread GitBox
lkishalmi opened a new pull request #1427: [NETBEANS-1836] Applied proposed patch, not adding self to the remove selection. URL: https://github.com/apache/netbeans/pull/1427 This is an automated message from the Apache Git

[GitHub] [netbeans] lkishalmi opened a new pull request #1426: [NETBEANS-2980] Fix potential NPE on ImportAnalysis2.getPackage()

2019-08-14 Thread GitBox
lkishalmi opened a new pull request #1426: [NETBEANS-2980] Fix potential NPE on ImportAnalysis2.getPackage() URL: https://github.com/apache/netbeans/pull/1426 Trivial patch preventing NPE. The result of this method is already checked for null, so returning that would be fine.

[GitHub] [netbeans] tmysik merged pull request #1423: [NETBEANS-53] Improve constructor getter setter code generation

2019-08-14 Thread GitBox
tmysik merged pull request #1423: [NETBEANS-53] Improve constructor getter setter code generation URL: https://github.com/apache/netbeans/pull/1423 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [netbeans] tmysik commented on a change in pull request #1423: [NETBEANS-53] Improve constructor getter setter code generation

2019-08-14 Thread GitBox
tmysik commented on a change in pull request #1423: [NETBEANS-53] Improve constructor getter setter code generation URL: https://github.com/apache/netbeans/pull/1423#discussion_r313758384 ## File path: php/php.api.phpmodule/src/org/netbeans/modules/php/api/PhpVersion.java

[GitHub] [netbeans] one-leaf opened a new pull request #1425: add gradle support org.gradle.jvmargs

2019-08-14 Thread GitBox
one-leaf opened a new pull request #1425: add gradle support org.gradle.jvmargs URL: https://github.com/apache/netbeans/pull/1425 add read jvmargs from gradle.properties. This is an automated message from the Apache Git

[GitHub] [netbeans] one-leaf closed pull request #1416: add read jvmargs from ~/.gradle/gradle.properties.

2019-08-14 Thread GitBox
one-leaf closed pull request #1416: add read jvmargs from ~/.gradle/gradle.properties. URL: https://github.com/apache/netbeans/pull/1416 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [netbeans] junichi11 commented on issue #1423: [NETBEANS-53] Improve constructor getter setter code generation

2019-08-14 Thread GitBox
junichi11 commented on issue #1423: [NETBEANS-53] Improve constructor getter setter code generation URL: https://github.com/apache/netbeans/pull/1423#issuecomment-521137816 Fixed. It's a great idea to add methods to `PhpVersion`. Thank you, Tomas!

[GitHub] [netbeans] jlahoda merged pull request #1322: Fixing java.completion tests on JDK 13.

2019-08-14 Thread GitBox
jlahoda merged pull request #1322: Fixing java.completion tests on JDK 13. URL: https://github.com/apache/netbeans/pull/1322 This is an automated message from the Apache Git Service. To respond to the message, please log on