[GitHub] [netbeans] rtaneja1 opened a new pull request #1443: Jdk13 text block support

2019-08-18 Thread GitBox
rtaneja1 opened a new pull request #1443: Jdk13 text block support URL: https://github.com/apache/netbeans/pull/1443 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [netbeans] matthiasblaesing commented on issue #1442: Fix tests in ide/versioning module

2019-08-18 Thread GitBox
matthiasblaesing commented on issue #1442: Fix tests in ide/versioning module URL: https://github.com/apache/netbeans/pull/1442#issuecomment-522349596 Could you please describe what you are fixing and how it is archived? I see that before your change I see failures and afterwards they are

[GitHub] [netbeans] matthiasblaesing commented on issue #1439: Fix tests in ide/db.mysql module

2019-08-18 Thread GitBox
matthiasblaesing commented on issue #1439: Fix tests in ide/db.mysql module URL: https://github.com/apache/netbeans/pull/1439#issuecomment-522348903 I can understand why you check for the mysql driver, but without the driver none of the tests is run - so why pretend different? I would not

[GitHub] [netbeans] matthiasblaesing merged pull request #1437: Fix tests in ide/db module

2019-08-18 Thread GitBox
matthiasblaesing merged pull request #1437: Fix tests in ide/db module URL: https://github.com/apache/netbeans/pull/1437 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [netbeans] matthiasblaesing commented on issue #1437: Fix tests in ide/db module

2019-08-18 Thread GitBox
matthiasblaesing commented on issue #1437: Fix tests in ide/db module URL: https://github.com/apache/netbeans/pull/1437#issuecomment-522348707 I get nervous if people catch `Throwable`, but I think in this case its ok. Merging. Thank you.

[GitHub] [netbeans] matthiasblaesing merged pull request #1440: Fix tests in ide/versioning.ui module

2019-08-18 Thread GitBox
matthiasblaesing merged pull request #1440: Fix tests in ide/versioning.ui module URL: https://github.com/apache/netbeans/pull/1440 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [netbeans] matthiasblaesing commented on issue #1440: Fix tests in ide/versioning.ui module

2019-08-18 Thread GitBox
matthiasblaesing commented on issue #1440: Fix tests in ide/versioning.ui module URL: https://github.com/apache/netbeans/pull/1440#issuecomment-522347039 Looks good to me. This is an automated message from the Apache Git

[GitHub] [netbeans] matthiasblaesing merged pull request #1438: Fix derby database tests in ide/db.metadata.model module.

2019-08-18 Thread GitBox
matthiasblaesing merged pull request #1438: Fix derby database tests in ide/db.metadata.model module. URL: https://github.com/apache/netbeans/pull/1438 This is an automated message from the Apache Git Service. To respond to

[GitHub] [netbeans] matthiasblaesing commented on issue #1438: Fix derby database tests in ide/db.metadata.model module.

2019-08-18 Thread GitBox
matthiasblaesing commented on issue #1438: Fix derby database tests in ide/db.metadata.model module. URL: https://github.com/apache/netbeans/pull/1438#issuecomment-522346623 Looks good to me. Thank you. This is an automated

[GitHub] [netbeans] matthiasblaesing merged pull request #1429: Fix SaasUtilTest test in websvc.saas.api module

2019-08-18 Thread GitBox
matthiasblaesing merged pull request #1429: Fix SaasUtilTest test in websvc.saas.api module URL: https://github.com/apache/netbeans/pull/1429 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [netbeans] matthiasblaesing commented on issue #1429: Fix SaasUtilTest test in websvc.saas.api module

2019-08-18 Thread GitBox
matthiasblaesing commented on issue #1429: Fix SaasUtilTest test in websvc.saas.api module URL: https://github.com/apache/netbeans/pull/1429#issuecomment-522346188 Looks sane - thank you. This is an automated message from

[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #1428: Adding Markdown syntax highlighting

2019-08-18 Thread GitBox
matthiasblaesing commented on a change in pull request #1428: Adding Markdown syntax highlighting URL: https://github.com/apache/netbeans/pull/1428#discussion_r314995806 ## File path: nbbuild/licenses/CC0-markdown ## @@ -0,0 +1,35 @@ +DEDICATED TO THE PUBLIC DOMAIN BY

[GitHub] [netbeans] blackleg opened a new pull request #1442: Fix tests in ide/versioning module

2019-08-18 Thread GitBox
blackleg opened a new pull request #1442: Fix tests in ide/versioning module URL: https://github.com/apache/netbeans/pull/1442 Fix tests in ide/versioning module This is an automated message from the Apache Git Service. To

[GitHub] [netbeans] blackleg opened a new pull request #1441: Fix tests in ide/versioning.core module

2019-08-18 Thread GitBox
blackleg opened a new pull request #1441: Fix tests in ide/versioning.core module URL: https://github.com/apache/netbeans/pull/1441 Fix tests in ide/versioning.core module This is an automated message from the Apache Git

[GitHub] [netbeans] oyarzun commented on issue #1203: [NETBEANS-2361] Fix app.conf and launcher on macOS after changes in #573

2019-08-18 Thread GitBox
oyarzun commented on issue #1203: [NETBEANS-2361] Fix app.conf and launcher on macOS after changes in #573 URL: https://github.com/apache/netbeans/pull/1203#issuecomment-522327678 @branscha It looks like the problem is that nbm-maven-plugin needs to be updated and built with the new

[GitHub] [netbeans] branscha commented on issue #1203: [NETBEANS-2361] Fix app.conf and launcher on macOS after changes in #573

2019-08-18 Thread GitBox
branscha commented on issue #1203: [NETBEANS-2361] Fix app.conf and launcher on macOS after changes in #573 URL: https://github.com/apache/netbeans/pull/1203#issuecomment-522325156 @oyarzun I am creating a netbeans platform application on Linux (not on OSX), and I still get the extra "

[GitHub] [netbeans] mcdonnell-john merged pull request #1421: [NETBEANS-2418][NETBEANS-2298] update suggested MySQL Driver to latest

2019-08-18 Thread GitBox
mcdonnell-john merged pull request #1421: [NETBEANS-2418][NETBEANS-2298] update suggested MySQL Driver to latest URL: https://github.com/apache/netbeans/pull/1421 This is an automated message from the Apache Git Service. To

[GitHub] [netbeans] blackleg opened a new pull request #1440: Fix tests in ide/versioning.ui module

2019-08-18 Thread GitBox
blackleg opened a new pull request #1440: Fix tests in ide/versioning.ui module URL: https://github.com/apache/netbeans/pull/1440 Fix tests in ide/versioning.ui module This is an automated message from the Apache Git Service.

[GitHub] [netbeans] oyarzun edited a comment on issue #1203: [NETBEANS-2361] Fix app.conf and launcher on macOS after changes in #573

2019-08-18 Thread GitBox
oyarzun edited a comment on issue #1203: [NETBEANS-2361] Fix app.conf and launcher on macOS after changes in #573 URL: https://github.com/apache/netbeans/pull/1203#issuecomment-522322299 @branscha This was merged in before 11.1 was released. It is included in the binaries from

[GitHub] [netbeans] oyarzun commented on issue #1203: [NETBEANS-2361] Fix app.conf and launcher on macOS after changes in #573

2019-08-18 Thread GitBox
oyarzun commented on issue #1203: [NETBEANS-2361] Fix app.conf and launcher on macOS after changes in #573 URL: https://github.com/apache/netbeans/pull/1203#issuecomment-522322299 @branscha This was merged in before 11.1 was released. It is included in the binaries from

[GitHub] [netbeans] blackleg opened a new pull request #1439: Fix tests in ide/db.mysql module

2019-08-18 Thread GitBox
blackleg opened a new pull request #1439: Fix tests in ide/db.mysql module URL: https://github.com/apache/netbeans/pull/1439 Fix tests in ide/db.mysql module, tests are disable if class `com.mysql.jdbc.Driver` isn't available in the classpath.

[GitHub] [netbeans] Saljack commented on issue #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output

2019-08-18 Thread GitBox
Saljack commented on issue #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output URL: https://github.com/apache/netbeans/pull/1402#issuecomment-522306875 Would it be possible to add something like IT into tab label instead of `_2` for example `nameofproject...

[GitHub] [netbeans] matthiasblaesing commented on issue #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output

2019-08-18 Thread GitBox
matthiasblaesing commented on issue #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output URL: https://github.com/apache/netbeans/pull/1402#issuecomment-522304059 @toepi no it does not change the GUI integration for running test. That was out of scope for this.

[GitHub] [netbeans] matthiasblaesing commented on issue #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output

2019-08-18 Thread GitBox
matthiasblaesing commented on issue #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output URL: https://github.com/apache/netbeans/pull/1402#issuecomment-522304094 @junichi11 thanks for checking This

[GitHub] [netbeans] toepi commented on issue #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output

2019-08-18 Thread GitBox
toepi commented on issue #1402: [NETBEANS-1763] Integrate maven failsafe output into test runner output URL: https://github.com/apache/netbeans/pull/1402#issuecomment-522303866 sry to ask, has this change also a impact on 'Test File'? Currently if I you it on a `*Test` file it will use