[GitHub] [netbeans] matthiasblaesing merged pull request #4986: Lookup CSS properties case-insensitive
matthiasblaesing merged PR #4986: URL: https://github.com/apache/netbeans/pull/4986 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing closed issue #4861: CSS: Hint "unknown property" is displayed, in case the css property is written in uppercase letters.
matthiasblaesing closed issue #4861: CSS: Hint "unknown property" is displayed, in case the css property is written in uppercase letters. URL: https://github.com/apache/netbeans/issues/4861 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #4979: Optimize matching for CSS completion queries
matthiasblaesing merged PR #4979: URL: https://github.com/apache/netbeans/pull/4979 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing closed issue #4778: CSS: Show documentation (ctrl+shift+space) displays incorrect documentation
matthiasblaesing closed issue #4778: CSS: Show documentation (ctrl+shift+space) displays incorrect documentation URL: https://github.com/apache/netbeans/issues/4778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4964: Css improvements
matthiasblaesing commented on PR #4964: URL: https://github.com/apache/netbeans/pull/4964#issuecomment-1327690259 Hearing no objections and having used this the last few days I'll merge this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #4964: Css improvements
matthiasblaesing merged PR #4964: URL: https://github.com/apache/netbeans/pull/4964 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing closed issue #4304: CSS hex color support with alpha
matthiasblaesing closed issue #4304: CSS hex color support with alpha URL: https://github.com/apache/netbeans/issues/4304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing closed issue #4312: CSS: min-width: auto => Unexpected character(s) "auto" found
matthiasblaesing closed issue #4312: CSS: min-width: auto => Unexpected character(s) "auto" found URL: https://github.com/apache/netbeans/issues/4312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4728: LSP Client: Use full complete item to complete, not just the missing suffix
matthiasblaesing commented on PR #4728: URL: https://github.com/apache/netbeans/pull/4728#issuecomment-1327837798 Hearing no objects, having run with this the last few weeks, travis and github action being happy. I'll merge this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #4728: LSP Client: Use full complete item to complete, not just the missing suffix
matthiasblaesing merged PR #4728: URL: https://github.com/apache/netbeans/pull/4728 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #5006: Gradle: Support for proxy detection / autoconfiguration.
sdedic commented on PR #5006: URL: https://github.com/apache/netbeans/pull/5006#issuecomment-1327892602 I would advise against that, but it is surely doable. In siuations where the DNS does not reject the proxy name immediately (timeout) or when the intranet simply drops (not rejects) outgoing packets, gradle app + network timeouts are huuge. It may take several to dozen minutes for the project load to fail. It seemed safer + better user experience to hook before any non-offline operation and check in advance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] javierllorente commented on pull request #57: NBPackage RPM fixes and options tidy up towards first release
javierllorente commented on PR #57:
URL: https://github.com/apache/netbeans-tools/pull/57#issuecomment-1327932784
Nice job cleaning :)
One question: why are you using hard-coded paths instead of rpm macros? ie:
/usr/bin vs %{_bindir}
I also have a suggestion for a future version: signing rpms.
```
apache-netbeans-16-0.noarch.rpm:
Package header is not signed!
apache-netbeans-16-0.noarch (Plain RPM files cache): Signature verification
failed [6-File is unsigned]
Abort, retry, ignore? [a/r/i] (a):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien opened a new pull request, #5009: adds a basic maven dependency updater hint.
mbien opened a new pull request, #5009: URL: https://github.com/apache/netbeans/pull/5009 - marks artifacts which have a newer version available - provides a fix to bump the version - supports maven properties - ignores non-numerical versions I wasn't sure whether or not to enable this by default but I decided to enable it mostly because: - many new-project-poms are outdated, this mitigates the issue a little bit (this is also the original motivation for the hint) - poms don't have a lot of hints right now, so adding a little bit of noise probably doesn't hurt atm - users can turn it off / we can turn it off based on feedback later I leave this as draft until I got more testing in. Performance isn't bad so far. It checks large poms in about a second. Although I noticed that the cancel method is never called on maven hints? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-native-launchers] eirikbakke commented on pull request #4: Windows: Allow NetBeans to run with non-ASCII path in some cases
eirikbakke commented on PR #4: URL: https://github.com/apache/netbeans-native-launchers/pull/4#issuecomment-1327994817 I did some additional work on supporting launching from paths containing arbitrary unicode characters, but it needs a bit of additional testing before I can make a PR out of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] trixon commented on issue #5003: Possible to hide, remove, or override Help button on Platform Applications?
trixon commented on issue #5003:
URL: https://github.com/apache/netbeans/issues/5003#issuecomment-1328037196
For a) I use
System.setProperty("netbeans.winsys.no_help_in_dialogs", "true");
as per
https://bits.netbeans.org/dev/javadoc/org-openide-windows/architecture-summary.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] neilcsmith-net commented on pull request #57: NBPackage RPM fixes and options tidy up towards first release
neilcsmith-net commented on PR #57:
URL: https://github.com/apache/netbeans-tools/pull/57#issuecomment-1328040112
> One question: why are you using hard-coded paths instead of rpm macros?
ie: /usr/bin vs %{_bindir}
Because I had a problem with `rpmbuild` resolving `%{_libdir}` to be
`/usr/lib64` and then complaining about missing files. The image and the
`/bin/netbeans` file are currently built to expect `/usr/lib`. This is
mentioned in the to-do at
https://github.com/apache/netbeans-tools/blob/master/nbpackage/src/main/java/org/apache/netbeans/nbpackage/rpm/RpmTask.java#L68
While `%{_bindir}` is probably OK, it made sense to hard-code all the paths
set in the image for now, unless I'm missing something obvious?
Removing the wildcard on `/usr/lib/` also seems to be needed to ensure the
`/usr/lib/apache-netbeans` directory is deleted on uninstall.
I couldn't get either the noarch (without JDK) or x86_64 (with JDK)
packaging to work on my setup. They both work for you before? And with these
changes?
> I also have a suggestion for a future version: signing rpms.
Sounds like it could be a good addition. The macOS packager is the only one
with built in signing, including signing of binaries inside JARs, currently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] javierllorente commented on pull request #57: NBPackage RPM fixes and options tidy up towards first release
javierllorente commented on PR #57:
URL: https://github.com/apache/netbeans-tools/pull/57#issuecomment-1328093167
> Because I had a problem with rpmbuild resolving %{_libdir} to be
/usr/lib64 and then complaining about missing files. The image and the
/bin/netbeans file are currently built to expect /usr/lib. This is mentioned in
the to-do at
https://github.com/apache/netbeans-tools/blob/master/nbpackage/src/main/java/org/apache/netbeans/nbpackage/rpm/RpmTask.java#L68
Having `BuildArch: noarch` should make `%{_libdir}` resolve to `/usr/lib/`.
I had no problems with this. Same with `%{_bindir}`
> Removing the wildcard on /usr/lib/ also seems to be needed to ensure the
/usr/lib/apache-netbeans directory is deleted on uninstall.
I have just seen that there was a leftover after uninstalling it. Thanks for
fixing it.
>I couldn't get either the noarch (without JDK) or x86_64 (with JDK)
packaging to work on my setup. They both work for you before? And with these
changes?
I have only tested the rpm without JDK. I had no issues with packaging
before (and after your changes). I am not using any fancy options;
`nbpackage-1.0-beta1-SNAPSHOT/bin/nbpackage --verbose --type linux-rpm
--input /home/javier/Descargas/netbeans-16-rc4-bin.zip -Ppackage.name="Apache
NetBeans" -Ppackage.version=16 -Ppackage.rpm.maintainer="My name
"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] noelma opened a new issue, #5010: Detection of syntax highlighting when using heredoc
noelma opened a new issue, #5010: URL: https://github.com/apache/netbeans/issues/5010 ### Description The HereDoc syntax in PHP allows you to specify the string type. I would like Netbeans to detect the type of string and apply syntax highlighting. ### Use case/motivation If the string type starts with a type known to netbeans, apply syntax highlighting to the string Currently:  Goal:  ### Related issues _No response_ ### Are you willing to submit a pull request? No ### Code of Conduct Yes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] neilcsmith-net commented on pull request #57: NBPackage RPM fixes and options tidy up towards first release
neilcsmith-net commented on PR #57:
URL: https://github.com/apache/netbeans-tools/pull/57#issuecomment-1328104349
> Having `BuildArch: noarch` should make `%{_libdir}` resolve to `/usr/lib/`
...
> I have only tested the rpm without JDK
That explains it then. Adding the JDK changes the arch to eg. x86_64 (now
the --eval call is fixed). This then changes the libdir value. Need to consider
option to change the image layout in future.
I needed the define to not terminate on binaries in the spec file to get
build without JDK to work.
Thanks for confirming this doesn't break things on your end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] korenevskiy commented on issue #4942: Add automatic closing of the menu IntelliSense.
korenevskiy commented on issue #4942: URL: https://github.com/apache/netbeans/issues/4942#issuecomment-1328119776 @neilcsmith-net @junichi11 Please, I need your support. What do you think about these problems? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #4985: Use Project Dictated JVM for Gradle Discovery
lkishalmi commented on PR #4985: URL: https://github.com/apache/netbeans/pull/4985#issuecomment-1328150120 Well, this form is a good enough implementation, without major changes. The `GradleProjectConnection` got rid of the "compatible" connection thing, So NetBeans does not try override the Gradle distribution in any case. The `javaHome` is set there so other places where `ProjectConnection` is needed, has the Java home and the Gradle Distribution set. The Java vs Gradle version mismatch problem only triggered, if the Project Java setting is off. I'm going to create a new update branch for NB16, where this and a few other fixes would go, as I think the Gradle support in base NB16 is not that great. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi merged pull request #4995: #4965: Fix issues with gradle pre-6.4
lkishalmi merged PR #4995: URL: https://github.com/apache/netbeans/pull/4995 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi closed issue #4965: Gradle: "Failed to retrieve project information" (Gradle 6.1.1)
lkishalmi closed issue #4965: Gradle: "Failed to retrieve project information" (Gradle 6.1.1) URL: https://github.com/apache/netbeans/issues/4965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi merged pull request #4984: [#4865] Register JDPA and Java Compiler Output on Project level
lkishalmi merged PR #4984: URL: https://github.com/apache/netbeans/pull/4984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi closed issue #4865: Gradle: can't debug composite build
lkishalmi closed issue #4865: Gradle: can't debug composite build URL: https://github.com/apache/netbeans/issues/4865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a diff in pull request #4860: Cleanup raw type Iterator warnings..
BradWalker commented on code in PR #4860:
URL: https://github.com/apache/netbeans/pull/4860#discussion_r1032876028
##
enterprise/j2eeserver/src/org/netbeans/modules/j2ee/deployment/config/ConfigSupportImpl.java:
##
@@ -151,8 +152,8 @@ public static File[] getDeploymentConfigurationFiles
(J2eeModuleProvider provide
public static FileObject[] getConfigurationFiles(J2eeModuleProvider jmp) {
Collection servers = ServerRegistry.getInstance().getServers();
-ArrayList files = new ArrayList();
-for (Iterator i=servers.iterator(); i.hasNext();) {
+List files = new ArrayList<>();
Review Comment:
Hey @mbien , it's fixed..
Can I get an approval from ya' ? 8-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] noelma opened a new issue, #5011: [PHP] coalescing operator is formatted as ternary operator
noelma opened a new issue, #5011: URL: https://github.com/apache/netbeans/issues/5011 ### Apache NetBeans version Apache NetBeans 15 ### What happened When I format my PHP 7+ code Coalescing operators are aligned as ternary operators Currently:  Goal:  Or separate into 2 packing option: - coalescing operator - ternary operator ### How to reproduce - In `Tools` > `Options` > `Editor` > `Formatting` > `PHP(Wrapping)`  - Use `Always` for the `Ternary Operator `option - And `Apply` - Insert the following code in a PHP file: ```php 10, 'key_2' => 100, ]; $tenaryOperator = isset($data['key_1']) ? $data['key_1'] : 'default'; $coalescingOperator = $data['key_1'] ?? 'default'; ``` - Apply formatting ### Did this work correctly in an earlier version? Apache NetBeans 15 ### Operating System Linux version 5.15.0-53-generic running on amd64 ### JDK 8.0.2-ea; OpenJDK 64-Bit Server VM 18.0.2-ea+9-Ubuntu-222.04; Private Build ### Apache NetBeans packaging Apache NetBeans Snap Package ### Anything else _No response_ ### Are you willing to submit a pull request? No ### Code of Conduct Yes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4985: Use Project Dictated JVM for Gradle Discovery
matthiasblaesing commented on PR #4985: URL: https://github.com/apache/netbeans/pull/4985#issuecomment-1328217773 Works for me. Build from this branch, ensured JDK 17 is active and was able to load liferay project after setting its JDK to 8. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] noelma opened a new issue, #5012: [CSS] Color error on Pseudo-classes
noelma opened a new issue, #5012:
URL: https://github.com/apache/netbeans/issues/5012
### Apache NetBeans version
Apache NetBeans 15
### What happened
Syntax highlighting fails when writing complex selectors with pseudo-classes
### How to reproduce
- In `Tools` > `Font & Colors` > `Syntax` > `Langauge(Cascading Style
Sheet)`,
- Add different colors to:
- `Property Name`,
- `Pseudo Class`,
- `Selector`.
- And `Apply`,
- Insert the following code in a CSS file:
```css
:before,
:after {
}
input:disabled,
input:focus,
input:hover {
}
[type="checkbox"]:nth-child(2n), /* color error on '2n' */
[type="checkbox"]:not([hidden]), /* color error on '([' */
[type="checkbox"]:not(.active), /* color error on '(' */
[type="checkbox"]:not(:checked), /* color error on '(' */
[type="checkbox"]:checked {
}
```
### Did this work correctly in an earlier version?
Apache NetBeans 15
### Operating System
Linux version 5.15.0-53-generic running on amd64
### JDK
18.0.2-ea; OpenJDK 64-Bit Server VM 18.0.2-ea+9-Ubuntu-222.04; Private Build
### Apache NetBeans packaging
Apache NetBeans Snap Package
### Anything else
_No response_
### Are you willing to submit a pull request?
No
### Code of Conduct
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #4522: Adding inline type hint for 'var' variables
Chris2011 commented on PR #4522: URL: https://github.com/apache/netbeans/pull/4522#issuecomment-1328228421 @jlahoda I can remember your implementation for virtual-text-prepend: https://github.com/apache/netbeans/pull/1247#issuecomment-504723095 so I also want to add some hints to other files than Java and I was searching not for prepending but for appending text, what you already add but I'm missing the point of finding the keyword virtual-text-append. All of your implementation (showing types of chaining collections and var implementation) looks like some hardcoded just for those things without having such a keyword. Is this correct? Shouldn't we add this also as a keyword (virtual-text-append) to make this more consistent with the other implementation to can be reused in other contexted. I know cases where we can have virtual-text-prepend, virtual-text-append and virtual-text-above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing opened a new pull request, #5013: Make more hints for java available
matthiasblaesing opened a new pull request, #5013: URL: https://github.com/apache/netbeans/pull/5013 There are two PRs currently bitrotting: #2785 and #4522. Both add type information to the java editor view. The type information is shown like the parameter name hint, that is already part of NetBeans. For a visual example please have a look at the linked PRs. This PR bundles the two, fixes a compilation problem and adds an option to enable and disable the hints individually:  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #5013: Make more hints for java available
matthiasblaesing commented on PR #5013: URL: https://github.com/apache/netbeans/pull/5013#issuecomment-1328243077 @neilcsmith-net @mbien @jtulach: What do you think? I agree, that `var` and chaining should not be abused and that code should not rely on IDE to help understanding. However there are times where you don't have influence on decisions or you want to understand better what the `javac` thinks about your code and then it can help to show the hints. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5013: Make more hints for java available
neilcsmith-net commented on PR #5013: URL: https://github.com/apache/netbeans/pull/5013#issuecomment-1328260743 Good to see enablement options. My opinion on #4522 is the same as stated there - could we bring it more in line with #2785 ? Hinting method return types, like chaining, at the end of lines would help with most cases of var while not screwing around with formatting within the line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi opened a new pull request, #5014: Fixed some Gradle introspection problems wit pre-6.1 Gradle Versions
lkishalmi opened a new pull request, #5014: URL: https://github.com/apache/netbeans/pull/5014 Yet another fix, restoring some pre-6.1 Gradle Compatibility. Brief list of the changes: * `VersionNumber` -> `GradleVersion` (VersionNumber is deprecated for a while) * Also comparing on base version, so no comparisons to RCs are needed. * Identify plugin by name instead of class * Checking for MissingPropertyException-s in `getProperty` and returning `null` if that would happen. I'm still unhappy about the issues caused by the mass auto-discovery feature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi opened a new issue, #5015: Some Gradle Projects can't be Loaded due to NotSerializableException
lkishalmi opened a new issue, #5015: URL: https://github.com/apache/netbeans/issues/5015 ### Apache NetBeans version Apache NetBeans 16 release candidate ### What happened I've tried to open the `netbeans-website/netbeans.apache.org` the IDE reports a notification that it cannot be open due to NotSerializableException on `tasks.propertyValues` ### How to reproduce 1. Clone https://github.com/apache/netbeans-website 2. Open the netbeans.apace.org project in it ### Did this work correctly in an earlier version? Apache NetBeans 15 ### Operating System Ubuntu 22.04 and 22.10 ### JDK Java 17 ### Apache NetBeans packaging Own source build ### Anything else _No response_ ### Are you willing to submit a pull request? No ### Code of Conduct Yes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on issue #5015: Some Gradle Projects can't be Loaded due to NotSerializableException
sdedic commented on issue #5015: URL: https://github.com/apache/netbeans/issues/5015#issuecomment-1328301397 Will fix by tomorrow to get to the patch release. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5013: Make more hints for java available
mbien commented on PR #5013:
URL: https://github.com/apache/netbeans/pull/5013#issuecomment-1328321040
@matthiasblaesing I had no time to look at the code yet but having more
granularity for this setting is great, +1 from me.
The short version about my opinion on inline hints taken from past
discussions: I am not a fan of inline-text since the demand for them indicates
problems with the code ("code smell"). Code has to be readable without them.
Wanting to see the type of a `var` indicates that this probably should not be a
`var` - swapping `var` with the type can sometimes even be more compact than
letting the IDE draw the type next to `var`. Enabling those kind of hints by
default is risky since it could influence how new devs write new code and lead
to more var-overuse - if you see the type anyway, why not use `var` literally
everywhere. The parameter hints have a similar issue (but this has smaller
impact IMO) since they could influence formatting.
So how should an IDE make (somewhat) badly written code more readable
without influencing how new code is written? I am not sure.
(one thought: if you really want to see the type of a `var` to understand
the code better, why not draw the type _instead_ of `var` with some kind of
toggle button. This would be a pure readability aid and would not make sense to
have always on while you write code. There is also the `ctrl+p `option to
render param types on methods - what if this would appear by default if the
cursor is over the method name? Maybe the answer to all this is to have some
buttons in the editor toolbar to quickly toggle the setting on or off on demand
instead of global options you set once?)
But more options is a good start +1 from me - good job Matthias. I wouldn't
say no to having them on by default - I just would prefer not to due to the
reasons given.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a diff in pull request #4860: Cleanup raw type Iterator warnings..
matthiasblaesing commented on code in PR #4860:
URL: https://github.com/apache/netbeans/pull/4860#discussion_r1033007673
##
profiler/profiler.oql/src/org/netbeans/modules/profiler/oql/engine/api/impl/Snapshot.java:
##
@@ -166,7 +166,7 @@ public Iterator getClasses() {
return delegate.getAllClasses().iterator();
}
-public Iterator getClassNames(String regex) {
+public Iterator getClassNames(String regex) {
Review Comment:
This is wrong! The iterator defined in line 170 maps the `JavaClass` to its
name (see the implementation of `next`) so the Iterator should be
`Iterator` and the implementation should be `String next()`. That then
correctly lets the compiler tell you something is fishy.
##
enterprise/glassfish.javaee/src/org/netbeans/modules/glassfish/javaee/RunTimeDDCatalog.java:
##
@@ -239,7 +239,7 @@ public static synchronized RunTimeDDCatalog
getEE6RunTimeDDCatalog(){
* @return null if cannot proceed, try later.
*/
@Override
-public Iterator getPublicIDs() {
+public Iterator getPublicIDs() {
Review Comment:
Wouldn't it make sense to also fix the interface `CatalogReader` that is
implemented here? The documentation indicates, that this is right, but I would
make it explicit in the code:
> Get String iterator representing all public IDs registered in catalog
This affects all `CatalogReader` implementations.
##
java/dbschema/src/org/netbeans/modules/dbschema/jdbcimpl/IndexElementImpl.java:
##
@@ -95,7 +95,7 @@ public ColumnElement getColumn(DBIdentifier name) {
return (ColumnElement) columns.find(name);
}
-protected void initColumns(LinkedList idxs) {
+protected void initColumns(List idxs) {
Review Comment:
This is an incompatible change. I don't see enough value to risk breakage
(this is friendonly, but changing this is not friendly).
##
enterprise/j2ee.ddloaders/src/org/netbeans/modules/j2ee/ddloaders/ejb/DDChangesPanel.java:
##
@@ -101,12 +101,12 @@ public java.awt.Dimension getPreferredSize () {
return new java.awt.Dimension(600, 400);
}
-public synchronized void setChanges (List changes) {
-listModel.clear ();
+public synchronized void setChanges (List changes) {
Review Comment:
This method exists more or less identically also in:
- `org.netbeans.modules.j2ee.ddloaders.web.DDChangesPanel`
- `org.netbeans.modules.j2ee.ddloaders.client.DDChangesPanel`
- `org.netbeans.modules.j2ee.ddloaders.app.DDChangesPanel`
should these not be updated?
##
enterprise/websvc.jaxwsmodel/src/org/netbeans/modules/websvc/api/jaxws/wsdlmodel/java/WsdlJavaMethod.java:
##
@@ -76,15 +76,15 @@ public JavaParameter getParameter(String paramName) {
public List getParametersList() {
if(this.parameters == null) {
-this.parameters = new ArrayList();
+this.parameters = new ArrayList<>();
for(com.sun.tools.ws.processor.model.java.JavaParameter
p:this.method.getParametersList()) {
this.parameters.add(new WsdlJavaParameter(p));
}
}
return this.parameters;
}
-public Iterator getExceptions() {
+public Iterator getExceptions() {
Review Comment:
Would it make sense to update the return value of the interface (module
`websvc.jaxwsmodelapi`)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi merged pull request #5014: Fixed some Gradle introspection problems wit pre-6.1 Gradle Versions
lkishalmi merged PR #5014: URL: https://github.com/apache/netbeans/pull/5014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi opened a new pull request, #5016: #4965: Fix issues with gradle pre-6.4 (#4995)
lkishalmi opened a new pull request, #5016: URL: https://github.com/apache/netbeans/pull/5016 Cherry picked from master for NB17. * Fix #4965: Avoid NPE: return null for no supplier. * Improve compatibility for Gradle < 6.4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi opened a new pull request, #5017: Fixed some Gradle introspection problems wit pre-6.1 Gradle Versions
lkishalmi opened a new pull request, #5017: URL: https://github.com/apache/netbeans/pull/5017 #5014 Cherry picked from master for NB17. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi opened a new pull request, #5018: [#4865] Register JDPA and Java Compiler Output on Project level
lkishalmi opened a new pull request, #5018: URL: https://github.com/apache/netbeans/pull/5018 #4984 Cherry picked from master for NB17. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi opened a new pull request, #5019: Upgrade version numbers for the affected modules
lkishalmi opened a new pull request, #5019: URL: https://github.com/apache/netbeans/pull/5019 This is just an administrative PR updating the versions of the affected modules for NB16u1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a diff in pull request #4860: Cleanup raw type Iterator warnings..
BradWalker commented on code in PR #4860:
URL: https://github.com/apache/netbeans/pull/4860#discussion_r1033112547
##
java/dbschema/src/org/netbeans/modules/dbschema/jdbcimpl/IndexElementImpl.java:
##
@@ -95,7 +95,7 @@ public ColumnElement getColumn(DBIdentifier name) {
return (ColumnElement) columns.find(name);
}
-protected void initColumns(LinkedList idxs) {
+protected void initColumns(List idxs) {
Review Comment:
done..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a diff in pull request #4860: Cleanup raw type Iterator warnings..
BradWalker commented on code in PR #4860:
URL: https://github.com/apache/netbeans/pull/4860#discussion_r1033113320
##
profiler/profiler.oql/src/org/netbeans/modules/profiler/oql/engine/api/impl/Snapshot.java:
##
@@ -166,7 +166,7 @@ public Iterator getClasses() {
return delegate.getAllClasses().iterator();
}
-public Iterator getClassNames(String regex) {
+public Iterator getClassNames(String regex) {
Review Comment:
Fixed..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a diff in pull request #4860: Cleanup raw type Iterator warnings..
BradWalker commented on code in PR #4860:
URL: https://github.com/apache/netbeans/pull/4860#discussion_r1033121258
##
enterprise/websvc.jaxwsmodel/src/org/netbeans/modules/websvc/api/jaxws/wsdlmodel/java/WsdlJavaMethod.java:
##
@@ -76,15 +76,15 @@ public JavaParameter getParameter(String paramName) {
public List getParametersList() {
if(this.parameters == null) {
-this.parameters = new ArrayList();
+this.parameters = new ArrayList<>();
for(com.sun.tools.ws.processor.model.java.JavaParameter
p:this.method.getParametersList()) {
this.parameters.add(new WsdlJavaParameter(p));
}
}
return this.parameters;
}
-public Iterator getExceptions() {
+public Iterator getExceptions() {
Review Comment:
It would make sense to update the interface. The problem is that would
require the change to be done to IndexElementImpl.java.
So we're going to have to leave it alone for the time being..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a diff in pull request #4860: Cleanup raw type Iterator warnings..
BradWalker commented on code in PR #4860:
URL: https://github.com/apache/netbeans/pull/4860#discussion_r1033132479
##
enterprise/glassfish.javaee/src/org/netbeans/modules/glassfish/javaee/RunTimeDDCatalog.java:
##
@@ -239,7 +239,7 @@ public static synchronized RunTimeDDCatalog
getEE6RunTimeDDCatalog(){
* @return null if cannot proceed, try later.
*/
@Override
-public Iterator getPublicIDs() {
+public Iterator getPublicIDs() {
Review Comment:
I agree. The `CatalogReader` interface needs updating.
Fixed..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a diff in pull request #4860: Cleanup raw type Iterator warnings..
BradWalker commented on code in PR #4860:
URL: https://github.com/apache/netbeans/pull/4860#discussion_r1033144646
##
enterprise/j2ee.ddloaders/src/org/netbeans/modules/j2ee/ddloaders/ejb/DDChangesPanel.java:
##
@@ -101,12 +101,12 @@ public java.awt.Dimension getPreferredSize () {
return new java.awt.Dimension(600, 400);
}
-public synchronized void setChanges (List changes) {
-listModel.clear ();
+public synchronized void setChanges (List changes) {
Review Comment:
Completely agreed.. They should also be changed..
Fixed..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] OS4 opened a new issue, #5020: java debug asserts at start up and crashes out
OS4 opened a new issue, #5020: URL: https://github.com/apache/netbeans/issues/5020 ### Apache NetBeans version Apache NetBeans latest daily build ### What happened Attempts to launch a Java debug session causes the following assert: /home/owen/.cache/netbeans/dev/executor-snippets/debug.xml:31: java.lang.AssertionError at org.netbeans.modules.parsing.api.ParserManager$MimeTaskAction.(ParserManager.java:354) at org.netbeans.modules.parsing.api.ParserManager.parseWhenScanFinished(ParserManager.java:341) at org.netbeans.api.java.source.SourceUtils.waitScanFinished(SourceUtils.java:785) at org.netbeans.modules.java.source.usages.BuildArtifactMapperImpl$DefaultCompileOnSaveAction.performSync(BuildArtifactMapperImpl.java:743) at org.netbeans.modules.java.source.usages.BuildArtifactMapperImpl$DefaultCompileOnSaveAction.performAction(BuildArtifactMapperImpl.java:660) at org.netbeans.modules.java.preprocessorbridge.api.CompileOnSaveActionQuery$ProxyAction.lambda$performAction$3(CompileOnSaveActionQuery.java:130) at java.base/java.util.Optional.map(Optional.java:265) at org.netbeans.modules.java.preprocessorbridge.api.CompileOnSaveActionQuery$ProxyAction.performAction(CompileOnSaveActionQuery.java:128) at org.netbeans.modules.java.source.usages.BuildArtifactMapperImpl.ensureBuilt(BuildArtifactMapperImpl.java:168) at org.netbeans.modules.java.source.ant.TranslateClassPath.translateEntry(TranslateClassPath.java:130) at org.netbeans.modules.java.source.ant.TranslateClassPath.translate(TranslateClassPath.java:91) at org.netbeans.modules.java.source.ant.TranslateClassPath.execute(TranslateClassPath.java:80) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99) at org.apache.tools.ant.Task.perform(Task.java:350) at org.apache.tools.ant.Target.execute(Target.java:449) at org.apache.tools.ant.Target.performTasks(Target.java:470) at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1391) at org.apache.tools.ant.Project.executeTarget(Project.java:1364) at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) at org.apache.tools.ant.Project.executeTargets(Project.java:1254) at org.apache.tools.ant.module.bridge.impl.BridgeImpl.run(BridgeImpl.java:261) at org.apache.tools.ant.module.run.TargetExecutor.run(TargetExecutor.java:573) at org.netbeans.core.execution.RunClassThread.doRun(RunClassThread.java:132) at org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45) at org.openide.util.lookup.Lookups.executeWith(Lookups.java:278) at org.netbeans.core.execution.RunClassThread.run(RunClassThread.java:81) BUILD FAILED (total time: 0 seconds) then it does nothing else, no debug session nor any further output. I assume the debugger just crashes out at this point. I'm using the default JRE, which I think is open JDK 11, on Ubuntu 22.10. I have tried Oracle's JDK 8 as well and it throws exactly the same exception, so maybe it's Netbeans rather than an issue with the JDK or platform it's running on. ### How to reproduce Debug any Java application ### Did this work correctly in an earlier version? Apache NetBeans 15 ### Operating System Ubuntu 22.10 on Intel i7 64 bit ### JDK openjdk version "11.0.17" 2022-10-18 OpenJDK Runtime Environment (build 11.0.17+8-post-Ubuntu-1ubuntu2) OpenJDK 64-Bit Server VM (build 11.0.17+8-post-Ubuntu-1ubuntu2, mixed mode, sharing) ### Apache NetBeans packaging Apache NetBeans binary zip ### Anything else Occurs every time ### Are you willing to submit a pull request? No ### Code of Conduct Yes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the Ne
[GitHub] [netbeans] tbw777 commented on issue #4314: Error: "Cannot be run from folder contains non-ASCII characters in path"
tbw777 commented on issue #4314: URL: https://github.com/apache/netbeans/issues/4314#issuecomment-1328924731 > I suspect @tbw777 is using a Windows version that actually has a Cyrillic codepage as the default Yes, it is -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-website] ebarboni merged pull request #630: some fixes and regrouping for c++
ebarboni merged PR #630: URL: https://github.com/apache/netbeans-website/pull/630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] neilcsmith-net merged pull request #57: NBPackage RPM fixes and options tidy up towards first release
neilcsmith-net merged PR #57: URL: https://github.com/apache/netbeans-tools/pull/57 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-website] BradWalker commented on pull request #630: some fixes and regrouping for c++
BradWalker commented on PR #630: URL: https://github.com/apache/netbeans-website/pull/630#issuecomment-1329368961 Hey @ebarboni , does this mean that CND might be coming in soon? Please say so.. 8-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on pull request #4860: Cleanup raw type Iterator warnings..
BradWalker commented on PR #4860: URL: https://github.com/apache/netbeans/pull/4860#issuecomment-1329372739 Hey @mbien & @matthiasblaesing , I do very much appreciate the comments. Does it now meet with your approval? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic opened a new pull request, #5021: Support directly native build plugin
sdedic opened a new pull request, #5021: URL: https://github.com/apache/netbeans/pull/5021 The micronaut module supports 'nativeCompile' task indirectly - only if `io.micronaut.application` plugin was included. This PR reacts also on `org.graalvm.buildtools.native` plugin provided by GraalVM community -- so it would serve native artifacts even for other configuration than just with `io.micronaut.application`. The GraalVM plugin is also used by SpringBoot and possibly by other 4rd party plugins, too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a diff in pull request #4860: Cleanup raw type Iterator warnings..
matthiasblaesing commented on code in PR #4860:
URL: https://github.com/apache/netbeans/pull/4860#discussion_r1033922529
##
enterprise/j2ee.ddloaders/src/org/netbeans/modules/j2ee/ddloaders/app/DDChangesPanel.java:
##
@@ -101,12 +101,12 @@ public java.awt.Dimension getPreferredSize () {
return new java.awt.Dimension(600, 400);
}
-synchronized void setChanges (List changes) {
-listModel.clear ();
+synchronized void setChanges(List changes) {
Review Comment:
Sorry - I missed this on the first round. This is not correct. `changes` is
not a list of `DefaultListModel`, but
`org.netbeans.modules.j2ee.ddloaders.app.DDChangeEvent`. At least this is what
I traced back. This needs to be double checked and should affect all panels.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic opened a new pull request, #5022: Fix Gradle/broken task dependency and serialization
sdedic opened a new pull request, #5022: URL: https://github.com/apache/netbeans/pull/5022 During debugging of #5015, I've also encountered some broken task that depended on a non-existing class: so I wrapped task dependencies into `try-catch(LinkageError)`. The not serializable bug itself was caused by an improper test for primitive that passed on even some generated proxy with no package. The current version will still pass more values than just primitive wrappers (anything from java.lang). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] swpalmer opened a new issue, #5023: Formatting preferences for Java contains bad sample code
swpalmer opened a new issue, #5023: URL: https://github.com/apache/netbeans/issues/5023 ### Apache NetBeans version Apache NetBeans 16 release candidate ### What happened In preferences/settings under Editor, Formatting, language Java, category Spaces: The sample code used has a misplaced closing brace. Instead of closing the ‘meth’ method it is after the following “add” method, ending the example with a double “} }” on the same line. ### How to reproduce Open the preferences/settings dialog. Those "Editor", then "Formatting". Select language "Java", category "Spaces". Observer the sample code in the preview area. ### Did this work correctly in an earlier version? No / Don't know ### Operating System macOS 13.1 ### JDK JDK 17.0.5 ### Apache NetBeans packaging Apache NetBeans binary zip ### Anything else Always ### Are you willing to submit a pull request? Yes ### Code of Conduct Yes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] PashaTurok opened a new issue, #5024: Add generics angle brackets (<>) highlighting for Java
PashaTurok opened a new issue, #5024: URL: https://github.com/apache/netbeans/issues/5024 ### Description When we work with round brackets in java we can see the start and end bracket via highlighting. For example:  I suggest to add the same functionality for angle bracket of generics, because rather often a structure can be complex and it is not seen where the bracket starts and where it ends. For example, `Map, Map>> coursesByStudentTypeAndTime;` The issue was also opened in old jira: https://issues.apache.org/jira/browse/NETBEANS-5716 ### Use case/motivation _No response_ ### Related issues _No response_ ### Are you willing to submit a pull request? No ### Code of Conduct Yes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] noelma opened a new issue, #5025: [CSS] A warning annotation for nested CSS functions in an attribute
noelma opened a new issue, #5025:
URL: https://github.com/apache/netbeans/issues/5025
### Apache NetBeans version
Apache NetBeans 15
### What happened
When the `var()` function is used in a `calc()` function for the declaration
of a variable there is no problem.
But their uses in a CSS attribute, a warning annotation is displayed
### How to reproduce
Insert the following code in a CSS file:
```css
.foo {
--widthA: 100px;
--widthB: calc(var(--widthA) + 2px);
width: var(--widthB);
}
.bar {
--widthC: 100px;
width: calc(var(--widthC) + 2px);
}
```
### Did this work correctly in an earlier version?
Apache NetBeans 15
### Operating System
Linux version 5.15.0-53-generic running on amd64
### JDK
18.0.2-ea; OpenJDK 64-Bit Server VM 18.0.2-ea+9-Ubuntu-222.04; Private Build
### Apache NetBeans packaging
Apache NetBeans Snap Package
### Anything else
_No response_
### Are you willing to submit a pull request?
No
### Code of Conduct
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] noelma opened a new issue, #5026: [PHP] Error for octal numbers with prefix in php8.1
noelma opened a new issue, #5026: URL: https://github.com/apache/netbeans/issues/5026 ### Apache NetBeans version Apache NetBeans 15 ### What happened In PHP 8.1, it is possible to write octal numbers with the explicit prefix 0o. https://wiki.php.net/rfc/explicit_octal_notation https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.core.octal-literal-prefix This new octal prefix causes a syntax error   ### How to reproduce - In `Properties` > `Sources` > `PHP Version`, - Select `PHP 8.1`, - Insert the following code in a PHP file: ```php https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke opened a new pull request, #5027: [NETBEANS-1914] Fix startup problems on Windows after moving NetBeans install directory
eirikbakke opened a new pull request, #5027: URL: https://github.com/apache/netbeans/pull/5027 On Windows, renaming or moving the NetBeans installation directory caused errors on startup, due to references to old paths in all-layers.dat in the cache directory. The bug did not seem to happen on Linux or MacOS; I'm not sure why. See https://issues.apache.org/jira/browse/NETBEANS-1914 for an example stack trace. The solution in this patch is to include the netbeans.home path in the all-checksum.txt file. This will invalidate the cache if the installation directory is changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #5013: Make more hints for java available
mbien commented on code in PR #5013:
URL: https://github.com/apache/netbeans/pull/5013#discussion_r1034111025
##
java/java.editor.base/src/org/netbeans/modules/java/editor/base/semantic/SemanticHighlighterBase.java:
##
@@ -84,17 +90,78 @@
import org.netbeans.modules.parsing.spi.SchedulerEvent;
import org.netbeans.modules.parsing.spi.TaskIndexingMode;
import org.openide.filesystems.FileUtil;
+import org.openide.util.NbPreferences;
import org.openide.util.Pair;
+import org.openide.util.WeakListeners;
/**
*
* @author Jan Lahoda
*/
public abstract class SemanticHighlighterBase extends JavaParserResultTask {
-
+
+public static final String JAVA_INLINE_HINT_PARAMETER_NAME =
"javaInlineHintParameterName"; //NOI18N
+public static final String JAVA_INLINE_HINT_CHAINED_TYPES =
"javaInlineHintChainedTypes"; //NOI18N
+public static final String JAVA_INLINE_HINT_VAR_TYPE =
"javaInlineHintVarType"; //NOI18N
+
+private static final Map DEFAULT_VALUES;
+
+static {
+Map defaultValuesBuilder = new HashMap<>();
+defaultValuesBuilder.put(JAVA_INLINE_HINT_PARAMETER_NAME, true);
+defaultValuesBuilder.put(JAVA_INLINE_HINT_CHAINED_TYPES, false);
+defaultValuesBuilder.put(JAVA_INLINE_HINT_VAR_TYPE, false);
+DEFAULT_VALUES = Collections.unmodifiableMap(defaultValuesBuilder);
+}
+
+private static final AtomicBoolean inited = new AtomicBoolean();
+private static Preferences preferences;
+private static final PreferenceChangeListener preferencesTracker = new
PreferenceChangeListener() {
+@Override
+public void preferenceChange(PreferenceChangeEvent evt) {
+String settingName = evt == null ? null : evt.getKey();
+if (settingName == null ||
JAVA_INLINE_HINT_PARAMETER_NAME.equals(settingName)) {
+javaInlineHintParameterName =
preferences.getBoolean(JAVA_INLINE_HINT_PARAMETER_NAME,
DEFAULT_VALUES.get(JAVA_INLINE_HINT_PARAMETER_NAME));
+}
+if (settingName == null ||
JAVA_INLINE_HINT_CHAINED_TYPES.equals(settingName)) {
+javaInlineHintChainedTypes =
preferences.getBoolean(JAVA_INLINE_HINT_CHAINED_TYPES,
DEFAULT_VALUES.get(JAVA_INLINE_HINT_CHAINED_TYPES));
+}
+if (settingName == null ||
JAVA_INLINE_HINT_VAR_TYPE.equals(settingName)) {
+javaInlineHintVarType =
preferences.getBoolean(JAVA_INLINE_HINT_VAR_TYPE,
DEFAULT_VALUES.get(JAVA_INLINE_HINT_VAR_TYPE));
+}
+}
+};
+
+private static boolean javaInlineHintParameterName;
+private static boolean javaInlineHintChainedTypes;
+private static boolean javaInlineHintVarType;
+
+private static boolean isJavaInlineHintParameterName() {
+lazyInit();
+return javaInlineHintParameterName;
+}
+
+private static boolean isJavaInlineHintChainedTypes() {
+lazyInit();
+return javaInlineHintChainedTypes;
+}
+
+private static boolean isJavaInlineHintVarType() {
+lazyInit();
+return javaInlineHintVarType;
+}
+
+private static void lazyInit() {
+if (inited.compareAndSet(false, true)) {
+preferences =
NbPreferences.root().node("/org/netbeans/modules/java/editor/InlineHints/default");
+
preferences.addPreferenceChangeListener(WeakListeners.create(PreferenceChangeListener.class,
preferencesTracker, preferences));
+preferencesTracker.preferenceChange(null);
+}
Review Comment:
this isn't thread safe unfortunately. Since `inited` is set right away
without waiting for the block to complete. A second thread could see everything
uninitialized while the first is still working on it. This essentially needs to
be a critical section while `inited` is converted back to a normal boolean and
read and written inside it or:
a trick I sometimes use in situations like this is to use a static
initializer of a not exposed inner class and let the classloader do the work
lazily.
`get()` would give you the initialized Preferences singleton,
`init()`/`get()` would both make sure the listener was called accordingly.
```java
// inner class
private class PreferencesHolder {
private static final Preferences preferences;
static {
preferences =
NbPreferences.root().node("/org/netbeans/modules/java/editor/InlineHints/default");
preferences.addPreferenceChangeListener(WeakListeners.create(PreferenceChangeListener.class,
preferencesTracker, preferences));
preferencesTracker.preferenceChange(null);
}
private static void init(){}
private static Preferences get() {
return preferences;
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
[GitHub] [netbeans] mbien commented on a diff in pull request #5013: Make more hints for java available
mbien commented on code in PR #5013:
URL: https://github.com/apache/netbeans/pull/5013#discussion_r1034111025
##
java/java.editor.base/src/org/netbeans/modules/java/editor/base/semantic/SemanticHighlighterBase.java:
##
@@ -84,17 +90,78 @@
import org.netbeans.modules.parsing.spi.SchedulerEvent;
import org.netbeans.modules.parsing.spi.TaskIndexingMode;
import org.openide.filesystems.FileUtil;
+import org.openide.util.NbPreferences;
import org.openide.util.Pair;
+import org.openide.util.WeakListeners;
/**
*
* @author Jan Lahoda
*/
public abstract class SemanticHighlighterBase extends JavaParserResultTask {
-
+
+public static final String JAVA_INLINE_HINT_PARAMETER_NAME =
"javaInlineHintParameterName"; //NOI18N
+public static final String JAVA_INLINE_HINT_CHAINED_TYPES =
"javaInlineHintChainedTypes"; //NOI18N
+public static final String JAVA_INLINE_HINT_VAR_TYPE =
"javaInlineHintVarType"; //NOI18N
+
+private static final Map DEFAULT_VALUES;
+
+static {
+Map defaultValuesBuilder = new HashMap<>();
+defaultValuesBuilder.put(JAVA_INLINE_HINT_PARAMETER_NAME, true);
+defaultValuesBuilder.put(JAVA_INLINE_HINT_CHAINED_TYPES, false);
+defaultValuesBuilder.put(JAVA_INLINE_HINT_VAR_TYPE, false);
+DEFAULT_VALUES = Collections.unmodifiableMap(defaultValuesBuilder);
+}
+
+private static final AtomicBoolean inited = new AtomicBoolean();
+private static Preferences preferences;
+private static final PreferenceChangeListener preferencesTracker = new
PreferenceChangeListener() {
+@Override
+public void preferenceChange(PreferenceChangeEvent evt) {
+String settingName = evt == null ? null : evt.getKey();
+if (settingName == null ||
JAVA_INLINE_HINT_PARAMETER_NAME.equals(settingName)) {
+javaInlineHintParameterName =
preferences.getBoolean(JAVA_INLINE_HINT_PARAMETER_NAME,
DEFAULT_VALUES.get(JAVA_INLINE_HINT_PARAMETER_NAME));
+}
+if (settingName == null ||
JAVA_INLINE_HINT_CHAINED_TYPES.equals(settingName)) {
+javaInlineHintChainedTypes =
preferences.getBoolean(JAVA_INLINE_HINT_CHAINED_TYPES,
DEFAULT_VALUES.get(JAVA_INLINE_HINT_CHAINED_TYPES));
+}
+if (settingName == null ||
JAVA_INLINE_HINT_VAR_TYPE.equals(settingName)) {
+javaInlineHintVarType =
preferences.getBoolean(JAVA_INLINE_HINT_VAR_TYPE,
DEFAULT_VALUES.get(JAVA_INLINE_HINT_VAR_TYPE));
+}
+}
+};
+
+private static boolean javaInlineHintParameterName;
+private static boolean javaInlineHintChainedTypes;
+private static boolean javaInlineHintVarType;
+
+private static boolean isJavaInlineHintParameterName() {
+lazyInit();
+return javaInlineHintParameterName;
+}
+
+private static boolean isJavaInlineHintChainedTypes() {
+lazyInit();
+return javaInlineHintChainedTypes;
+}
+
+private static boolean isJavaInlineHintVarType() {
+lazyInit();
+return javaInlineHintVarType;
+}
+
+private static void lazyInit() {
+if (inited.compareAndSet(false, true)) {
+preferences =
NbPreferences.root().node("/org/netbeans/modules/java/editor/InlineHints/default");
+
preferences.addPreferenceChangeListener(WeakListeners.create(PreferenceChangeListener.class,
preferencesTracker, preferences));
+preferencesTracker.preferenceChange(null);
+}
Review Comment:
this isn't thread safe unfortunately. Since `inited` is set right away
without waiting for the block to complete. A second thread could see everything
uninitialized while the first is still working on it. This essentially needs to
be a critical section while `inited` is converted back to a normal boolean and
read and written inside it or:
a trick I sometimes use in situations like this is to use a static
initializer of a not exposed inner class and let the classloader do the work
lazily.
`PreferencesHolder.get()` would give you the initialized Preferences
singleton, `PreferencesHolder.init()`/`get()` would both make sure the listener
was called accordingly.
```java
// inner class
private class PreferencesHolder {
private static final Preferences preferences;
static {
preferences =
NbPreferences.root().node("/org/netbeans/modules/java/editor/InlineHints/default");
preferences.addPreferenceChangeListener(WeakListeners.create(PreferenceChangeListener.class,
preferencesTracker, preferences));
preferencesTracker.preferenceChange(null);
}
private static void init(){}
private static Preferences get() {
return preferences;
}
}
```
--
This is an automated message from the Apache Git Service.
To respon
[GitHub] [netbeans] mbien commented on a diff in pull request #5013: Make more hints for java available
mbien commented on code in PR #5013:
URL: https://github.com/apache/netbeans/pull/5013#discussion_r1034123339
##
java/java.editor/src/org/netbeans/modules/java/editor/options/InlineHintsPanel.java:
##
@@ -0,0 +1,214 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.netbeans.modules.java.editor.options;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.prefs.BackingStoreException;
+import java.util.prefs.Preferences;
+import javax.swing.JCheckBox;
+import javax.swing.event.ChangeEvent;
+import javax.swing.event.ChangeListener;
+import org.netbeans.api.editor.EditorRegistry;
+import org.netbeans.modules.editor.NbEditorUtilities;
+import org.netbeans.modules.parsing.api.indexing.IndexingManager;
+import org.openide.util.Exceptions;
+
+
+public class InlineHintsPanel extends javax.swing.JPanel {
+
+public static final String JAVA_INLINE_HINT_PARAMETER_NAME =
"javaInlineHintParameterName"; //NOI18N
+public static final String JAVA_INLINE_HINT_CHAINED_TYPES =
"javaInlineHintChainedTypes"; //NOI18N
+public static final String JAVA_INLINE_HINT_VAR_TYPE =
"javaInlineHintVarType"; //NOI18N
+
+private static final Map DEFAULT_VALUES;
+
+static {
+Map defaultValuesBuilder = new HashMap<>();
+defaultValuesBuilder.put(JAVA_INLINE_HINT_PARAMETER_NAME, true);
+defaultValuesBuilder.put(JAVA_INLINE_HINT_CHAINED_TYPES, false);
+defaultValuesBuilder.put(JAVA_INLINE_HINT_VAR_TYPE, false);
+DEFAULT_VALUES = Collections.unmodifiableMap(defaultValuesBuilder);
+}
+
+private List boxes;
+private InlineHintsOptionsPanelController controller;
+private boolean changed = false;
+
+/** Creates new form InlineHintsPanel */
+public InlineHintsPanel( InlineHintsOptionsPanelController controller ) {
+initComponents();
+//if( "Windows".equals(UIManager.getLookAndFeel().getID()) ) //NOI18N
+//setOpaque( false );
+fillBoxes();
+addListeners();
+load( controller );
+}
+
+public void load( InlineHintsOptionsPanelController controller ) {
+this.controller = controller;
+
+Preferences node = InlineHintsSettings.getCurrentNode();
+
+for (JCheckBox box : boxes) {
+box.setSelected(node.getBoolean(box.getActionCommand(),
DEFAULT_VALUES.get(box.getActionCommand(;
+}
+
+changed = false;
+}
+
+public void store( ) {
+Preferences node = InlineHintsSettings.getCurrentNode();
+
+for (javax.swing.JCheckBox box : boxes) {
+boolean value = box.isSelected();
+boolean original = node.getBoolean(box.getActionCommand(),
+
DEFAULT_VALUES.get(box.getActionCommand()));
+
+if (value != original) {
+node.putBoolean(box.getActionCommand(), value);
+}
+}
+try {
+node.flush();
+}
+catch (BackingStoreException ex) {
+Exceptions.printStackTrace(ex);
+}
+changed = false;
+
+EditorRegistry
+.componentList()
+.stream()
+.map(jtc -> jtc.getDocument())
+.filter(doc -> doc != null)
+.map(doc -> NbEditorUtilities.getFileObject(doc))
+.filter(fo -> fo != null)
+.forEach(fo ->
IndexingManager.getDefault().refreshAllIndices(fo));
+}
Review Comment:
indentation in front of brace
##
java/java.editor/src/org/netbeans/modules/java/editor/options/InlineHintsOptionsPanelController.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain
[GitHub] [netbeans] mbien commented on a diff in pull request #5013: Make more hints for java available
mbien commented on code in PR #5013:
URL: https://github.com/apache/netbeans/pull/5013#discussion_r1034127427
##
java/java.editor/src/org/netbeans/modules/java/editor/options/InlineHintsPanel.java:
##
@@ -0,0 +1,214 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.netbeans.modules.java.editor.options;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.prefs.BackingStoreException;
+import java.util.prefs.Preferences;
+import javax.swing.JCheckBox;
+import javax.swing.event.ChangeEvent;
+import javax.swing.event.ChangeListener;
+import org.netbeans.api.editor.EditorRegistry;
+import org.netbeans.modules.editor.NbEditorUtilities;
+import org.netbeans.modules.parsing.api.indexing.IndexingManager;
+import org.openide.util.Exceptions;
+
+
+public class InlineHintsPanel extends javax.swing.JPanel {
+
+public static final String JAVA_INLINE_HINT_PARAMETER_NAME =
"javaInlineHintParameterName"; //NOI18N
+public static final String JAVA_INLINE_HINT_CHAINED_TYPES =
"javaInlineHintChainedTypes"; //NOI18N
+public static final String JAVA_INLINE_HINT_VAR_TYPE =
"javaInlineHintVarType"; //NOI18N
+
+private static final Map DEFAULT_VALUES;
+
+static {
+Map defaultValuesBuilder = new HashMap<>();
+defaultValuesBuilder.put(JAVA_INLINE_HINT_PARAMETER_NAME, true);
+defaultValuesBuilder.put(JAVA_INLINE_HINT_CHAINED_TYPES, false);
+defaultValuesBuilder.put(JAVA_INLINE_HINT_VAR_TYPE, false);
+DEFAULT_VALUES = Collections.unmodifiableMap(defaultValuesBuilder);
+}
+
+private List boxes;
+private InlineHintsOptionsPanelController controller;
+private boolean changed = false;
+
+/** Creates new form InlineHintsPanel */
+public InlineHintsPanel( InlineHintsOptionsPanelController controller ) {
+initComponents();
+//if( "Windows".equals(UIManager.getLookAndFeel().getID()) ) //NOI18N
+//setOpaque( false );
+fillBoxes();
+addListeners();
+load( controller );
+}
+
+public void load( InlineHintsOptionsPanelController controller ) {
Review Comment:
nitpick: feel free to ignore but this class uses different formatting rules
for methods compared to the other new code added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] swpalmer opened a new pull request, #5028: #5023: Formatting preferences for Java contains bad sample code
swpalmer opened a new pull request, #5028: URL: https://github.com/apache/netbeans/pull/5028 Trivial fix for a misplaced closing brace. --- **^Add meaningful description above** By opening a pull request you confirm that, unless explicitly stated otherwise, the changes - - are all your own work, and you have the right to contribute them. - are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information). Please make sure (eg. `git log`) that all commits have a valid name and email address for you in the Author field. If you're a first time contributor, see the Contributing guidelines for more information. If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5027: [NETBEANS-1914] Fix startup problems on Windows after moving NetBeans install directory
mbien commented on PR #5027: URL: https://github.com/apache/netbeans/pull/5027#issuecomment-1329908368 the tests don't want absolute paths in the file. ``` at org.netbeans.core.startup.layers.CachingPreventsFileTouchesTest.assertFileDoesNotContain(CachingPreventsFileTouchesTest.java:200) at org.netbeans.core.startup.layers.CachingPreventsFileTouchesTest.testCachesDontUseAbsolutePaths(CachingPreventsFileTouchesTest.java:166) at org.netbeans.junit.NbTestCase.access$200(NbTestCase.java:77) at org.netbeans.junit.NbTestCase$2.doSomething(NbTestCase.java:476) at org.netbeans.junit.NbTestCase$1Guard.run(NbTestCase.java:402) at java.lang.Thread.run(Thread.java:750) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #5027: [NETBEANS-1914] Fix startup problems on Windows after moving NetBeans install directory
eirikbakke commented on PR #5027: URL: https://github.com/apache/netbeans/pull/5027#issuecomment-1329937102 Hmm, I think that test is trying to catch the absolute paths that caused the problem in the first place (in files other than the checksum). Here was the discussion around the change that introduced this test: https://bz.apache.org/netbeans/show_bug.cgi?id=208749 While getting rid of absolute paths from the cache is good, it seems like good hygiene to flush the cache when the installation directory changes in any case. Would be useful to get @jtulach's opinion here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-native-launchers] eirikbakke opened a new pull request, #7: Make the Windows launcher work with Unicode paths
eirikbakke opened a new pull request, #7:
URL: https://github.com/apache/netbeans-native-launchers/pull/7
On Windows, the `C:\Users\` path will often contain the user's
real human name. When this path contains characters outside the current "ANSI
code page" (an old DOS concept that predates Unicode), lots of different things
break, and NetBeans will fail to work. See
https://github.com/apache/netbeans/issues/4314.
The underlying problem is that both OpenJDK and the NetBeans launcher, like
most old Windows software, tend to use the "ANSI" versions of Win32 APIs rather
than the "Wide Char" versions (e.g. GetCurrentDirectoryA instead of
GetCurrentDirectoryW). About 3 years ago, Microsoft started recommending an
easy solution: Rather than replacing "char *" with "wchar_t *" everywhere, we
can now set UTF-8 as the default "code page" for all ANSI Win32 API calls, at
the EXE file process level. We do this here for the NetBeans Windows launcher.
See
https://learn.microsoft.com/en-us/windows/apps/design/globalizing/use-utf8-code-page
Since the NetBeans Windows launcher uses JNA to start Java in-process, the
JVM inherits the same default code page setting, without the user having to
change regional settings in the Control Panel. Everything then works
consistently; passing of system properties into the JVM, loading of libraries
from Unicode paths from the system classloader or JNA, and so on. This assumes
that the JVM takes its Win32 code page setting from the "user" locale (the
GetACP() Win32 function) rather than the "system" locale. This been explicitly
the case since https://bugs.openjdk.org/browse/JDK-8272352, in Java 19 and
recent backports to Java 11.0.17 and Java 17.0.5.
We also set the UTF-8 code page for the windows console, so that Unicode
characters display correctly there.
On the aforementioned recent Java versions, NetBeans should now run fine
when there are Unicode characters in the NetBeans installation path, the JDK
path, the user/cache directory paths, or in the java.io.tmpdir path (the latter
sometimes being a problem for JNA, which is used by FlatLAF). This was tested
on Java 17.0.5 with Cyrillic and Norwegian characters in the OS home directory
path and all of the paths above, with different combinations of Cyrillic vs. US
English code pages set at the user vs. system level ("Formats/Format" vs.
"Administrative/Change System Locale" in the "Region" control panel dialog).
Both the NetBeans IDE launcher and a NetBeans Platform application launcher
were tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-native-launchers] eirikbakke commented on pull request #4: Windows: Allow NetBeans to run with non-ASCII path in some cases
eirikbakke commented on PR #4: URL: https://github.com/apache/netbeans-native-launchers/pull/4#issuecomment-1329976314 There's a followup PR now at https://github.com/apache/netbeans-native-launchers/pull/7 , with a more general solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on issue #4314: Error: "Cannot be run from folder contains non-ASCII characters in path"
eirikbakke commented on issue #4314: URL: https://github.com/apache/netbeans/issues/4314#issuecomment-1329980689 There's an improved solution at https://github.com/apache/netbeans-native-launchers/pull/7 now, which should work for arbitrary characters without having to change Control Panel settings (assuming a recent version of Java 11, 17, or 19). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien opened a new pull request, #5029: spi.java.hints: remove unused byte buddy dependency.
mbien opened a new pull request, #5029: URL: https://github.com/apache/netbeans/pull/5029 should have removed it back in #3396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tonihele commented on a diff in pull request #5004: Cleanup few remaining raw type List warnings..
tonihele commented on code in PR #5004:
URL: https://github.com/apache/netbeans/pull/5004#discussion_r1034367564
##
enterprise/web.core/src/org/netbeans/modules/web/core/api/JspColoringData.java:
##
@@ -118,9 +118,9 @@ public void parsingStarted() {
/** Incorporates new parse data from the parser, possibly firing a change
about coloring.
* @param newTaglibs the new map of (uri -> TagLibraryInfo)
* @param newPrefixMapper the new map of (prefix, uri)
- * @param parseSuccessful wherher parsing was successful. If false, then
the new information is partial only
+ * @param parseSuccessful wheher parsing was successful. If false, then
the new information is partial only
Review Comment:
Should it be _whether_?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tonihele commented on pull request #5004: Cleanup few remaining raw type List warnings..
tonihele commented on PR #5004: URL: https://github.com/apache/netbeans/pull/5004#issuecomment-1330178573 There are lot of these old Hashtables. I think they should be evaluated whether synchronization is really needed. If it is needed, changing them to ConcurrentHashMap, otherwise HashMap. Oh, and this is just food for thought. I'm not affiliated with Netbeans development in any way :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4984: [#4865] Register JDPA and Java Compiler Output on Project level
mbien commented on PR #4984: URL: https://github.com/apache/netbeans/pull/4984#issuecomment-1330291655 @lkishalmi this PR wasn't green before merge. Its likely the one causing master to fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lbuchs opened a new issue, #5030: async method with super call: Error "Expected an operand but found super"
lbuchs opened a new issue, #5030:
URL: https://github.com/apache/netbeans/issues/5030
### Apache NetBeans version
Apache NetBeans 15
### What happened
Netbeans marks valid JavaScript code as invalid, when awaiting a super call
in a async function.
### How to reproduce
1. Create a javascript file with following content:
```
class Foo {
async baseMethod() {
return 10;
}
}
class Bar extends Foo {
async extendedMethod() {
let i = await super.baseMethod();
console.log(i);
}
}
x = new Bar();
x.extendedMethod();
```
Netbeans will show a syntax error:
```
Expected an operand but found super
let i = await super.baseMethod();
(Alt-Enter shows hints)
```
Project Setting for Javascript ECMA Version is: _ES.Next (Experimental)_,
but the error is reproducible with every version.
### Did this work correctly in an earlier version?
No / Don't know
### Operating System
Windows 11
### JDK
Java(TM) SE Runtime Environment 17.0.1+12-LTS-39
### Apache NetBeans packaging
Apache NetBeans provided installer
### Anything else
_No response_
### Are you willing to submit a pull request?
No
### Code of Conduct
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-native-launchers] ebarboni commented on pull request #7: Make the Windows launcher work with Unicode paths
ebarboni commented on PR #7: URL: https://github.com/apache/netbeans-native-launchers/pull/7#issuecomment-1330354372 @eirikbakke @neilcsmith-net I will cancel the vote. There is no need to release launcher as this PR contains a nice fixe. @eirikbakke I'm not very fluent in the "native area". I wonder if we should/have to add more mingw parameter to easy your compilation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] dbalek opened a new pull request, #5031: VSCode: Hide Run Configuration panel when Java support is disabled.
dbalek opened a new pull request, #5031: URL: https://github.com/apache/netbeans/pull/5031 Run Configuration panel should be hidden with Java support disabled as the corresponding `Java8+` run/debug configuration is not available. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] qmegas opened a new issue, #5032: [JS] StackOverflowError when trying to see function declaration
qmegas opened a new issue, #5032: URL: https://github.com/apache/netbeans/issues/5032 ### Apache NetBeans version Apache NetBeans 15 ### What happened That is a general error that happens to me frequently when trying to navigate to declaration while working on JS code. I can't provide exact code to reproduce, but here is the stack: ``` java.lang.StackOverflowError at java.base/java.util.HashMap.hash(HashMap.java:340) at java.base/java.util.HashMap.getNode(HashMap.java:570) at java.base/java.util.LinkedHashMap.get(LinkedHashMap.java:441) at org.netbeans.modules.javascript2.model.api.Index.getCachedValue(Index.java:246) at org.netbeans.modules.javascript2.model.api.Index.query(Index.java:185) at org.netbeans.modules.javascript2.model.api.Index.findByFqn(Index.java:412) at org.netbeans.modules.javascript2.editor.navigation.DeclarationFinderImpl.findPropertyOfType(DeclarationFinderImpl.java:301) at org.netbeans.modules.javascript2.editor.navigation.DeclarationFinderImpl.findPropertyOfType(DeclarationFinderImpl.java:311) at org.netbeans.modules.javascript2.editor.navigation.DeclarationFinderImpl.findPropertyOfType(DeclarationFinderImpl.java:311) at org.netbeans.modules.javascript2.editor.navigation.DeclarationFinderImpl.findPropertyOfType(DeclarationFinderImpl.java:311) and so on many times ``` ### How to reproduce _No response_ ### Did this work correctly in an earlier version? No / Don't know ### Operating System Windows 10 ### JDK 16.0.1 ### Apache NetBeans packaging Apache NetBeans provided installer ### Anything else _No response_ ### Are you willing to submit a pull request? Yes ### Code of Conduct Yes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #4984: [#4865] Register JDPA and Java Compiler Output on Project level
sdedic commented on PR #4984: URL: https://github.com/apache/netbeans/pull/4984#issuecomment-1330538302 Yup; the `JavaCompilerProcessorFactory` does not handle the case the classpath is not available in the project, which is the case of umbrella / root projects without even `java-base` plugin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #5022: Fix #5015: Fix Gradle/broken task dependency and serialization
sdedic commented on PR #5022: URL: https://github.com/apache/netbeans/pull/5022#issuecomment-1330545349 Note - the failing test is because of #4984, this PR should not have any effect on that test (negative or positive). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #5006: Gradle: Support for proxy detection / autoconfiguration.
sdedic commented on PR #5006: URL: https://github.com/apache/netbeans/pull/5006#issuecomment-1330548314 I would appreciate if this PR could land in NB16u1-gradle (cc: @MartinBalin) -- in NB a misconfigured proxy is bad enough, but if the vscode environment is used with several lang servers all working against bad proxy/network configuration, it is a true hell on developer's machine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] neilcsmith-net opened a new pull request, #58: Update NBPackage for 1.0-beta1 vote.
neilcsmith-net opened a new pull request, #58: URL: https://github.com/apache/netbeans-tools/pull/58 Update version. Configure binary notice file. Update readme. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] neilcsmith-net merged pull request #58: Update NBPackage for 1.0-beta1 vote.
neilcsmith-net merged PR #58: URL: https://github.com/apache/netbeans-tools/pull/58 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5006: Gradle: Support for proxy detection / autoconfiguration.
neilcsmith-net commented on PR #5006: URL: https://github.com/apache/netbeans/pull/5006#issuecomment-1330570170 @sdedic you'll need to open a second PR, cherry picking these changes on top of `release160`, taking care of module versions if necessary. @MartinBalin I'll liaise with you when we can start merging into the release branch - not until the existing votes are closed anyway! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #5006: Gradle: Support for proxy detection / autoconfiguration.
sdedic commented on PR #5006: URL: https://github.com/apache/netbeans/pull/5006#issuecomment-1330617715 @neilcsmith-net understood - but I'd like to get the code in here reviewed or sanity-checked first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] dbalek merged pull request #5031: VSCode: Hide Run Configuration panel when Java support is disabled.
dbalek merged PR #5031: URL: https://github.com/apache/netbeans/pull/5031 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-native-launchers] eirikbakke commented on pull request #7: Make the Windows launcher work with Unicode paths
eirikbakke commented on PR #7: URL: https://github.com/apache/netbeans-native-launchers/pull/7#issuecomment-1331011212 Compilation is easy, actually, I just did "mvn clean install". Kudos to whoever set this up! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] neilcsmith-net opened a new pull request, #59: Fix RPM packager recommends and increment to beta2.
neilcsmith-net opened a new pull request, #59: URL: https://github.com/apache/netbeans-tools/pull/59 Fix RPM packager recommends and increment to beta2. RPM recommends should apply when runtime is *not* present. Vote attempt take two! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] neilcsmith-net merged pull request #59: Fix RPM packager recommends and increment to beta2.
neilcsmith-net merged PR #59: URL: https://github.com/apache/netbeans-tools/pull/59 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #4985: Use Project Dictated JVM for Gradle Discovery
sdedic commented on PR #4985: URL: https://github.com/apache/netbeans/pull/4985#issuecomment-1331128138 Question: should be https://github.com/apache/netbeans/pull/4985/files#diff-3c58a0a0828b9926f6fc248e3020e6552233d2abe62b93fc0481dae7701dd1feR312 this still a warning message ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #4848: Remove support for Windows 95/98/XP
eirikbakke commented on PR #4848: URL: https://github.com/apache/netbeans/pull/4848#issuecomment-1331226187 Removing old code can be tricky. E.g. even though something says "WinXP", it may well mean "WinXP and after". It's probably best to leave old code untouched unless you are currently working on the files in question and have the ability to test and verify that each change does not break anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] errael commented on pull request #4985: Use Project Dictated JVM for Gradle Discovery
errael commented on PR #4985: URL: https://github.com/apache/netbeans/pull/4985#issuecomment-1331231751 @sdedic > Question: should still a warning message ? I think the link is messed up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-website] ebarboni commented on pull request #630: some fixes and regrouping for c++
ebarboni commented on PR #630: URL: https://github.com/apache/netbeans-website/pull/630#issuecomment-1331968985 @BradWalker sorry no it's just factorising and cleanup to determine missing page. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-nbpackage] ebarboni opened a new pull request, #1: migration from tools
ebarboni opened a new pull request, #1: URL: https://github.com/apache/netbeans-nbpackage/pull/1 to get the history. No modification from tools -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] the-liquid-metal commented on issue #5010: [PHP] Detection of syntax highlighting when using heredoc
the-liquid-metal commented on issue #5010: URL: https://github.com/apache/netbeans/issues/5010#issuecomment-1332548241 Lovely proposal, very useful for inline templating. I usually use phpstorm to do this, and i wish netbeans had this feature. Some considerations should be included: * including [nowdoc](https://www.php.net/manual/en/language.types.string.php#language.types.string.syntax.nowdoc) * since sql has many dialects, popular dialect should be included (MYSQL, SQLSERVER, etc), rather than adding a note comment above the statement to clarify which dialect is. * including [Doctrine](https://www.doctrine-project.org/projects/doctrine-orm/en/2.13/reference/dql-doctrine-query-language.html) * including popular language (Java, C#, etc). and most importantly: PHP ❤️ This is the first step towards becoming a more powerful feature. I hope netbeans won't stop here, considering phpstorm has very solid feature beyond syntax highlighting: syntax validation and connection to datasources. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a diff in pull request #5013: Make more hints for java available
matthiasblaesing commented on code in PR #5013:
URL: https://github.com/apache/netbeans/pull/5013#discussion_r1036322367
##
java/java.editor/src/org/netbeans/modules/java/editor/options/InlineHintsOptionsPanelController.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.java.editor.options;
+
+import java.beans.PropertyChangeListener;
+import java.beans.PropertyChangeSupport;
+import javax.swing.JComponent;
+import org.netbeans.spi.options.OptionsPanelController;
+import org.openide.util.HelpCtx;
+import org.openide.util.Lookup;
+
+public final class InlineHintsOptionsPanelController extends
OptionsPanelController {
+
+private InlineHintsPanel panel;
+
+private final PropertyChangeSupport pcs = new PropertyChangeSupport(this);
+
+@Override
+public void update() {
+panel.load( this );
+}
+
+@Override
+public void applyChanges() {
+panel.store();
+}
+
+@Override
+public void cancel() {
+ // need not do anything special, if no changes have been persisted yet
+}
+
+@Override
+public boolean isValid() {
+return true; // Always valid
+}
+
+@Override
+public boolean isChanged() {
+ return panel.changed();
+}
+
+@Override
+public HelpCtx getHelpCtx() {
+ return new HelpCtx("netbeans.optionsDialog.java.inlineHints");
Review Comment:
It is a copy from the `Controller` in the same directory. Actually your
settings might be different. If you look at the changeset on github everything
is in line and the same was true on my system (default NetBeans settings).
Anyway, I ran the class through the reformatter and it will be updated with
spaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] noelma opened a new issue, #5033: Invisible characters error
noelma opened a new issue, #5033: URL: https://github.com/apache/netbeans/issues/5033 ### Apache NetBeans version Apache NetBeans 15 ### What happened I got an error copying this code into Netbeans:    Opening it in Visual Studio Code, the code contains **No-Break Spaces**.  Messages and highlighting invisible characters in Netbeans does not help to understand this error ### How to reproduce Go to https://www.php.net/manual/en/language.generators.syntax.php, Go to section **Example #5 yield from with iterator_to_array()**, Copy the sample code to a php file in Netbeans. Or copy the code: ```php https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 opened a new pull request, #5034: Fix wrong popuppath by changing order of popupPresenterFilePath strings
Chris2011 opened a new pull request, #5034: URL: https://github.com/apache/netbeans/pull/5034 **^Add meaningful description above** After finding a weird context mentu entry, I started investigating what this is and here you can read more about it: https://github.com/apache/netbeans/discussions/4894 So before the fix, the string looked like Editors/Popup/mimeType which was wrong and lead to misbehavior of EditorActions in PopupMenus (Context menu). After the fix, it looks correct now Editors/mimeType/Popup. The 2 actions were added just for the Java Shell support but because of wrong order, the action were added for each editor. Also I removed unnecessary layer.xml entry which led to an empty etnry after the original fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
