[GitHub] [netbeans] emilianbold commented on issue #1260: Adds SHA-512 to external binaries

2019-09-16 Thread GitBox
emilianbold commented on issue #1260: Adds SHA-512 to external binaries URL: https://github.com/apache/netbeans/pull/1260#issuecomment-531845527 Would be an interesting proof of concept to build a JAR with a colliding SHA1 using the https://shattered.io paper and show that if one were to

[GitHub] [netbeans] emilianbold commented on issue #1260: Adds SHA-512 to external binaries

2019-08-12 Thread GitBox
emilianbold commented on issue #1260: Adds SHA-512 to external binaries URL: https://github.com/apache/netbeans/pull/1260#issuecomment-520629055 Wasn't blaming you. It happened for reasons, can still be frustrating. This is

[GitHub] [netbeans] emilianbold commented on issue #1260: Adds SHA-512 to external binaries

2019-08-12 Thread GitBox
emilianbold commented on issue #1260: Adds SHA-512 to external binaries URL: https://github.com/apache/netbeans/pull/1260#issuecomment-520571716 By drop I mean abandon. BTW, it's quite frustrating that as I committer I made a PR then nicely waited in line just so my PR does not get

[GitHub] [netbeans] emilianbold commented on issue #1260: Adds SHA-512 to external binaries

2019-08-12 Thread GitBox
emilianbold commented on issue #1260: Adds SHA-512 to external binaries URL: https://github.com/apache/netbeans/pull/1260#issuecomment-520515441 I think we can drop this PR, correct? Don't understand why it wasn't merged for 11.1...

[GitHub] [netbeans] emilianbold commented on issue #1260: Adds SHA-512 to external binaries

2019-05-30 Thread GitBox
emilianbold commented on issue #1260: Adds SHA-512 to external binaries URL: https://github.com/apache/netbeans/pull/1260#issuecomment-497291265 I would prefer to merge this before we add some new libs and I have to re-add the SHA512 values.

[GitHub] [netbeans] emilianbold commented on issue #1260: Adds SHA-512 to external binaries

2019-05-26 Thread GitBox
emilianbold commented on issue #1260: Adds SHA-512 to external binaries URL: https://github.com/apache/netbeans/pull/1260#issuecomment-496071509 We can add the size check later on. SHA-512 is really strong compared to SHA-1. I think we'll be good.

[GitHub] [netbeans] emilianbold commented on issue #1260: Adds SHA-512 to external binaries

2019-05-26 Thread GitBox
emilianbold commented on issue #1260: Adds SHA-512 to external binaries URL: https://github.com/apache/netbeans/pull/1260#issuecomment-496020352 I like the current format but it probably needs some README. My changes bring it closed to a distinfo file from pkgsrc. See