[jira] [Commented] (OFBIZ-1463) JUnit test case for various application components

2018-12-20 Thread Suraj Khurana (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726479#comment-16726479 ] Suraj Khurana commented on OFBIZ-1463: -- IMO, we can commit these patches and convert them to Java

[jira] [Commented] (OFBIZ-10724) Refactor ServiceUtil.isSuccess() method

2018-12-20 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726461#comment-16726461 ] Aditya Sharma commented on OFBIZ-10724: --- Indeed.  I will commit in a day if no conflicts. Thanks

[jira] [Assigned] (OFBIZ-7610) Product Price set based on 'Purchase Price Agreement' isn't honored while same is used during ordering

2018-12-20 Thread Ankush Upadhyay (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankush Upadhyay reassigned OFBIZ-7610: -- Assignee: Ankush Upadhyay > Product Price set based on 'Purchase Price Agreement'

[jira] [Commented] (OFBIZ-1463) JUnit test case for various application components

2018-12-20 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725844#comment-16725844 ] Pierre Smits commented on OFBIZ-1463: - What a pity to waste the effort spent by the various parties

[jira] [Commented] (OFBIZ-1463) JUnit test case for various application components

2018-12-20 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725776#comment-16725776 ] Aditya Sharma commented on OFBIZ-1463: -- Makes sense Michael. IMO we can close these tickets with

[jira] [Commented] (OFBIZ-10724) Refactor ServiceUtil.isSuccess() method

2018-12-20 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725723#comment-16725723 ] Jacques Le Roux commented on OFBIZ-10724: - +1 all such patterns should be improved the same way,

[jira] [Updated] (OFBIZ-10724) Refactor ServiceUtil.isSuccess() method

2018-12-20 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10724: -- Attachment: OFBIZ-10724.patch > Refactor ServiceUtil.isSuccess() method >

[jira] [Created] (OFBIZ-10724) Refactor ServiceUtil.isSuccess() method

2018-12-20 Thread Aditya Sharma (JIRA)
Aditya Sharma created OFBIZ-10724: - Summary: Refactor ServiceUtil.isSuccess() method Key: OFBIZ-10724 URL: https://issues.apache.org/jira/browse/OFBIZ-10724 Project: OFBiz Issue Type: