[jira] [Commented] (OFBIZ-9254) Inconsistent String Comparisons

2020-07-29 Thread Devanshu Vyas (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167617#comment-17167617 ] Devanshu Vyas commented on OFBIZ-9254: -- Yes, the last 2 patches which I added in May are pending. I

[GitHub] [ofbiz-framework] JacquesLeRoux edited a comment on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-29 Thread GitBox
JacquesLeRoux edited a comment on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-665591935 OK, GH is not able to show the zipped WidgetWorker.java.rej.zip file in preview above despite saying it's uploaded :/. Trying here rather... OK

[GitHub] [ofbiz-framework] danwatford edited a comment on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-29 Thread GitBox
danwatford edited a comment on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-665611006 I'm don't know how to resolve this @JacquesLeRoux . Before the most recent merge commit a few moments ago I attempted to apply the patch you linked to

[GitHub] [ofbiz-framework] fehnomenal opened a new pull request #220: Make latitude and longitude numeric fields for correct comparisons

2020-07-29 Thread GitBox
fehnomenal opened a new pull request #220: URL: https://github.com/apache/ofbiz-framework/pull/220 Improved: Make the latitude and longitude fields of `GeoPoint` numeric Explanation: Before this commit both are stored as strings in the database and at least PostgreSQL does not

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-29 Thread GitBox
JacquesLeRoux commented on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-665512570 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [ofbiz-framework] danwatford commented on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-29 Thread GitBox
danwatford commented on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-665611006 I'm don't know how to resolve this @JacquesLeRoux . Before the most recent merge commit a few moments ago I attempted to apply the patch you linked to against trunk

[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-29 Thread GitBox
sonarcloud[bot] removed a comment on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-665190079 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #220: Make latitude and longitude numeric fields for correct comparisons

2020-07-29 Thread GitBox
sonarcloud[bot] commented on pull request #220: URL: https://github.com/apache/ofbiz-framework/pull/220#issuecomment-665603293 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=220=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-29 Thread GitBox
sonarcloud[bot] commented on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-665608381 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=BUG)

[jira] [Comment Edited] (OFBIZ-9254) Inconsistent String Comparisons

2020-07-29 Thread Pawan Verma (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167308#comment-17167308 ] Pawan Verma edited comment on OFBIZ-9254 at 7/29/20, 3:12 PM: -- Hi [~jleroux]

[jira] [Commented] (OFBIZ-9254) Inconsistent String Comparisons

2020-07-29 Thread Pawan Verma (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167308#comment-17167308 ] Pawan Verma commented on OFBIZ-9254: Hi [~jleroux] [~devanshu.vyas] I think we missed to commit the

[jira] [Commented] (OFBIZ-11184) No option for passing rounding mode to the ofbizCurrency Macro

2020-07-29 Thread Suraj Khurana (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167282#comment-17167282 ] Suraj Khurana commented on OFBIZ-11184: --- Hello Priya, Thanks for the findings, as per comments on

[jira] [Commented] (OFBIZ-10791) Unable to add product (of ASSET_USAGE type) in order

2020-07-29 Thread Priya Sharma (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167235#comment-17167235 ] Priya Sharma commented on OFBIZ-10791: -- Thanks for the review Pawan. Yes, that was a good

[jira] [Updated] (OFBIZ-10791) Unable to add product (of ASSET_USAGE type) in order

2020-07-29 Thread Priya Sharma (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priya Sharma updated OFBIZ-10791: - Attachment: OFBIZ-10791.patch > Unable to add product (of ASSET_USAGE type) in order >

[jira] [Commented] (OFBIZ-10791) Unable to add product (of ASSET_USAGE type) in order

2020-07-29 Thread Pawan Verma (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167180#comment-17167180 ] Pawan Verma commented on OFBIZ-10791: - Hi [~priya.sharma.9362] The solution makes sense to me. Just

[jira] [Assigned] (OFBIZ-11877) Convert testCreateAndUpdateContactList test from XML to Groovy

2020-07-29 Thread Akash Jain (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain reassigned OFBIZ-11877: -- Assignee: (was: Akash Jain) > Convert testCreateAndUpdateContactList test from XML to

[jira] [Assigned] (OFBIZ-11876) Convert tests (available in WorkEffortSimpleServices.xml) from xml to Groovy

2020-07-29 Thread Akash Jain (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain reassigned OFBIZ-11876: -- Assignee: (was: Akash Jain) > Convert tests (available in WorkEffortSimpleServices.xml)

[jira] [Assigned] (OFBIZ-11867) Convert ShoppingCartTests.xml to Groovy

2020-07-29 Thread Akash Jain (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain reassigned OFBIZ-11867: -- Assignee: (was: Akash Jain) > Convert ShoppingCartTests.xml to Groovy >

[jira] [Assigned] (OFBIZ-11869) Convert ProductionRunTests.xml to Groovy

2020-07-29 Thread Akash Jain (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain reassigned OFBIZ-11869: -- Assignee: (was: Akash Jain) > Convert ProductionRunTests.xml to Groovy >

[jira] [Assigned] (OFBIZ-11875) Convert WorkEffortTests.xml to Groovy

2020-07-29 Thread Akash Jain (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain reassigned OFBIZ-11875: -- Assignee: (was: Akash Jain) > Convert WorkEffortTests.xml to Groovy >

[jira] [Assigned] (OFBIZ-11861) Convert ShoppingListTests.xml to Groovy

2020-07-29 Thread Akash Jain (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain reassigned OFBIZ-11861: -- Assignee: (was: Akash Jain) > Convert ShoppingListTests.xml to Groovy >

[jira] [Commented] (OFBIZ-11184) No option for passing rounding mode to the ofbizCurrency Macro

2020-07-29 Thread Priya Sharma (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167147#comment-17167147 ] Priya Sharma commented on OFBIZ-11184: -- Hi Murugeswari/All We do have support for rounding in

[jira] [Assigned] (OFBIZ-11860) Convert CustRequestTests.xml to Groovy

2020-07-29 Thread Akash Jain (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain reassigned OFBIZ-11860: -- Assignee: (was: Akash Jain) > Convert CustRequestTests.xml to Groovy >

[jira] [Assigned] (OFBIZ-7107) RMA should be able to reject the items in the return before accepting the return

2020-07-29 Thread Akash Jain (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-7107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain reassigned OFBIZ-7107: - Assignee: (was: Akash Jain) > RMA should be able to reject the items in the return before

[jira] [Commented] (OFBIZ-10111) The child event added is not listed in the Child Work Efforts. While if we add an existing event it is listed in the WorkEffort component

2020-07-29 Thread Priya Sharma (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167077#comment-17167077 ] Priya Sharma commented on OFBIZ-10111: -- Hello All, I have attached a quick-fix patch of the

[jira] [Commented] (OFBIZ-11910) product summary cards don't have uniform height

2020-07-29 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167060#comment-17167060 ] Jacques Le Roux commented on OFBIZ-11910: - Thanks Alex, Good point, in the past we had few

[jira] [Updated] (OFBIZ-11741) Headerize external script in multi-block html template

2020-07-29 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11741: Fix Version/s: Upcoming Branch Affects Version/s: (was: Upcoming Branch)

[jira] [Updated] (OFBIZ-11741) Headerize external script in multi-block html template

2020-07-29 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11741: Fix Version/s: (was: Trunk) > Headerize external script in multi-block html template

[jira] [Updated] (OFBIZ-10111) The child event added is not listed in the Child Work Efforts. While if we add an existing event it is listed in the WorkEffort component

2020-07-29 Thread Priya Sharma (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priya Sharma updated OFBIZ-10111: - Attachment: child.png > The child event added is not listed in the Child Work Efforts. While if

[jira] [Assigned] (OFBIZ-10575) Move 'SecurityPermission' data to seed data files

2020-07-29 Thread Priya Sharma (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priya Sharma reassigned OFBIZ-10575: Assignee: Priya Sharma (was: Deepak Nigam) > Move 'SecurityPermission' data to seed

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-29 Thread GitBox
JacquesLeRoux commented on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-665155521 Hi Daniel, Sorry again, "This branch has conflicts that must be resolved" as reports GH. I guess it will be easier to fix for you. TIA :)

[jira] [Updated] (OFBIZ-10111) The child event added is not listed in the Child Work Efforts. While if we add an existing event it is listed in the WorkEffort component

2020-07-29 Thread Priya Sharma (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priya Sharma updated OFBIZ-10111: - Attachment: child-2.png > The child event added is not listed in the Child Work Efforts. While

[jira] [Updated] (OFBIZ-10111) The child event added is not listed in the Child Work Efforts. While if we add an existing event it is listed in the WorkEffort component

2020-07-29 Thread Priya Sharma (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priya Sharma updated OFBIZ-10111: - Attachment: OFBIZ-10111.patch > The child event added is not listed in the Child Work Efforts.

[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-29 Thread GitBox
sonarcloud[bot] removed a comment on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-663977154 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-29 Thread GitBox
sonarcloud[bot] commented on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-665190079 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=BUG)

[GitHub] [ofbiz-framework] danwatford commented on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-29 Thread GitBox
danwatford commented on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-665192736 All fixed @JacquesLeRoux This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (OFBIZ-11928) Explode items not handling tax and adjustments properly

2020-07-29 Thread Pawan Verma (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11928: Description: Steps to re-generate: 1) Create order with 4 qty of purple Gizmo and 3 qty of 

[jira] [Updated] (OFBIZ-11928) Explode items not handling tax and adjustments properly

2020-07-29 Thread Suraj Khurana (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11928: -- Description: Steps to re-generate: 1) Create order with 4 qty of purple Gizmo and 3 qty of 

[jira] [Created] (OFBIZ-11928) Explode items not handling tax and adjustments properly

2020-07-29 Thread Suraj Khurana (Jira)
Suraj Khurana created OFBIZ-11928: - Summary: Explode items not handling tax and adjustments properly Key: OFBIZ-11928 URL: https://issues.apache.org/jira/browse/OFBIZ-11928 Project: OFBiz