[GitHub] [ofbiz-framework] JacquesLeRoux commented on a diff in pull request #517: Codenarc integration

2023-03-21 Thread via GitHub
JacquesLeRoux commented on code in PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1143685341 ## applications/product/groovyScripts/product/cost/CostServices.groovy: ## @@ -495,15 +497,14 @@ def getProductAverageCost() { /** * Formula that creat

Re: [GitHub] [ofbiz-framework] JacquesLeRoux commented on a diff in pull request #517: Codenarc integration

2023-03-21 Thread Jacques Le Roux
I answered to my own question, so deleted the comment (BTW, in groovy we say interpolated not interpreted, like in Python :) Le 21/03/2023 à 17:05, JacquesLeRoux (via GitHub) a écrit : JacquesLeRoux commented on code in PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#discussion

[GitHub] [ofbiz-framework] JacquesLeRoux commented on a diff in pull request #517: Codenarc integration

2023-03-21 Thread via GitHub
JacquesLeRoux commented on code in PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1143636661 ## applications/product/groovyScripts/product/cost/CostServices.groovy: ## @@ -246,67 +239,69 @@ def getTaskCost() { /** * Calculates estimated costs f

[GitHub] [ofbiz-framework] JacquesLeRoux commented on a diff in pull request #517: Codenarc integration

2023-03-21 Thread via GitHub
JacquesLeRoux commented on code in PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1143636661 ## applications/product/groovyScripts/product/cost/CostServices.groovy: ## @@ -246,67 +239,69 @@ def getTaskCost() { /** * Calculates estimated costs f

[GitHub] [ofbiz-framework]: Workflow run "Build and push docker images" is working again!

2023-03-21 Thread GitBox
The GitHub Actions job "Build and push docker images" on ofbiz-framework.git has succeeded. Run started by GitHub user danwatford (triggered by danwatford). Head commit for run: 4e398d890b5af52e67ccbf88f5a81ff30898693c / Daniel Watford Fixed: Allow conditional copying of plugins to docker con

[jira] [Commented] (OFBIZ-12781) Add docker build capability to trunk

2023-03-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703176#comment-17703176 ] ASF subversion and git services commented on OFBIZ-12781: - Commi

[GitHub] [ofbiz-framework] danwatford merged pull request #609: Fixed: Allow conditional copying of plugins to docker container (OFBIZ-12781)

2023-03-21 Thread via GitHub
danwatford merged PR #609: URL: https://github.com/apache/ofbiz-framework/pull/609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #609: Fixed: Allow conditional copying of plugins to docker container (OFBIZ-12781)

2023-03-21 Thread via GitHub
sonarcloud[bot] commented on PR #609: URL: https://github.com/apache/ofbiz-framework/pull/609#issuecomment-1477743158 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #609: Fixed: Allow conditional copying of plugins to docker container (OFBIZ-12781)

2023-03-21 Thread via GitHub
sonarcloud[bot] commented on PR #609: URL: https://github.com/apache/ofbiz-framework/pull/609#issuecomment-1477730139 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #609: Fixed: Allow conditional copying of plugins to docker container (OFBIZ-12781)

2023-03-21 Thread via GitHub
sonarcloud[bot] commented on PR #609: URL: https://github.com/apache/ofbiz-framework/pull/609#issuecomment-1477715314 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [ofbiz-framework] danwatford opened a new pull request, #609: Fixed: Allow conditional copying of plugins to docker container (OFBIZ-12781)

2023-03-21 Thread via GitHub
danwatford opened a new pull request, #609: URL: https://github.com/apache/ofbiz-framework/pull/609 To support docker container builds with and without plugins, apply a Go Character Class regular expression matcher on the source plugins directory. -- This is an automated message from

[GitHub] [ofbiz-framework]: Workflow run "Build and push docker images" failed!

2023-03-21 Thread GitBox
The GitHub Actions job "Build and push docker images" on ofbiz-framework.git has failed. Run started by GitHub user danwatford (triggered by danwatford). Head commit for run: b61f127f2df596943249a6d3d22dfad98ee308fe / Daniel Watford Improved: Enabled trunk for GH Action docker workflow (OFBIZ

[jira] [Commented] (OFBIZ-12781) Add docker build capability to trunk

2023-03-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703148#comment-17703148 ] ASF subversion and git services commented on OFBIZ-12781: - Commi

[jira] [Commented] (OFBIZ-12781) Add docker build capability to trunk

2023-03-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703146#comment-17703146 ] ASF subversion and git services commented on OFBIZ-12781: - Commi

[GitHub] [ofbiz-framework] danwatford merged pull request #608: Improved: OFBiz docker container images (OFBIZ-12781)

2023-03-21 Thread via GitHub
danwatford merged PR #608: URL: https://github.com/apache/ofbiz-framework/pull/608 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #608: Improved: OFBiz docker container images (OFBIZ-12781)

2023-03-21 Thread via GitHub
sonarcloud[bot] commented on PR #608: URL: https://github.com/apache/ofbiz-framework/pull/608#issuecomment-1477631775 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

Re: [GitHub] [ofbiz-framework] JacquesLeRoux commented on a diff in pull request #517: Codenarc integration

2023-03-21 Thread Jacques Le Roux
I deleted this one Le 21/03/2023 à 09:44, JacquesLeRoux (via GitHub) a écrit : JacquesLeRoux commented on code in PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1143040049 ## applications/product/groovyScripts/facility/shipment/EditShipmentPlan.groovy: ###

[GitHub] [ofbiz-framework] danwatford commented on pull request #608: Improved: OFBiz docker container images (OFBIZ-12781)

2023-03-21 Thread via GitHub
danwatford commented on PR #608: URL: https://github.com/apache/ofbiz-framework/pull/608#issuecomment-1477511017 I'll work on the suggestions from SonarCloud Code Analysis to improve the security of the built container images. -- This is an automated message from the Apache Git Service. T

[GitHub] [ofbiz-framework] JacquesLeRoux commented on a diff in pull request #517: Codenarc integration

2023-03-21 Thread via GitHub
JacquesLeRoux commented on code in PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1143063628 ## applications/product/groovyScripts/facility/shipment/PrintPickSheets.groovy: ## @@ -60,16 +59,18 @@ if (toPrintOrders) { orderMap.or

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #608: Improved: OFBiz docker container images (OFBIZ-12781)

2023-03-21 Thread via GitHub
sonarcloud[bot] commented on PR #608: URL: https://github.com/apache/ofbiz-framework/pull/608#issuecomment-1477462156 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quali

[GitHub] [ofbiz-framework] danwatford opened a new pull request, #608: Improved: OFBiz docker container images (OFBIZ-12781)

2023-03-21 Thread via GitHub
danwatford opened a new pull request, #608: URL: https://github.com/apache/ofbiz-framework/pull/608 Added necessary files and documentation (DOCKER.md) to enable out-of-the-box building of OFBIz as a docker container image. Also added a docker directory with an example container deplo

[GitHub] [ofbiz-framework] JacquesLeRoux commented on a diff in pull request #517: Codenarc integration

2023-03-21 Thread via GitHub
JacquesLeRoux commented on code in PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1143040049 ## applications/product/groovyScripts/facility/shipment/EditShipmentPlan.groovy: ## @@ -19,21 +19,17 @@ import org.apache.ofbiz.entity.condition.EntityCo

[GitHub] [ofbiz-framework] JacquesLeRoux commented on a diff in pull request #517: Codenarc integration

2023-03-21 Thread via GitHub
JacquesLeRoux commented on code in PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1143019683 ## applications/product/groovyScripts/facility/inventory/InventoryItemTotals.groovy: ## @@ -31,30 +32,30 @@ retailPriceGrandTotal = 0.0 totalCostPriceGrand

[jira] [Created] (OFBIZ-12781) Add docker build capability to trunk

2023-03-21 Thread Daniel Watford (Jira)
Daniel Watford created OFBIZ-12781: -- Summary: Add docker build capability to trunk Key: OFBIZ-12781 URL: https://issues.apache.org/jira/browse/OFBIZ-12781 Project: OFBiz Issue Type: Improvem