[GitHub] [ofbiz-framework] danwatford commented on a diff in pull request #517: Codenarc integration

2023-04-04 Thread via GitHub
danwatford commented on code in PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1157555615 ## framework/common/groovyScripts/CommonServices.groovy: ## @@ -350,107 +335,112 @@ def createKeywordThesaurus() { /** * Delete a complete Entry

[GitHub] [ofbiz-framework] danwatford commented on a diff in pull request #517: Codenarc integration

2023-04-04 Thread via GitHub
danwatford commented on code in PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1157502903 ## framework/webtools/groovyScripts/entity/XmlDsDump.groovy: ## @@ -17,151 +17,158 @@ * under the License. */ -import java.util.* -import java.io.*

[GitHub] [ofbiz-framework] danwatford commented on a diff in pull request #517: Codenarc integration

2023-04-04 Thread via GitHub
danwatford commented on code in PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1157497733 ## applications/product/groovyScripts/facility/facility/CountFacilityInventoryByProduct.groovy: ## @@ -55,165 +57,168 @@ rows = [] as ArrayList if (action) {

[jira] [Commented] (OFBIZ-12174) Convert InventoryServices.xml mini lang to groovy

2023-04-04 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708339#comment-17708339 ] Jacques Le Roux commented on OFBIZ-12174: - Hi Daniel, Ah yes, I remember that discussion now...

[jira] [Commented] (OFBIZ-12174) Convert InventoryServices.xml mini lang to groovy

2023-04-04 Thread Daniel Watford (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708314#comment-17708314 ] Daniel Watford commented on OFBIZ-12174: Yes, still lots to do, I'm afraid. The original PR 401

[jira] [Closed] (OFBIZ-12793) Cannot add a new geo point to a facility

2023-04-04 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-12793. --- Resolution: Fixed > Cannot add a new geo point to a facility >

[jira] [Commented] (OFBIZ-12174) Convert InventoryServices.xml mini lang to groovy

2023-04-04 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708307#comment-17708307 ] Jacques Le Roux commented on OFBIZ-12174: - Hi, Is there still work here? > Convert

[jira] [Commented] (OFBIZ-12793) Cannot add a new geo point to a facility

2023-04-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708305#comment-17708305 ] ASF subversion and git services commented on OFBIZ-12793: - Commit

[jira] [Commented] (OFBIZ-12723) Remove fields oldQuantityOnHand and oldAvailableToPromise from InventoryItem entity

2023-04-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708304#comment-17708304 ] ASF subversion and git services commented on OFBIZ-12723: - Commit

[jira] [Assigned] (OFBIZ-12793) Cannot add a new geo point to a facility

2023-04-04 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-12793: --- Assignee: Jacques Le Roux > Cannot add a new geo point to a facility >