[jira] [Closed] (OFBIZ-13042) Ecommerce-parameterized menu location

2024-05-10 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-13042. --- Fix Version/s: Upcoming Branch Assignee: Jacques Le Roux Resolution: Fixed

[jira] [Commented] (OFBIZ-13042) Ecommerce-parameterized menu location

2024-05-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845451#comment-17845451 ] ASF subversion and git services commented on OFBIZ-13042: - Commit

Re: [PR] Improved: Ecommerce - parameterized menu location (OFBIZ-13042) [ofbiz-plugins]

2024-05-10 Thread via GitHub
JacquesLeRoux merged PR #115: URL: https://github.com/apache/ofbiz-plugins/pull/115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Improved: Ecommerce - parameterized menu location (OFBIZ-13042) [ofbiz-plugins]

2024-05-10 Thread via GitHub
JacquesLeRoux commented on PR #115: URL: https://github.com/apache/ofbiz-plugins/pull/115#issuecomment-2105081507 Hi Pierre, Test OK, your proposition sounds reasonable to me since only blog*.xml are apart -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (OFBIZ-13039) dateType parameter not existing in "renderDateTimeField" Macro

2024-05-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845431#comment-17845431 ] ASF subversion and git services commented on OFBIZ-13039: - Commit

[jira] [Commented] (OFBIZ-7949) E-commerce : FTL formatting

2024-05-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-7949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845430#comment-17845430 ] ASF subversion and git services commented on OFBIZ-7949: Commit

[jira] [Commented] (OFBIZ-12126) Refactor MacroFormRenderer to use RenderableFtlElements for datetime fields

2024-05-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845432#comment-17845432 ] ASF subversion and git services commented on OFBIZ-12126: - Commit

[jira] [Commented] (OFBIZ-7949) E-commerce : FTL formatting

2024-05-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-7949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845433#comment-17845433 ] ASF subversion and git services commented on OFBIZ-7949: Commit

[jira] [Commented] (OFBIZ-12126) Refactor MacroFormRenderer to use RenderableFtlElements for datetime fields

2024-05-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845429#comment-17845429 ] ASF subversion and git services commented on OFBIZ-12126: - Commit

[jira] [Commented] (OFBIZ-13039) dateType parameter not existing in "renderDateTimeField" Macro

2024-05-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845428#comment-17845428 ] ASF subversion and git services commented on OFBIZ-13039: - Commit

[jira] [Commented] (OFBIZ-12126) Refactor MacroFormRenderer to use RenderableFtlElements for datetime fields

2024-05-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845425#comment-17845425 ] ASF subversion and git services commented on OFBIZ-12126: - Commit

[jira] [Commented] (OFBIZ-13039) dateType parameter not existing in "renderDateTimeField" Macro

2024-05-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845424#comment-17845424 ] ASF subversion and git services commented on OFBIZ-13039: - Commit

[jira] [Commented] (OFBIZ-12126) Refactor MacroFormRenderer to use RenderableFtlElements for datetime fields

2024-05-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845423#comment-17845423 ] ASF subversion and git services commented on OFBIZ-12126: - Commit

[jira] [Commented] (OFBIZ-13039) dateType parameter not existing in "renderDateTimeField" Macro

2024-05-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845422#comment-17845422 ] ASF subversion and git services commented on OFBIZ-13039: - Commit

[jira] [Commented] (OFBIZ-13086) Convert SampleCommissionServices.xml from mini-lang to Groovy

2024-05-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845329#comment-17845329 ] ASF subversion and git services commented on OFBIZ-13086: - Commit

[jira] [Closed] (OFBIZ-13076) PartyTypeAttr correction

2024-05-10 Thread Sebastian Tschikin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Tschikin closed OFBIZ-13076. -- Resolution: Not A Problem > PartyTypeAttr correction > > >

[jira] [Commented] (OFBIZ-13076) PartyTypeAttr correction

2024-05-10 Thread Sebastian Tschikin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845324#comment-17845324 ] Sebastian Tschikin commented on OFBIZ-13076: |After re-evaluating the entire pull request,

Re: [PR] Fixed: PartyTypeAttr correction (OFBIZ-13076) [ofbiz-framework]

2024-05-10 Thread via GitHub
stschikin closed pull request #793: Fixed: PartyTypeAttr correction (OFBIZ-13076) URL: https://github.com/apache/ofbiz-framework/pull/793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Fixed: PartyTypeAttr correction (OFBIZ-13076) [ofbiz-framework]

2024-05-10 Thread via GitHub
JacquesLeRoux commented on PR #793: URL: https://github.com/apache/ofbiz-framework/pull/793#issuecomment-2104502150 Thanks for the clarification @stschikin Please close your PR, TIA -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Closed] (OFBIZ-13086) Convert SampleCommissionServices.xml from mini-lang to Groovy

2024-05-10 Thread Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-13086. - Resolution: Done > Convert SampleCommissionServices.xml from mini-lang to Groovy >

Re: [PR] Fixed: PartyTypeAttr correction (OFBIZ-13076) [ofbiz-framework]

2024-05-10 Thread via GitHub
stschikin commented on PR #793: URL: https://github.com/apache/ofbiz-framework/pull/793#issuecomment-2104298510 After re-evaluating the entire pull request, it looks like I have confused TypeAttr entities with Attribute entities. Attribute entities need a AttrValue, but TypeAttr do not.

Re: [PR] Improved: Ecommerce - parameterized menu location (OFBIZ-13042) [ofbiz-plugins]

2024-05-10 Thread via GitHub
sonarcloud[bot] commented on PR #115: URL: https://github.com/apache/ofbiz-plugins/pull/115#issuecomment-2104126667 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[jira] [Commented] (OFBIZ-13053) Manufacturing-Main page

2024-05-10 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845230#comment-17845230 ] Pierre Smits commented on OFBIZ-13053: -- Hi [~jleroux] < As with the PR re OFBIZ-13054, I found a

Re: [PR] Improved: Manufacturing-Main page (OFBIZ-13053) [ofbiz-framework]

2024-05-10 Thread via GitHub
sonarcloud[bot] commented on PR #784: URL: https://github.com/apache/ofbiz-framework/pull/784#issuecomment-2103979123 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]

2024-05-10 Thread via GitHub
sonarcloud[bot] commented on PR #785: URL: https://github.com/apache/ofbiz-framework/pull/785#issuecomment-2103975317 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]

2024-05-10 Thread via GitHub
PierreSmits commented on PR #785: URL: https://github.com/apache/ofbiz-framework/pull/785#issuecomment-2103974953 Hi @JacquesLeRoux , I have updated the pull request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and