[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-07-04 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10438: --- Attachment: (was: OFBIZ-10438_0006-Improved-Split-resolveURI-in-two-methods.patch) >

[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-07-04 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10438: --- Attachment: (was:

[jira] [Updated] (OFBIZ-10453) Factorize code logic from ‘ConfigXMLReader’

2018-06-28 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10453: --- Attachment: OFBIZ-10453_0001-Add-ConfigXMLReader.ControllerConfig-pushIncludes.patch >

[jira] [Updated] (OFBIZ-10453) Factorize code logic from ‘ConfigXMLReader’

2018-06-28 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10453: --- Attachment: (was:

[jira] [Updated] (OFBIZ-10453) Factorize code logic from ‘ConfigXMLReader’

2018-06-28 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10453: --- Attachment: OFBIZ-10453_0001-Add-ConfigXMLReader.ControllerConfig-pushIncludes.patch

[jira] [Created] (OFBIZ-10453) Factorize code logic from ‘ConfigXMLReader’

2018-06-28 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10453: -- Summary: Factorize code logic from ‘ConfigXMLReader’ Key: OFBIZ-10453 URL: https://issues.apache.org/jira/browse/OFBIZ-10453 Project: OFBiz Issue Type:

[jira] [Updated] (OFBIZ-10452) Remove unused ‘RequestHandler::doRequest’ method

2018-06-28 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10452: --- Attachment: OFBIZ-10452_Remove-unused-RequestHandler-doRequest-method.patch > Remove unused

[jira] [Created] (OFBIZ-10452) Remove unused ‘RequestHandler::doRequest’ method

2018-06-28 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10452: -- Summary: Remove unused ‘RequestHandler::doRequest’ method Key: OFBIZ-10452 URL: https://issues.apache.org/jira/browse/OFBIZ-10452 Project: OFBiz Issue

[jira] [Updated] (OFBIZ-10451) Use ‘String::equalsIgnoreCase’ in ‘RequestHandler::doRequest’

2018-06-28 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10451: --- Attachment: OFBIZ-10451_Improved-Use-String-equalsIgnoreCase-in-RequestHandl.patch > Use

[jira] [Updated] (OFBIZ-10451) Use ‘String::equalsIgnoreCase’ in ‘RequestHandler::doRequest’

2018-06-28 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10451: --- Description: Use {{String::equalsIgnoreCase}} instead of combining {{String::equals}} and

[jira] [Created] (OFBIZ-10451) Use ‘String::equalsIgnoreCase’ in ‘RequestHandler::doRequest’

2018-06-28 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10451: -- Summary: Use ‘String::equalsIgnoreCase’ in  ‘RequestHandler::doRequest’ Key: OFBIZ-10451 URL: https://issues.apache.org/jira/browse/OFBIZ-10451 Project: OFBiz

[jira] [Updated] (OFBIZ-10450) Extract verification of certificates in ‘RequestHandler’

2018-06-27 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10450: --- Attachment: OFBIZ-10450_Improved-Extract-verification-of-certificates-in-Req.patch >

[jira] [Created] (OFBIZ-10450) Extract verification of certificates in ‘RequestHandler’

2018-06-27 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10450: -- Summary: Extract verification of certificates in ‘RequestHandler’ Key: OFBIZ-10450 URL: https://issues.apache.org/jira/browse/OFBIZ-10450 Project: OFBiz

[jira] [Updated] (OFBIZ-10449) Refactor ControlFilter

2018-06-27 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10449: --- Attachment: OFBIZ-10449_Improved-Refactor-ControlFilter.patch > Refactor ControlFilter >

[jira] [Created] (OFBIZ-10449) Refactor ControlFilter

2018-06-27 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10449: -- Summary: Refactor ControlFilter Key: OFBIZ-10449 URL: https://issues.apache.org/jira/browse/OFBIZ-10449 Project: OFBiz Issue Type: Improvement

[jira] [Updated] (OFBIZ-10448) Remove useless logging levels checks in ControlServlet

2018-06-27 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10448: --- Attachment: OFBIZ-10448_Improved-Remove-useless-logging-levels-checks.patch > Remove

[jira] [Created] (OFBIZ-10448) Remove useless logging levels checks in ControlServlet

2018-06-27 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10448: -- Summary: Remove useless logging levels checks in ControlServlet Key: OFBIZ-10448 URL: https://issues.apache.org/jira/browse/OFBIZ-10448 Project: OFBiz

[jira] [Updated] (OFBIZ-10447) Remove useless ControlServlet code

2018-06-27 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10447: --- Attachment: OFBIZ-10447_Improved-Remove-useless-ControlServlet-code.patch > Remove useless

[jira] [Created] (OFBIZ-10447) Remove useless ControlServlet code

2018-06-27 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10447: -- Summary: Remove useless ControlServlet code Key: OFBIZ-10447 URL: https://issues.apache.org/jira/browse/OFBIZ-10447 Project: OFBiz Issue Type:

[jira] [Updated] (OFBIZ-10446) Override ‘GenericServlet::init’ instead of ‘Servlet::init’

2018-06-27 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10446: --- Attachment: OFBIZ-10446_Improved-Override-GenericServlet-init-instead-of-Ser.patch >

[jira] [Created] (OFBIZ-10446) Override ‘GenericServlet::init’ instead of ‘Servlet::init’

2018-06-27 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10446: -- Summary: Override ‘GenericServlet::init’ instead of ‘Servlet::init’ Key: OFBIZ-10446 URL: https://issues.apache.org/jira/browse/OFBIZ-10446 Project: OFBiz

[jira] [Updated] (OFBIZ-10445) Inline ‘ControlServlet::getRequestHandler’ method

2018-06-27 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10445: --- Attachment: OFBIZ-10445-Improved-Inline-ControlServlet-getRequestHandler-met.patch >

[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-06-27 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524843#comment-16524843 ] Mathieu Lirzin commented on OFBIZ-10438: [~shi.jinghai] I agree :-) > Add method attribute to

[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-06-27 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524831#comment-16524831 ] Mathieu Lirzin commented on OFBIZ-10438: {quote}And method="" and method="all" are OK. I insist

[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-06-26 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524296#comment-16524296 ] Mathieu Lirzin commented on OFBIZ-10438: Here are two patches for the refactoring

[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-06-26 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10438: --- Attachment: OFBIZ-10438_0005-Improved-Parse-controller-config-in-one-place.patch

[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-06-26 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10438: --- Attachment: (was: OFBIZ-10438_0001-Improved-Parse-controller-config-in-one-place.patch)

[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-06-26 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10438: --- Attachment: (was: OFBIZ-10438_0002-Improved-Split-resolveURI-in-two-methods.patch) >

[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-06-26 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10438: --- Attachment: OFBIZ-10438_0001-Improved-Parse-controller-config-in-one-place.patch

[jira] [Comment Edited] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-06-26 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523353#comment-16523353 ] Mathieu Lirzin edited comment on OFBIZ-10438 at 6/26/18 7:39 AM: - Ok

[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-06-26 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523353#comment-16523353 ] Mathieu Lirzin commented on OFBIZ-10438: Ok make more sense. I was confuse by “backporting to

[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-06-26 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523318#comment-16523318 ] Mathieu Lirzin commented on OFBIZ-10438: Great, thanks for working on it! If that's OK with

[jira] [Commented] (OFBIZ-10355) Define generic types in `ProductStoreEvents`

2018-06-23 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521090#comment-16521090 ] Mathieu Lirzin commented on OFBIZ-10355: Thanks Arun > Define generic types in

[jira] [Commented] (OFBIZ-4274) Implement a REST Servlet

2018-06-22 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520089#comment-16520089 ] Mathieu Lirzin commented on OFBIZ-4274: --- I have been working on a POC during the last month. What

[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-06-22 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520070#comment-16520070 ] Mathieu Lirzin commented on OFBIZ-10438: Thanks for the feedback, I am looking into it. > Add

[jira] [Commented] (OFBIZ-10430) Use `in` and spread operator in `gradlewSubprocess`

2018-06-21 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519292#comment-16519292 ] Mathieu Lirzin commented on OFBIZ-10430: Thanks Jacques > Use `in` and spread operator in

[jira] [Commented] (OFBIZ-10430) Use `in` and spread operator in `gradlewSubprocess`

2018-06-21 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519208#comment-16519208 ] Mathieu Lirzin commented on OFBIZ-10430: Hum I was trusting compilation to detect such issue but

[jira] [Commented] (OFBIZ-10431) Use list literals when possible

2018-06-21 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519097#comment-16519097 ] Mathieu Lirzin commented on OFBIZ-10431: Thanks Jacques > Use list literals when possible >

[jira] [Commented] (OFBIZ-10428) Don't guess the system file separator

2018-06-20 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518603#comment-16518603 ] Mathieu Lirzin commented on OFBIZ-10428: Thanks Jacques, can you tell me more about this quirk?

[jira] [Commented] (OFBIZ-10429) Use functional programming in build script

2018-06-20 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518600#comment-16518600 ] Mathieu Lirzin commented on OFBIZ-10429: Thanks Jacques > Use functional programming in build

[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-06-20 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518592#comment-16518592 ] Mathieu Lirzin commented on OFBIZ-10438: Hello Shi, Having a {{method}} attribute has the

[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-06-20 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10438: --- Attachment: OFBIZ-10438_0001-Improved-Add-ControlServlet-service-method.patch

[jira] [Commented] (OFBIZ-10413) Remove unused code in `CommonEvents::setFollowerPage`

2018-06-18 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515438#comment-16515438 ] Mathieu Lirzin commented on OFBIZ-10413: Thanks for investigating. > Remove unused code in

[jira] [Updated] (OFBIZ-10429) Use functional programming in build script

2018-06-10 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10429: --- Attachment: OFBIZ-10429-Use-findAll-instead-of-getTasksMatchingRegex.patch > Use functional

[jira] [Updated] (OFBIZ-10429) Use functional programming in build script

2018-06-10 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10429: --- Attachment: (was: OFBIZ-10429-Use-findAll-instead-of-getTasksMatchingRegex.patch) >

[jira] [Updated] (OFBIZ-10431) Use list literals when possible

2018-06-10 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10431: --- Attachment: OFBIZ-10431_use-list-literals-when-possible.patch > Use list literals when

[jira] [Created] (OFBIZ-10431) Use list literals when possible

2018-06-10 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10431: -- Summary: Use list literals when possible Key: OFBIZ-10431 URL: https://issues.apache.org/jira/browse/OFBIZ-10431 Project: OFBiz Issue Type: Improvement

[jira] [Updated] (OFBIZ-10430) Use `in` and spread operator in `gradlewSubprocess`

2018-06-10 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10430: --- Attachment: OFBIZ-10430_Use-in-and-spread-operator-in-gradlewSubprocess.patch > Use `in`

[jira] [Created] (OFBIZ-10430) Use `in` and spread operator in `gradlewSubprocess`

2018-06-10 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10430: -- Summary: Use `in` and spread operator in `gradlewSubprocess` Key: OFBIZ-10430 URL: https://issues.apache.org/jira/browse/OFBIZ-10430 Project: OFBiz

[jira] [Updated] (OFBIZ-10429) Use functional programming in build script

2018-06-10 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10429: --- Attachment: OFBIZ-10429-Use-stream-processing-in-subprojectExists.patch > Use functional

[jira] [Updated] (OFBIZ-10429) Use functional programming in build script

2018-06-10 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10429: --- Attachment: OFBIZ-10429-Use-stream-processing-in-taskExistsInproject.patch > Use functional

[jira] [Updated] (OFBIZ-10429) Use functional programming in build script

2018-06-10 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10429: --- Attachment: OFBIZ-10429-Use-findAll-instead-of-getTasksMatchingRegex.patch > Use functional

[jira] [Created] (OFBIZ-10429) Use functional programming in build script

2018-06-10 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10429: -- Summary: Use functional programming in build script Key: OFBIZ-10429 URL: https://issues.apache.org/jira/browse/OFBIZ-10429 Project: OFBiz Issue Type:

[jira] [Updated] (OFBIZ-10428) Don't guess the system file separator

2018-06-10 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10428: --- Attachment: OFBIZ-10428_Don_t-guess-the-system-file-separator.patch > Don't guess the

[jira] [Created] (OFBIZ-10428) Don't guess the system file separator

2018-06-10 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10428: -- Summary: Don't guess the system file separator Key: OFBIZ-10428 URL: https://issues.apache.org/jira/browse/OFBIZ-10428 Project: OFBiz Issue Type:

[jira] [Comment Edited] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2018-06-09 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506881#comment-16506881 ] Mathieu Lirzin edited comment on OFBIZ-6747 at 6/9/18 9:39 AM: --- I am not

[jira] [Comment Edited] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2018-06-09 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506881#comment-16506881 ] Mathieu Lirzin edited comment on OFBIZ-6747 at 6/9/18 9:37 AM: --- I am not

[jira] [Commented] (OFBIZ-6747) Replace ConcurrentLinkedHashMap by Caffeine

2018-06-09 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506881#comment-16506881 ] Mathieu Lirzin commented on OFBIZ-6747: --- I am not aware about the whole story and the rationale

[jira] [Commented] (OFBIZ-9893) New methods for EntityQuery

2018-05-31 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496520#comment-16496520 ] Mathieu Lirzin commented on OFBIZ-9893: --- [~gareth.carter] What about adding some docstrings to make

[jira] [Commented] (OFBIZ-10412) Remove `UtilValidate::isEmpty(String)` method

2018-05-25 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16490414#comment-16490414 ] Mathieu Lirzin commented on OFBIZ-10412: Thanks Jacques > Remove `UtilValidate::isEmpty(String)`

[jira] [Commented] (OFBIZ-4274) Implement a REST Servlet

2018-05-24 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1642#comment-1642 ] Mathieu Lirzin commented on OFBIZ-4274: --- Hi Jacques, The Camel REST DSL will only serve as an

[jira] [Comment Edited] (OFBIZ-4274) Implement a REST Servlet

2018-05-24 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1642#comment-1642 ] Mathieu Lirzin edited comment on OFBIZ-4274 at 5/24/18 12:18 PM: - Hi

[jira] [Commented] (OFBIZ-10410) Refactor `JavaEventHandler` class

2018-05-24 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488733#comment-16488733 ] Mathieu Lirzin commented on OFBIZ-10410: Hello Shi, Even if I effectively worked on this while

[jira] [Commented] (OFBIZ-4274) Implement a REST Servlet

2018-05-23 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486900#comment-16486900 ] Mathieu Lirzin commented on OFBIZ-4274: --- I agree with Scott that it is better to make OFBiz _RESTFul

[jira] [Comment Edited] (OFBIZ-4274) Implement a REST Servlet

2018-05-23 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486900#comment-16486900 ] Mathieu Lirzin edited comment on OFBIZ-4274 at 5/23/18 8:34 AM: I agree

[jira] [Updated] (OFBIZ-10413) Remove unused code in `CommonEvents::setFollowerPage`

2018-05-22 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10413: --- Attachment: OFBIZ-10413-Improve-setFollowerPage.patch > Remove unused code in

[jira] [Created] (OFBIZ-10413) Remove unused code in `CommonEvents::setFollowerPage`

2018-05-22 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10413: -- Summary: Remove unused code in `CommonEvents::setFollowerPage` Key: OFBIZ-10413 URL: https://issues.apache.org/jira/browse/OFBIZ-10413 Project: OFBiz

[jira] [Commented] (OFBIZ-10394) Fix typo "paramters" => "parameters"

2018-05-20 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482014#comment-16482014 ] Mathieu Lirzin commented on OFBIZ-10394: Thanks Deepak, your request regarding the use of `git

[jira] [Updated] (OFBIZ-10412) Remove `UtilValidate::isEmpty(String)` method

2018-05-20 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10412: --- Component/s: base > Remove `UtilValidate::isEmpty(String)` method >

[jira] [Updated] (OFBIZ-10411) XML schemas should use predefined boolean type

2018-05-20 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10411: --- Labels: patch (was: ) > XML schemas should use predefined boolean type >

[jira] [Updated] (OFBIZ-10412) Remove `UtilValidate::isEmpty(String)` method

2018-05-20 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10412: --- Attachment: OFBIZ-10412-remove-isEmpty-for-strings.patch > Remove

[jira] [Created] (OFBIZ-10412) Remove `UtilValidate::isEmpty(String)` method

2018-05-20 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10412: -- Summary: Remove `UtilValidate::isEmpty(String)` method Key: OFBIZ-10412 URL: https://issues.apache.org/jira/browse/OFBIZ-10412 Project: OFBiz Issue

[jira] [Updated] (OFBIZ-10411) XML schemas should use predefined boolean type

2018-05-20 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10411: --- Attachment: OFBIZ-10411-xml-use-boolean-type-follow-up.patch > XML schemas should use

[jira] [Updated] (OFBIZ-10411) XML schemas should use predefined boolean type

2018-05-20 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10411: --- Attachment: (was: OFBIZ-10411-xml-use-boolean-type-follow-up.patch) > XML schemas should

[jira] [Updated] (OFBIZ-10411) XML schemas should use predefined boolean type

2018-05-20 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10411: --- Description: To define boolean values, some ad-hoc enumeration of "true" and "false" are

[jira] [Commented] (OFBIZ-10411) XML schemas should use predefined boolean type

2018-05-20 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481967#comment-16481967 ] Mathieu Lirzin commented on OFBIZ-10411: I have included the fix for the other xsd files.

[jira] [Updated] (OFBIZ-10411) XML schemas should use predefined boolean type

2018-05-20 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10411: --- Attachment: OFBIZ-10411-xml-use-boolean-type-follow-up.patch > XML schemas should use

[jira] [Commented] (OFBIZ-10411) XML schemas should use predefined boolean type

2018-05-20 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481955#comment-16481955 ] Mathieu Lirzin commented on OFBIZ-10411: Thanks Jacques for applying this patch. > XML schemas

[jira] [Updated] (OFBIZ-10411) XML schemas should use predefined boolean type

2018-05-19 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10411: --- Attachment: OFBIZ-10411-use-boolean-type-in-site-conf.patch > XML schemas should use

[jira] [Created] (OFBIZ-10411) XML schemas should use predefined boolean type

2018-05-19 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10411: -- Summary: XML schemas should use predefined boolean type Key: OFBIZ-10411 URL: https://issues.apache.org/jira/browse/OFBIZ-10411 Project: OFBiz Issue

[jira] [Updated] (OFBIZ-10410) Refactor `JavaEventHandler` class

2018-05-19 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10410: --- Description: Instead of relying on manual synchronisation, use a concurrent map for caching

[jira] [Updated] (OFBIZ-10410) Refactor `JavaEventHandler` class

2018-05-19 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10410: --- Attachment: OFBIZ-10410-refactor-java-event-handler.patch > Refactor `JavaEventHandler`

[jira] [Created] (OFBIZ-10410) Refactor `JavaEventHandler` class

2018-05-19 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10410: -- Summary: Refactor `JavaEventHandler` class Key: OFBIZ-10410 URL: https://issues.apache.org/jira/browse/OFBIZ-10410 Project: OFBiz Issue Type:

[jira] [Commented] (OFBIZ-4274) Implement a REST Servlet

2018-05-16 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478111#comment-16478111 ] Mathieu Lirzin commented on OFBIZ-4274: --- Indeed to document REST APIs, OpenAPI specs are useful when

[jira] [Commented] (OFBIZ-4274) Implement a REST Servlet

2018-05-16 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477992#comment-16477992 ] Mathieu Lirzin commented on OFBIZ-4274: --- I have been [studying for a

[jira] [Updated] (OFBIZ-10394) Fix typo "paramters" => "parameters"

2018-05-04 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10394: --- Attachment: OFBIZ-10394-Fix-typo-paramters-parameters.patch > Fix typo "paramters" =>

[jira] [Updated] (OFBIZ-10394) Fix typo "paramters" => "parameters"

2018-05-04 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10394: --- Priority: Minor (was: Major) > Fix typo "paramters" => "parameters" >

[jira] [Created] (OFBIZ-10394) Fix typo "paramters" => "parameters"

2018-05-04 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10394: -- Summary: Fix typo "paramters" => "parameters" Key: OFBIZ-10394 URL: https://issues.apache.org/jira/browse/OFBIZ-10394 Project: OFBiz Issue Type: Bug

[jira] [Updated] (OFBIZ-10393) Remove `createContent` Java service implementation

2018-05-04 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10393: --- Attachment: OFBIZ-10393-improved-Remove-createContent-Java-service-implement.patch > Remove

[jira] [Created] (OFBIZ-10393) Remove `createContent` Java service implementation

2018-05-04 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10393: -- Summary: Remove `createContent` Java service implementation Key: OFBIZ-10393 URL: https://issues.apache.org/jira/browse/OFBIZ-10393 Project: OFBiz Issue

[jira] [Commented] (OFBIZ-10354) Generalize `toMap` to abitrary key types

2018-05-02 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460705#comment-16460705 ] Mathieu Lirzin commented on OFBIZ-10354: OK, next time I will take care of referencing the issue

[jira] [Created] (OFBIZ-10355) Define generic types in `ProductStoreEvents`

2018-04-19 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10355: -- Summary: Define generic types in `ProductStoreEvents` Key: OFBIZ-10355 URL: https://issues.apache.org/jira/browse/OFBIZ-10355 Project: OFBiz Issue Type:

[jira] [Updated] (OFBIZ-10354) Generalize `toMap` to abitrary key types

2018-04-19 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10354: --- Attachment: 0001-improved-Generalize-toMap-to-abitrary-key-types.patch > Generalize `toMap`

[jira] [Created] (OFBIZ-10354) Generalize `toMap` to abitrary key types

2018-04-19 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10354: -- Summary: Generalize `toMap` to abitrary key types Key: OFBIZ-10354 URL: https://issues.apache.org/jira/browse/OFBIZ-10354 Project: OFBiz Issue Type:

<    5   6   7   8   9   10