Re: [PR] Bump inputmask from 5.0.8 to 5.0.9 in /themes/common-theme/webapp/common-theme/js [ofbiz-framework]

2024-05-31 Thread via GitHub
JacquesLeRoux merged PR #811: URL: https://github.com/apache/ofbiz-framework/pull/811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump dompurify from 3.1.4 to 3.1.5 in /themes/common-theme/webapp/common-theme/js [ofbiz-framework]

2024-05-31 Thread via GitHub
JacquesLeRoux merged PR #812: URL: https://github.com/apache/ofbiz-framework/pull/812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump inputmask from 5.0.8 to 5.0.9 in /themes/common-theme/webapp/common-theme/js [ofbiz-framework]

2024-05-31 Thread via GitHub
sonarcloud[bot] commented on PR #811: URL: https://github.com/apache/ofbiz-framework/pull/811#issuecomment-2142189766 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Bump dompurify from 3.1.4 to 3.1.5 in /themes/common-theme/webapp/common-theme/js [ofbiz-framework]

2024-05-31 Thread via GitHub
sonarcloud[bot] commented on PR #812: URL: https://github.com/apache/ofbiz-framework/pull/812#issuecomment-2142190041 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] Bump dompurify from 3.1.4 to 3.1.5 in /themes/common-theme/webapp/common-theme/js [ofbiz-framework]

2024-05-31 Thread via GitHub
dependabot[bot] opened a new pull request, #812: URL: https://github.com/apache/ofbiz-framework/pull/812 Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.1.4 to 3.1.5. Release notes Sourced from https://github.com/cure53/DOMPurify/releases;>dompurify's releases.

[PR] Bump inputmask from 5.0.8 to 5.0.9 in /themes/common-theme/webapp/common-theme/js [ofbiz-framework]

2024-05-31 Thread via GitHub
dependabot[bot] opened a new pull request, #811: URL: https://github.com/apache/ofbiz-framework/pull/811 Bumps [inputmask](https://github.com/RobinHerbots/Inputmask) from 5.0.8 to 5.0.9. Changelog Sourced from

Re: [PR] fixed: Link to supplier in Accounting Main does not show PartyFinancialHistory (OFBIZ-13100) [ofbiz-framework]

2024-05-29 Thread via GitHub
mbrohl closed pull request #805: fixed: Link to supplier in Accounting Main does not show PartyFinancialHistory (OFBIZ-13100) URL: https://github.com/apache/ofbiz-framework/pull/805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Improved: createPlugin - improve process and templates (OFBIZ-13048) [ofbiz-framework]

2024-05-29 Thread via GitHub
mbrohl closed pull request #807: Improved: createPlugin - improve process and templates (OFBIZ-13048) URL: https://github.com/apache/ofbiz-framework/pull/807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] fixed: PartyFinancialHistory shows parentTypeId of invoice, not invoiceTypeId (OFBIZ-13110) [ofbiz-framework]

2024-05-29 Thread via GitHub
mbrohl closed pull request #809: fixed: PartyFinancialHistory shows parentTypeId of invoice, not invoiceTypeId (OFBIZ-13110) URL: https://github.com/apache/ofbiz-framework/pull/809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Fixed: MainActionMenu not shown on findreturn screen (OFBIZ-13107) [ofbiz-framework]

2024-05-29 Thread via GitHub
JacquesLeRoux merged PR #810: URL: https://github.com/apache/ofbiz-framework/pull/810 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fixed: MainActionMenu not shown on findreturn screen (OFBIZ-13107) [ofbiz-framework]

2024-05-28 Thread via GitHub
sonarcloud[bot] commented on PR #810: URL: https://github.com/apache/ofbiz-framework/pull/810#issuecomment-2136107790 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] Fixed: MainActionMenu not shown on findreturn screen (OFBIZ-13107) [ofbiz-framework]

2024-05-28 Thread via GitHub
PierreSmits opened a new pull request, #810: URL: https://github.com/apache/ofbiz-framework/pull/810 The MainActionMenu of the order component is shown on various screens, but not on the findreturn screen. modified: OrderReturnScreens,xml - added pre-body decorator section having

Re: [PR] improved: PartyFinancialHistory shows parentTypeId of invoice, not invoiceTypeId (OFBIZ-13110) [ofbiz-framework]

2024-05-28 Thread via GitHub
sonarcloud[bot] commented on PR #809: URL: https://github.com/apache/ofbiz-framework/pull/809#issuecomment-2136070591 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] improved: PartyFinancialHistory shows parentTypeId of invoice, not invoiceTypeId (OFBIZ-13110) [ofbiz-framework]

2024-05-28 Thread via GitHub
PierreSmits opened a new pull request, #809: URL: https://github.com/apache/ofbiz-framework/pull/809 modified: PartyForms - ListInvoicesApplPayments, ListUnAppliedInvoices, ListUnAppliedPayments - harmonized overviews to show the same regarding id and type description fields --

Re: [PR] Improved: createPlugin - improve process and templates (OFBIZ-13048) [ofbiz-framework]

2024-05-28 Thread via GitHub
mbrohl commented on PR #807: URL: https://github.com/apache/ofbiz-framework/pull/807#issuecomment-2135198391 This needs more review, later... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Improved: createPlugin - improve process and templates (OFBIZ-13048) [ofbiz-framework]

2024-05-28 Thread via GitHub
JacquesLeRoux commented on PR #807: URL: https://github.com/apache/ofbiz-framework/pull/807#issuecomment-2135119725 Hi Pierre, Thanks for your work. How is the > process to generate plugin.properties file from StaticProperties.properties template supposed to work

Re: [PR] Bump jquery-ui-dist from 1.13.2 to 1.13.3 in /themes/common-theme/webapp/common-theme/js [ofbiz-framework]

2024-05-27 Thread via GitHub
JacquesLeRoux merged PR #808: URL: https://github.com/apache/ofbiz-framework/pull/808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump jquery-ui-dist from 1.13.2 to 1.13.3 in /themes/common-theme/webapp/common-theme/js [ofbiz-framework]

2024-05-27 Thread via GitHub
sonarcloud[bot] commented on PR #808: URL: https://github.com/apache/ofbiz-framework/pull/808#issuecomment-2133445125 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] Bump jquery-ui-dist from 1.13.2 to 1.13.3 in /themes/common-theme/webapp/common-theme/js [ofbiz-framework]

2024-05-27 Thread via GitHub
dependabot[bot] opened a new pull request, #808: URL: https://github.com/apache/ofbiz-framework/pull/808 Bumps [jquery-ui-dist](https://github.com/jquery/jquery-ui) from 1.13.2 to 1.13.3. Release notes Sourced from https://github.com/jquery/jquery-ui/releases;>jquery-ui-dist's

Re: [PR] Improved: createPlugin - improve process and templates (OFBIZ-13048) [ofbiz-framework]

2024-05-27 Thread via GitHub
PierreSmits commented on PR #807: URL: https://github.com/apache/ofbiz-framework/pull/807#issuecomment-2133386292 Hi @JacquesLeRoux, I have done this new pr (and closed the previous one relating to the ticket), taking into account: - removal of minilang folder - addressing the

Re: [PR] Improved: createPlugin - improve process and templates (OFBIZ-13048) [ofbiz-framework]

2024-05-27 Thread via GitHub
sonarcloud[bot] commented on PR #807: URL: https://github.com/apache/ofbiz-framework/pull/807#issuecomment-2133386391 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] Improved: createPlugin - improve process and templates (OFBIZ-13048) [ofbiz-framework]

2024-05-27 Thread via GitHub
PierreSmits opened a new pull request, #807: URL: https://github.com/apache/ofbiz-framework/pull/807 With the parameterization of the menu location, improvements to the createPlugin templates are warranted. added: StaticProperties.properties template SystemPropertyData.xml

Re: [PR] Improved: createPlugin - improve process and templates (OFBIZ-13048) [ofbiz-framework]

2024-05-27 Thread via GitHub
PierreSmits closed pull request #778: Improved: createPlugin - improve process and templates (OFBIZ-13048) URL: https://github.com/apache/ofbiz-framework/pull/778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Improved: createPlugin - improve process and templates (OFBIZ-13048) [ofbiz-framework]

2024-05-25 Thread via GitHub
JacquesLeRoux commented on PR #778: URL: https://github.com/apache/ofbiz-framework/pull/778#issuecomment-2131023395 Note: I was started on this by trying to find documentation about createPlugin Gradle task. I did not find any but the explanation of the task itself. I have though to read 8

Re: [PR] Improved: createPlugin - improve process and templates (OFBIZ-13048) [ofbiz-framework]

2024-05-25 Thread via GitHub
JacquesLeRoux commented on PR #778: URL: https://github.com/apache/ofbiz-framework/pull/778#issuecomment-2131001527 Michael's comment has been already addressed with OFBIZ-12813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Improved: createPlugin - improve process and templates (OFBIZ-13048) [ofbiz-framework]

2024-05-25 Thread via GitHub
JacquesLeRoux commented on PR #778: URL: https://github.com/apache/ofbiz-framework/pull/778#issuecomment-2130989972 Hi Pierre, The 1st thing to do is to address Michael's comment: > Scripts is deprecated also, Groovy files are now in src. Then update your branch by uploading

Re: [PR] improved: Duplicate action trigger in Manufacturing (OFBIZ-13101) [ofbiz-framework]

2024-05-24 Thread via GitHub
JacquesLeRoux merged PR #806: URL: https://github.com/apache/ofbiz-framework/pull/806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] improved: Duplicate action trigger in Manufacturing (OFBIZ-13101) [ofbiz-framework]

2024-05-24 Thread via GitHub
sonarcloud[bot] commented on PR #806: URL: https://github.com/apache/ofbiz-framework/pull/806#issuecomment-2129440136 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] improved: Duplicate action trigger in Manufacturing (OFBIZ-13101) [ofbiz-framework]

2024-05-24 Thread via GitHub
PierreSmits opened a new pull request, #806: URL: https://github.com/apache/ofbiz-framework/pull/806 On the 'FndProductionRun' an action trigger to create something is shown. This links to CreateProductionRun. This action trigger is already available via the MainActionMenu. Removing

Re: [PR] fixed: PartyFinancialHistory throws an error (OFBIZ-13099) [ofbiz-framework]

2024-05-24 Thread via GitHub
JacquesLeRoux merged PR #804: URL: https://github.com/apache/ofbiz-framework/pull/804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fixed: PartyFinancialHistory throws an error (OFBIZ-13099) [ofbiz-framework]

2024-05-24 Thread via GitHub
sonarcloud[bot] commented on PR #804: URL: https://github.com/apache/ofbiz-framework/pull/804#issuecomment-2129350456 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] fixed: Link to supplier in Accounting Main does not show PartyFinancialHistory (OFBIZ-13100) [ofbiz-framework]

2024-05-24 Thread via GitHub
sonarcloud[bot] commented on PR #805: URL: https://github.com/apache/ofbiz-framework/pull/805#issuecomment-2129192405 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] fixed: Link to supplier in Accounting Main does not show PartyFinancialHistory (OFBIZ-13100) [ofbiz-framework]

2024-05-24 Thread via GitHub
PierreSmits opened a new pull request, #805: URL: https://github.com/apache/ofbiz-framework/pull/805 When accessing the link to the PartyFinancialHistory screen of the supplier in

Re: [PR] fixed: PartyFinancialHistory throws an error (OFBIZ-13099) [ofbiz-framework]

2024-05-24 Thread via GitHub
sonarcloud[bot] commented on PR #804: URL: https://github.com/apache/ofbiz-framework/pull/804#issuecomment-2129106446 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] fixed: PartyFinancialHistory throws an error (OFBIZ-13099) [ofbiz-framework]

2024-05-24 Thread via GitHub
PierreSmits opened a new pull request, #804: URL: https://github.com/apache/ofbiz-framework/pull/804 When accessing the financial history screen in the partymgr application (e.g. via [https://localhost:8443/partymgr/control/PartyFinancialHistory?partyId=EuroSupplier] following error

Re: [PR] Improvements for ContentWorker methods and view-entities (OFBIZ-12829) [ofbiz-framework]

2024-05-23 Thread via GitHub
mbrohl merged PR #643: URL: https://github.com/apache/ofbiz-framework/pull/643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Improved: Refactoring WebSiteProperties.java (OFBIZ-12843) [ofbiz-framework]

2024-05-23 Thread via GitHub
mbrohl merged PR #667: URL: https://github.com/apache/ofbiz-framework/pull/667 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fixed: Apply orderItemAttributes when adding to Shoppingcart from addToCartFromOrder. (OFBIZ-12886) [ofbiz-framework]

2024-05-23 Thread via GitHub
mbrohl merged PR #685: URL: https://github.com/apache/ofbiz-framework/pull/685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] FIxed: Miss UI User message for pprojecgtmgr (OFBIZ-13015) [ofbiz-plugins]

2024-05-23 Thread via GitHub
JacquesLeRoux commented on PR #123: URL: https://github.com/apache/ofbiz-plugins/pull/123#issuecomment-2126404606 Closing, not the right solution unless proved otherwise -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] FIxed: Miss UI User message for pprojecgtmgr (OFBIZ-13015) [ofbiz-plugins]

2024-05-23 Thread via GitHub
JacquesLeRoux closed pull request #123: FIxed: Miss UI User message for pprojecgtmgr (OFBIZ-13015) URL: https://github.com/apache/ofbiz-plugins/pull/123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] improved: Have an XSD regarding portal records (OFBIZ-13097) [ofbiz-framework]

2024-05-22 Thread via GitHub
sonarcloud[bot] commented on PR #803: URL: https://github.com/apache/ofbiz-framework/pull/803#issuecomment-2124777603 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] improved: Have an XSD regarding portal records (OFBIZ-13097) [ofbiz-framework]

2024-05-22 Thread via GitHub
sonarcloud[bot] commented on PR #803: URL: https://github.com/apache/ofbiz-framework/pull/803#issuecomment-2124216956 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] improved: Have an XSD regarding portal records (OFBIZ-13097) [ofbiz-framework]

2024-05-22 Thread via GitHub
PierreSmits opened a new pull request, #803: URL: https://github.com/apache/ofbiz-framework/pull/803 Per suggestion by Jacques Le Roux: But we really miss the same for data used to define portals. So I strongly suggest that we create a shema for *PortletData.xml files. It should not be

[PR] improved: Have an XSD regarding portal records (OFBIZ-13097) [ofbiz-site]

2024-05-22 Thread via GitHub
PierreSmits opened a new pull request, #11: URL: https://github.com/apache/ofbiz-site/pull/11 Per suggestion by Jacques Le Roux: But we really miss the same for data used to define portals. So I strongly suggest that we create a shema for *PortletData.xml files. It should not be hard to

Re: [PR] Improved: createPlugin - improve process and templates (OFBIZ-13048) [ofbiz-framework]

2024-05-20 Thread via GitHub
PierreSmits commented on PR #778: URL: https://github.com/apache/ofbiz-framework/pull/778#issuecomment-2121098465 Hi @JacquesLeRoux , Your latest change did to resolve the conflict. For an explanation on choices made, see description of the ticket. -- This is an automated

Re: [PR] Improved: createPlugin - improve process and templates (OFBIZ-13048) [ofbiz-framework]

2024-05-20 Thread via GitHub
sonarcloud[bot] commented on PR #778: URL: https://github.com/apache/ofbiz-framework/pull/778#issuecomment-2120953997 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Bump dompurify from 3.1.3 to 3.1.4 in /themes/common-theme/webapp/common-theme/js [ofbiz-framework]

2024-05-20 Thread via GitHub
JacquesLeRoux merged PR #802: URL: https://github.com/apache/ofbiz-framework/pull/802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump dompurify from 3.1.3 to 3.1.4 in /themes/common-theme/webapp/common-theme/js [ofbiz-framework]

2024-05-20 Thread via GitHub
sonarcloud[bot] commented on PR #802: URL: https://github.com/apache/ofbiz-framework/pull/802#issuecomment-2120464662 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] Bump dompurify from 3.1.3 to 3.1.4 in /themes/common-theme/webapp/common-theme/js [ofbiz-framework]

2024-05-20 Thread via GitHub
dependabot[bot] opened a new pull request, #802: URL: https://github.com/apache/ofbiz-framework/pull/802 Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.1.3 to 3.1.4. Release notes Sourced from https://github.com/cure53/DOMPurify/releases;>dompurify's releases.

Re: [PR] Improved: CONTENT- Move from hard-coded menu location to parameterized (OFBIZ-12978) [ofbiz-plugins]

2024-05-19 Thread via GitHub
sonarcloud[bot] commented on PR #124: URL: https://github.com/apache/ofbiz-plugins/pull/124#issuecomment-2119320358 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Improved: CONTENT- Move from hard-coded menu location to parameterized (OFBIZ-12978) [ofbiz-plugins]

2024-05-19 Thread via GitHub
sonarcloud[bot] commented on PR #124: URL: https://github.com/apache/ofbiz-plugins/pull/124#issuecomment-2119230620 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] Improved: CONTENT- Move from hard-coded menu location to parameterized (OFBIZ-12978) [ofbiz-plugins]

2024-05-19 Thread via GitHub
PierreSmits opened a new pull request, #124: URL: https://github.com/apache/ofbiz-plugins/pull/124 modified: web.xml (lucene) - added: context-param for content menus -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Fixed: Duplicate main menu button after plugin creation (OFBIZ-13080) [ofbiz-framework]

2024-05-19 Thread via GitHub
JacquesLeRoux merged PR #794: URL: https://github.com/apache/ofbiz-framework/pull/794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Improved: Manufacturing-Main page (OFBIZ-13053) [ofbiz-framework]

2024-05-19 Thread via GitHub
sonarcloud[bot] commented on PR #784: URL: https://github.com/apache/ofbiz-framework/pull/784#issuecomment-2119138667 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Improved: CommonExt - Move from hard-code menu location to parameterized (OFBIZ-12951) [ofbiz-framework]

2024-05-19 Thread via GitHub
JacquesLeRoux merged PR #795: URL: https://github.com/apache/ofbiz-framework/pull/795 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Improved: CommonExt - Move from hard-code menu location to parameterized (OFBIZ-12951) [ofbiz-framework]

2024-05-18 Thread via GitHub
sonarcloud[bot] commented on PR #795: URL: https://github.com/apache/ofbiz-framework/pull/795#issuecomment-2118995653 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Improved: Corrected the condition to fetch currency UOM id from shipment instead of shipment route segment [ofbiz-framework]

2024-05-18 Thread via GitHub
vyasdevanshu merged PR #801: URL: https://github.com/apache/ofbiz-framework/pull/801 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Improved: Corrected the condition to fetch currency UOM id from shipment instead of shipment route segment [ofbiz-framework]

2024-05-18 Thread via GitHub
sonarcloud[bot] commented on PR #801: URL: https://github.com/apache/ofbiz-framework/pull/801#issuecomment-2118749666 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] Improved: Corrected the condition to fetch currency UOM id from shipment instead of shipment route segment [ofbiz-framework]

2024-05-18 Thread via GitHub
SandeepRajput20 opened a new pull request, #801: URL: https://github.com/apache/ofbiz-framework/pull/801 There is a typo in the condition while fetching a currency UOM id from the shipment route segment entity instead of shipment at the time of creating a shipment on the FedEx carrier.

Re: [PR] Improved: CommonExt - Move from hard-code menu location to parameterized (OFBIZ-12951) [ofbiz-framework]

2024-05-17 Thread via GitHub
sonarcloud[bot] commented on PR #795: URL: https://github.com/apache/ofbiz-framework/pull/795#issuecomment-2117462913 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Fixed: Error when calling EntityQuery.from() with a dve via groovy DSL (OFBIZ-13077) [ofbiz-framework]

2024-05-13 Thread via GitHub
MkLeila merged PR #792: URL: https://github.com/apache/ofbiz-framework/pull/792 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump dompurify from 3.1.2 to 3.1.3 in /themes/common-theme/webapp/common-theme/js [ofbiz-framework]

2024-05-13 Thread via GitHub
JacquesLeRoux merged PR #800: URL: https://github.com/apache/ofbiz-framework/pull/800 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump dompurify from 3.1.2 to 3.1.3 in /themes/common-theme/webapp/common-theme/js [ofbiz-framework]

2024-05-13 Thread via GitHub
sonarcloud[bot] commented on PR #800: URL: https://github.com/apache/ofbiz-framework/pull/800#issuecomment-2107619111 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] Bump dompurify from 3.1.2 to 3.1.3 in /themes/common-theme/webapp/common-theme/js [ofbiz-framework]

2024-05-13 Thread via GitHub
dependabot[bot] opened a new pull request, #800: URL: https://github.com/apache/ofbiz-framework/pull/800 Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.1.2 to 3.1.3. Release notes Sourced from https://github.com/cure53/DOMPurify/releases;>dompurify's releases.

Re: [PR] Improved: Manufacturing - VIEW permissions (OFBIZ-13090) [ofbiz-framework]

2024-05-13 Thread via GitHub
sonarcloud[bot] commented on PR #799: URL: https://github.com/apache/ofbiz-framework/pull/799#issuecomment-2106958534 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] Improved: Manufacturing - VIEW permissions (OFBIZ-13090) [ofbiz-framework]

2024-05-13 Thread via GitHub
PierreSmits opened a new pull request, #799: URL: https://github.com/apache/ofbiz-framework/pull/799 Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo with userId = auditor, accessing a ProductionRun related screen, sees triggers (to requests) reserved for users

Re: [PR] FIxed: Miss UI User message for pprojecgtmgr (OFBIZ-13015) [ofbiz-plugins]

2024-05-13 Thread via GitHub
sonarcloud[bot] commented on PR #123: URL: https://github.com/apache/ofbiz-plugins/pull/123#issuecomment-2106885610 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] FIxed: Miss UI User message for pprojecgtmgr (OFBIZ-13015) [ofbiz-plugins]

2024-05-13 Thread via GitHub
PierreSmits opened a new pull request, #123: URL: https://github.com/apache/ofbiz-plugins/pull/123 fixing the permission dependency on ASSETMAINT modified: secas.xml - changed dependencies -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Improved: CATALOG-Main: VIEW permission (OFBIZ-13088) [ofbiz-framework]

2024-05-13 Thread via GitHub
sonarcloud[bot] commented on PR #798: URL: https://github.com/apache/ofbiz-framework/pull/798#issuecomment-2106858696 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]

2024-05-11 Thread via GitHub
PierreSmits commented on PR #785: URL: https://github.com/apache/ofbiz-framework/pull/785#issuecomment-2105623501 Hi Jacques, Thanks for fixing the typo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]

2024-05-11 Thread via GitHub
JacquesLeRoux merged PR #785: URL: https://github.com/apache/ofbiz-framework/pull/785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]

2024-05-11 Thread via GitHub
sonarcloud[bot] commented on PR #785: URL: https://github.com/apache/ofbiz-framework/pull/785#issuecomment-2105615680 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]

2024-05-11 Thread via GitHub
JacquesLeRoux commented on PR #785: URL: https://github.com/apache/ofbiz-framework/pull/785#issuecomment-2105615193 Hi, About the error above where git diff did not give any information ``` error: applications/marketing/data/MarketingPortletData.xml: already exists in working

Re: [PR] Improved: Ecommerce - parameterized menu location (OFBIZ-13042) [ofbiz-plugins]

2024-05-10 Thread via GitHub
JacquesLeRoux merged PR #115: URL: https://github.com/apache/ofbiz-plugins/pull/115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Improved: Ecommerce - parameterized menu location (OFBIZ-13042) [ofbiz-plugins]

2024-05-10 Thread via GitHub
JacquesLeRoux commented on PR #115: URL: https://github.com/apache/ofbiz-plugins/pull/115#issuecomment-2105081507 Hi Pierre, Test OK, your proposition sounds reasonable to me since only blog*.xml are apart -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Fixed: PartyTypeAttr correction (OFBIZ-13076) [ofbiz-framework]

2024-05-10 Thread via GitHub
stschikin closed pull request #793: Fixed: PartyTypeAttr correction (OFBIZ-13076) URL: https://github.com/apache/ofbiz-framework/pull/793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Fixed: PartyTypeAttr correction (OFBIZ-13076) [ofbiz-framework]

2024-05-10 Thread via GitHub
JacquesLeRoux commented on PR #793: URL: https://github.com/apache/ofbiz-framework/pull/793#issuecomment-2104502150 Thanks for the clarification @stschikin Please close your PR, TIA -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Fixed: PartyTypeAttr correction (OFBIZ-13076) [ofbiz-framework]

2024-05-10 Thread via GitHub
stschikin commented on PR #793: URL: https://github.com/apache/ofbiz-framework/pull/793#issuecomment-2104298510 After re-evaluating the entire pull request, it looks like I have confused TypeAttr entities with Attribute entities. Attribute entities need a AttrValue, but TypeAttr do not.

Re: [PR] Improved: Ecommerce - parameterized menu location (OFBIZ-13042) [ofbiz-plugins]

2024-05-10 Thread via GitHub
sonarcloud[bot] commented on PR #115: URL: https://github.com/apache/ofbiz-plugins/pull/115#issuecomment-2104126667 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Improved: Manufacturing-Main page (OFBIZ-13053) [ofbiz-framework]

2024-05-10 Thread via GitHub
sonarcloud[bot] commented on PR #784: URL: https://github.com/apache/ofbiz-framework/pull/784#issuecomment-2103979123 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]

2024-05-10 Thread via GitHub
sonarcloud[bot] commented on PR #785: URL: https://github.com/apache/ofbiz-framework/pull/785#issuecomment-2103975317 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]

2024-05-10 Thread via GitHub
PierreSmits commented on PR #785: URL: https://github.com/apache/ofbiz-framework/pull/785#issuecomment-2103974953 Hi @JacquesLeRoux , I have updated the pull request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Improved: Ecommerce - parameterized menu location (OFBIZ-13042) [ofbiz-plugins]

2024-05-09 Thread via GitHub
PierreSmits commented on PR #115: URL: https://github.com/apache/ofbiz-plugins/pull/115#issuecomment-2103296555 HI @JacquesLeRoux, As there is only one menu in BlogMenu.xml, I will move the menu to the default menu (EcommerceMenus.xml) and remove the BlogMenus.xml file. Then,

Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]

2024-05-09 Thread via GitHub
PierreSmits commented on PR #785: URL: https://github.com/apache/ofbiz-framework/pull/785#issuecomment-2103232314 Now that is unfortunate. I will address this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]

2024-05-09 Thread via GitHub
JacquesLeRoux commented on PR #785: URL: https://github.com/apache/ofbiz-framework/pull/785#issuecomment-2103005543 Hi Pierre, The patch does no apply in Elipse nor with git apply: > C:\projectsASF\Git\ofbiz-framework>git apply 785.patch > 785.patch:70: trailing whitespace.

Re: [PR] Improved: Ecommerce - parameterized menu location (OFBIZ-13042) [ofbiz-plugins]

2024-05-09 Thread via GitHub
PierreSmits commented on PR #115: URL: https://github.com/apache/ofbiz-plugins/pull/115#issuecomment-2102518754 Hi @JacquesLeRoux , Thanks for your due-diligence. I will look into this -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Improved: Ecommerce - parameterized menu location (OFBIZ-13042) [ofbiz-plugins]

2024-05-09 Thread via GitHub
JacquesLeRoux commented on PR #115: URL: https://github.com/apache/ofbiz-plugins/pull/115#issuecomment-2102369490 Hi @PierreSmits, Patching works but getting to blogs. I locally get this error: > ERROR MESSAGE > java.lang.RuntimeException: Error rendering included menu named

Re: [PR] Improved: DOCKER.adoc corrections (OFBIZ-13087) [ofbiz-framework]

2024-05-08 Thread via GitHub
danwatford merged PR #797: URL: https://github.com/apache/ofbiz-framework/pull/797 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Improved: DOCKER.adoc corrections (OFBIZ-13087) [ofbiz-framework]

2024-05-08 Thread via GitHub
sonarcloud[bot] commented on PR #797: URL: https://github.com/apache/ofbiz-framework/pull/797#issuecomment-2100482566 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] Improved: DOCKER.adoc corrections (OFBIZ-13087) [ofbiz-framework]

2024-05-08 Thread via GitHub
danwatford opened a new pull request, #797: URL: https://github.com/apache/ofbiz-framework/pull/797 Correct the example command lines given in DOCKER.adoc used to build docker images. Remove use of redundant DOCKER_BUILDKIT environment variable. -- This is an automated message

Re: [PR] Improved: Manufacturing-Main page (OFBIZ-13053) [ofbiz-framework]

2024-05-08 Thread via GitHub
sonarcloud[bot] commented on PR #784: URL: https://github.com/apache/ofbiz-framework/pull/784#issuecomment-2099902061 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Fixed: Find Record buttons not working in EDM (OFBIZ-13083) [ofbiz-framework]

2024-05-06 Thread via GitHub
JacquesLeRoux merged PR #796: URL: https://github.com/apache/ofbiz-framework/pull/796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fixed: PartyTypeAttr correction (OFBIZ-13076) [ofbiz-framework]

2024-05-06 Thread via GitHub
JacquesLeRoux commented on PR #793: URL: https://github.com/apache/ofbiz-framework/pull/793#issuecomment-2095961995 Yes, we finally can keep it. A party has only one type, but a party type may have several attributes, hence several relations with a party. -- This is an automated message

Re: [PR] Fixed: PartyTypeAttr correction (OFBIZ-13076) [ofbiz-framework]

2024-05-06 Thread via GitHub
stschikin commented on PR #793: URL: https://github.com/apache/ofbiz-framework/pull/793#issuecomment-2095786293 The relation to Party seems kind of redundant with the relation to PartyType. I thought I had seen similar relations in other entities of that type, but after rechecking the

Re: [PR] Fixed: Find Record buttons not working in EDM (OFBIZ-13083) [ofbiz-framework]

2024-05-06 Thread via GitHub
sonarcloud[bot] commented on PR #796: URL: https://github.com/apache/ofbiz-framework/pull/796#issuecomment-2095661320 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] Fixed: Find Record buttons not working in EDM (OFBIZ-13083) [ofbiz-framework]

2024-05-06 Thread via GitHub
stschikin opened a new pull request, #796: URL: https://github.com/apache/ofbiz-framework/pull/796 Fixes Find Record Buttons A - Z in Entity Data Maintenance (EDM) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Fixed: PartyTypeAttr correction (OFBIZ-13076) [ofbiz-framework]

2024-05-06 Thread via GitHub
JacquesLeRoux commented on PR #793: URL: https://github.com/apache/ofbiz-framework/pull/793#issuecomment-2095516741 Ha, I think I know why now, because of ``` ``` Right? -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Fixed: PartyTypeAttr correction (OFBIZ-13076) [ofbiz-framework]

2024-05-06 Thread via GitHub
JacquesLeRoux commented on PR #793: URL: https://github.com/apache/ofbiz-framework/pull/793#issuecomment-2095508641 Hi @stschikin, Why did you remove? ``` ``` I see no pb with that. -- This is an automated message from the Apache Git

Re: [PR] Fixed: PartyTypeAttr correction (OFBIZ-13076) [ofbiz-framework]

2024-05-06 Thread via GitHub
stschikin commented on PR #793: URL: https://github.com/apache/ofbiz-framework/pull/793#issuecomment-2095332774 Hi @JacquesLeRoux thanks for your advice. I have edited the original post as requested. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Improved: CommonExt - Move from hard-code menu location to parameterized (OFBIZ-12951) [ofbiz-framework]

2024-05-04 Thread via GitHub
JacquesLeRoux commented on PR #795: URL: https://github.com/apache/ofbiz-framework/pull/795#issuecomment-2094120610 Hi @PierreSmits , After applying and a restart, I still get :+1: ERROR MESSAGE java.lang.RuntimeException: Error rendering included menu named

  1   2   3   4   5   6   7   8   9   10   >