Re: [PR] Improved: Ecommerce - parameterized menu location (OFBIZ-13042) [ofbiz-plugins]

2024-05-10 Thread via GitHub
JacquesLeRoux merged PR #115: URL: https://github.com/apache/ofbiz-plugins/pull/115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Improved: Ecommerce - parameterized menu location (OFBIZ-13042) [ofbiz-plugins]

2024-05-10 Thread via GitHub
JacquesLeRoux commented on PR #115: URL: https://github.com/apache/ofbiz-plugins/pull/115#issuecomment-2105081507 Hi Pierre, Test OK, your proposition sounds reasonable to me since only blog*.xml are apart -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Improved: Ecommerce - parameterized menu location (OFBIZ-13042) [ofbiz-plugins]

2024-05-10 Thread via GitHub
sonarcloud[bot] commented on PR #115: URL: https://github.com/apache/ofbiz-plugins/pull/115#issuecomment-2104126667 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Improved: Ecommerce - parameterized menu location (OFBIZ-13042) [ofbiz-plugins]

2024-05-09 Thread via GitHub
PierreSmits commented on PR #115: URL: https://github.com/apache/ofbiz-plugins/pull/115#issuecomment-2103296555 HI @JacquesLeRoux, As there is only one menu in BlogMenu.xml, I will move the menu to the default menu (EcommerceMenus.xml) and remove the BlogMenus.xml file. Then,

Re: [PR] Improved: Ecommerce - parameterized menu location (OFBIZ-13042) [ofbiz-plugins]

2024-05-09 Thread via GitHub
PierreSmits commented on PR #115: URL: https://github.com/apache/ofbiz-plugins/pull/115#issuecomment-2102518754 Hi @JacquesLeRoux , Thanks for your due-diligence. I will look into this -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Improved: Ecommerce - parameterized menu location (OFBIZ-13042) [ofbiz-plugins]

2024-05-09 Thread via GitHub
JacquesLeRoux commented on PR #115: URL: https://github.com/apache/ofbiz-plugins/pull/115#issuecomment-2102369490 Hi @PierreSmits, Patching works but getting to blogs. I locally get this error: > ERROR MESSAGE > java.lang.RuntimeException: Error rendering included menu named

Re: [PR] Improved: Ecommerce - parameterized menu location (OFBIZ-13042) [ofbiz-plugins]

2024-04-18 Thread via GitHub
sonarcloud[bot] commented on PR #115: URL: https://github.com/apache/ofbiz-plugins/pull/115#issuecomment-2064353423 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Improved: Ecommerce - parameterized menu location (OFBIZ-13042) [ofbiz-plugins]

2024-04-18 Thread via GitHub
sonarcloud[bot] commented on PR #115: URL: https://github.com/apache/ofbiz-plugins/pull/115#issuecomment-2064341307 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] Improved: Ecommerce - parameterized menu location (OFBIZ-13042) [ofbiz-plugins]

2024-04-18 Thread via GitHub
PierreSmits opened a new pull request, #115: URL: https://github.com/apache/ofbiz-plugins/pull/115 modified: - web.xml: added mainMenuLocation - BlogScreens.xml: changed menuLocation added: - EcommerceMenus.xml -- This is an automated message from the Apache Git