[ https://issues.apache.org/jira/browse/OFBIZ-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691911#comment-16691911 ]
Dennis Balkir commented on OFBIZ-10653: --------------------------------------- This patch adds a nullcheck for the partyEmail and provides a better errorMessage for the in-request service call. In addition the failing partyID will be logged for the admin to see > Missing nullcheck in service createContactListParty > --------------------------------------------------- > > Key: OFBIZ-10653 > URL: https://issues.apache.org/jira/browse/OFBIZ-10653 > Project: OFBiz > Issue Type: Bug > Components: marketing > Affects Versions: Trunk > Reporter: Dennis Balkir > Priority: Major > Attachments: OFBIZ-10653_ContactListServices.patch > > > This service searches for the primary email-address of the given party, if it > doesn't have a preffered contact mechanism ID in its parameters. > For this it uses the service {{getPartyEmail}} which, as a result, can > deliver an optional email-address. > This is where the problem is: the result is optional. > Without any further checks, the result, empty or not, will be used to call > another service called {{createContactListPartyStatus}}. For this service the > field {{preferredContactMechId}} is a non optional input value, which is set > before from the result of {{getPartyEmail}}. > If the party email could not be found, because a party group is added, or > simply because the party has no mail given for some reason, this service call > will result in an error because of missing parameters. -- This message was sent by Atlassian JIRA (v7.6.3#76005)