[
https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832419#comment-17832419
]
ASF subversion and git services commented on OFBIZ-11030:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067756#comment-17067756
]
ASF subversion and git services commented on OFBIZ-11030:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058927#comment-17058927
]
Pierre Smits commented on OFBIZ-11030:
--
And thank you, [~pierresmits], for your review and testing!
[
https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17055075#comment-17055075
]
Sebastian Berg commented on OFBIZ-11030:
Hi,
I updated the groovy formatting accordingly and
[
https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17054933#comment-17054933
]
Michael Brohl commented on OFBIZ-11030:
---
[~sberg]I think the latest patch needs more refactoring
[
https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049584#comment-17049584
]
Pierre Smits commented on OFBIZ-11030:
--
Then I guess we're good to go and have this merged, so that
[
https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049351#comment-17049351
]
Pierre Smits commented on OFBIZ-11030:
--
Thanks, [~sberg],
Must be on my side then.
> Convert
[
https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049345#comment-17049345
]
Sebastian Berg commented on OFBIZ-11030:
Hi [~pierresmits],
for me new entries appear in
[
https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049229#comment-17049229
]
Pierre Smits commented on OFBIZ-11030:
--
Hi [~sberg],
Did you see, while testing, data appearing in
[
https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049196#comment-17049196
]
Pierre Smits commented on OFBIZ-11030:
--
I got this again when trying to apply your patch in my git
[
https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049189#comment-17049189
]
Sebastian Berg commented on OFBIZ-11030:
I reuploaded the patch with the correct if-check. Sorry
[
https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17048488#comment-17048488
]
Pierre Smits commented on OFBIZ-11030:
--
[~sberg]
In 'loadSalesInvoiceItemFact' you have:
[
https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046616#comment-17046616
]
Pierre Smits commented on OFBIZ-11030:
--
[~sberg]
Applying the patch gave following in a window in
[
https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046358#comment-17046358
]
Pierre Smits commented on OFBIZ-11030:
--
No worries, [~sberg]. Human errors do happen. For all kinds
[
https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046355#comment-17046355
]
Sebastian Berg commented on OFBIZ-11030:
You are right [~pierresmits] in loadInventoryFact()
[
https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045911#comment-17045911
]
Pierre Smits commented on OFBIZ-11030:
--
Thanks [~sberg],
I did some aceptance testing with the
[
https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045547#comment-17045547
]
Sebastian Berg commented on OFBIZ-11030:
I have reuploaded the patch, it should work now.
>
[
https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045450#comment-17045450
]
Pierre Smits commented on OFBIZ-11030:
--
When trying to apply the patch I get an error as shown in
[
https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045403#comment-17045403
]
Pierre Smits commented on OFBIZ-11030:
--
HI [~sberg],
A cursory review looks good. I will test
[
https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044456#comment-17044456
]
Pierre Smits commented on OFBIZ-11030:
--
Ahh. Ok.
Thanks for the update. I will postpone changes to
[
https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044452#comment-17044452
]
Sebastian Berg commented on OFBIZ-11030:
Hi [~pierresmits],
I have migrated the the Methods
[
https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044433#comment-17044433
]
Pierre Smits commented on OFBIZ-11030:
--
Hi [~sberg],
Do you mind if I takes this on me. I am
22 matches
Mail list logo
