[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion

2019-04-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820944#comment-16820944 ] Jacques Le Roux commented on OFBIZ-4160: Thanks Pierre, Looking forward... > Tax not added for

[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion

2019-04-18 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820915#comment-16820915 ] Pierre Smits commented on OFBIZ-4160: - Hi Jacques, Of course, if and when that leads to more parties

[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion

2019-04-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820837#comment-16820837 ] Jacques Le Roux commented on OFBIZ-4160: Hi Benjamin, Pierre, Should we not create a Jira to

[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion

2018-11-28 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702819#comment-16702819 ] Jacques Le Roux commented on OFBIZ-4160: I'll try to fix the tests (I suppose they need to be

[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion

2018-11-28 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702454#comment-16702454 ] Jacques Le Roux commented on OFBIZ-4160: Seems that there are some tests issue. I'll check that

[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion

2018-11-28 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702449#comment-16702449 ] Jacques Le Roux commented on OFBIZ-4160: Thanks Benjamin, Your patch is in trunk r1847670 R17

[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion

2018-11-28 Thread Benjamin Jugl (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701917#comment-16701917 ] Benjamin Jugl commented on OFBIZ-4160: -- We do not use it, since it was only something that I

[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion

2018-11-21 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694393#comment-16694393 ] Jacques Le Roux commented on OFBIZ-4160: Hi [~bjugl] Before I commit could you please confirm

[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion

2018-11-16 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689503#comment-16689503 ] Jacques Le Roux commented on OFBIZ-4160: Hi Benjamin, Your patch looks good to me. Before I

[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion

2018-11-16 Thread Benjamin Jugl (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689277#comment-16689277 ] Benjamin Jugl commented on OFBIZ-4160: -- Sorry, i am currently a little bit entangled in projects for

[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion

2018-11-12 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683545#comment-16683545 ] Pierre Smits commented on OFBIZ-4160: - I agree. let's not dilute this issue (too much). > Tax not

[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion

2018-11-12 Thread Benjamin Jugl (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683521#comment-16683521 ] Benjamin Jugl commented on OFBIZ-4160: -- That is exactly how it is used in Germany and I think most

[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion

2018-11-10 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682297#comment-16682297 ] Pierre Smits commented on OFBIZ-4160: - The Nederlandse Belastingdienst states on their website

[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion

2018-11-09 Thread Benjamin Jugl (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681569#comment-16681569 ] Benjamin Jugl commented on OFBIZ-4160: -- I would not want to change that, after all, they are

[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion

2018-11-09 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681457#comment-16681457 ] Pierre Smits commented on OFBIZ-4160: - I don't think that there is a need for that. The setup of

[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion

2018-11-09 Thread Benjamin Jugl (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681204#comment-16681204 ] Benjamin Jugl commented on OFBIZ-4160: -- That is a tough one. I had a good thought about that and I

[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion

2018-11-08 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679532#comment-16679532 ] Pierre Smits commented on OFBIZ-4160: - How do we factor in the possibility that shipping has a

[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion

2018-11-07 Thread Benjamin Jugl (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678447#comment-16678447 ] Benjamin Jugl commented on OFBIZ-4160: -- Patch Provided. Tax on shipping is now weighted as

[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion

2018-10-08 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641808#comment-16641808 ] Jacques Le Roux commented on OFBIZ-4160: Hi Benjami, Sounds good, please proceed > Tax not

[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion

2018-10-08 Thread Benjamin Jugl (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641681#comment-16641681 ] Benjamin Jugl commented on OFBIZ-4160: -- Hi, I am currently implementing multinational