[jira] [Commented] (OFBIZ-9144) refactor javadocs in OFBiz to be standards compliant

2016-12-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15759342#comment-15759342 ] Jacques Le Roux commented on OFBIZ-9144: Moot point to me for true over removing, can be removed

[jira] [Commented] (OFBIZ-9144) refactor javadocs in OFBiz to be standards compliant

2016-12-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15759339#comment-15759339 ] Jacques Le Roux commented on OFBIZ-9144: I'm now used to see Taher doing the hardest tasks, so I

[jira] [Commented] (OFBIZ-9144) refactor javadocs in OFBiz to be standards compliant

2016-12-18 Thread Michael Brohl (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15759333#comment-15759333 ] Michael Brohl commented on OFBIZ-9144: -- Yes, I have noticed that you suggested to remove it. I think

[jira] [Commented] (OFBIZ-9144) refactor javadocs in OFBiz to be standards compliant

2016-12-18 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15759314#comment-15759314 ] Taher Alkhateeb commented on OFBIZ-9144: Minor point, but deleting this flag is the same as

[jira] [Commented] (OFBIZ-9144) refactor javadocs in OFBiz to be standards compliant

2016-12-18 Thread Michael Brohl (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15759308#comment-15759308 ] Michael Brohl commented on OFBIZ-9144: -- I have changed to javadoc.failOnError = true in trunk

[jira] [Commented] (OFBIZ-9144) refactor javadocs in OFBiz to be standards compliant

2016-12-18 Thread Michael Brohl (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15759306#comment-15759306 ] Michael Brohl commented on OFBIZ-9144: -- Thanks, Jacques. The hardest work was done by Taher, I was

[jira] [Commented] (OFBIZ-9144) refactor javadocs in OFBiz to be standards compliant

2016-12-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15759250#comment-15759250 ] Jacques Le Roux commented on OFBIZ-9144: (y) for the hard work, thanks Michael! +1 for capturing

[jira] [Commented] (OFBIZ-9144) refactor javadocs in OFBiz to be standards compliant

2016-12-18 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15759225#comment-15759225 ] Taher Alkhateeb commented on OFBIZ-9144: And yeah if all errors are removed, we can tolerate

[jira] [Commented] (OFBIZ-9144) refactor javadocs in OFBiz to be standards compliant

2016-12-18 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15759223#comment-15759223 ] Taher Alkhateeb commented on OFBIZ-9144: Wonderful work! Thank you Michael. I suggest if

[jira] [Commented] (OFBIZ-9144) refactor javadocs in OFBiz to be standards compliant

2016-12-18 Thread Michael Brohl (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15758555#comment-15758555 ] Michael Brohl commented on OFBIZ-9144: -- Of course, Pierre. I just created a reminder issue for this

[jira] [Commented] (OFBIZ-9144) refactor javadocs in OFBiz to be standards compliant

2016-12-18 Thread Michael Brohl (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15758504#comment-15758504 ] Michael Brohl commented on OFBIZ-9144: -- Yes, the flags does not show any errors in the log. I have

[jira] [Commented] (OFBIZ-9144) refactor javadocs in OFBiz to be standards compliant

2016-12-17 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15758159#comment-15758159 ] Taher Alkhateeb commented on OFBIZ-9144: Yeah good idea. Does this flag stop you from detecting

[jira] [Commented] (OFBIZ-9144) refactor javadocs in OFBiz to be standards compliant

2016-12-17 Thread Michael Brohl (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15757809#comment-15757809 ] Michael Brohl commented on OFBIZ-9144: -- Committed a bunch of corrections in r1774815. I've attached

[jira] [Commented] (OFBIZ-9144) refactor javadocs in OFBiz to be standards compliant

2016-12-17 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15757693#comment-15757693 ] Taher Alkhateeb commented on OFBIZ-9144: There is probably a flag somewhere but by default gradle

[jira] [Commented] (OFBIZ-9144) refactor javadocs in OFBiz to be standards compliant

2016-12-17 Thread Michael Brohl (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15757690#comment-15757690 ] Michael Brohl commented on OFBIZ-9144: -- Are you sure they are that many? I checked with the above

[jira] [Commented] (OFBIZ-9144) refactor javadocs in OFBiz to be standards compliant

2016-12-17 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15757663#comment-15757663 ] Taher Alkhateeb commented on OFBIZ-9144: Hi Michael, By all means .. please help! Please note

[jira] [Commented] (OFBIZ-9144) refactor javadocs in OFBiz to be standards compliant

2016-12-17 Thread Michael Brohl (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15757656#comment-15757656 ] Michael Brohl commented on OFBIZ-9144: -- Are you still working on this issue, [~taher]? Else I will

[jira] [Commented] (OFBIZ-9144) refactor javadocs in OFBiz to be standards compliant

2016-12-14 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15747785#comment-15747785 ] Taher Alkhateeb commented on OFBIZ-9144: Committed a large fix in r1774154. > refactor javadocs

[jira] [Commented] (OFBIZ-9144) refactor javadocs in OFBiz to be standards compliant

2016-12-14 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15747669#comment-15747669 ] Taher Alkhateeb commented on OFBIZ-9144: This is a little bash code snippet that I use to quickly