[
https://issues.apache.org/jira/browse/OFBIZ-9592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Foxworthy updated OFBIZ-9592:
----------------------------------
Description:
In the quantities relating to order items, there are two numbers presented:
"remaining" and "outstanding". The calculations for these two numbers are
identical.
Compare
[https://github.com/apache/ofbiz-framework/blame/trunk/applications/order/template/order/OrderItems.ftl#L250]
for a purchase order item (and two lines below for a sales order item)
with
[https://github.com/apache/ofbiz-framework/blame/trunk/applications/order/template/order/OrderItems.ftl#L302]
for a purchases order item (and two lines below for a sales order item)
The only difference I can see between the Remaining and Outstanding numbers
is the extra test the second time to force the outstanding number to zero for a
status of ITEM_COMPLETED. -As the comment says, some goods won't need a-
-shipment. In that case, it seems confusing and ridiculous to say some items-
-are "remaining" but none are "outstanding". In other words, the calculation-
-for outstanding is slightly better.-
-I propose we should remove "remaining".-
I have worked out why there are two different numbers: the original intent was
that Remaining is the quantity after any cancellations, so in the common
situation where there have been no cancellations, Remaining should be the same
as the original quantity ordered.
A bug was introduced in a commit a long time ago, where "Remaining" was changed
so it replicates "Outstanding".
was:
In the quantities relating to order items, there are two numbers presented:
"remaining" and "outstanding". The calculations for these two numbers are
identical.
Compare
https://github.com/apache/ofbiz-framework/blame/trunk/applications/order/template/order/OrderItems.ftl#L250
for a purchase order item (and two lines below for a sales order item)
with
https://github.com/apache/ofbiz-framework/blame/trunk/applications/order/template/order/OrderItems.ftl#L302
for a purchases order item (and two lines below for a sales order item)
The only difference I can see between the Remaining and Outstanding numbers
is the extra test the second time to force the outstanding number to zero for a
status of ITEM_COMPLETED. As the comment says, some goods won't need a
shipment. In that case, it seems confusing and ridiculous to say some items
are "remaining" but none are "outstanding". In other words, the calculation
for outstanding is slightly better.
I propose we should remove "remaining".
> Order Item "Remaining" duplicates "Outstanding"
> ------------------------------------------------
>
> Key: OFBIZ-9592
> URL: https://issues.apache.org/jira/browse/OFBIZ-9592
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: Trunk, Upcoming Branch
> Reporter: Paul Foxworthy
> Assignee: Paul Foxworthy
> Priority: Major
> Labels: order, order_item
>
> In the quantities relating to order items, there are two numbers presented:
> "remaining" and "outstanding". The calculations for these two numbers are
> identical.
> Compare
> [https://github.com/apache/ofbiz-framework/blame/trunk/applications/order/template/order/OrderItems.ftl#L250]
> for a purchase order item (and two lines below for a sales order item)
> with
> [https://github.com/apache/ofbiz-framework/blame/trunk/applications/order/template/order/OrderItems.ftl#L302]
> for a purchases order item (and two lines below for a sales order item)
> The only difference I can see between the Remaining and Outstanding numbers
> is the extra test the second time to force the outstanding number to zero for
> a
> status of ITEM_COMPLETED. -As the comment says, some goods won't need a-
> -shipment. In that case, it seems confusing and ridiculous to say some items-
> -are "remaining" but none are "outstanding". In other words, the calculation-
> -for outstanding is slightly better.-
> -I propose we should remove "remaining".-
> I have worked out why there are two different numbers: the original intent
> was that Remaining is the quantity after any cancellations, so in the common
> situation where there have been no cancellations, Remaining should be the
> same as the original quantity ordered.
> A bug was introduced in a commit a long time ago, where "Remaining" was
> changed so it replicates "Outstanding".
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
