[jira] [Commented] (OFBIZ-2208) ServerHit aborts transactions when trying to create entries with duplicate startTime(s).

[Abhishek Kumar (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104482#comment-16104482
 ] 

Abhishek Kumar commented on OFBIZ-2208:
---

its not working. i did changes in fieldtypemsql.xml but then also its not
working.please tell me what to do?


On Thu, Jul 27, 2017 at 10:03 PM, Deepak Dixit (JIRA) 



> ServerHit aborts transactions when trying to create entries with duplicate 
> startTime(s).
> 
>
> Key: OFBIZ-2208
> URL: https://issues.apache.org/jira/browse/OFBIZ-2208
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 4.0, Trunk
> Environment: any
>Reporter: Karim Rahimpur
>Assignee: Jacques Le Roux
> Attachments: ServerHitBin.java.patch, ServerHitBin.patch, 
> ServerHit.patch, SynchronizedHitBin.patch
>
>
> org.ofbiz.webapp.stats.ServerHitBin.saveHit(...) causes transactions to be 
> aborted due to duplicate PKs.
> The problem is that said method will try to create two or more entries with 
> identical startTimes (i.e. duplicate hitStartDateTime and the other fields 
> composing the PK: visitId, contentId, hitStartDateTime, hitTypeId) if two or 
> more subsequent requests are made in a sufficiently small interval. This can 
> and *will* be the case for example if an application rapidly issues requests 
> for similar data. It would usually not be observed when human users cause 
> requests being issued.
> The cause is that the above mentioned method uses
> serverHit.create();
> to store the entries.
> A solution to this is to _create or update_ an existing entry, thus 
> overwriting an existing entry in case there already was an entry, but more 
> importantly avoiding the actual transaction being aborted. This may not 
> satisfy those who want to record each and every server hit even with equal 
> startTimes. For these cases other approaches might be considered ...
> This is an example where a transaction fails due to saveHit(...). In our case 
> an applet tries to pull data off the server and fails ...
> {panel}Failure in create operation for entity [ServerHit]: 
> org.ofbiz.entity.GenericEntityException: Error while inserting: 
> [GenericEntity:ServerHit][contentId,gdm.getProductFeatureApplAttrs(java.lang.String)][createdStamp,2009-02-24
>  10:34:29.454(java.sql.Timestamp)][createdTxStamp,2009-02-24 
> 10:34:29.454(java.sql.Timestamp)][hitStartDateTime,2009-02-24 
> 10:34:29.443(java.sql.Timestamp)][hitTypeId,REQUEST(java.lang.String)][lastUpdatedStamp,2009-02-24
>  10:34:29.454(java.sql.Timestamp)][lastUpdatedTxStamp,2009-02-24 
> 10:34:29.454(java.sql.Timestamp)][partyId,KR(java.lang.String)][referrerUrl,(java.lang.String)][requestUrl,https://127.0.0.1:8443/gdm/control/getProductFeatureApplAttrs(java.lang.String)][runningTimeMillis,8(java.lang.Long)][serverHostName,Kitty(java.lang.String)][serverIpAddress,192.168.1.70(java.lang.String)][userLoginId,karim(java.lang.String)][visitId,11900(java.lang.String)]
>  (SQL Exception while executing the following:INSERT INTO SERVER_HIT 
> (VISIT_ID, CONTENT_ID, HIT_START_DATE_TIME, HIT_TYPE_ID, NUM_OF_BYTES, 
> RUNNING_TIME_MILLIS, USER_LOGIN_ID, STATUS_ID, REQUEST_URL, REFERRER_URL, 
> SERVER_IP_ADDRESS, SERVER_HOST_NAME, LAST_UPDATED_STAMP, 
> LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP, INTERNAL_CONTENT_ID, 
> PARTY_ID, ID_BY_IP_CONTACT_MECH_ID, REF_BY_WEB_CONTACT_MECH_ID) VALUES (?, ?, 
> ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) (Duplicate entry 
> '11900-gdm.getProductFeatureApplAttrs-2009-02-24 10:34:29-REQUEST' for key 
> 'PRIMARY')). Rolling back transaction.
> Exception: org.ofbiz.entity.GenericEntityException{panel}
> This issue seems to be related (it refers to the releae branch 4.0 and the 
> same error shows up):
> [https://issues.apache.org/jira/browse/OFBIZ-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OFBIZ-9540) UI inconsistency in "Current Status Id" dropdown of FindRouting screen.

[Renuka Srishti (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Renuka Srishti updated OFBIZ-9540:
--
Labels: routing  (was: )

> UI inconsistency in "Current Status Id" dropdown of FindRouting screen.
> ---
>
> Key: OFBIZ-9540
> URL: https://issues.apache.org/jira/browse/OFBIZ-9540
> Project: OFBiz
>  Issue Type: Bug
>  Components: manufacturing
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Renuka Srishti
>Priority: Minor
>  Labels: routing
> Attachments: FindRouting.png
>
>
> 1. Click on Manufacturing component.
> 2. Here you can see one label "Routing". Click on it, you will redirect to 
> [https://demo-trunk.ofbiz.apache.org/manufacturing/control/FindRouting]
> 3. Select status from "Current Status Id" drop-down, where status with Remove 
> label will be shown, which is not consistent with the other forms.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OFBIZ-9540) UI inconsistency in "Current Status Id" dropdown of FindRouting screen.

[Renuka Srishti (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Renuka Srishti updated OFBIZ-9540:
--
Component/s: manufacturing

> UI inconsistency in "Current Status Id" dropdown of FindRouting screen.
> ---
>
> Key: OFBIZ-9540
> URL: https://issues.apache.org/jira/browse/OFBIZ-9540
> Project: OFBiz
>  Issue Type: Bug
>  Components: manufacturing
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Renuka Srishti
>Priority: Minor
>  Labels: routing
> Attachments: FindRouting.png
>
>
> 1. Click on Manufacturing component.
> 2. Here you can see one label "Routing". Click on it, you will redirect to 
> [https://demo-trunk.ofbiz.apache.org/manufacturing/control/FindRouting]
> 3. Select status from "Current Status Id" drop-down, where status with Remove 
> label will be shown, which is not consistent with the other forms.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OFBIZ-9540) UI inconsistency in "Current Status Id" dropdown of FindRouting screen.

[Renuka Srishti (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Renuka Srishti updated OFBIZ-9540:
--
Affects Version/s: Trunk
   Release Branch 16.11

> UI inconsistency in "Current Status Id" dropdown of FindRouting screen.
> ---
>
> Key: OFBIZ-9540
> URL: https://issues.apache.org/jira/browse/OFBIZ-9540
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Renuka Srishti
>Priority: Minor
> Attachments: FindRouting.png
>
>
> 1. Click on Manufacturing component.
> 2. Here you can see one label "Routing". Click on it, you will redirect to 
> [https://demo-trunk.ofbiz.apache.org/manufacturing/control/FindRouting]
> 3. Select status from "Current Status Id" drop-down, where status with Remove 
> label will be shown, which is not consistent with the other forms.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OFBIZ-9540) UI inconsistency in "Current Status Id" dropdown of FindRouting screen.

[Renuka Srishti (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Renuka Srishti updated OFBIZ-9540:
--
Priority: Minor  (was: Major)

> UI inconsistency in "Current Status Id" dropdown of FindRouting screen.
> ---
>
> Key: OFBIZ-9540
> URL: https://issues.apache.org/jira/browse/OFBIZ-9540
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Renuka Srishti
>Priority: Minor
> Attachments: FindRouting.png
>
>
> 1. Click on Manufacturing component.
> 2. Here you can see one label "Routing". Click on it, you will redirect to 
> [https://demo-trunk.ofbiz.apache.org/manufacturing/control/FindRouting]
> 3. Select status from "Current Status Id" drop-down, where status with Remove 
> label will be shown, which is not consistent with the other forms.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OFBIZ-9540) UI inconsistency in "Current Status Id" dropdown of FindRouting screen.

[Renuka Srishti (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Renuka Srishti updated OFBIZ-9540:
--
Attachment: FindRouting.png

> UI inconsistency in "Current Status Id" dropdown of FindRouting screen.
> ---
>
> Key: OFBIZ-9540
> URL: https://issues.apache.org/jira/browse/OFBIZ-9540
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Renuka Srishti
> Attachments: FindRouting.png
>
>
> 1. Click on Manufacturing component.
> 2. Here you can see one label "Routing". Click on it, you will redirect to 
> [https://demo-trunk.ofbiz.apache.org/manufacturing/control/FindRouting]
> 3. Select status from "Current Status Id" drop-down, where status with Remove 
> label will be shown, which is not consistent with the other forms.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (OFBIZ-9540) UI inconsistency in "Current Status Id" dropdown of FindRouting screen.

[Renuka Srishti (JIRA)]

Renuka Srishti created OFBIZ-9540:
-

 Summary: UI inconsistency in "Current Status Id" dropdown of 
FindRouting screen.
 Key: OFBIZ-9540
 URL: https://issues.apache.org/jira/browse/OFBIZ-9540
 Project: OFBiz
  Issue Type: Bug
Reporter: Renuka Srishti


1. Click on Manufacturing component.
2. Here you can see one label "Routing". Click on it, you will redirect to 
[https://demo-trunk.ofbiz.apache.org/manufacturing/control/FindRouting]
3. Select status from "Current Status Id" drop-down, where status with Remove 
label will be shown, which is not consistent with the other forms.




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OFBIZ-7722) Sub-menu looks overlapping in Tomahawk theme

[Jacques Le Roux (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-7722:
---
  Priority: Minor  (was: Major)
Issue Type: Improvement  (was: Bug)

> Sub-menu looks overlapping in Tomahawk theme
> 
>
> Key: OFBIZ-7722
> URL: https://issues.apache.org/jira/browse/OFBIZ-7722
> Project: OFBiz
>  Issue Type: Improvement
>  Components: themes
>Affects Versions: Trunk
>Reporter: Swapnil Shah
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-7722.patch, OFBIZ-7722.png, Theme.png
>
>
> Please refer to attached screenshot for reference



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Closed] (OFBIZ-7722) Sub-menu looks overlapping in Tomahawk theme

[Jacques Le Roux (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-7722.
--
   Resolution: Done
Fix Version/s: Upcoming Release

Thanks Ayushi,

Your patch is in trunk at revision: 1803211  

I did not backport because actually nothing is overlapped, it's only the 
background color which was misleading, so it's not a bug but an improvement.


> Sub-menu looks overlapping in Tomahawk theme
> 
>
> Key: OFBIZ-7722
> URL: https://issues.apache.org/jira/browse/OFBIZ-7722
> Project: OFBiz
>  Issue Type: Bug
>  Components: themes
>Affects Versions: Trunk
>Reporter: Swapnil Shah
>Assignee: Jacques Le Roux
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-7722.patch, OFBIZ-7722.png, Theme.png
>
>
> Please refer to attached screenshot for reference



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OFBIZ-2208) ServerHit aborts transactions when trying to create entries with duplicate startTime(s).

[Abhishek Kumar (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103314#comment-16103314
 ] 

Abhishek Kumar commented on OFBIZ-2208:
---

if possible can you give your phone number?so that I can directly contact
you as I am new to ofbiz.


On Thu, Jul 27, 2017 at 8:02 AM, ABHISHEK KUMAR 



> ServerHit aborts transactions when trying to create entries with duplicate 
> startTime(s).
> 
>
> Key: OFBIZ-2208
> URL: https://issues.apache.org/jira/browse/OFBIZ-2208
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 4.0, Trunk
> Environment: any
>Reporter: Karim Rahimpur
>Assignee: Jacques Le Roux
> Attachments: ServerHitBin.java.patch, ServerHitBin.patch, 
> ServerHit.patch, SynchronizedHitBin.patch
>
>
> org.ofbiz.webapp.stats.ServerHitBin.saveHit(...) causes transactions to be 
> aborted due to duplicate PKs.
> The problem is that said method will try to create two or more entries with 
> identical startTimes (i.e. duplicate hitStartDateTime and the other fields 
> composing the PK: visitId, contentId, hitStartDateTime, hitTypeId) if two or 
> more subsequent requests are made in a sufficiently small interval. This can 
> and *will* be the case for example if an application rapidly issues requests 
> for similar data. It would usually not be observed when human users cause 
> requests being issued.
> The cause is that the above mentioned method uses
> serverHit.create();
> to store the entries.
> A solution to this is to _create or update_ an existing entry, thus 
> overwriting an existing entry in case there already was an entry, but more 
> importantly avoiding the actual transaction being aborted. This may not 
> satisfy those who want to record each and every server hit even with equal 
> startTimes. For these cases other approaches might be considered ...
> This is an example where a transaction fails due to saveHit(...). In our case 
> an applet tries to pull data off the server and fails ...
> {panel}Failure in create operation for entity [ServerHit]: 
> org.ofbiz.entity.GenericEntityException: Error while inserting: 
> [GenericEntity:ServerHit][contentId,gdm.getProductFeatureApplAttrs(java.lang.String)][createdStamp,2009-02-24
>  10:34:29.454(java.sql.Timestamp)][createdTxStamp,2009-02-24 
> 10:34:29.454(java.sql.Timestamp)][hitStartDateTime,2009-02-24 
> 10:34:29.443(java.sql.Timestamp)][hitTypeId,REQUEST(java.lang.String)][lastUpdatedStamp,2009-02-24
>  10:34:29.454(java.sql.Timestamp)][lastUpdatedTxStamp,2009-02-24 
> 10:34:29.454(java.sql.Timestamp)][partyId,KR(java.lang.String)][referrerUrl,(java.lang.String)][requestUrl,https://127.0.0.1:8443/gdm/control/getProductFeatureApplAttrs(java.lang.String)][runningTimeMillis,8(java.lang.Long)][serverHostName,Kitty(java.lang.String)][serverIpAddress,192.168.1.70(java.lang.String)][userLoginId,karim(java.lang.String)][visitId,11900(java.lang.String)]
>  (SQL Exception while executing the following:INSERT INTO SERVER_HIT 
> (VISIT_ID, CONTENT_ID, HIT_START_DATE_TIME, HIT_TYPE_ID, NUM_OF_BYTES, 
> RUNNING_TIME_MILLIS, USER_LOGIN_ID, STATUS_ID, REQUEST_URL, REFERRER_URL, 
> SERVER_IP_ADDRESS, SERVER_HOST_NAME, LAST_UPDATED_STAMP, 
> LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP, INTERNAL_CONTENT_ID, 
> PARTY_ID, ID_BY_IP_CONTACT_MECH_ID, REF_BY_WEB_CONTACT_MECH_ID) VALUES (?, ?, 
> ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) (Duplicate entry 
> '11900-gdm.getProductFeatureApplAttrs-2009-02-24 10:34:29-REQUEST' for key 
> 'PRIMARY')). Rolling back transaction.
> Exception: org.ofbiz.entity.GenericEntityException{panel}
> This issue seems to be related (it refers to the releae branch 4.0 and the 
> same error shows up):
> [https://issues.apache.org/jira/browse/OFBIZ-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OFBIZ-2208) ServerHit aborts transactions when trying to create entries with duplicate startTime(s).

[Abhishek Kumar (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103313#comment-16103313
 ] 

Abhishek Kumar commented on OFBIZ-2208:
---

mysql 6.3 and ofbiz-13.07.03


On Thu, Jul 27, 2017 at 1:02 AM, Deepak Dixit (JIRA) 



> ServerHit aborts transactions when trying to create entries with duplicate 
> startTime(s).
> 
>
> Key: OFBIZ-2208
> URL: https://issues.apache.org/jira/browse/OFBIZ-2208
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 4.0, Trunk
> Environment: any
>Reporter: Karim Rahimpur
>Assignee: Jacques Le Roux
> Attachments: ServerHitBin.java.patch, ServerHitBin.patch, 
> ServerHit.patch, SynchronizedHitBin.patch
>
>
> org.ofbiz.webapp.stats.ServerHitBin.saveHit(...) causes transactions to be 
> aborted due to duplicate PKs.
> The problem is that said method will try to create two or more entries with 
> identical startTimes (i.e. duplicate hitStartDateTime and the other fields 
> composing the PK: visitId, contentId, hitStartDateTime, hitTypeId) if two or 
> more subsequent requests are made in a sufficiently small interval. This can 
> and *will* be the case for example if an application rapidly issues requests 
> for similar data. It would usually not be observed when human users cause 
> requests being issued.
> The cause is that the above mentioned method uses
> serverHit.create();
> to store the entries.
> A solution to this is to _create or update_ an existing entry, thus 
> overwriting an existing entry in case there already was an entry, but more 
> importantly avoiding the actual transaction being aborted. This may not 
> satisfy those who want to record each and every server hit even with equal 
> startTimes. For these cases other approaches might be considered ...
> This is an example where a transaction fails due to saveHit(...). In our case 
> an applet tries to pull data off the server and fails ...
> {panel}Failure in create operation for entity [ServerHit]: 
> org.ofbiz.entity.GenericEntityException: Error while inserting: 
> [GenericEntity:ServerHit][contentId,gdm.getProductFeatureApplAttrs(java.lang.String)][createdStamp,2009-02-24
>  10:34:29.454(java.sql.Timestamp)][createdTxStamp,2009-02-24 
> 10:34:29.454(java.sql.Timestamp)][hitStartDateTime,2009-02-24 
> 10:34:29.443(java.sql.Timestamp)][hitTypeId,REQUEST(java.lang.String)][lastUpdatedStamp,2009-02-24
>  10:34:29.454(java.sql.Timestamp)][lastUpdatedTxStamp,2009-02-24 
> 10:34:29.454(java.sql.Timestamp)][partyId,KR(java.lang.String)][referrerUrl,(java.lang.String)][requestUrl,https://127.0.0.1:8443/gdm/control/getProductFeatureApplAttrs(java.lang.String)][runningTimeMillis,8(java.lang.Long)][serverHostName,Kitty(java.lang.String)][serverIpAddress,192.168.1.70(java.lang.String)][userLoginId,karim(java.lang.String)][visitId,11900(java.lang.String)]
>  (SQL Exception while executing the following:INSERT INTO SERVER_HIT 
> (VISIT_ID, CONTENT_ID, HIT_START_DATE_TIME, HIT_TYPE_ID, NUM_OF_BYTES, 
> RUNNING_TIME_MILLIS, USER_LOGIN_ID, STATUS_ID, REQUEST_URL, REFERRER_URL, 
> SERVER_IP_ADDRESS, SERVER_HOST_NAME, LAST_UPDATED_STAMP, 
> LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP, INTERNAL_CONTENT_ID, 
> PARTY_ID, ID_BY_IP_CONTACT_MECH_ID, REF_BY_WEB_CONTACT_MECH_ID) VALUES (?, ?, 
> ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) (Duplicate entry 
> '11900-gdm.getProductFeatureApplAttrs-2009-02-24 10:34:29-REQUEST' for key 
> 'PRIMARY')). Rolling back transaction.
> Exception: org.ofbiz.entity.GenericEntityException{panel}
> This issue seems to be related (it refers to the releae branch 4.0 and the 
> same error shows up):
> [https://issues.apache.org/jira/browse/OFBIZ-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (OFBIZ-9537) In case of reqeust redirect context filter override the redirect parameter

[Deepak Dixit (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103077#comment-16103077
 ] 

Deepak Dixit edited comment on OFBIZ-9537 at 7/27/17 11:28 AM:
---

Removed unused and dead code from RequestHandler, as _REQ_ATTR_MAP_ is removed 
from session in ContextFilter so it will always be null while accessing this in 
RequestHandler. 
Thanks Jacopo


was (Author: deepak.dixit):
Removed unused and dead code from RequestHandler, as _REQ_ATTR_MAP_ is removed 
from session in ContextFilter so it will always be null while accessing this in 
RequestHandler. 

> In case of reqeust redirect context filter override the redirect parameter
> --
>
> Key: OFBIZ-9537
> URL: https://issues.apache.org/jira/browse/OFBIZ-9537
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, 16.11.03
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
> Attachments: OFBIZ-9537.patch, OFBIZ-9537.patch
>
>
> In case of request redirect ContextFilter override the redirect parameter
> Like if you use following pattern
> {code}
> 
>   
>   
>   
> 
>   
>   
> 
> {code}
> In this case service creates new workEffort and put the newly created 
> workEffortId in requestAttribute, 
> but in response we are redirecting  parentWorkEffortId as workEffortId,
> so in this case context filter override the workEffortId that passed as 
> redirect parameter, and replace it with newly created workEffortId.
> This is due to restoring all the redirected parameter instead of default one. 
> Need to restore only success/error message so redirected page can display 
> previous request's error msg etc.
> This is handled in RequestHandler.java.
> As in case of request redirect we pass the redirect parameter name so instead 
> of restoring all the previous redirected parameter restore only error/success 
> message related parameter.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OFBIZ-9537) In case of reqeust redirect context filter override the redirect parameter

[Deepak Dixit (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-9537:

Attachment: OFBIZ-9537.patch

Removed unused and dead code from RequestHandler, as _REQ_ATTR_MAP_ is removed 
from session in ContextFilter so it will always be null while accessing this in 
RequestHandler. 

> In case of reqeust redirect context filter override the redirect parameter
> --
>
> Key: OFBIZ-9537
> URL: https://issues.apache.org/jira/browse/OFBIZ-9537
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, 16.11.03
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
> Attachments: OFBIZ-9537.patch, OFBIZ-9537.patch
>
>
> In case of request redirect ContextFilter override the redirect parameter
> Like if you use following pattern
> {code}
> 
>   
>   
>   
> 
>   
>   
> 
> {code}
> In this case service creates new workEffort and put the newly created 
> workEffortId in requestAttribute, 
> but in response we are redirecting  parentWorkEffortId as workEffortId,
> so in this case context filter override the workEffortId that passed as 
> redirect parameter, and replace it with newly created workEffortId.
> This is due to restoring all the redirected parameter instead of default one. 
> Need to restore only success/error message so redirected page can display 
> previous request's error msg etc.
> This is handled in RequestHandler.java.
> As in case of request redirect we pass the redirect parameter name so instead 
> of restoring all the previous redirected parameter restore only error/success 
> message related parameter.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (OFBIZ-9539) [FB] Package org.apache.ofbiz.accounting.thirdparty.paypal

[Kyra Pritzel-Hentley (JIRA)]

Kyra Pritzel-Hentley created OFBIZ-9539:
---

 Summary: [FB] Package org.apache.ofbiz.accounting.thirdparty.paypal
 Key: OFBIZ-9539
 URL: https://issues.apache.org/jira/browse/OFBIZ-9539
 Project: OFBiz
  Issue Type: Sub-task
  Components: accounting
Affects Versions: Trunk
Reporter: Kyra Pritzel-Hentley
Priority: Minor


PayPalEvents.java:236, DM_DEFAULT_ENCODING
* Dm: Found reliance on default encoding in 
org.apache.ofbiz.accounting.thirdparty.paypal.PayPalEvents.payPalIPN(HttpServletRequest,
 HttpServletResponse): new java.io.PrintWriter(OutputStream)
Found a call to a method which will perform a byte to String (or String to 
byte) conversion, and will assume that the default platform encoding is 
suitable. This will cause the application behaviour to vary between platforms. 
Use an alternative API and specify a charset name or Charset object explicitly.

PayPalEvents.java:240, OS_OPEN_STREAM_EXCEPTION_PATH
* OS: 
org.apache.ofbiz.accounting.thirdparty.paypal.PayPalEvents.payPalIPN(HttpServletRequest,
 HttpServletResponse) may fail to close stream on exception
The method creates an IO stream object, does not assign it to any fields, pass 
it to other methods, or return it, and does not appear to close it on all 
possible exception paths out of the method.  This may result in a file 
descriptor leak.  It is generally a good idea to use a finally block to ensure 
that streams are closed.

PayPalEvents.java:240, DM_DEFAULT_ENCODING
* Dm: Found reliance on default encoding in 
org.apache.ofbiz.accounting.thirdparty.paypal.PayPalEvents.payPalIPN(HttpServletRequest,
 HttpServletResponse): new java.io.InputStreamReader(InputStream)
Found a call to a method which will perform a byte to String (or String to 
byte) conversion, and will assume that the default platform encoding is 
suitable. This will cause the application behaviour to vary between platforms. 
Use an alternative API and specify a charset name or Charset object explicitly.

PayPalEvents.java:343, 393 RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT
* Return value of method without side effect is ignored
This code calls a method and ignores the return value. However our analysis 
shows that the method (including its implementations in subclasses if any) does 
not produce any effect other than return value. Thus this call can be removed.

PayPalEvents.java:493, NP_NULL_ON_SOME_PATH
* NP: Possible null pointer dereference of results in 
org.apache.ofbiz.accounting.thirdparty.paypal.PayPalEvents.setPaymentPreference(LocalDispatcher,
 GenericValue, GenericValue, HttpServletRequest)
There is a branch of statement that, if executed, guarantees that a null value 
will be dereferenced, which would generate a NullPointerException when the code 
is executed. Of course, the problem might be that the branch or statement is 
infeasible and that the null pointer exception can't ever be executed; deciding 
that is beyond the ability of FindBugs.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (OFBIZ-9538) User should be notified with success message on adding note for party in party component

[Aditya Sharma (JIRA)]

Aditya Sharma created OFBIZ-9538:


 Summary: User should be notified with success message on adding 
note for party in party component
 Key: OFBIZ-9538
 URL: https://issues.apache.org/jira/browse/OFBIZ-9538
 Project: OFBiz
  Issue Type: Sub-task
  Components: party
Affects Versions: Trunk
Reporter: Aditya Sharma
Priority: Trivial


Steps to regenerate:
1. Go to Party component 
(https://demo-trunk.ofbiz.apache.org/partymgr/control/main)
2. Apply filters and search party.
3. Click on Party Id link 
(https://demo-trunk.ofbiz.apache.org/partymgr/control/viewprofile?partyId=DemoCustomer)
4. Click on Create new link from Notes section 
(https://demo-trunk.ofbiz.apache.org/partymgr/control/AddPartyNote?partyId=DemoCustomer)
5. Fill the required field & click on Save button
On success, the user should be notified with success message.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OFBIZ-9492) Tax Authorities need two GL accounts for sales and purchases

[Deepak Nigam (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-9492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103008#comment-16103008
 ] 

Deepak Nigam commented on OFBIZ-9492:
-

Hi [~paul_foxworthy],

I think we can go for using AcctgTransType. I can help you in testing this 
feature, once the patch is available. 

> Tax Authorities need two GL accounts for sales and purchases
> 
>
> Key: OFBIZ-9492
> URL: https://issues.apache.org/jira/browse/OFBIZ-9492
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Paul Foxworthy
>Assignee: Paul Foxworthy
>  Labels: accounting, vat
>
> In jurisdictions with Value Added Tax, you need to track tax you have paid on 
> purchases, and tax you have collected with sales. When you report to a tax 
> authority, you pay them the difference between the two, i.e. you pay tax on 
> the value added, not on your inputs.
> OFBiz has an entity, TaxAuthorityGlAccount (TAGLA), which currently assumes 
> the GL account is for a sale.
> We need to extend OFBiz so it is possible to find two GL accounts for a tax 
> authority, one for sales and one for purchases.
> I propose:
> - Define a new Enumeration for the direction of a transaction. I suggest
> calling the Enumeration TAGLADIR, with two values TAGLADIR_INCOMING
> and TAGLADIR_OUTGOING.
> We could reuse an existing indication of the direction of a transaction,
> for example the GlAccountClassIds INCOME and EXPENSE. However, when we receive
> income from a sale, we would incur a tax *liability*, and the GL account for 
> that
> would be a liability account. So I think it would be less confusing to have a
> separate enum here that's just for TAGLA.
> - add a new attribute to the TaxAuthorityGlAccount entity for the direction 
> of the transaction.
> The new attribute should be included in the primary key.
> - Add a new service in TaxAuthorityServices named getTaxAuthorityGlAccountId 
> which
> looks up a TAGLA given primary key values, including the direction
> - There are two places in TaxAuthorityServices that would call 
> getTaxAuthorityGlAccountId: getTaxAdjustments and getItemTaxAdjustments, one 
> for orders, and the other for invoice item types. The direction can be 
> inferred from the order type or the invoice item type
> - createAcctgTransForPurchaseInvoice and 
> createAcctgTransForCustomerReturnInvoice
> should use getTaxAuthorityGlAccountId
> - createAcctgTransactionForSalesInvoice should be rewritten to use 
> getTaxAuthorityGlAccountId.
> I am working on a patch to do this, but I'd like your thoughts on my proposal



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OFBIZ-6330) The invoiceTaxTotal value is missing from createAcctgTransForPurchaseInvoice service

[Moatasim Al Masri (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Moatasim Al Masri updated OFBIZ-6330:
-
Attachment: pic01.PNG
pic02.png

Dears 
kindly find attached two images screens that discussed the total debit & credit 
issue


> The invoiceTaxTotal value is missing from createAcctgTransForPurchaseInvoice 
> service
> 
>
> Key: OFBIZ-6330
> URL: https://issues.apache.org/jira/browse/OFBIZ-6330
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Paul Foxworthy
>  Labels: tax, vat
> Attachments: GeneralLedgerServices.patch, 
> OFBIZ-6330_TaxAccountingOnPurchasesAndReturns-alternative.patch, 
> OFBIZ-6330_TaxAccountingOnPurchasesAndReturns_inline.patch, 
> OFBIZ-6330_TaxAccountingOnPurchasesAndReturns.patch, 
> OFBIZ-6330_TaxAccountingOnPurchasesAndReturns.patch, pic01.PNG, pic02.png
>
>
> Hi All,
> Scenario: The sum of debit and credit in InvoiceAcctgTransEntriesPdf of 
> purchase invoice are not equal.
> Question: I'm not sure why the createAcctgTransForPurchaseInvoice service did 
> not call the method to get invoiceTaxTotal.
> {code}
>  class-name="org.ofbiz.accounting.invoice.InvoiceWorker" 
> ret-field="invoiceTaxTotal">
> 
> 
> {code}
> And the invoiceTaxTotal value needs to add to totalAmountFromInvoice via code 
> below:
> {code}
>  decimal-scale="${ledgerDecimals}" rounding-mode="${roundingMode}">
> 
> 
> 
> 
> 
> {code}
> That it should work like the createAcctgTransForSalesInvoice service of the 
> sales invoice.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OFBIZ-9537) In case of reqeust redirect context filter override the redirect parameter

[Deepak Dixit (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-9537:

Attachment: OFBIZ-9537.patch

Here is the patch for this issue. 

> In case of reqeust redirect context filter override the redirect parameter
> --
>
> Key: OFBIZ-9537
> URL: https://issues.apache.org/jira/browse/OFBIZ-9537
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, 16.11.03
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
> Attachments: OFBIZ-9537.patch
>
>
> In case of request redirect ContextFilter override the redirect parameter
> Like if you use following pattern
> {code}
> 
>   
>   
>   
> 
>   
>   
> 
> {code}
> In this case service creates new workEffort and put the newly created 
> workEffortId in requestAttribute, 
> but in response we are redirecting  parentWorkEffortId as workEffortId,
> so in this case context filter override the workEffortId that passed as 
> redirect parameter, and replace it with newly created workEffortId.
> This is due to restoring all the redirected parameter instead of default one. 
> Need to restore only success/error message so redirected page can display 
> previous request's error msg etc.
> This is handled in RequestHandler.java.
> As in case of request redirect we pass the redirect parameter name so instead 
> of restoring all the previous redirected parameter restore only error/success 
> message related parameter.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (OFBIZ-9537) In case of reqeust redirect context filter override the redirect parameter

[Deepak Dixit (JIRA)]

Deepak Dixit created OFBIZ-9537:
---

 Summary: In case of reqeust redirect context filter override the 
redirect parameter
 Key: OFBIZ-9537
 URL: https://issues.apache.org/jira/browse/OFBIZ-9537
 Project: OFBiz
  Issue Type: Bug
Affects Versions: 16.11.03, Trunk
Reporter: Deepak Dixit
Assignee: Deepak Dixit


In case of request redirect ContextFilter override the redirect parameter
Like if you use following pattern
{code}

  
  
  

  
  

{code}
In this case service creates new workEffort and put the newly created 
workEffortId in requestAttribute, 
but in response we are redirecting  parentWorkEffortId as workEffortId,
so in this case context filter override the workEffortId that passed as 
redirect parameter, and replace it with newly created workEffortId.


This is due to restoring all the redirected parameter instead of default one. 
Need to restore only success/error message so redirected page can display 
previous request's error msg etc.
This is handled in RequestHandler.java.

As in case of request redirect we pass the redirect parameter name so instead 
of restoring all the previous redirected parameter restore only error/success 
message related parameter.







--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OFBIZ-7711) Label not showing properly on 'Add EFT Account' screen of scrum

[Jacques Le Roux (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102786#comment-16102786
 ] 

Jacques Le Roux commented on OFBIZ-7711:


Thanks Pranay,

It's the right thing to do. We already do that in many places. A dependency 
from Scrum to Party is not an issue but the way things should be normally done.

> Label not showing properly on 'Add EFT Account' screen of scrum
> ---
>
> Key: OFBIZ-7711
> URL: https://issues.apache.org/jira/browse/OFBIZ-7711
> Project: OFBiz
>  Issue Type: Improvement
>  Components: scrum
>Affects Versions: Trunk
>Reporter: Chandan Khandelwal
>Assignee: Pranay Pandey
>Priority: Trivial
> Attachments: OFBIZ-7711-Add-New-Check-Account.png, 
> OFBIZ-7711-Add-New-Credit-Card.png, 
> OFBIZ-7711-Add-New-EFT-Account-Scrum-Profile-View.png, OFBIZ-7711.patch, 
> OFBIZ-7711-Payment-Method-Block-Scrum-Profile-View.png
>
>
> Accounting Uilabel resource not added in scrum main decorator.
> URL : 
> https://localhost:8443/scrum/control/editeftaccount?partyId=DemoScrumCompany



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)