[jira] [Closed] (OFBIZ-10247) Resolve address from InvoiceWorker not respect the invoice date
[
https://issues.apache.org/jira/browse/OFBIZ-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin closed OFBIZ-10247.
-
Resolution: Duplicate
> Resolve address from InvoiceWorker not respect the invoice date
>
>
> Key: OFBIZ-10247
> URL: https://issues.apache.org/jira/browse/OFBIZ-10247
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Priority: Major
>
> When you edit an invoice pdf, the different addresses are resolved by the
> InvoiceWorker with the method getInvoiceAddressByType.
> {code:java}
> public static GenericValue getInvoiceAddressByType(GenericValue invoice,
> String contactMechPurposeTypeId, boolean fetchPartyAddress) {{code}
> This method check first on the InvoiceContactMech table and if no address
> found, check directly on the party with a filter date to now.
> {code:java}
> try {
> locations = invoice.getRelated("InvoiceContactMech",
> UtilMisc.toMap("contactMechPurposeTypeId", contactMechPurposeTypeId), null,
> false);
> } catch (GenericEntityException e) {
> Debug.logError("Touble getting InvoiceContactMech entity list", module);
> }
> if (UtilValidate.isEmpty(locations) && fetchPartyAddress) {
> // if no locations found get it from the PartyAndContactMech using the from
> and to party on the invoice
> ...
> locations = EntityUtil.filterByDate(locations, date, "contactFromDate",
> "contactThruDate", true);
> {code}
> If you edit the invoice pdf one year after, addresses present on it can be
> change because the invoice date isn't use to resolve validate address related.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10248) Resolve address from InvoiceWorker not respect the invoice date
[
https://issues.apache.org/jira/browse/OFBIZ-10248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin updated OFBIZ-10248:
--
Attachment: OFBIZ-10248.patch
> Resolve address from InvoiceWorker not respect the invoice date
>
>
> Key: OFBIZ-10248
> URL: https://issues.apache.org/jira/browse/OFBIZ-10248
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Priority: Major
> Attachments: OFBIZ-10248.patch
>
>
> When you edit an invoice pdf, the different addresses are resolved by the
> InvoiceWorker with the method getInvoiceAddressByType.
> {code:java}
> public static GenericValue getInvoiceAddressByType(GenericValue invoice,
> String contactMechPurposeTypeId, boolean fetchPartyAddress) {{code}
> This method check first on the InvoiceContactMech table and if no address
> found, check directly on the party with a filter date to now.
> {code:java}
> try {
> locations = invoice.getRelated("InvoiceContactMech",
> UtilMisc.toMap("contactMechPurposeTypeId", contactMechPurposeTypeId), null,
> false);
> } catch (GenericEntityException e) {
> Debug.logError("Touble getting InvoiceContactMech entity list", module);
> }
> if (UtilValidate.isEmpty(locations) && fetchPartyAddress) {
> // if no locations found get it from the PartyAndContactMech using the from
> and to party on the invoice
> ...
> locations = EntityUtil.filterByDate(locations, date, "contactFromDate",
> "contactThruDate", true);
> {code}
> If you edit the invoice pdf one year after, addresses present on it can be
> change because the invoice date isn't use to resolve validate address related.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10248) Resolve address from InvoiceWorker not respect the invoice date
Nicolas Malin created OFBIZ-10248:
-
Summary: Resolve address from InvoiceWorker not respect the
invoice date
Key: OFBIZ-10248
URL: https://issues.apache.org/jira/browse/OFBIZ-10248
Project: OFBiz
Issue Type: Bug
Components: accounting
Affects Versions: Trunk
Reporter: Nicolas Malin
When you edit an invoice pdf, the different addresses are resolved by the
InvoiceWorker with the method getInvoiceAddressByType.
{code:java}
public static GenericValue getInvoiceAddressByType(GenericValue invoice, String
contactMechPurposeTypeId, boolean fetchPartyAddress) {{code}
This method check first on the InvoiceContactMech table and if no address
found, check directly on the party with a filter date to now.
{code:java}
try {
locations = invoice.getRelated("InvoiceContactMech",
UtilMisc.toMap("contactMechPurposeTypeId", contactMechPurposeTypeId), null,
false);
} catch (GenericEntityException e) {
Debug.logError("Touble getting InvoiceContactMech entity list", module);
}
if (UtilValidate.isEmpty(locations) && fetchPartyAddress) {
// if no locations found get it from the PartyAndContactMech using the from and
to party on the invoice
...
locations = EntityUtil.filterByDate(locations, date, "contactFromDate",
"contactThruDate", true);
{code}
If you edit the invoice pdf one year after, addresses present on it can be
change because the invoice date isn't use to resolve validate address related.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10247) Resolve address from InvoiceWorker not respect the invoice date
Nicolas Malin created OFBIZ-10247:
-
Summary: Resolve address from InvoiceWorker not respect the
invoice date
Key: OFBIZ-10247
URL: https://issues.apache.org/jira/browse/OFBIZ-10247
Project: OFBiz
Issue Type: Bug
Components: accounting
Affects Versions: Trunk
Reporter: Nicolas Malin
When you edit an invoice pdf, the different addresses are resolved by the
InvoiceWorker with the method getInvoiceAddressByType.
{code:java}
public static GenericValue getInvoiceAddressByType(GenericValue invoice, String
contactMechPurposeTypeId, boolean fetchPartyAddress) {{code}
This method check first on the InvoiceContactMech table and if no address
found, check directly on the party with a filter date to now.
{code:java}
try {
locations = invoice.getRelated("InvoiceContactMech",
UtilMisc.toMap("contactMechPurposeTypeId", contactMechPurposeTypeId), null,
false);
} catch (GenericEntityException e) {
Debug.logError("Touble getting InvoiceContactMech entity list", module);
}
if (UtilValidate.isEmpty(locations) && fetchPartyAddress) {
// if no locations found get it from the PartyAndContactMech using the from and
to party on the invoice
...
locations = EntityUtil.filterByDate(locations, date, "contactFromDate",
"contactThruDate", true);
{code}
If you edit the invoice pdf one year after, addresses present on it can be
change because the invoice date isn't use to resolve validate address related.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10031) Convert CategoryServices.xml mini lang to groovy
[
https://issues.apache.org/jira/browse/OFBIZ-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380300#comment-16380300
]
Dennis Balkir commented on OFBIZ-10031:
---
I tested this one better, this works now.
The problem was, that the value {{newEntity}} was made with the {{parameters}}
map, which resulted in a value, which didn't had the sequenced id, that I tried
to fix.
But after removing the map, everything works just fine
> Convert CategoryServices.xml mini lang to groovy
>
>
> Key: OFBIZ-10031
> URL: https://issues.apache.org/jira/browse/OFBIZ-10031
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: CategoryServices.patch,
> OFBIZ-10031_org.apache.ofbiz.product.category.CategoryServices_convert.patch,
> OFBIZ-10031_org.apache.ofbiz.product.category.CategoryServices_convert.patch
>
>
> Migration of the CategoryServices.xml to Groovy
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10031) Convert CategoryServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Balkir updated OFBIZ-10031: -- Attachment: CategoryServices.patch > Convert CategoryServices.xml mini lang to groovy > > > Key: OFBIZ-10031 > URL: https://issues.apache.org/jira/browse/OFBIZ-10031 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Nicolas Malin >Priority: Minor > Attachments: CategoryServices.patch, > OFBIZ-10031_org.apache.ofbiz.product.category.CategoryServices_convert.patch, > OFBIZ-10031_org.apache.ofbiz.product.category.CategoryServices_convert.patch > > > Migration of the CategoryServices.xml to Groovy -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10031) Convert CategoryServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380166#comment-16380166 ] Dennis Balkir commented on OFBIZ-10031: --- I made some additional testing, and found out, that my patch seem to only partially fix the problem. I will provide a finished version asap though > Convert CategoryServices.xml mini lang to groovy > > > Key: OFBIZ-10031 > URL: https://issues.apache.org/jira/browse/OFBIZ-10031 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Nicolas Malin >Priority: Minor > Attachments: > OFBIZ-10031_org.apache.ofbiz.product.category.CategoryServices_convert.patch, > OFBIZ-10031_org.apache.ofbiz.product.category.CategoryServices_convert.patch > > > Migration of the CategoryServices.xml to Groovy -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10031) Convert CategoryServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Balkir updated OFBIZ-10031: -- Attachment: (was: CategoryServices.patch) > Convert CategoryServices.xml mini lang to groovy > > > Key: OFBIZ-10031 > URL: https://issues.apache.org/jira/browse/OFBIZ-10031 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Nicolas Malin >Priority: Minor > Attachments: > OFBIZ-10031_org.apache.ofbiz.product.category.CategoryServices_convert.patch, > OFBIZ-10031_org.apache.ofbiz.product.category.CategoryServices_convert.patch > > > Migration of the CategoryServices.xml to Groovy -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-7738) OFBIZ-7471: Improve all the service level error messages for missing required field for workeffort component
[ https://issues.apache.org/jira/browse/OFBIZ-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379975#comment-16379975 ] Michael Brohl edited comment on OFBIZ-7738 at 2/28/18 9:32 AM: --- Committed changes at revision 1825537 Thanks [~Dennis Balkir] for reporting and Dhaval Wagela for providing patch. was (Author: arunpati): Committed changes at revision 1825537 Thanks [~bartlett.dc.1] for reporting and Dhaval Wagela for providing patch. > OFBIZ-7471: Improve all the service level error messages for missing required > field for workeffort component > > > Key: OFBIZ-7738 > URL: https://issues.apache.org/jira/browse/OFBIZ-7738 > Project: OFBiz > Issue Type: Sub-task > Components: workeffort >Affects Versions: 16.11.01 >Reporter: Ratnesh Upadhyay >Assignee: Arun Patidar >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-7738.patch, OFBIZ-7738.patch, OFBIZ-7738.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7738) OFBIZ-7471: Improve all the service level error messages for missing required field for workeffort component
[ https://issues.apache.org/jira/browse/OFBIZ-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379975#comment-16379975 ] Arun Patidar commented on OFBIZ-7738: - Committed changes at revision 1825537 Thanks [~bartlett.dc.1] for reporting and Dhaval Wagela for providing patch. > OFBIZ-7471: Improve all the service level error messages for missing required > field for workeffort component > > > Key: OFBIZ-7738 > URL: https://issues.apache.org/jira/browse/OFBIZ-7738 > Project: OFBiz > Issue Type: Sub-task > Components: workeffort >Affects Versions: 16.11.01 >Reporter: Ratnesh Upadhyay >Assignee: Arun Patidar >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-7738.patch, OFBIZ-7738.patch, OFBIZ-7738.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
