[jira] [Commented] (OFBIZ-10008) Add mechanism to prevent the usage of EntitySyncRemove
[ https://issues.apache.org/jira/browse/OFBIZ-10008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438793#comment-16438793 ] Jacques Le Roux commented on OFBIZ-10008: - Here is a patch, I did not commit because, though I don't think it's needed, I wondered if we should handle it at the tenant level. Of course it would then need a bigger effort. Also I wondered if the test/filter should be part of saveEntitySyncRemoveInfo() (comment "don't store remove info on entities where it is disabled") but it would be diluted and is more appropriate at a higher level. I'm currently (slowly) working on 2 related aspects: "Separate System and Business properties" (new thread to come on dev ML) and refactoring (actually rewriting) the EntitySync documentation. And this slows things. For instance if we want to have this per tenant EntityUtilProperties should be used instead of UtilProperties, but there is no getPropertyAsBoolean() in EntityUtilProperties. > Add mechanism to prevent the usage of EntitySyncRemove > -- > > Key: OFBIZ-10008 > URL: https://issues.apache.org/jira/browse/OFBIZ-10008 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Chandan Khandelwal >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-10008.patch > > > No configurations available to disable usage of EntitySyncRemove. And It is > creating problems when having a large database and frequent delete operations. > saveEntitySyncRemoveInfo is used to create EntitySyncRemove records in > GenericDelegator.removeValue() and removeByPrimaryKey(). > Idea is to add mechanism to prevent the usage of EntitySyncRemove by adding > configuration in entityengine.xml. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10337) Check for only QOH while doing reservations
[ https://issues.apache.org/jira/browse/OFBIZ-10337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438629#comment-16438629 ] Jacques Le Roux commented on OFBIZ-10337: - While at it, I found Swapnil's message interesting and Rishi's related one promising. Should we not create a Jira for that, in order to not forget the idea? > Check for only QOH while doing reservations > --- > > Key: OFBIZ-10337 > URL: https://issues.apache.org/jira/browse/OFBIZ-10337 > Project: OFBiz > Issue Type: Improvement >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-10337.patch > > > While checking around code around inventory reservations, I was surprised to > see that _*reserveProductInventory*_ service only checks for QOH quantity > greater than one apart from that when _*reserveFromInventoryItemInline*_ is > called, it checks for ATP confirming system to behave as required. > Everything works fine but this is redundant code and we can have check for > ATP at top level so make reservations logic works faster. We can improve this > flow by adding ATP check at _*reserveProductInventory*_ service as well. > We can check QOH being on safer side, but ideally a system will always have > lesser ATP than QOH and logically we should only check for ATP while doing > reservations. > Same discussion is also available on dev ML. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10337) Check for only QOH while doing reservations
[ https://issues.apache.org/jira/browse/OFBIZ-10337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438614#comment-16438614 ] Jacques Le Roux commented on OFBIZ-10337: - Hi Suraj, You say bq. reserveProductInventory service only checks for QOH quantity greater than one When I look at the code I see rather that it checks for QOH quantity greater than 0. > Check for only QOH while doing reservations > --- > > Key: OFBIZ-10337 > URL: https://issues.apache.org/jira/browse/OFBIZ-10337 > Project: OFBiz > Issue Type: Improvement >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-10337.patch > > > While checking around code around inventory reservations, I was surprised to > see that _*reserveProductInventory*_ service only checks for QOH quantity > greater than one apart from that when _*reserveFromInventoryItemInline*_ is > called, it checks for ATP confirming system to behave as required. > Everything works fine but this is redundant code and we can have check for > ATP at top level so make reservations logic works faster. We can improve this > flow by adding ATP check at _*reserveProductInventory*_ service as well. > We can check QOH being on safer side, but ideally a system will always have > lesser ATP than QOH and logically we should only check for ATP while doing > reservations. > Same discussion is also available on dev ML. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
