[jira] [Created] (OFBIZ-10677) Standalone Asciidoc plugins documents can't render logo correctly in PDF
Jacques Le Roux created OFBIZ-10677: --- Summary: Standalone Asciidoc plugins documents can't render logo correctly in PDF Key: OFBIZ-10677 URL: https://issues.apache.org/jira/browse/OFBIZ-10677 Project: OFBiz Issue Type: Bug Components: ALL PLUGINS Affects Versions: Trunk, Release Branch 17.12 Reporter: Jacques Le Roux Asciidoc plugins documents should be standalone as described in [Documentation guidelines|https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk/docs/asciidoc/documentation_guidelines.adoc]. When rendering in PDF we should use the {{docs/asciidoc/images/OFBiz-Logo.svg}} file to avoid duplication. For a reason, maybe related to [https://github.com/asciidoctor/asciidoctor-epub3/issues/22], it seems there is a conflict between declaring {code} :imagesdir: ./images {code} and {code} ifdef::backend-pdf[] :title-logo-image: ../../../../../docs/asciidoc/images/OFBiz-Logo.svg[Apache OFBiz Logo, pdfwidth=4.25in, align=center] :source-highlighter: rouge endif::[] {code} in the same file. You then get {code} [] | ../../../../../docs/asciidoc/images/OFBiz-Logo.svg[Apache OFBiz Logo, pdfwidth=4.25in, align=center] {code} instead of the logo in the 1st page of the document. So it seems it's not an OFBiz bug but rather a Asciidoctor issue. Not sure yet, so I create this Jira more as a reminder. For now I'll not put logos in plugins standalone files. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10677) Standalone Asciidoc plugins documents can't render logo correctly in PDF
[ https://issues.apache.org/jira/browse/OFBIZ-10677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-10677: Description: Asciidoc plugins documents should be standalone as described in [Documentation guidelines|https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk/docs/asciidoc/documentation_guidelines.adoc]. When rendering in PDF we should use the {{docs/asciidoc/images/OFBiz-Logo.svg}} file to avoid duplication. For a reason, maybe related to [https://github.com/asciidoctor/asciidoctor-epub3/issues/22], it seems there is a conflict between declaring {code} :imagesdir: ./images {code} and {code} ifdef::backend-pdf[] :title-logo-image: ../../../../../docs/asciidoc/images/OFBiz-Logo.svg[Apache OFBiz Logo, pdfwidth=4.25in, align=center] :source-highlighter: rouge endif::[] {code} in the same file. You then get {code} [] | ../../../../../docs/asciidoc/images/OFBiz-Logo.svg[Apache OFBiz Logo, pdfwidth=4.25in, align=center] {code} instead of the logo in the 1st page of the PDF document. So it seems it's not an OFBiz bug but rather a Asciidoctor issue. Not sure yet, so I create this Jira more as a reminder. For now I'll not put logos in plugins standalone files. was: Asciidoc plugins documents should be standalone as described in [Documentation guidelines|https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk/docs/asciidoc/documentation_guidelines.adoc]. When rendering in PDF we should use the {{docs/asciidoc/images/OFBiz-Logo.svg}} file to avoid duplication. For a reason, maybe related to [https://github.com/asciidoctor/asciidoctor-epub3/issues/22], it seems there is a conflict between declaring {code} :imagesdir: ./images {code} and {code} ifdef::backend-pdf[] :title-logo-image: ../../../../../docs/asciidoc/images/OFBiz-Logo.svg[Apache OFBiz Logo, pdfwidth=4.25in, align=center] :source-highlighter: rouge endif::[] {code} in the same file. You then get {code} [] | ../../../../../docs/asciidoc/images/OFBiz-Logo.svg[Apache OFBiz Logo, pdfwidth=4.25in, align=center] {code} instead of the logo in the 1st page of the document. So it seems it's not an OFBiz bug but rather a Asciidoctor issue. Not sure yet, so I create this Jira more as a reminder. For now I'll not put logos in plugins standalone files. > Standalone Asciidoc plugins documents can't render logo correctly in PDF > > > Key: OFBIZ-10677 > URL: https://issues.apache.org/jira/browse/OFBIZ-10677 > Project: OFBiz > Issue Type: Bug > Components: ALL PLUGINS >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Jacques Le Roux >Priority: Minor > > Asciidoc plugins documents should be standalone as described in > [Documentation > guidelines|https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk/docs/asciidoc/documentation_guidelines.adoc]. > When rendering in PDF we should use the > {{docs/asciidoc/images/OFBiz-Logo.svg}} file to avoid duplication. For a > reason, maybe related to > [https://github.com/asciidoctor/asciidoctor-epub3/issues/22], it seems there > is a conflict between declaring > {code} > :imagesdir: ./images > {code} > and > {code} > ifdef::backend-pdf[] > :title-logo-image: ../../../../../docs/asciidoc/images/OFBiz-Logo.svg[Apache > OFBiz Logo, pdfwidth=4.25in, align=center] > :source-highlighter: rouge > endif::[] > {code} > in the same file. > You then get > {code} > [] | ../../../../../docs/asciidoc/images/OFBiz-Logo.svg[Apache OFBiz Logo, > pdfwidth=4.25in, align=center] > {code} > instead of the logo in the 1st page of the PDF document. > So it seems it's not an OFBiz bug but rather a Asciidoctor issue. Not sure > yet, so I create this Jira more as a reminder. > For now I'll not put logos in plugins standalone files. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10677) Standalone Asciidoc plugins documents can't render logo correctly in PDF
[ https://issues.apache.org/jira/browse/OFBIZ-10677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701571#comment-16701571 ] Jacques Le Roux commented on OFBIZ-10677: - I think there are several solutions to this problem. I'll have a look again soon... > Standalone Asciidoc plugins documents can't render logo correctly in PDF > > > Key: OFBIZ-10677 > URL: https://issues.apache.org/jira/browse/OFBIZ-10677 > Project: OFBiz > Issue Type: Bug > Components: ALL PLUGINS >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Jacques Le Roux >Priority: Minor > > Asciidoc plugins documents should be standalone as described in > [Documentation > guidelines|https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk/docs/asciidoc/documentation_guidelines.adoc]. > When rendering in PDF we should use the > {{docs/asciidoc/images/OFBiz-Logo.svg}} file to avoid duplication. For a > reason, maybe related to > [https://github.com/asciidoctor/asciidoctor-epub3/issues/22], it seems there > is a conflict between declaring > {code} > :imagesdir: ./images > {code} > and > {code} > ifdef::backend-pdf[] > :title-logo-image: ../../../../../docs/asciidoc/images/OFBiz-Logo.svg[Apache > OFBiz Logo, pdfwidth=4.25in, align=center] > :source-highlighter: rouge > endif::[] > {code} > in the same file. > You then get > {code} > [] | ../../../../../docs/asciidoc/images/OFBiz-Logo.svg[Apache OFBiz Logo, > pdfwidth=4.25in, align=center] > {code} > instead of the logo in the 1st page of the PDF document. > So it seems it's not an OFBiz bug but rather a Asciidoctor issue. Not sure > yet, so I create this Jira more as a reminder. > For now I'll not put logos in plugins standalone files. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10677) Standalone Asciidoc plugins documents can't render logo correctly in PDF
[ https://issues.apache.org/jira/browse/OFBIZ-10677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-10677: --- Assignee: Jacques Le Roux > Standalone Asciidoc plugins documents can't render logo correctly in PDF > > > Key: OFBIZ-10677 > URL: https://issues.apache.org/jira/browse/OFBIZ-10677 > Project: OFBiz > Issue Type: Bug > Components: ALL PLUGINS >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > > Asciidoc plugins documents should be standalone as described in > [Documentation > guidelines|https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk/docs/asciidoc/documentation_guidelines.adoc]. > When rendering in PDF we should use the > {{docs/asciidoc/images/OFBiz-Logo.svg}} file to avoid duplication. For a > reason, maybe related to > [https://github.com/asciidoctor/asciidoctor-epub3/issues/22], it seems there > is a conflict between declaring > {code} > :imagesdir: ./images > {code} > and > {code} > ifdef::backend-pdf[] > :title-logo-image: ../../../../../docs/asciidoc/images/OFBiz-Logo.svg[Apache > OFBiz Logo, pdfwidth=4.25in, align=center] > :source-highlighter: rouge > endif::[] > {code} > in the same file. > You then get > {code} > [] | ../../../../../docs/asciidoc/images/OFBiz-Logo.svg[Apache OFBiz Logo, > pdfwidth=4.25in, align=center] > {code} > instead of the logo in the 1st page of the PDF document. > So it seems it's not an OFBiz bug but rather a Asciidoctor issue. Not sure > yet, so I create this Jira more as a reminder. > For now I'll not put logos in plugins standalone files. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10678) CLONE - Check embedded Javascript libs vulnerabilities using retire.js
[ https://issues.apache.org/jira/browse/OFBIZ-10678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-10678: Affects Version/s: Release Branch 17.12 Release Branch 16.11 Fix Version/s: (was: 17.12.01) Description: 3 years ago I created the page https://cwiki.apache.org/confluence/display/OFBIZ/About+retire.js After OFBIZ-9269 (done 1 year ago) that I cloned here, I just checked and here are the results: h3. Trunk {code} C:\projectsASF\ofbiz\plugins\ecommerce\webapp\ecommerce\js\bootstrap.bundle.min.js ? bootstrap 4.0.0-beta.2 has known vulnerabilities: severity: medium; issue: 20184, summary: XSS in data-target property of scrollspy, CVE: CVE-2018-14041; https://github.com/twbs/bootstrap/issues/20184 severity: medium; issue: 20184, s ummary: XSS in collapse data-parent attribute, CVE: CVE-2018-14040; https://github.com/twbs/bootstrap/issues/20184 severity: medium; issue: 20184, summary: XSS in data-container property of tooltip, CVE: CVE-2018-14042; https://github.co m/twbs/bootstrap/issues/20184 C:\projectsASF\ofbiz\plugins\ecommerce\webapp\ecommerce\js\bootstrap.min.js ? bootstrap 4.0.0 has known vulnerabilities: severity: medium; issue: 20184, summary: XSS in data-target property of scrollspy, CVE: CVE-2018-14041; https://github.com/twbs/bootstrap/issues/20184 severity: medium; issue: 20184, summary: XSS in collapse data-parent attribute, CVE: CVE-2018-14040; https://github.com/twbs/bootstrap/issues/20184 severity: medium; issue: 20184, summary: XSS in data-container property of tooltip, CVE: CVE-2018-14042; https://github.com/twbs/ bootstrap/issues/20184 C:\projectsASF\ofbiz\plugins\solr\webapp\solr\js\require.js ? jquery 1.7.1 has known vulnerabilities: severity: medium; CVE: CVE-2012-6708, bug: 11290, summary: Selector interpreted as HTML; http://bugs.jquery.com/ticket/11290 https://nvd.nist.gov/vuln/detail/CVE-2012-6708 http://research.insecu relabs.org/jquery/test/ severity: medium; issue: 2432, summary: 3rd party CORS request may execute, CVE: CVE-2015-9251; https://github.com/jquery/jquery/issues/2432 http://blog.jquery.com/2016/01/08/jquery-2-2-and-1-12-released/ https:// nvd.nist.gov/vuln/detail/CVE-2015-9251 http://research.insecurelabs.org/jquery/test/ C:\projectsASF\ofbiz\plugins\solr\webapp\solr\libs\angular.js ? angularjs 1.3.8 has known vulnerabilities: severity: medium; summary: The attribute usemap can be used as a security exploit; https://github.com/angular/angular.js/blob/master/CHANGELOG.md#1230-patronal-resurrection-2016-07-21 severit y: medium; summary: Universal CSP bypass via add-on in Firefox; https://github.com/mozilla/addons-linter/issues/1000#issuecomment-282083435 http://pastebin.com/raw/kGrdaypP severity: medium; summary: DOS in $sanitize; https://github.com/ angular/angular.js/blob/master/CHANGELOG.md severity: low; summary: XSS in $sanitize in Safari/Firefox; https://github.com/angular/angular.js/commit/8f31f1ff43b673a24f84422d5c13d6312b2c4d94 C:\projectsASF\ofbiz\plugins\solr\webapp\solr\libs\angular.min.js ? angularjs 1.3.8 has known vulnerabilities: severity: medium; summary: The attribute usemap can be used as a security exploit; https://github.com/angular/angular.js/blob/master/CHANGELOG.md#1230-patronal-resurrection-2016-07-21 severit y: medium; summary: Universal CSP bypass via add-on in Firefox; https://github.com/mozilla/addons-linter/issues/1000#issuecomment-282083435 http://pastebin.com/raw/kGrdaypP severity: medium; summary: DOS in $sanitize; https://github.com/ angular/angular.js/blob/master/CHANGELOG.md severity: low; summary: XSS in $sanitize in Safari/Firefox; https://github.com/angular/angular.js/commit/8f31f1ff43b673a24f84422d5c13d6312b2c4d94 C:\projectsASF\ofbiz\plugins\solr\webapp\solr\libs\jquery-2.1.3.min.js ? jquery 2.1.3.min has known vulnerabilities: severity: medium; issue: 2432, summary: 3rd party CORS request may execute, CVE: CVE-2015-9251; https://github.com/jquery/jquery/issues/2432 http://blog.jquery.com/2016/01/08/jquery-2-2-and- 1-12-released/ https://nvd.nist.gov/vuln/detail/CVE-2015-9251 http://research.insecurelabs.org/jquery/test/ severity: medium; CVE: CVE-2015-9251, issue: 11974, summary: parseHTML() executes scripts in event handlers; https://bugs.jquery. com/ticket/11974 https://nvd.nist.gov/vuln/detail/CVE-2015-9251 http://research.insecurelabs.org/jquery/test/ C:\projectsASF\ofbiz\plugins\solr\webapp\solr\js\lib\jquery-1.7.2.min.js ? jquery 1.7.2.min has known vulnerabilities: severity: medium; CVE: CVE-2012-6708, bug: 11290, summary: Selector interpreted as HTML; http://bugs.jquery.com/ticket/11290 https://nvd.nist.gov/vuln/detail/CVE-2012-6708 http://research.in securelabs.org/jquery/test/ severity: medium; issue: 2432, summary: 3rd party CORS request may execute, CVE: CVE-2015-9251;
[jira] [Created] (OFBIZ-10678) CLONE - Check embedded Javascript libs vulnerabilities using retire.js
Jacques Le Roux created OFBIZ-10678: --- Summary: CLONE - Check embedded Javascript libs vulnerabilities using retire.js Key: OFBIZ-10678 URL: https://issues.apache.org/jira/browse/OFBIZ-10678 Project: OFBiz Issue Type: Sub-task Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux Fix For: 17.12.01 1+ years ago I created the page https://cwiki.apache.org/confluence/display/OFBIZ/About+retire.js I just checked again and here are the results {code} C:\projectsASF\ofbiz-framework\framework\images\webapp\images\jquery\jquery-1.11.0.js ? jquery 1.11.0 has known vulnerabilities: severity: medium; issue: 2432, summary: 3rd party CORS request may execute; https://github.com/jquery/jquery/issues/2432 http://blog.jquery.com/2016/01/08/jquery-2-2-and-1-12-released/ C:\projectsASF\ofbiz-framework\framework\images\webapp\images\jquery\jquery-migrate-1.2.1.js ? jquery-migrate 1.2.1 has known vulnerabilities: severity: medium; bug: 11290, summary: Selector interpreted as HTML; http://bugs.jquery.com/ticket/11290 http://research.insecurelabs.org/jquery/test/ C:\projectsASF\ofbiz-framework\framework\images\webapp\images\jquery\jquery-1.11.0.min.js ? jquery 1.11.0.min has known vulnerabilities: severity: medium; issue: 2432, summary: 3rd party CORS request may execute; https://github.com/jquery/jquery/issues/2432 http://blog.jquery.com/2016/01/08/jquery-2-2-and-1-12-released/ C:\projectsASF\ofbiz-framework\plugins\solr\webapp\solr\js\require.js ? jquery 1.7.1 has known vulnerabilities: severity: medium; bug: 11290, summary: Selector interpreted as HTML; http://bugs.jquery.com/ticket/11290 http://research.insecurelabs.org/jquery/test/ severity: medium; issue: 2432, summary: 3rd party CORS request may execute; https://github.com/jquery/jquery/issues/2432 http://blog.jquery.com/2016/01/08/jquery-2-2-and-1-12-released/ C:\projectsASF\ofbiz-framework\plugins\solr\webapp\solr\libs\angular.min.js ? angularjs 1.3.8 has known vulnerabilities: severity: medium; summary: The attribute usemap can be used as a security exploit; https://github.com/angular/angular.js/blob/master/CHANGELOG.md severity: medium; summary: Universal CSP bypass via add-on in Firefox; https://github.com/mozilla/addons-linter/issues/1000#issuecomment-282083435 http://pastebin.com/raw/kGrdaypP severity: medium; summary: DOS in $sanitize; https://github.com/angular/angular.js/blob/master/CHANGELOG.md C:\projectsASF\ofbiz-framework\plugins\solr\webapp\solr\libs\angular.js ? angularjs 1.3.8 has known vulnerabilities: severity: medium; summary: The attribute usemap can be used as a security exploit; https://github.com/angular/angular.js/blob/master/CHANGELOG.md severity: medium; summary: Universal CSP bypass via add-on in Firefox; https://github.com/mozilla/addons-linter/issues/1000#issuecomment-282083435 http://pastebin.com/raw/kGrdaypP severity: medium; summary: DOS in $sanitize; https://github.com/angular/angular.js/blob/master/CHANGELOG.md C:\projectsASF\ofbiz-framework\plugins\solr\webapp\solr\libs\jquery-2.1.3.min.js ? jquery 2.1.3.min has known vulnerabilities: severity: medium; issue: 2432, summary: 3rd party CORS request may execute; https://github.com/jquery/jquery/issues/2432 http://blog.jquery.com/2016/01/08/jquery-2-2-and-1-12-released/ C:\projectsASF\ofbiz-framework\framework\images\webapp\images\jquery\jquery.mobile\jquery.mobile-1.4.0.js ? jquery-mobile 1.4.0 has known vulnerabilities: severity: medium; summary: open redirect leads to cross site scripting; http://sirdarckcat.blogspot.no/2017/02/unpatched-0day-jquery-mobile-xss.html C:\projectsASF\ofbiz-framework\framework\images\webapp\images\jquery\jquery.mobile\jquery.mobile-1.4.0.min.js ? jquery-mobile 1.4.0.min has known vulnerabilities: severity: medium; summary: open redirect leads to cross site scripting; http://sirdarckcat.blogspot.no/2017/02/unpatched-0day-jquery-mobile-xss.html C:\projectsASF\ofbiz-framework\plugins\solr\webapp\solr\js\lib\jquery-1.7.2.min.js ? jquery 1.7.2.min has known vulnerabilities: severity: medium; bug: 11290, summary: Selector interpreted as HTML; http://bugs.jquery.com/ticket/11290 http://research.insecurelabs.org/jquery/test/ severity:medium; issue: 2432, summary: 3rd party CORS request may execute; https://github.com/jquery/jquery/issues/2432 http://blog.jquery.com/2016/01/08/jquery-2-2-and-1-12-released/ C:\projectsASF\ofbiz-framework\plugins\birt\webapp\birt\webcontent\birt\ajax\lib\prototype.js ? prototypejs 1.4.0 has known vulnerabilities: severity: high; CVE: CVE-2008-7220; http://www.cvedetails.com/cve/CVE-2008-7220/ {code} So it's time to update again the Javascript embedded libs -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-7096) Inventory received are not getting reserved based on set Est. Delivery Date over Sales Order
[ https://issues.apache.org/jira/browse/OFBIZ-7096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato updated OFBIZ-7096: - Priority: Minor (was: Critical) > Inventory received are not getting reserved based on set Est. Delivery Date > over Sales Order > > > Key: OFBIZ-7096 > URL: https://issues.apache.org/jira/browse/OFBIZ-7096 > Project: OFBiz > Issue Type: Improvement >Reporter: Swapnil Shah >Assignee: Divesh Dutta >Priority: Minor > Attachments: SO1002.png, SO1003.png, SO1004.png > > > Generally system would carry multiple sales order for a SKU with different > Est.Delivery Date(EDD) and inventory might not be available that time when > orders were created/approved. > Once we start receiving the inventory then reservations gets auto-triggered > and allocated based on created/approved date by overlooking the EDD > altogether. > A simple scenario could be that we have 3 different orders created in system > at 3 different time stamps as follows and all 3 are backordered: > Order A>> Created on 05/21 10 AM >> EDD: 5/25 > Order B>> Created on 05/21 11 AM >> EDD: 5/27 > Order C>> Created on 05/21 12 AM >> EDD: 5/23 > As soon as inventory is received it first get allocated to Order A whereas > Order C is supposed to ship first even though it got approved later. > Expected Behavior: System should first honor the EDD and if its not set then > use the existing criteria of honoring Created/Approved time stamp for > allocating the reservations > Please refer to attached screenshots for reference -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-7096) Inventory received are not getting reserved based on set Est. Delivery Date over Sales Order
[ https://issues.apache.org/jira/browse/OFBIZ-7096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato updated OFBIZ-7096: - Issue Type: Improvement (was: Bug) > Inventory received are not getting reserved based on set Est. Delivery Date > over Sales Order > > > Key: OFBIZ-7096 > URL: https://issues.apache.org/jira/browse/OFBIZ-7096 > Project: OFBiz > Issue Type: Improvement >Reporter: Swapnil Shah >Assignee: Divesh Dutta >Priority: Critical > Attachments: SO1002.png, SO1003.png, SO1004.png > > > Generally system would carry multiple sales order for a SKU with different > Est.Delivery Date(EDD) and inventory might not be available that time when > orders were created/approved. > Once we start receiving the inventory then reservations gets auto-triggered > and allocated based on created/approved date by overlooking the EDD > altogether. > A simple scenario could be that we have 3 different orders created in system > at 3 different time stamps as follows and all 3 are backordered: > Order A>> Created on 05/21 10 AM >> EDD: 5/25 > Order B>> Created on 05/21 11 AM >> EDD: 5/27 > Order C>> Created on 05/21 12 AM >> EDD: 5/23 > As soon as inventory is received it first get allocated to Order A whereas > Order C is supposed to ship first even though it got approved later. > Expected Behavior: System should first honor the EDD and if its not set then > use the existing criteria of honoring Created/Approved time stamp for > allocating the reservations > Please refer to attached screenshots for reference -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7096) Inventory received are not getting reserved based on set Est. Delivery Date over Sales Order
[ https://issues.apache.org/jira/browse/OFBIZ-7096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701667#comment-16701667 ] Jacopo Cappellato commented on OFBIZ-7096: -- I think this ticket/proposal and all the follow up comments are valuable and so I am trying to summarize an actionable plan for the resolution of this ticket: # change the type and priority of the ticket from Bug/Critical to Improvement/Minor (based on the 4th of July by Divesh Dutta and comments by Taher and Jacques); I will take care of this now # enhance the reservation algorithm to "honor Desired Delivery Date in case Ship After Date is found missing or not set by user" (quoting the proposal at the end of Swapnil Shah); this should provide enough flexibility to manage use cases like the ones mentioned by Leonard Lin) > Inventory received are not getting reserved based on set Est. Delivery Date > over Sales Order > > > Key: OFBIZ-7096 > URL: https://issues.apache.org/jira/browse/OFBIZ-7096 > Project: OFBiz > Issue Type: Bug >Reporter: Swapnil Shah >Assignee: Divesh Dutta >Priority: Critical > Attachments: SO1002.png, SO1003.png, SO1004.png > > > Generally system would carry multiple sales order for a SKU with different > Est.Delivery Date(EDD) and inventory might not be available that time when > orders were created/approved. > Once we start receiving the inventory then reservations gets auto-triggered > and allocated based on created/approved date by overlooking the EDD > altogether. > A simple scenario could be that we have 3 different orders created in system > at 3 different time stamps as follows and all 3 are backordered: > Order A>> Created on 05/21 10 AM >> EDD: 5/25 > Order B>> Created on 05/21 11 AM >> EDD: 5/27 > Order C>> Created on 05/21 12 AM >> EDD: 5/23 > As soon as inventory is received it first get allocated to Order A whereas > Order C is supposed to ship first even though it got approved later. > Expected Behavior: System should first honor the EDD and if its not set then > use the existing criteria of honoring Created/Approved time stamp for > allocating the reservations > Please refer to attached screenshots for reference -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10676) Self XSS
[ https://issues.apache.org/jira/browse/OFBIZ-10676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-10676: -- Attachment: OFBIZ-10676_OfbizUtil.patch > Self XSS > > > Key: OFBIZ-10676 > URL: https://issues.apache.org/jira/browse/OFBIZ-10676 > Project: OFBiz > Issue Type: Bug > Components: scrum >Affects Versions: Trunk, 16.11.05 >Reporter: Dinesh Mohanty >Assignee: Benjamin Jugl >Priority: Major > Labels: security > Attachments: OFBIZ-10676_OfbizUtil.patch > > > An Self XSS Vulnerability is present for "Product Backlog Item" for adding a > Product Backlog details of the issue has been emailed to security team. > *Steps to Reproduce:* > 1. Login into Scrum Management Portal as *productowner* and click on your > desired product in default instance it's *"Demo Product 1 [DEMO-PRODUCT-1]"* > 2. The above url in my case is > [https://localhost:8443/scrum/control/AddProductBacklog?productId=DEMO-PRODUCT-1] > 3. Now double click on any of the "*PRODUCT BACKLOG ITEM*" and change the > value to *alert(1)* and click on OK > 4. One can see that the XSS payload executed confirming the Self XSS > Note: Same has been confirmed by Security Team so publishing publicly through > Ofbiz Jira platform. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10676) Self XSS
[ https://issues.apache.org/jira/browse/OFBIZ-10676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701754#comment-16701754 ] Benjamin Jugl commented on OFBIZ-10676: --- The confirmational blinking of the newly added value was implemented using the .html(value) funktion of jQuery. This causes the html to be interpreted and the script to be performed. But the data is stored, converting it into html (eg. "<" becomes ). Thus it will never be executed again. I changed the call to .text. This prevents the html to be interpreted. > Self XSS > > > Key: OFBIZ-10676 > URL: https://issues.apache.org/jira/browse/OFBIZ-10676 > Project: OFBiz > Issue Type: Bug > Components: scrum >Affects Versions: Trunk, 16.11.05 >Reporter: Dinesh Mohanty >Assignee: Benjamin Jugl >Priority: Major > Labels: security > > An Self XSS Vulnerability is present for "Product Backlog Item" for adding a > Product Backlog details of the issue has been emailed to security team. > *Steps to Reproduce:* > 1. Login into Scrum Management Portal as *productowner* and click on your > desired product in default instance it's *"Demo Product 1 [DEMO-PRODUCT-1]"* > 2. The above url in my case is > [https://localhost:8443/scrum/control/AddProductBacklog?productId=DEMO-PRODUCT-1] > 3. Now double click on any of the "*PRODUCT BACKLOG ITEM*" and change the > value to *alert(1)* and click on OK > 4. One can see that the XSS payload executed confirming the Self XSS > Note: Same has been confirmed by Security Team so publishing publicly through > Ofbiz Jira platform. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702819#comment-16702819 ] Jacques Le Roux commented on OFBIZ-4160: I'll try to fix the tests (I suppose they need to be amended). If it does not work I'll revert > Tax not added for order shipping or promotion > - > > Key: OFBIZ-4160 > URL: https://issues.apache.org/jira/browse/OFBIZ-4160 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk > Environment: rev 1065908 >Reporter: Paul Foxworthy >Assignee: Jacques Le Roux >Priority: Major > Labels: VAT, tax > Fix For: 17.12.01 > > Attachments: OFBIZ-4160_shipping_tax.patch, > OFBIZ-4160_weighted_shipping_tax.patch > > > When shipping is calculated for the entire order or a promotion adjustment is > made, the relevant tax rows from the TaxAuthorityRateProduct table are not > being found. > Here's a patch. > This bug was discovered independently by Sergei Biletnikov, see > http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (OFBIZ-4160) Tax not added for order shipping or promotion
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-4160: The tests don't pass. Also forgot to do the tasks I planned in a comment, reopening > Tax not added for order shipping or promotion > - > > Key: OFBIZ-4160 > URL: https://issues.apache.org/jira/browse/OFBIZ-4160 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk > Environment: rev 1065908 >Reporter: Paul Foxworthy >Assignee: Jacques Le Roux >Priority: Major > Labels: VAT, tax > Fix For: 17.12.01 > > Attachments: OFBIZ-4160_shipping_tax.patch, > OFBIZ-4160_weighted_shipping_tax.patch > > > When shipping is calculated for the entire order or a promotion adjustment is > made, the relevant tax rows from the TaxAuthorityRateProduct table are not > being found. > Here's a patch. > This bug was discovered independently by Sergei Biletnikov, see > http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10677) Standalone Asciidoc plugins documents can't render logo correctly in PDF
[ https://issues.apache.org/jira/browse/OFBIZ-10677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701761#comment-16701761 ] Jacques Le Roux commented on OFBIZ-10677: - I referred to this document http://gist.asciidoctor.org/?github-asciidoctor%2Fasciidoctor-pdf%2F%2Fdocs%2Ftheming-guide.adoc So as noted above I tried the relative path, which works in terminal: {code} C:\projectsASF\ofbiz\plugins\birt\src\docs\asciidoc>dir "../../../../../docs/asciidoc/images/" Répertoire de C:\projectsASF\ofbiz\docs\asciidoc\images 29/03/2018 09:39 228 428 ofbiz-architecture.png 19/03/2018 09:1715 110 OFBiz-Logo-250w.png 01/04/2018 20:0313 981 OFBiz-Logo.svg {code} Then an easy way is to manually copy the {{OFBiz-Logo.svg}} file and use {code} :title-logo-image: image::OFBiz-Logo.svg[Apache OFBiz Logo, pdfwidth=4.25in, align=center] {code} We could improve that by making Buildbot temporary copy the file from {{../../../../../docs/asciidoc/images/} to the images directory. If you see a better way please explain, thanks. There are interesting related discussions. Here is one https://github.com/asciidoctor/asciidoctor-pdf/issues/95 see notaly comments from Nov 27, 2018 > Standalone Asciidoc plugins documents can't render logo correctly in PDF > > > Key: OFBIZ-10677 > URL: https://issues.apache.org/jira/browse/OFBIZ-10677 > Project: OFBiz > Issue Type: Bug > Components: ALL PLUGINS >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > > Asciidoc plugins documents should be standalone as described in > [Documentation > guidelines|https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk/docs/asciidoc/documentation_guidelines.adoc]. > When rendering in PDF we should use the > {{docs/asciidoc/images/OFBiz-Logo.svg}} file to avoid duplication. For a > reason, maybe related to > [https://github.com/asciidoctor/asciidoctor-epub3/issues/22], it seems there > is a conflict between declaring > {code} > :imagesdir: ./images > {code} > and > {code} > ifdef::backend-pdf[] > :title-logo-image: ../../../../../docs/asciidoc/images/OFBiz-Logo.svg[Apache > OFBiz Logo, pdfwidth=4.25in, align=center] > :source-highlighter: rouge > endif::[] > {code} > in the same file. > You then get > {code} > [] | ../../../../../docs/asciidoc/images/OFBiz-Logo.svg[Apache OFBiz Logo, > pdfwidth=4.25in, align=center] > {code} > instead of the logo in the 1st page of the PDF document. > So it seems it's not an OFBiz bug but rather a Asciidoctor issue. Not sure > yet, so I create this Jira more as a reminder. > For now I'll not put logos in plugins standalone files. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10679) Regarding national laws when applying taxes on shipping costs
Benjamin Jugl created OFBIZ-10679: - Summary: Regarding national laws when applying taxes on shipping costs Key: OFBIZ-10679 URL: https://issues.apache.org/jira/browse/OFBIZ-10679 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Benjamin Jugl As mentioned in [#OFBIZ-4160] there are different ways to approach tax-calculation on shipping-costs. While some countries (like the Netherlands) have a fixed price for this, others calculate the delivery just like the delivered good (or a weighted version, if multiple taxrates are applied to the shipping). As I stated: {quote}[..]it is advisable to introduce a new ProductCategory "TAX_SHIPPING". This could be administered through TAX_AUTHORITY_RATE_PRODUCT for individual tax authorities. Then there could be a condition before my newly implemented logic, to use this tax rate, if it is found, and if it is not, my logic is executed. {quote} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10679) Regarding national laws when applying taxes on shipping costs
[ https://issues.apache.org/jira/browse/OFBIZ-10679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-10679: -- Priority: Minor (was: Major) > Regarding national laws when applying taxes on shipping costs > - > > Key: OFBIZ-10679 > URL: https://issues.apache.org/jira/browse/OFBIZ-10679 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Benjamin Jugl >Priority: Minor > > As mentioned in [#OFBIZ-4160] there are different ways to approach > tax-calculation on shipping-costs. > While some countries (like the Netherlands) have a fixed price for this, > others calculate the delivery just like the delivered good (or a weighted > version, if multiple taxrates are applied to the shipping). > As I stated: > {quote}[..]it is advisable to introduce a new ProductCategory "TAX_SHIPPING". > This could be administered through TAX_AUTHORITY_RATE_PRODUCT for individual > tax authorities. Then there could be a condition before my newly implemented > logic, to use this tax rate, if it is found, and if it is not, my logic is > executed. > {quote} > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9972) Find an alternative suitable syntax for OFBiz rule tasks in gradle
[ https://issues.apache.org/jira/browse/OFBIZ-9972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702097#comment-16702097 ] Mathieu Lirzin commented on OFBIZ-9972: --- Hello Taher, As described in your second link, I would advocate adopting the standard [“Application” plugin|https://docs.gradle.org/current/userguide/application_plugin.html] which in recent Gradle version provides a {{--args}} command line option to the {{:run}} task. The benefits would be a meaningful reduction of OFBiz specific code in the {{build.gradle}} which helps maintainability and a familiar interface for people already familiar with common Gradle idioms. In any case, I have tried to upgrade {{OFBiz}} Gradle wrapper to 5.0 (as done in [^OFBIZ-9972_Upgrade-to-Gradle-5.0.patch]) and everything seems to work perfectly even {{./gradlew "ofbiz --test"}}. > Find an alternative suitable syntax for OFBiz rule tasks in gradle > -- > > Key: OFBIZ-9972 > URL: https://issues.apache.org/jira/browse/OFBIZ-9972 > Project: OFBiz > Issue Type: Improvement >Reporter: Taher Alkhateeb >Priority: Major > Attachments: OFBIZ-9972_Upgrade-to-Gradle-5.0.patch > > > In testing OFBiz with a new version of gradle, I identified a potential > problem. The rule based tasks such as "ofbiz --test" will not work in > versions 5 and above. The exact error message that I received is: > The task name 'ofbiz --test' contains at least one of the following > characters: [ , /, \, :, <, >, ", ?, *, |]. This has been deprecated and is > scheduled to be removed in Gradle 5.0. > In other words, spaces are not allowed. We need to find an alternative > solution. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-9972) Find an alternative suitable syntax for OFBiz rule tasks in gradle
[ https://issues.apache.org/jira/browse/OFBIZ-9972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-9972: -- Attachment: OFBIZ-9972_Upgrade-to-Gradle-5.0.patch > Find an alternative suitable syntax for OFBiz rule tasks in gradle > -- > > Key: OFBIZ-9972 > URL: https://issues.apache.org/jira/browse/OFBIZ-9972 > Project: OFBiz > Issue Type: Improvement >Reporter: Taher Alkhateeb >Priority: Major > Attachments: OFBIZ-9972_Upgrade-to-Gradle-5.0.patch > > > In testing OFBiz with a new version of gradle, I identified a potential > problem. The rule based tasks such as "ofbiz --test" will not work in > versions 5 and above. The exact error message that I received is: > The task name 'ofbiz --test' contains at least one of the following > characters: [ , /, \, :, <, >, ", ?, *, |]. This has been deprecated and is > scheduled to be removed in Gradle 5.0. > In other words, spaces are not allowed. We need to find an alternative > solution. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-9972) Find an alternative suitable syntax for OFBiz rule tasks in gradle
[ https://issues.apache.org/jira/browse/OFBIZ-9972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb reassigned OFBIZ-9972: -- Assignee: (was: Taher Alkhateeb) > Find an alternative suitable syntax for OFBiz rule tasks in gradle > -- > > Key: OFBIZ-9972 > URL: https://issues.apache.org/jira/browse/OFBIZ-9972 > Project: OFBiz > Issue Type: Improvement >Reporter: Taher Alkhateeb >Priority: Major > Attachments: OFBIZ-9972_Upgrade-to-Gradle-5.0.patch > > > In testing OFBiz with a new version of gradle, I identified a potential > problem. The rule based tasks such as "ofbiz --test" will not work in > versions 5 and above. The exact error message that I received is: > The task name 'ofbiz --test' contains at least one of the following > characters: [ , /, \, :, <, >, ", ?, *, |]. This has been deprecated and is > scheduled to be removed in Gradle 5.0. > In other words, spaces are not allowed. We need to find an alternative > solution. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-9972) Find an alternative suitable syntax for OFBiz rule tasks in gradle
[ https://issues.apache.org/jira/browse/OFBIZ-9972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb reassigned OFBIZ-9972: -- Assignee: Taher Alkhateeb > Find an alternative suitable syntax for OFBiz rule tasks in gradle > -- > > Key: OFBIZ-9972 > URL: https://issues.apache.org/jira/browse/OFBIZ-9972 > Project: OFBiz > Issue Type: Improvement >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Major > Attachments: OFBIZ-9972_Upgrade-to-Gradle-5.0.patch > > > In testing OFBiz with a new version of gradle, I identified a potential > problem. The rule based tasks such as "ofbiz --test" will not work in > versions 5 and above. The exact error message that I received is: > The task name 'ofbiz --test' contains at least one of the following > characters: [ , /, \, :, <, >, ", ?, *, |]. This has been deprecated and is > scheduled to be removed in Gradle 5.0. > In other words, spaces are not allowed. We need to find an alternative > solution. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9972) Find an alternative suitable syntax for OFBiz rule tasks in gradle
[ https://issues.apache.org/jira/browse/OFBIZ-9972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702124#comment-16702124 ] Taher Alkhateeb commented on OFBIZ-9972: Hi Mathieu, This is great news, however, did you get a warning. Did the folks at gradle change their mind and now spaces are allowed again? Or are they still putting that deprecation warning? > Find an alternative suitable syntax for OFBiz rule tasks in gradle > -- > > Key: OFBIZ-9972 > URL: https://issues.apache.org/jira/browse/OFBIZ-9972 > Project: OFBiz > Issue Type: Improvement >Reporter: Taher Alkhateeb >Priority: Major > Attachments: OFBIZ-9972_Upgrade-to-Gradle-5.0.patch > > > In testing OFBiz with a new version of gradle, I identified a potential > problem. The rule based tasks such as "ofbiz --test" will not work in > versions 5 and above. The exact error message that I received is: > The task name 'ofbiz --test' contains at least one of the following > characters: [ , /, \, :, <, >, ", ?, *, |]. This has been deprecated and is > scheduled to be removed in Gradle 5.0. > In other words, spaces are not allowed. We need to find an alternative > solution. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10226) Adds groovyScripts in the Gradle sourceSets
[ https://issues.apache.org/jira/browse/OFBIZ-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702051#comment-16702051 ] Mathieu Lirzin commented on OFBIZ-10226: Hello Jacques, I think it would be a good idea to compile groovy files too, However if we were to do it would be a good idea to follow the common convention of putting groovy compiled sources in {{${COMPONENT}/src/main/groovy}}. > Adds groovyScripts in the Gradle sourceSets > --- > > Key: OFBIZ-10226 > URL: https://issues.apache.org/jira/browse/OFBIZ-10226 > Project: OFBiz > Issue Type: Improvement > Components: Gradle >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Major > > With the Eclipse Groovy Development Tools plugin installed, we can use the > Eclipe debugger with Groovy files if we provide source paths for them. So we > need to improve the sourceSets defined in the main build.gradle file. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10226) Adds groovyScripts in the Gradle sourceSets
[ https://issues.apache.org/jira/browse/OFBIZ-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702125#comment-16702125 ] Jacques Le Roux commented on OFBIZ-10226: - Hi Mathieu, Yes, this improvement was only for scripts. I propose that you create another Jira for your suggestion. In a 1st step we can work on the current one. > Adds groovyScripts in the Gradle sourceSets > --- > > Key: OFBIZ-10226 > URL: https://issues.apache.org/jira/browse/OFBIZ-10226 > Project: OFBiz > Issue Type: Improvement > Components: Gradle >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Major > > With the Eclipse Groovy Development Tools plugin installed, we can use the > Eclipe debugger with Groovy files if we provide source paths for them. So we > need to improve the sourceSets defined in the main build.gradle file. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9972) Find an alternative suitable syntax for OFBiz rule tasks in gradle
[ https://issues.apache.org/jira/browse/OFBIZ-9972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702133#comment-16702133 ] Mathieu Lirzin commented on OFBIZ-9972: --- I don't know if they change their mind, but I see no warning. > Find an alternative suitable syntax for OFBiz rule tasks in gradle > -- > > Key: OFBIZ-9972 > URL: https://issues.apache.org/jira/browse/OFBIZ-9972 > Project: OFBiz > Issue Type: Improvement >Reporter: Taher Alkhateeb >Priority: Major > Attachments: OFBIZ-9972_Upgrade-to-Gradle-5.0.patch > > > In testing OFBiz with a new version of gradle, I identified a potential > problem. The rule based tasks such as "ofbiz --test" will not work in > versions 5 and above. The exact error message that I received is: > The task name 'ofbiz --test' contains at least one of the following > characters: [ , /, \, :, <, >, ", ?, *, |]. This has been deprecated and is > scheduled to be removed in Gradle 5.0. > In other words, spaces are not allowed. We need to find an alternative > solution. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-4160) Tax not added for order shipping or promotion
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701917#comment-16701917 ] Benjamin Jugl edited comment on OFBIZ-4160 at 11/28/18 2:11 PM: We do not use it, since it was only something that I discovered while working on an international tax-calculation for a customer (who does only have one item per shipment, so this does not really benefit him) but I tested it was (Author: bjugl): We do not use it, since it was only something that I discovered while working on an international tax-calculation for a customer (who does only have one item per shipment, so this does not really benefit him) but I tested it [#16641681] > Tax not added for order shipping or promotion > - > > Key: OFBIZ-4160 > URL: https://issues.apache.org/jira/browse/OFBIZ-4160 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk > Environment: rev 1065908 >Reporter: Paul Foxworthy >Assignee: Jacques Le Roux >Priority: Major > Labels: VAT, tax > Attachments: OFBIZ-4160_shipping_tax.patch, > OFBIZ-4160_weighted_shipping_tax.patch > > > When shipping is calculated for the entire order or a promotion adjustment is > made, the relevant tax rows from the TaxAuthorityRateProduct table are not > being found. > Here's a patch. > This bug was discovered independently by Sergei Biletnikov, see > http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-4160) Tax not added for order shipping or promotion
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701917#comment-16701917 ] Benjamin Jugl edited comment on OFBIZ-4160 at 11/28/18 2:09 PM: We do not use it, since it was only something that I discovered while working on an international tax-calculation for a customer (who does only have one item per shipment, so this does not really benefit him) but I tested it. [#OFBIZ-4160?focusedCommentId=16641681] was (Author: bjugl): We do not use it, since it was only something that I discovered while working on an international tax-calculation for a customer (who does only have one item per shipment, so this does not really benefit him) but I tested it. > Tax not added for order shipping or promotion > - > > Key: OFBIZ-4160 > URL: https://issues.apache.org/jira/browse/OFBIZ-4160 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk > Environment: rev 1065908 >Reporter: Paul Foxworthy >Assignee: Jacques Le Roux >Priority: Major > Labels: VAT, tax > Attachments: OFBIZ-4160_shipping_tax.patch, > OFBIZ-4160_weighted_shipping_tax.patch > > > When shipping is calculated for the entire order or a promotion adjustment is > made, the relevant tax rows from the TaxAuthorityRateProduct table are not > being found. > Here's a patch. > This bug was discovered independently by Sergei Biletnikov, see > http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701917#comment-16701917 ] Benjamin Jugl commented on OFBIZ-4160: -- We do not use it, since it was only something that I discovered while working on an international tax-calculation for a customer (who does only have one item per shipment, so this does not really benefit him) but I tested it. > Tax not added for order shipping or promotion > - > > Key: OFBIZ-4160 > URL: https://issues.apache.org/jira/browse/OFBIZ-4160 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk > Environment: rev 1065908 >Reporter: Paul Foxworthy >Assignee: Jacques Le Roux >Priority: Major > Labels: VAT, tax > Attachments: OFBIZ-4160_shipping_tax.patch, > OFBIZ-4160_weighted_shipping_tax.patch > > > When shipping is calculated for the entire order or a promotion adjustment is > made, the relevant tax rows from the TaxAuthorityRateProduct table are not > being found. > Here's a patch. > This bug was discovered independently by Sergei Biletnikov, see > http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-4160) Tax not added for order shipping or promotion
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701917#comment-16701917 ] Benjamin Jugl edited comment on OFBIZ-4160 at 11/28/18 2:11 PM: We do not use it, since it was only something that I discovered while working on an international tax-calculation for a customer (who does only have one item per shipment, so this does not really benefit him) but I tested it [#16641681] was (Author: bjugl): We do not use it, since it was only something that I discovered while working on an international tax-calculation for a customer (who does only have one item per shipment, so this does not really benefit him) but I tested it > Tax not added for order shipping or promotion > - > > Key: OFBIZ-4160 > URL: https://issues.apache.org/jira/browse/OFBIZ-4160 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk > Environment: rev 1065908 >Reporter: Paul Foxworthy >Assignee: Jacques Le Roux >Priority: Major > Labels: VAT, tax > Attachments: OFBIZ-4160_shipping_tax.patch, > OFBIZ-4160_weighted_shipping_tax.patch > > > When shipping is calculated for the entire order or a promotion adjustment is > made, the relevant tax rows from the TaxAuthorityRateProduct table are not > being found. > Here's a patch. > This bug was discovered independently by Sergei Biletnikov, see > http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-4160) Tax not added for order shipping or promotion
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701917#comment-16701917 ] Benjamin Jugl edited comment on OFBIZ-4160 at 11/28/18 2:10 PM: We do not use it, since it was only something that I discovered while working on an international tax-calculation for a customer (who does only have one item per shipment, so this does not really benefit him) but I tested it was (Author: bjugl): We do not use it, since it was only something that I discovered while working on an international tax-calculation for a customer (who does only have one item per shipment, so this does not really benefit him) but I tested it. [#OFBIZ-4160?focusedCommentId=16641681] > Tax not added for order shipping or promotion > - > > Key: OFBIZ-4160 > URL: https://issues.apache.org/jira/browse/OFBIZ-4160 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk > Environment: rev 1065908 >Reporter: Paul Foxworthy >Assignee: Jacques Le Roux >Priority: Major > Labels: VAT, tax > Attachments: OFBIZ-4160_shipping_tax.patch, > OFBIZ-4160_weighted_shipping_tax.patch > > > When shipping is calculated for the entire order or a promotion adjustment is > made, the relevant tax rows from the TaxAuthorityRateProduct table are not > being found. > Here's a patch. > This bug was discovered independently by Sergei Biletnikov, see > http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9972) Find an alternative suitable syntax for OFBiz rule tasks in gradle
[ https://issues.apache.org/jira/browse/OFBIZ-9972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702149#comment-16702149 ] Taher Alkhateeb commented on OFBIZ-9972: This is wonderful news, I'll start a thread on the ML to go ahead with the upgrade. > Find an alternative suitable syntax for OFBiz rule tasks in gradle > -- > > Key: OFBIZ-9972 > URL: https://issues.apache.org/jira/browse/OFBIZ-9972 > Project: OFBiz > Issue Type: Improvement >Reporter: Taher Alkhateeb >Priority: Major > Attachments: OFBIZ-9972_Upgrade-to-Gradle-5.0.patch > > > In testing OFBiz with a new version of gradle, I identified a potential > problem. The rule based tasks such as "ofbiz --test" will not work in > versions 5 and above. The exact error message that I received is: > The task name 'ofbiz --test' contains at least one of the following > characters: [ , /, \, :, <, >, ", ?, *, |]. This has been deprecated and is > scheduled to be removed in Gradle 5.0. > In other words, spaces are not allowed. We need to find an alternative > solution. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-4160) Tax not added for order shipping or promotion
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4160. -- Resolution: Fixed Fix Version/s: 17.12.01 > Tax not added for order shipping or promotion > - > > Key: OFBIZ-4160 > URL: https://issues.apache.org/jira/browse/OFBIZ-4160 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk > Environment: rev 1065908 >Reporter: Paul Foxworthy >Assignee: Jacques Le Roux >Priority: Major > Labels: VAT, tax > Fix For: 17.12.01 > > Attachments: OFBIZ-4160_shipping_tax.patch, > OFBIZ-4160_weighted_shipping_tax.patch > > > When shipping is calculated for the entire order or a promotion adjustment is > made, the relevant tax rows from the TaxAuthorityRateProduct table are not > being found. > Here's a patch. > This bug was discovered independently by Sergei Biletnikov, see > http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702449#comment-16702449 ] Jacques Le Roux commented on OFBIZ-4160: Thanks Benjamin, Your patch is in trunk r1847670 R17 r1847671 I did not backport in R16, too much conflicts > Tax not added for order shipping or promotion > - > > Key: OFBIZ-4160 > URL: https://issues.apache.org/jira/browse/OFBIZ-4160 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk > Environment: rev 1065908 >Reporter: Paul Foxworthy >Assignee: Jacques Le Roux >Priority: Major > Labels: VAT, tax > Fix For: 17.12.01 > > Attachments: OFBIZ-4160_shipping_tax.patch, > OFBIZ-4160_weighted_shipping_tax.patch > > > When shipping is calculated for the entire order or a promotion adjustment is > made, the relevant tax rows from the TaxAuthorityRateProduct table are not > being found. > Here's a patch. > This bug was discovered independently by Sergei Biletnikov, see > http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702454#comment-16702454 ] Jacques Le Roux commented on OFBIZ-4160: Seems that there are some tests issue. I'll check that tmrw... > Tax not added for order shipping or promotion > - > > Key: OFBIZ-4160 > URL: https://issues.apache.org/jira/browse/OFBIZ-4160 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk > Environment: rev 1065908 >Reporter: Paul Foxworthy >Assignee: Jacques Le Roux >Priority: Major > Labels: VAT, tax > Fix For: 17.12.01 > > Attachments: OFBIZ-4160_shipping_tax.patch, > OFBIZ-4160_weighted_shipping_tax.patch > > > When shipping is calculated for the entire order or a promotion adjustment is > made, the relevant tax rows from the TaxAuthorityRateProduct table are not > being found. > Here's a patch. > This bug was discovered independently by Sergei Biletnikov, see > http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html. -- This message was sent by Atlassian JIRA (v7.6.3#76005)