[jira] [Commented] (OFBIZ-6932) In the case of MARKETING_PKG_PICK the invoice gets created of product components, Ideally the invoice should be created of package.
[ https://issues.apache.org/jira/browse/OFBIZ-6932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705734#comment-16705734 ] Pierre Smits commented on OFBIZ-6932: - Indeed a marketing package should be invoiced as any other end product. All the outgoing documents (shipment statement, invoice, etc.) should reflect that. However, there are situations where the breakdown could be required to be provided by the supplier. Jacques is referencing a good example.When you buy a car you get invoiced for a total package, but the elements are referenced (at least on the invoice). The same applies (at least here in the Netherlands) when buying a built-to-order product, e.g. like a computer. In such cases the invoice states the end product (with the line item price), and the components (including quantities, and e.g. serial numbers) but without their line item prices. > In the case of MARKETING_PKG_PICK the invoice gets created of product > components, Ideally the invoice should be created of package. > --- > > Key: OFBIZ-6932 > URL: https://issues.apache.org/jira/browse/OFBIZ-6932 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Yashwant Dhakad >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > > Steps to reproduce: > 1. Create sales order with MARKETING_PKG_PICK. > 2. Completed the order with its shipment. > 3. Invoice should be created. > Actual: Invoice created with its components. > Expected: Invoice should be created for its package. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10680) partyId misses in EditEftAccount.ftl (party) when you create an EFT account from the quick finalize page
Jacques Le Roux created OFBIZ-10680:
---
Summary: partyId misses in EditEftAccount.ftl (party) when you
create an EFT account from the quick finalize page
Key: OFBIZ-10680
URL: https://issues.apache.org/jira/browse/OFBIZ-10680
Project: OFBiz
Issue Type: Bug
Components: order
Affects Versions: Trunk
Reporter: Jacques Le Roux
While working on OFBIZ-9913 I stumbled upon this issue.
{quote}bq. If you split the payment and want to create an EFT account you get
an error in EditEftAccount.ftl (party) at line 40 colum 50: the partyId is
missing.
{quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-9913) Payment capturing twice on single action
[ https://issues.apache.org/jira/browse/OFBIZ-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-9913: --- Attachment: Image 001.png > Payment capturing twice on single action > > > Key: OFBIZ-9913 > URL: https://issues.apache.org/jira/browse/OFBIZ-9913 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Padmavati Rawat >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > Attachments: Image 001.png > > > Steps: > 1. Navigate order component. > 2. Set customer and select product for the order. > 3. Set payment method ( Credit Card and EFT Account ) and shipping method > for the corresponding order. > 4. Create an order. > 5. Captured amount in associated payment method. > Actual: > Payment capturing twice on single action on view order screen. > Expected: > Payment should captured single time on single action. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10681) Dependent dropdowns should be used in States.ftl
Jacques Le Roux created OFBIZ-10681:
---
Summary: Dependent dropdowns should be used in States.ftl
Key: OFBIZ-10681
URL: https://issues.apache.org/jira/browse/OFBIZ-10681
Project: OFBiz
Issue Type: Bug
Components: ALL APPLICATIONS, ALL PLUGINS
Affects Versions: Trunk
Reporter: Jacques Le Roux
If you create an EFT account from the quick finalyse page, at the
ordermgr/control/createPostalAddress the US states which are proposed by
default in the are not the US states but all states. You still can pick one US
state, but it's counter intuitive.
If you try to use the proposed alternative
{quote}Here is some alternate code to get states limited to a region
{quote}
You get an error at line 35, column 22
Dependent dropdowns should be used in States.ftl
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-9913) Payment capturing twice on single action
[ https://issues.apache.org/jira/browse/OFBIZ-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705729#comment-16705729 ] Jacques Le Roux edited comment on OFBIZ-9913 at 12/1/18 9:15 AM: - While checking this issue I crossed 2 others on the quick finalyse page, I'll not detail them, just a small report: # Major: If you split the payment and want to create an EFT account you get an error in EditEftAccount.ftl (party) at line 40 colum 50: the partyId is missing. I have created OFBIZ-10680 for that. # Minor: If you create an EFT account from the quick finalyse page, at the ordermgr/control/createPostalAddress the US states which are proposed by default in the are not the US states but all states. Dependent dropdowns should be used there. I have created OFBIZ-10681 for that. was (Author: jacques.le.roux): While checking this issue I crossed 2 others on the quick finalyse page, I'll not detail them, just a small report: # Major: If you split the payment and want to create an EFT account you get an error in EditEftAccount.ftl (party) at line 40 colum 50: the partyId is missing. # Minor: If you create an EFT account from the quick finalyse page, at the ordermgr/control/createPostalAddress the US states which are proposed by default in the are not the US states but all states. Dependent dropdowns should be used there. > Payment capturing twice on single action > > > Key: OFBIZ-9913 > URL: https://issues.apache.org/jira/browse/OFBIZ-9913 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Padmavati Rawat >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > Attachments: Image 001.png, Image 003.png > > > Steps: > 1. Navigate order component. > 2. Set customer and select product for the order. > 3. Set payment method ( Credit Card and EFT Account ) and shipping method > for the corresponding order. > 4. Create an order. > 5. Captured amount in associated payment method. > Actual: > Payment capturing twice on single action on view order screen. > Expected: > Payment should captured single time on single action. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-6932) In the case of MARKETING_PKG_PICK the invoice gets created of product components, Ideally the invoice should be created of package.
[
https://issues.apache.org/jira/browse/OFBIZ-6932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705360#comment-16705360
]
Jacques Le Roux edited comment on OFBIZ-6932 at 12/1/18 9:34 AM:
-
It indeed works for {{ In the case of MARKETING_PKG_PICK the invoice gets created of product
> components, Ideally the invoice should be created of package.
> ---
>
> Key: OFBIZ-6932
> URL: https://issues.apache.org/jira/browse/OFBIZ-6932
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Trunk
>Reporter: Yashwant Dhakad
>Assignee: Amit Gadaley
>Priority: Major
> Fix For: Trunk
>
>
> Steps to reproduce:
> 1. Create sales order with MARKETING_PKG_PICK.
> 2. Completed the order with its shipment.
> 3. Invoice should be created.
> Actual: Invoice created with its components.
> Expected: Invoice should be created for its package.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-9913) Payment capturing twice on single action
[ https://issues.apache.org/jira/browse/OFBIZ-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-9913: --- Attachment: Image 003.png > Payment capturing twice on single action > > > Key: OFBIZ-9913 > URL: https://issues.apache.org/jira/browse/OFBIZ-9913 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Padmavati Rawat >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > Attachments: Image 001.png, Image 003.png > > > Steps: > 1. Navigate order component. > 2. Set customer and select product for the order. > 3. Set payment method ( Credit Card and EFT Account ) and shipping method > for the corresponding order. > 4. Create an order. > 5. Captured amount in associated payment method. > Actual: > Payment capturing twice on single action on view order screen. > Expected: > Payment should captured single time on single action. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10580) Classification group filter not working on find party screen
[ https://issues.apache.org/jira/browse/OFBIZ-10580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705374#comment-16705374 ] Jacques Le Roux edited comment on OFBIZ-10580 at 12/1/18 9:24 AM: -- Actually it's not specific to this issue, but we need to address the "No results found" case (cf en.js) and it's not legible in the dropdown because it's then too narrow. I guess we need somethingin SetMultipleSelectJs.ftl and SetMultipleSelectJsList.ftl. I created OFBIZ-10682 for that. was (Author: jacques.le.roux): Actually it's not specific to this issue, but we need to address the "No results found" case (cf en.js) and it's not legible in the dropdown because it's then too narrow. I guess we need somethingin SetMultipleSelectJs.ftl and SetMultipleSelectJsList.ftl. A new Jira should be created... > Classification group filter not working on find party screen > > > Key: OFBIZ-10580 > URL: https://issues.apache.org/jira/browse/OFBIZ-10580 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12 >Reporter: Anushi Gupta >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-10580.patch > > > Steps to regenerate: > # Login to > partymgr([[https://demo-trunk.ofbiz.apache.org/partymgr/control/findparty])] > # Select classification group (if present, otherwise create new group) and > find party > Actual : > All parties are listed on searching > Expected : > Parties which are under the selected classification group should only be > listed -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10682) When using Select2 for multiple selects the field is too narrow in "no resuts" case
Jacques Le Roux created OFBIZ-10682: --- Summary: When using Select2 for multiple selects the field is too narrow in "no resuts" case Key: OFBIZ-10682 URL: https://issues.apache.org/jira/browse/OFBIZ-10682 Project: OFBiz Issue Type: Improvement Components: ALL APPLICATIONS, ALL PLUGINS Affects Versions: Trunk Reporter: Jacques Le Roux We need to address the "No results found" case (cf en.js). It's not legible in the dropdown because it's then too narrow. I guess we need somethingin SetMultipleSelectJs.ftl and SetMultipleSelectJsList.ftl. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9913) Payment capturing twice on single action
[
https://issues.apache.org/jira/browse/OFBIZ-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705737#comment-16705737
]
Jacques Le Roux commented on OFBIZ-9913:
I don't see, before creating the order, ho you can
{quote}Set payment method ( Credit Card and EFT Account ) and shipping method
for the corresponding order.
{quote}
I mean "Credit Card *and* EFT Account" it's one or the other be default. We
need more information (steps) on how we can have both. !Image 001.png!
Once the order is created you can use "Credit Card *and* EFT Account" and then
it works as expected !Image 003.png!
Sorry for the French :)
> Payment capturing twice on single action
>
>
> Key: OFBIZ-9913
> URL: https://issues.apache.org/jira/browse/OFBIZ-9913
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Reporter: Padmavati Rawat
>Assignee: Amit Gadaley
>Priority: Major
> Fix For: Trunk
>
> Attachments: Image 001.png, Image 003.png
>
>
> Steps:
> 1. Navigate order component.
> 2. Set customer and select product for the order.
> 3. Set payment method ( Credit Card and EFT Account ) and shipping method
> for the corresponding order.
> 4. Create an order.
> 5. Captured amount in associated payment method.
> Actual:
> Payment capturing twice on single action on view order screen.
> Expected:
> Payment should captured single time on single action.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (OFBIZ-9913) Payment capturing twice on single action
[ https://issues.apache.org/jira/browse/OFBIZ-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9913. -- > Payment capturing twice on single action > > > Key: OFBIZ-9913 > URL: https://issues.apache.org/jira/browse/OFBIZ-9913 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Padmavati Rawat >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > Attachments: Image 001.png, Image 003.png > > > Steps: > 1. Navigate order component. > 2. Set customer and select product for the order. > 3. Set payment method ( Credit Card and EFT Account ) and shipping method > for the corresponding order. > 4. Create an order. > 5. Captured amount in associated payment method. > Actual: > Payment capturing twice on single action on view order screen. > Expected: > Payment should captured single time on single action. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9913) Payment capturing twice on single action
[ https://issues.apache.org/jira/browse/OFBIZ-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705729#comment-16705729 ] Jacques Le Roux commented on OFBIZ-9913: While checking this issue I crossed 2 others on the quick finalyse page, I'll not detail them, just a small report: # Major: If you split the payment and want to create an EFT account you get an error in EditEftAccount.ftl (party) at line 40 colum 50: the partyId is missing. # Minor: If you create an EFT account from the quick finalyse page, at the ordermgr/control/createPostalAddress the US states which are proposed by default in the are not the US states but all states. Dependent dropdowns should be used there. > Payment capturing twice on single action > > > Key: OFBIZ-9913 > URL: https://issues.apache.org/jira/browse/OFBIZ-9913 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Padmavati Rawat >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > > Steps: > 1. Navigate order component. > 2. Set customer and select product for the order. > 3. Set payment method ( Credit Card and EFT Account ) and shipping method > for the corresponding order. > 4. Create an order. > 5. Captured amount in associated payment method. > Actual: > Payment capturing twice on single action on view order screen. > Expected: > Payment should captured single time on single action. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7675) Investigate if we should turn Freemarker autoescaping on
[
https://issues.apache.org/jira/browse/OFBIZ-7675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705742#comment-16705742
]
Jacques Le Roux commented on OFBIZ-7675:
Hi Deepak, good to see someone working on that :)
> Investigate if we should turn Freemarker autoescaping on
>
>
> Key: OFBIZ-7675
> URL: https://issues.apache.org/jira/browse/OFBIZ-7675
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: 17.12.01
>
>
> At OFBIZ-7041 [~f...@14x.net] suggested that we turn Freemarker autoescaping
> on. Quoting him there:
> {quote}
> This new version of FreeMarker includes auto-escaping and output formats. The
> <#escape> directive has been deprecated. Notice the comment at the very end
> of this page:
> "FreeMarker automatically escapes all values printed ... if it's properly
> configured (that's the responsibility of the programmers; [see here
> how|http://freemarker.org/docs/pgui_config_outputformatsautoesc.html])."
> Would be good to turn autoescaping on, and set the configuration to match
> .ftl as HTML and .fo.ftl as XML.
> {quote}
> [~pfm.smits] asked
> {quote}
> If we are going down that path I guess we have to visit a lot of Freemarker
> template files, right?
> {quote}
> Here is my answer
> {quote}
> We don' t use any <#escape> directives in all OFBiz. We have a couple of
> <#noescape> which should be replaced by <#noautoesc>. So I agree we could set
> the Freemarker environement to auto-escaping, and test if it has not
> unexpected side-effects.
> Could be that this will fix or complicate the issue I crossed (at bottom) of
> OFBIZ-7041 and more recently at OFBIZ-7343, let's see...
> {quote}
> Reply
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10683) ExternalLoginKey doesn't work with cluster doesn't support session sticky
Jason Hao created OFBIZ-10683: - Summary: ExternalLoginKey doesn't work with cluster doesn't support session sticky Key: OFBIZ-10683 URL: https://issues.apache.org/jira/browse/OFBIZ-10683 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: 16.11.05 Reporter: Jason Hao externalLoginKeys defined as static variable in LoginWorker. So in a cluster environment, if node A generated the externalLoginKey, but verify on B node it will fail. I'm trying some approach to replicate session and externalLoginKey to redis, will commit code later. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-9873) Create a PoC for a documentation system for OFBiz based on Asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-9873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9873. -- Resolution: Fixed Fix Version/s: (was: Upcoming Branch) 17.12.01 fixed in trunk r1847890+1847891 R17 r1847892 > Create a PoC for a documentation system for OFBiz based on Asciidoc > --- > > Key: OFBIZ-9873 > URL: https://issues.apache.org/jira/browse/OFBIZ-9873 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Jacques Le Roux >Priority: Minor > Fix For: 17.12.01 > > Attachments: OFBIZ-9873-final.patch, OFBIZ-9873-rouge-coderay.patch, > OFBIZ-9873.patch, OFBIZ-9873.patch, OFBIZ-9873.patch > > > In reference to the [discussion > thread|https://lists.apache.org/thread.html/8cc03b7b8733512244129ddae9e0cc1fb2a28e3e250aba1c8cf678f8@%3Cdev.ofbiz.apache.org%3E] > this is an attempt to create a PoC for OFBiz documentation system based on > Asciidoc. The main assumptions for the design of this system are: > - The documentation language to use is Asciidoc > - The documentation tool is Asciidoctor > - Publishing happens through Gradle using the asciidoctor gradle plugin (not > the OFBiz framework or anything else). > - The only place where we write documentation is inside the code base > - Every component contains its own documentation > - General documentation goes to either a standalone directory or a generic > component like common or base > - As much as possible, documentation files are small and focused on one > topic. And then other longer documents are constructed from these snippets of > documentation. > - We publish to all formats including PDF for users, or HTML for embedded > help and wiki pages. So OFBiz does not parse docbook for its help system, > instead it just renders generated HTML. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-9873) Create a PoC for a documentation system for OFBiz based on Asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-9873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-9873: -- Assignee: Taher Alkhateeb (was: Jacques Le Roux) > Create a PoC for a documentation system for OFBiz based on Asciidoc > --- > > Key: OFBIZ-9873 > URL: https://issues.apache.org/jira/browse/OFBIZ-9873 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > Fix For: 17.12.01 > > Attachments: OFBIZ-9873-final.patch, OFBIZ-9873-rouge-coderay.patch, > OFBIZ-9873.patch, OFBIZ-9873.patch, OFBIZ-9873.patch > > > In reference to the [discussion > thread|https://lists.apache.org/thread.html/8cc03b7b8733512244129ddae9e0cc1fb2a28e3e250aba1c8cf678f8@%3Cdev.ofbiz.apache.org%3E] > this is an attempt to create a PoC for OFBiz documentation system based on > Asciidoc. The main assumptions for the design of this system are: > - The documentation language to use is Asciidoc > - The documentation tool is Asciidoctor > - Publishing happens through Gradle using the asciidoctor gradle plugin (not > the OFBiz framework or anything else). > - The only place where we write documentation is inside the code base > - Every component contains its own documentation > - General documentation goes to either a standalone directory or a generic > component like common or base > - As much as possible, documentation files are small and focused on one > topic. And then other longer documents are constructed from these snippets of > documentation. > - We publish to all formats including PDF for users, or HTML for embedded > help and wiki pages. So OFBiz does not parse docbook for its help system, > instead it just renders generated HTML. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10663) Amount field is editable at Product Detail Page
[ https://issues.apache.org/jira/browse/OFBIZ-10663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705914#comment-16705914 ] Jacques Le Roux commented on OFBIZ-10663: - I agree Ratnesh, could you handle it? > Amount field is editable at Product Detail Page > --- > > Key: OFBIZ-10663 > URL: https://issues.apache.org/jira/browse/OFBIZ-10663 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Reporter: Dikpal Kanungo >Priority: Major > Attachments: Editable amount.png, Missing Heading.png > > > The customer is able to enter the price of a product from the product detail > page which should not happen. > Steps to regenerate- > Open - ofbiz demo trunk for ecomm. > Click on the product - Tiny Gizmo > Try editing the Amount field. > -- > Click on product - .NIT Gizmo > Quantity text is missing and No value is coming in reference to Amount > heading. > Please have a look at the attached screenshots. > Cheers, > Dikpal !Missing Heading.png! > > > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
