[jira] [Closed] (OFBIZ-10638) The ‘StartupLoader’ interface should be removed

2019-02-03 Thread Taher Alkhateeb (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Taher Alkhateeb closed OFBIZ-10638.
---
Resolution: Fixed

Patch implemented successfully in r1852847 after a full test of the system 
which reveals no abnormalities. Thank you Mathieu for your work.

> The ‘StartupLoader’ interface should be removed
> ---
>
> Key: OFBIZ-10638
> URL: https://issues.apache.org/jira/browse/OFBIZ-10638
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Taher Alkhateeb
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10638_Remove-StartupLoader-interface.patch
>
>
> OFBiz used to provide alternate Startup loaders. Nowadays only the container 
> loaders is used. As suggested by Taher [on the dev mailing 
> list|https://lists.apache.org/thread.html/f99d6f661eb8197df8eac6d8ba7db3fa9b7fe2569a4a24ef2fef5cae@%3Cdev.ofbiz.apache.org%3E],
>  the {{StartupLoader}} interface should be removed and startup code using it 
> should be adapted.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10638) The ‘StartupLoader’ interface should be removed

2019-02-03 Thread Mathieu Lirzin (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759513#comment-16759513
 ] 

Mathieu Lirzin commented on OFBIZ-10638:


Thanks alot Taher!

> The ‘StartupLoader’ interface should be removed
> ---
>
> Key: OFBIZ-10638
> URL: https://issues.apache.org/jira/browse/OFBIZ-10638
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Taher Alkhateeb
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10638_Remove-StartupLoader-interface.patch
>
>
> OFBiz used to provide alternate Startup loaders. Nowadays only the container 
> loaders is used. As suggested by Taher [on the dev mailing 
> list|https://lists.apache.org/thread.html/f99d6f661eb8197df8eac6d8ba7db3fa9b7fe2569a4a24ef2fef5cae@%3Cdev.ofbiz.apache.org%3E],
>  the {{StartupLoader}} interface should be removed and startup code using it 
> should be adapted.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10814) Error parsing JWT

2019-02-03 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759341#comment-16759341
 ] 

Jacques Le Roux commented on OFBIZ-10814:
-

Hi Michael,

Should we not use HttpHeaders.AUTHORIZATION in JWTManager::checkJWTLogin?
Also, please add a new line at the end of security.properties, it's else 
sometimes difficult to read (got issue in Eclipse Photon)

All, forget my question about
bq.  "USERNAME" and "PASSWORD" as parameters in a request
We already use that to sign in  without having to pass to the login screen and 
type credentials, that's OK with me.


> Error parsing JWT
> -
>
> Key: OFBIZ-10814
> URL: https://issues.apache.org/jira/browse/OFBIZ-10814
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Major
> Attachments: Apache OFBiz JWT Test.postman_collection.json, 
> OFBIZ-10814_JWT_parsing_error.patch, 
> OFBIZ-10814_JWT_parsing_error_and_refactoring.patch, 
> OFBIZ-10814_JWT_parsing_error_examples.patch
>
>
> I have problems using the Authorization: Bearer header value for requests 
> towards OFBiz. OFBiz has problems parsing externally generated JSON Web 
> Tokens.
> I have generated them using both [1] and [2] using HS512 and the default 
> secret.
> The JWT check fails because of a parsing error:
> {noformat}
> 2019-01-17 16:48:36,233 |jsse-nio-8443-exec-7 |JavaEventHandler  
> |E| Problems Processing Event
> io.jsonwebtoken.MalformedJwtException: Unable to read JSON value: 
> �z��'G�#�$�uB"�&�r#�$�3S"
>     at 
> io.jsonwebtoken.impl.DefaultJwtParser.readValue(DefaultJwtParser.java:554) 
> ~[jjwt-0.9.1.jar:0.9.1]
>     at io.jsonwebtoken.impl.DefaultJwtParser.parse(DefaultJwtParser.java:252) 
> ~[jjwt-0.9.1.jar:0.9.1]
>     at io.jsonwebtoken.impl.DefaultJwtParser.parse(DefaultJwtParser.java:481) 
> ~[jjwt-0.9.1.jar:0.9.1]
>     at 
> io.jsonwebtoken.impl.DefaultJwtParser.parseClaimsJws(DefaultJwtParser.java:541)
>  ~[jjwt-0.9.1.jar:0.9.1]
>     at 
> org.apache.ofbiz.webapp.control.JWTManager.validateToken(JWTManager.java:124) 
> ~[ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.ExternalLoginKeysManager.jwtValidation(ExternalLoginKeysManager.java:292)
>  ~[ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.ExternalLoginKeysManager.checkJWTLogin(ExternalLoginKeysManager.java:196)
>  ~[ofbiz.jar:?]
>     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[?:1.8.0_152]
>     at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> ~[?:1.8.0_152]
>     at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_152]
>     at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_152]
>     at 
> org.apache.ofbiz.webapp.event.JavaEventHandler.invoke(JavaEventHandler.java:86)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:774)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:407)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:208) 
> [ofbiz.jar:?]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:645) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:750) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:191)
>  [ofbiz.jar:?]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156)
>  [ofbiz.jar:?]
>     at javax.servlet.http.HttpFilter.doFilter(HttpFilter.java:127) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:199)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> 

[jira] [Commented] (OFBIZ-10814) Error parsing JWT

2019-02-03 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759342#comment-16759342
 ] 

Jacques Le Roux commented on OFBIZ-10814:
-

Thanks Deepak,

We crossed on wire (did not update the Jira), I did not thought about mobile 
apps, but we have the same case when login to demos.

> Error parsing JWT
> -
>
> Key: OFBIZ-10814
> URL: https://issues.apache.org/jira/browse/OFBIZ-10814
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Major
> Attachments: Apache OFBiz JWT Test.postman_collection.json, 
> OFBIZ-10814_JWT_parsing_error.patch, 
> OFBIZ-10814_JWT_parsing_error_and_refactoring.patch, 
> OFBIZ-10814_JWT_parsing_error_examples.patch
>
>
> I have problems using the Authorization: Bearer header value for requests 
> towards OFBiz. OFBiz has problems parsing externally generated JSON Web 
> Tokens.
> I have generated them using both [1] and [2] using HS512 and the default 
> secret.
> The JWT check fails because of a parsing error:
> {noformat}
> 2019-01-17 16:48:36,233 |jsse-nio-8443-exec-7 |JavaEventHandler  
> |E| Problems Processing Event
> io.jsonwebtoken.MalformedJwtException: Unable to read JSON value: 
> �z��'G�#�$�uB"�&�r#�$�3S"
>     at 
> io.jsonwebtoken.impl.DefaultJwtParser.readValue(DefaultJwtParser.java:554) 
> ~[jjwt-0.9.1.jar:0.9.1]
>     at io.jsonwebtoken.impl.DefaultJwtParser.parse(DefaultJwtParser.java:252) 
> ~[jjwt-0.9.1.jar:0.9.1]
>     at io.jsonwebtoken.impl.DefaultJwtParser.parse(DefaultJwtParser.java:481) 
> ~[jjwt-0.9.1.jar:0.9.1]
>     at 
> io.jsonwebtoken.impl.DefaultJwtParser.parseClaimsJws(DefaultJwtParser.java:541)
>  ~[jjwt-0.9.1.jar:0.9.1]
>     at 
> org.apache.ofbiz.webapp.control.JWTManager.validateToken(JWTManager.java:124) 
> ~[ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.ExternalLoginKeysManager.jwtValidation(ExternalLoginKeysManager.java:292)
>  ~[ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.ExternalLoginKeysManager.checkJWTLogin(ExternalLoginKeysManager.java:196)
>  ~[ofbiz.jar:?]
>     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[?:1.8.0_152]
>     at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> ~[?:1.8.0_152]
>     at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_152]
>     at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_152]
>     at 
> org.apache.ofbiz.webapp.event.JavaEventHandler.invoke(JavaEventHandler.java:86)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:774)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:407)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:208) 
> [ofbiz.jar:?]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:645) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:750) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:191)
>  [ofbiz.jar:?]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156)
>  [ofbiz.jar:?]
>     at javax.servlet.http.HttpFilter.doFilter(HttpFilter.java:127) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:199)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:490)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> 

[jira] [Comment Edited] (OFBIZ-10814) Error parsing JWT

2019-02-03 Thread Michael Brohl (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759345#comment-16759345
 ] 

Michael Brohl edited comment on OFBIZ-10814 at 2/3/19 9:39 AM:
---

{quote}Should we not use HttpHeaders.AUTHORIZATION in JWTManager::checkJWTLogin?
{quote}
Do you use the right patch? The 1st patch is outdated. I think that I've used 
it instead of a string value.
{quote}Also, please add a new line at the end of security.properties, it's else 
sometimes difficult to read (got issue in Eclipse Photon)
{quote}
What do you mean? What is the issue?


was (Author: mbrohl):
{quote}Should we not use HttpHeaders.AUTHORIZATION in JWTManager::checkJWTLogin?
{quote}
Do you use the right patch? I think that I've used it instead of a string value.
{quote}Also, please add a new line at the end of security.properties, it's else 
sometimes difficult to read (got issue in Eclipse Photon)
{quote}
What do you mean? What is the issue?

> Error parsing JWT
> -
>
> Key: OFBIZ-10814
> URL: https://issues.apache.org/jira/browse/OFBIZ-10814
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Major
> Attachments: Apache OFBiz JWT Test.postman_collection.json, 
> OFBIZ-10814_JWT_parsing_error.patch, 
> OFBIZ-10814_JWT_parsing_error_and_refactoring.patch, 
> OFBIZ-10814_JWT_parsing_error_examples.patch
>
>
> I have problems using the Authorization: Bearer header value for requests 
> towards OFBiz. OFBiz has problems parsing externally generated JSON Web 
> Tokens.
> I have generated them using both [1] and [2] using HS512 and the default 
> secret.
> The JWT check fails because of a parsing error:
> {noformat}
> 2019-01-17 16:48:36,233 |jsse-nio-8443-exec-7 |JavaEventHandler  
> |E| Problems Processing Event
> io.jsonwebtoken.MalformedJwtException: Unable to read JSON value: 
> �z��'G�#�$�uB"�&�r#�$�3S"
>     at 
> io.jsonwebtoken.impl.DefaultJwtParser.readValue(DefaultJwtParser.java:554) 
> ~[jjwt-0.9.1.jar:0.9.1]
>     at io.jsonwebtoken.impl.DefaultJwtParser.parse(DefaultJwtParser.java:252) 
> ~[jjwt-0.9.1.jar:0.9.1]
>     at io.jsonwebtoken.impl.DefaultJwtParser.parse(DefaultJwtParser.java:481) 
> ~[jjwt-0.9.1.jar:0.9.1]
>     at 
> io.jsonwebtoken.impl.DefaultJwtParser.parseClaimsJws(DefaultJwtParser.java:541)
>  ~[jjwt-0.9.1.jar:0.9.1]
>     at 
> org.apache.ofbiz.webapp.control.JWTManager.validateToken(JWTManager.java:124) 
> ~[ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.ExternalLoginKeysManager.jwtValidation(ExternalLoginKeysManager.java:292)
>  ~[ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.ExternalLoginKeysManager.checkJWTLogin(ExternalLoginKeysManager.java:196)
>  ~[ofbiz.jar:?]
>     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[?:1.8.0_152]
>     at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> ~[?:1.8.0_152]
>     at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_152]
>     at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_152]
>     at 
> org.apache.ofbiz.webapp.event.JavaEventHandler.invoke(JavaEventHandler.java:86)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:774)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:407)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:208) 
> [ofbiz.jar:?]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:645) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:750) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:191)
>  [ofbiz.jar:?]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156)
>  [ofbiz.jar:?]
>     at javax.servlet.http.HttpFilter.doFilter(HttpFilter.java:127) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
>     at 
> 

[jira] [Updated] (OFBIZ-10814) Error parsing JWT

2019-02-03 Thread Michael Brohl (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-10814:
--
Attachment: (was: OFBIZ-10814_JWT_parsing_error.patch)

> Error parsing JWT
> -
>
> Key: OFBIZ-10814
> URL: https://issues.apache.org/jira/browse/OFBIZ-10814
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Major
> Attachments: Apache OFBiz JWT Test.postman_collection.json, 
> OFBIZ-10814_JWT_parsing_error_and_refactoring.patch, 
> OFBIZ-10814_JWT_parsing_error_examples.patch
>
>
> I have problems using the Authorization: Bearer header value for requests 
> towards OFBiz. OFBiz has problems parsing externally generated JSON Web 
> Tokens.
> I have generated them using both [1] and [2] using HS512 and the default 
> secret.
> The JWT check fails because of a parsing error:
> {noformat}
> 2019-01-17 16:48:36,233 |jsse-nio-8443-exec-7 |JavaEventHandler  
> |E| Problems Processing Event
> io.jsonwebtoken.MalformedJwtException: Unable to read JSON value: 
> �z��'G�#�$�uB"�&�r#�$�3S"
>     at 
> io.jsonwebtoken.impl.DefaultJwtParser.readValue(DefaultJwtParser.java:554) 
> ~[jjwt-0.9.1.jar:0.9.1]
>     at io.jsonwebtoken.impl.DefaultJwtParser.parse(DefaultJwtParser.java:252) 
> ~[jjwt-0.9.1.jar:0.9.1]
>     at io.jsonwebtoken.impl.DefaultJwtParser.parse(DefaultJwtParser.java:481) 
> ~[jjwt-0.9.1.jar:0.9.1]
>     at 
> io.jsonwebtoken.impl.DefaultJwtParser.parseClaimsJws(DefaultJwtParser.java:541)
>  ~[jjwt-0.9.1.jar:0.9.1]
>     at 
> org.apache.ofbiz.webapp.control.JWTManager.validateToken(JWTManager.java:124) 
> ~[ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.ExternalLoginKeysManager.jwtValidation(ExternalLoginKeysManager.java:292)
>  ~[ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.ExternalLoginKeysManager.checkJWTLogin(ExternalLoginKeysManager.java:196)
>  ~[ofbiz.jar:?]
>     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[?:1.8.0_152]
>     at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> ~[?:1.8.0_152]
>     at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_152]
>     at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_152]
>     at 
> org.apache.ofbiz.webapp.event.JavaEventHandler.invoke(JavaEventHandler.java:86)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:774)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:407)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:208) 
> [ofbiz.jar:?]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:645) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:750) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:191)
>  [ofbiz.jar:?]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156)
>  [ofbiz.jar:?]
>     at javax.servlet.http.HttpFilter.doFilter(HttpFilter.java:127) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:199)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:490)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:139) 
> [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> 

[jira] [Comment Edited] (OFBIZ-10828) Html escaping missing for portalPageId parameter of Help button

2019-02-03 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759346#comment-16759346
 ] 

Deepak Dixit edited comment on OFBIZ-10828 at 2/3/19 9:41 AM:
--

This has been fixed at 
ofbiz framework trunk at r#1852818
ofbiz framework R18.12 at r#1852819
ofbiz framework R17.12 at r#1852820
R16.11 at r#1852820

 Thanks, Niels Heinen of the Google security team for reporting the issue. 


was (Author: deepak.dixit):
This has been fixed at 
ofbiz framework trunk at r#1852818
ofbiz framework R18.12 at r#1852819
ofbiz framework R17.12 at r#1852820
R16.11 at r#1852820

> Html escaping missing for portalPageId parameter of Help button
> ---
>
> Key: OFBIZ-10828
> URL: https://issues.apache.org/jira/browse/OFBIZ-10828
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, 17.12.01, 16.11.05, 18.12.01
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
>Priority: Major
>
> Html escaping missing on the portalPageId parameter of Help button
> Thanks, Niels Heinen of the Google security team for reporting the issue. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-6154) Add a label element into form widgets

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-6154:

Fix Version/s: (was: 17.12.01)

> Add a label element into form widgets
> -
>
> Key: OFBIZ-6154
> URL: https://issues.apache.org/jira/browse/OFBIZ-6154
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> In Screen widgets we have a specialised label element with a specific 
> behaviour when using h1 to h6 styles.
> The same would be useful in forms to clearly separate blocks. Currently there 
> is only the container type of field but it has no style attribute.
> Maybe only enhancing this container could be considered. But I would rather 
> prefer to have a real container element (at the field level) which would 
> allow to visually include a set of fields. It would also have a title and 
> style.
> And independently we would have a label element with title and style that 
> could be put anywhere in the form.
> This could be then used with the skip-start and skip-end form attributes to 
> easily build complex forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-6322) Widget form: renderFormClose not called when skip-start or skip-end is used

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-6322:

Fix Version/s: (was: 17.12.01)

> Widget form: renderFormClose not called when skip-start or skip-end is used
> ---
>
> Key: OFBIZ-6322
> URL: https://issues.apache.org/jira/browse/OFBIZ-6322
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> renderFormClose is not called when skip-start or skip-end is used, hence 
> jsvalidate is not present



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-6653) Upgrade our jQuery version

2019-02-03 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759355#comment-16759355
 ] 

Deepak Dixit commented on OFBIZ-6653:
-

I think we can close this issue. 
As jquery already updated to 3.2.1 

> Upgrade our jQuery version
> --
>
> Key: OFBIZ-6653
> URL: https://issues.apache.org/jira/browse/OFBIZ-6653
> Project: OFBiz
>  Issue Type: Task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> We currently use jquery-1.11.0.js and with jquery-migrate-1.2.1.js and 
> jquery-ui-1.10.3.js. 
> We should update to jQuery 2 but wer have to agree to let's go the  Internet 
> Explorer 6, 7, or 8 suport. I believe it's now safe to do so.
> Please read https://jquery.com/download/ to know more
> We should also decide if we want to get rid of jquery-migrate-1.2.1.js, which 
> can be used with version 2
> http://blog.jquery.com/2013/05/08/jquery-migrate-1-2-1-released/
> but has a medium vulnerability: selector interpreted as HTML 
> http://bugs.jquery.com/ticket/11290 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-6653) Upgrade our jQuery version

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-6653:

Fix Version/s: (was: 17.12.01)

> Upgrade our jQuery version
> --
>
> Key: OFBIZ-6653
> URL: https://issues.apache.org/jira/browse/OFBIZ-6653
> Project: OFBiz
>  Issue Type: Task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> We currently use jquery-1.11.0.js and with jquery-migrate-1.2.1.js and 
> jquery-ui-1.10.3.js. 
> We should update to jQuery 2 but wer have to agree to let's go the  Internet 
> Explorer 6, 7, or 8 suport. I believe it's now safe to do so.
> Please read https://jquery.com/download/ to know more
> We should also decide if we want to get rid of jquery-migrate-1.2.1.js, which 
> can be used with version 2
> http://blog.jquery.com/2013/05/08/jquery-migrate-1-2-1-released/
> but has a medium vulnerability: selector interpreted as HTML 
> http://bugs.jquery.com/ticket/11290 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7783) External library files are not in the OFBiz folder structure.

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-7783:

Fix Version/s: (was: 17.12.01)

> External library files are not in the OFBiz folder structure.
> -
>
> Key: OFBIZ-7783
> URL: https://issues.apache.org/jira/browse/OFBIZ-7783
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Pierre Smits
>Priority: Minor
>
> With the implementation of the external library download feature of 
> gradle/gradlew, the external libraries (jar files) are not in the folder 
> structure any more. 
> They should reside there, like before.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9490) Update UtilMisc.formatRuleBasedAmount() method to take rules and ruleSet and formatting can be done, rather than system providing all ruleset support.

2019-02-03 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759363#comment-16759363
 ] 

Deepak Dixit commented on OFBIZ-9490:
-

Hi [~arunpati],

Could you please have a look? 
I think we can close this issue.

> Update UtilMisc.formatRuleBasedAmount() method to take rules and ruleSet and 
> formatting can be done, rather than system providing all ruleset support.
> --
>
> Key: OFBIZ-9490
> URL: https://issues.apache.org/jira/browse/OFBIZ-9490
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: 16.11.03
>Reporter: Pradhan Yash Sharma
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: 17.12.01
>
> Attachments: OFBIZ-9490.patch, OFBIZ_9490.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7112) EntityUtilProperties

2019-02-03 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759366#comment-16759366
 ] 

Deepak Dixit commented on OFBIZ-7112:
-

I think we can close this task?

> EntityUtilProperties
> 
>
> Key: OFBIZ-7112
> URL: https://issues.apache.org/jira/browse/OFBIZ-7112
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Wai
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: OFBIZ-7112.patch, OFBIZ-7112.patch, OFBIZ-7112.patch, 
> OFBIZ-7112.patch, OFBIZ-7112.patch
>
>
> Ofbiz reads properties from either a properties file or the 
> entity:SystemProperty. The way it works previously is that ofbiz reads from 
> the entity:SystemProperty first and if there is no value associated with the 
> target propertyname, it would then locate the value from the relevant 
> properties file.
> In other words, if there is a database entry for a property, the database 
> entry should override the associated properties file.
> The issue is that if a database entry exist but the value is empty, it would 
> look for a value from the properties file.  It should not do so.  If a 
> database entry exists for the propertyname of interest, the value should be 
> taken from the database even if it holds an empty value.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9254) Inconsistent String Comparisons

2019-02-03 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759367#comment-16759367
 ] 

Deepak Dixit commented on OFBIZ-9254:
-

[~devanshu.vyas], Any update on this?

> Inconsistent String Comparisons
> ---
>
> Key: OFBIZ-9254
> URL: https://issues.apache.org/jira/browse/OFBIZ-9254
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Devanshu Vyas
>Priority: Minor
> Fix For: 17.12.01
>
> Attachments: OFBIZ-9251_ftl_accounting.patch, 
> OFBIZ-9251_ftl_framework.patch, OFBIZ-9251_ftl_manuf_workeffrt.patch, 
> OFBIZ-9251_ftl_order.patch, OFBIZ-9251_ftl_party_content.patch, 
> OFBIZ-9251_ftl_plugins_ebay_ebaystore.patch, 
> OFBIZ-9251_ftl_plugins_ecommerce.patch, 
> OFBIZ-9251_ftl_plugins_pricat_projmgr.patch, OFBIZ-9251_ftl_product.patch, 
> OFBIZ-9251_ftl_themes.patch, OFBIZ-9254_FTL-I.patch, 
> OFBIZ-9254_groovy_applications.patch, OFBIZ-9254_groovy_framework.patch, 
> OFBIZ-9254_java_Party_WE_MFC.patch, OFBIZ-9254_java_accounting.patch, 
> OFBIZ-9254_java_base.patch, OFBIZ-9254_java_content.patch, 
> OFBIZ-9254_java_entity.patch, OFBIZ-9254_java_order.patch, 
> OFBIZ-9254_java_product.patch, OFBIZ-9254_java_service.patch, 
> OFBIZ-9254_java_test_entityext_common_cattalina_datafile.patch, 
> OFBIZ-9254_java_webapp.patch, OFBIZ-9254_java_webtools.patch, 
> OFBIZ-9254_java_widget.patch, OFBIZ-9254_plugins_groovy.patch, 
> OFBIZ-9254_plugins_java.patch
>
>
> I found an inconsistency in the code for string comparison 
> statusId.equals("PRUN_COMPLETED") whereas it should be written as 
> "PRUN_COMPLETED".equals(statusId) 
> cause the former can throw NullPointerException if the variable found to be 
> NULL.
> This pattern should be applied to 
> - Java Files
> - Groovy Files
> - FTL Files
> Here is the reference for the discussion done on the dev list.
> http://markmail.org/message/iqfaab3fl3ukxchy



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-6712) Increase the number of EntityUtilProperties methods which really use getSystemPropertyValue()

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-6712:

Fix Version/s: (was: 17.12.01)

> Increase the number of EntityUtilProperties methods which really use 
> getSystemPropertyValue()
> -
>
> Key: OFBIZ-6712
> URL: https://issues.apache.org/jira/browse/OFBIZ-6712
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> Currently a number of EntityUtilProperties methods, notably  
> getPropertyNumber, 
> getPropertyAsBoolean/Integer/Long/Float/Double/BigInteger/BigDecimal, 
> propertyValueEquals (but not propertyValueEqualsIgnoreCase), etc. don't rely 
> on getSystemPropertyValue
> Note that getProperties methods are already covered by OFBIZ-6675
> If that would be done we could deprecate and ultimately replace 
> UtilProperties by EntityUtilProperties



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-8173) Improve labels descriptions where better in data files.

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-8173:

Fix Version/s: (was: 17.12.01)

> Improve labels descriptions where better in data files. 
> 
>
> Key: OFBIZ-8173
> URL: https://issues.apache.org/jira/browse/OFBIZ-8173
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Trivial
>
> There are sometimes better English labels descriptions in data files. They 
> should be used in labels and translations,



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10828) Html escaping missing for portalPageId parameter of Help button

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit closed OFBIZ-10828.

   Resolution: Fixed
Fix Version/s: 16.11.06

> Html escaping missing for portalPageId parameter of Help button
> ---
>
> Key: OFBIZ-10828
> URL: https://issues.apache.org/jira/browse/OFBIZ-10828
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, 17.12.01, 16.11.05, 18.12.01
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
>Priority: Major
> Fix For: 16.11.06
>
>
> Html escaping missing on the portalPageId parameter of Help button
> Thanks, Niels Heinen of the Google security team for reporting the issue. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10828) Html escaping missing for portalPageId parameter of Help button

2019-02-03 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759346#comment-16759346
 ] 

Deepak Dixit commented on OFBIZ-10828:
--

This has been fixed at 
ofbiz framework trunk at r#1852818
ofbiz framework R18.12 at r#1852819
ofbiz framework R17.12 at r#1852820
R16.11 at r#1852820

> Html escaping missing for portalPageId parameter of Help button
> ---
>
> Key: OFBIZ-10828
> URL: https://issues.apache.org/jira/browse/OFBIZ-10828
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, 17.12.01, 16.11.05, 18.12.01
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
>Priority: Major
>
> Html escaping missing on the portalPageId parameter of Help button
> Thanks, Niels Heinen of the Google security team for reporting the issue. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10828) Html escaping missing for portalPageId parameter of Help button

2019-02-03 Thread Deepak Dixit (JIRA)
Deepak Dixit created OFBIZ-10828:


 Summary: Html escaping missing for portalPageId parameter of Help 
button
 Key: OFBIZ-10828
 URL: https://issues.apache.org/jira/browse/OFBIZ-10828
 Project: OFBiz
  Issue Type: Bug
Affects Versions: 16.11.05, Trunk, 17.12.01, 18.12.01
Reporter: Deepak Dixit
Assignee: Deepak Dixit


Html escaping missing on the portalPageId parameter of Help button
Thanks, Niels Heinen of the Google security team for reporting the issue. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10814) Error parsing JWT

2019-02-03 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759348#comment-16759348
 ] 

Deepak Dixit commented on OFBIZ-10814:
--

Michael, 

Patch looks good, I think you can commit it. 


> Error parsing JWT
> -
>
> Key: OFBIZ-10814
> URL: https://issues.apache.org/jira/browse/OFBIZ-10814
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Major
> Attachments: Apache OFBiz JWT Test.postman_collection.json, 
> OFBIZ-10814_JWT_parsing_error_and_refactoring.patch, 
> OFBIZ-10814_JWT_parsing_error_examples.patch
>
>
> I have problems using the Authorization: Bearer header value for requests 
> towards OFBiz. OFBiz has problems parsing externally generated JSON Web 
> Tokens.
> I have generated them using both [1] and [2] using HS512 and the default 
> secret.
> The JWT check fails because of a parsing error:
> {noformat}
> 2019-01-17 16:48:36,233 |jsse-nio-8443-exec-7 |JavaEventHandler  
> |E| Problems Processing Event
> io.jsonwebtoken.MalformedJwtException: Unable to read JSON value: 
> �z��'G�#�$�uB"�&�r#�$�3S"
>     at 
> io.jsonwebtoken.impl.DefaultJwtParser.readValue(DefaultJwtParser.java:554) 
> ~[jjwt-0.9.1.jar:0.9.1]
>     at io.jsonwebtoken.impl.DefaultJwtParser.parse(DefaultJwtParser.java:252) 
> ~[jjwt-0.9.1.jar:0.9.1]
>     at io.jsonwebtoken.impl.DefaultJwtParser.parse(DefaultJwtParser.java:481) 
> ~[jjwt-0.9.1.jar:0.9.1]
>     at 
> io.jsonwebtoken.impl.DefaultJwtParser.parseClaimsJws(DefaultJwtParser.java:541)
>  ~[jjwt-0.9.1.jar:0.9.1]
>     at 
> org.apache.ofbiz.webapp.control.JWTManager.validateToken(JWTManager.java:124) 
> ~[ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.ExternalLoginKeysManager.jwtValidation(ExternalLoginKeysManager.java:292)
>  ~[ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.ExternalLoginKeysManager.checkJWTLogin(ExternalLoginKeysManager.java:196)
>  ~[ofbiz.jar:?]
>     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[?:1.8.0_152]
>     at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> ~[?:1.8.0_152]
>     at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_152]
>     at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_152]
>     at 
> org.apache.ofbiz.webapp.event.JavaEventHandler.invoke(JavaEventHandler.java:86)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:774)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:407)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:208) 
> [ofbiz.jar:?]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:645) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:750) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:191)
>  [ofbiz.jar:?]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156)
>  [ofbiz.jar:?]
>     at javax.servlet.http.HttpFilter.doFilter(HttpFilter.java:127) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:199)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:490)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:139) 
> [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> 

[jira] [Updated] (OFBIZ-9293) Review and possibly refactor code (not only Java, but mostly) in the ebaystore component

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-9293:

Fix Version/s: (was: 17.12.01)

> Review and possibly refactor code (not only Java, but mostly) in the 
> ebaystore component
> 
>
> Key: OFBIZ-9293
> URL: https://issues.apache.org/jira/browse/OFBIZ-9293
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ebaystore
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> While working on another issue, I noticed the ebaystore component code needs 
> some love...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9926) The online help contains 2 Tables of Contents

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-9926:

Fix Version/s: (was: 17.12.01)

> The online help contains 2 Tables of Contents
> -
>
> Key: OFBIZ-9926
> URL: https://issues.apache.org/jira/browse/OFBIZ-9926
> Project: OFBiz
>  Issue Type: Improvement
>  Components: cmssite
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Trivial
>
> See https://demo-trunk.ofbiz.apache.org/cmssite/cms/APACHE_OFBIZ_HTML



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-6358) Currently a field focus is not possible when using ajax-window links

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-6358:

Fix Version/s: (was: 17.12.01)

> Currently a field focus is not possible when using ajax-window links
> 
>
> Key: OFBIZ-6358
> URL: https://issues.apache.org/jira/browse/OFBIZ-6358
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Attachments: setFocusJs.ftl
>
>
> I want to handle the focus on field when usin ajax-window links in screen 
> widget (this does not exist in form) but it needs more work. For now, as a 
> workaround, I use the attached setFocusJs.ftl and pass a parameter 
> focusFieldName where necessary. Later I hope to create a field-focus 
> attribute to the link element, else I will maybe commit the attached file in 
> common...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-6695) Enhance auto-fields-entity and auto-fields-service to generate required fields on PK ones

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-6695:

Fix Version/s: (was: 17.12.01)

> Enhance auto-fields-entity and auto-fields-service to generate required 
> fields on PK ones
> -
>
> Key: OFBIZ-6695
> URL: https://issues.apache.org/jira/browse/OFBIZ-6695
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> This is an improvement. It seems it should be done starting from 
> induceFieldInfoFromEntityField() method



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9149) The replacement of form widget of type list by grid missed the case of use inside field

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-9149:

Fix Version/s: (was: 17.12.01)

> The replacement of form widget of type list by grid missed the case of use 
> inside field
> ---
>
> Key: OFBIZ-9149
> URL: https://issues.apache.org/jira/browse/OFBIZ-9149
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> I spotted that while working on OFBIZ-9146. 
> You get an error when you try to use a grid inside a field using 
> include-form. 
> So we lack an include-grid inside field.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7473) Induce Model XML from Database throws exception

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-7473:

Fix Version/s: (was: 17.12.01)

> Induce Model XML from Database throws exception
> ---
>
> Key: OFBIZ-7473
> URL: https://issues.apache.org/jira/browse/OFBIZ-7473
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Gopal Yadav
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-7473.patch
>
>
> Go to Webtools -> Import/Export -> Induce Model XML from Database 
> (https://localhost:8443/webtools/control/view/ModelInduceFromDb)
> An exception is thrown: javax.servlet.ServletException: File 
> [/entity/ModelInduceFromDb.jsp] not found.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10156) Fix issues related to images paths

2019-02-03 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759361#comment-16759361
 ] 

Deepak Dixit edited comment on OFBIZ-10156 at 2/3/19 10:52 AM:
---

Hi [~jacques.le.roux],

>>Also not sure why FOP complains (both locally and on trunk demo) about 
>>table-layout="auto", it's not used in any files, creasy stuff!

If you are using fo:table without specifying table-layout it will be considered 
as "auto"

There is an issue with table-layout="auto".
This is known issue https://xmlgraphics.apache.org/fop/knownissues.html
Here is the reference link for the same 
https://issues.apache.org/jira/browse/FOP-2469

>>|E| Image not found. URI: /images/ofbiz_logo.png. (See position 37:54)
This is not an issue, CompanyHeader.fo.ftl using ofbizContentUrl to prepare the 
image url. 
We need to set the content.url.prefix.secure/content.url.prefix.standard in 
url.properties to work in properly. 

I think we can close this issue. 


was (Author: deepak.dixit):
Hi [~jacques.le.roux],

>>Also not sure why FOP complains (both locally and on trunk demo) about 
>>table-layout="auto", it's not used in any files, creasy stuff!

If you are using fo:table without specifying table-layout it will be conder as 
"auto"

There is an issue with table-layout="auto".
This is know issue https://xmlgraphics.apache.org/fop/knownissues.html
Here is the reference link for the same 
https://issues.apache.org/jira/browse/FOP-2469

>>|E| Image not found. URI: /images/ofbiz_logo.png. (See position 37:54)
This is not an issue, CompanyHeader.fo.ftl using ofbizContentUrl to prepare the 
image url. We need to set the content.url.prefix.secure in url.properties to 
work in properly. 

I think we can close this issue. 

> Fix issues related to images paths
> --
>
> Key: OFBIZ-10156
> URL: https://issues.apache.org/jira/browse/OFBIZ-10156
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01
>
>
> While working on OFBIZ-10128 I stumbled upon this issue  found on trunk demo
> {code}
> 2018-01-11 09:35:08,370 |ajp-nio-8009-exec-8  |FOUserAgent   
> |E| Image not found. URI: /images/ofbiz_logo.png. (See position 37:54)
> 2018-01-11 09:35:08,603 |ajp-nio-8009-exec-8  |FOUserAgent   
> |E| Image not found. URI: /images/ofbiz_logo.png. (No context info available)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-8057) Automate the creation of several artifacts using BuildBot

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-8057:

Fix Version/s: (was: 17.12.01)

> Automate the creation of several artifacts using BuildBot 
> --
>
> Key: OFBIZ-8057
> URL: https://issues.apache.org/jira/browse/OFBIZ-8057
> Project: OFBiz
>  Issue Type: Task
>  Components: BuildBot
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> There are several artifacts which are manually generated.We should automate 
> this process using BuildBot like we have already JavaDoc and Rat reports, are 
> concerned so far
> * DTDs
> * the README.md.html, which needs Pandoc installed on BuildBot then



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7249) Error on removing scrum members

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-7249:

Fix Version/s: (was: 17.12.01)

> Error on removing scrum members
> ---
>
> Key: OFBIZ-7249
> URL: https://issues.apache.org/jira/browse/OFBIZ-7249
> Project: OFBiz
>  Issue Type: Bug
>  Components: scrum
>Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12
>Reporter: Anurag Chandak
>Priority: Major
> Attachments: OFBIZ-7249.patch
>
>
> Steps to regenerate:
> - Go to Scrum --> Administration --> Scrum Members
> - Try to remove only those scrum members whose party and role type are 
> similar to product members
> - The following error is shown:
> {code}
> The Following Errors Occurred:
> Error:Error doing entity-auto operation for entity PartyRole in service 
> deletePartyRole: org.ofbiz.entity.GenericEntityException: 
> org.ofbiz.entity.GenericDataSourceException: Exception while deleting the 
> following entity: 
> [GenericEntity:PartyRole][partyId,SCRUMASTER(java.lang.String)][roleTypeId,SCRUM_MASTER(java.lang.String)]
>  (SQL Exception while executing the following:DELETE FROM OFBIZ.PARTY_ROLE 
> WHERE PARTY_ID=? AND ROLE_TYPE_ID=? (DELETE on table 'PARTY_ROLE' caused a 
> violation of foreign key constraint 'PROD_RLE_PTYRLE' for key 
> (SCRUMASTER,SCRUM_MASTER). The statement has been rolled back.)) (Exception 
> while deleting the following entity: 
> [GenericEntity:PartyRole][partyId,SCRUMASTER(java.lang.String)][roleTypeId,SCRUM_MASTER(java.lang.String)]
>  (SQL Exception while executing the following:DELETE FROM OFBIZ.PARTY_ROLE 
> WHERE PARTY_ID=? AND ROLE_TYPE_ID=? (DELETE on table 'PARTY_ROLE' caused a 
> violation of foreign key constraint 'PROD_RLE_PTYRLE' for key 
> (SCRUMASTER,SCRUM_MASTER). The statement has been rolled back.)))
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10814) Error parsing JWT

2019-02-03 Thread Michael Brohl (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759345#comment-16759345
 ] 

Michael Brohl commented on OFBIZ-10814:
---

{quote}Should we not use HttpHeaders.AUTHORIZATION in JWTManager::checkJWTLogin?
{quote}
Do you use the right patch? I think that I've used it instead of a string value.
{quote}Also, please add a new line at the end of security.properties, it's else 
sometimes difficult to read (got issue in Eclipse Photon)
{quote}
What do you mean? What is the issue?

> Error parsing JWT
> -
>
> Key: OFBIZ-10814
> URL: https://issues.apache.org/jira/browse/OFBIZ-10814
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Major
> Attachments: Apache OFBiz JWT Test.postman_collection.json, 
> OFBIZ-10814_JWT_parsing_error.patch, 
> OFBIZ-10814_JWT_parsing_error_and_refactoring.patch, 
> OFBIZ-10814_JWT_parsing_error_examples.patch
>
>
> I have problems using the Authorization: Bearer header value for requests 
> towards OFBiz. OFBiz has problems parsing externally generated JSON Web 
> Tokens.
> I have generated them using both [1] and [2] using HS512 and the default 
> secret.
> The JWT check fails because of a parsing error:
> {noformat}
> 2019-01-17 16:48:36,233 |jsse-nio-8443-exec-7 |JavaEventHandler  
> |E| Problems Processing Event
> io.jsonwebtoken.MalformedJwtException: Unable to read JSON value: 
> �z��'G�#�$�uB"�&�r#�$�3S"
>     at 
> io.jsonwebtoken.impl.DefaultJwtParser.readValue(DefaultJwtParser.java:554) 
> ~[jjwt-0.9.1.jar:0.9.1]
>     at io.jsonwebtoken.impl.DefaultJwtParser.parse(DefaultJwtParser.java:252) 
> ~[jjwt-0.9.1.jar:0.9.1]
>     at io.jsonwebtoken.impl.DefaultJwtParser.parse(DefaultJwtParser.java:481) 
> ~[jjwt-0.9.1.jar:0.9.1]
>     at 
> io.jsonwebtoken.impl.DefaultJwtParser.parseClaimsJws(DefaultJwtParser.java:541)
>  ~[jjwt-0.9.1.jar:0.9.1]
>     at 
> org.apache.ofbiz.webapp.control.JWTManager.validateToken(JWTManager.java:124) 
> ~[ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.ExternalLoginKeysManager.jwtValidation(ExternalLoginKeysManager.java:292)
>  ~[ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.ExternalLoginKeysManager.checkJWTLogin(ExternalLoginKeysManager.java:196)
>  ~[ofbiz.jar:?]
>     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[?:1.8.0_152]
>     at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> ~[?:1.8.0_152]
>     at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_152]
>     at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_152]
>     at 
> org.apache.ofbiz.webapp.event.JavaEventHandler.invoke(JavaEventHandler.java:86)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:774)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:407)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:208) 
> [ofbiz.jar:?]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:645) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:750) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:191)
>  [ofbiz.jar:?]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156)
>  [ofbiz.jar:?]
>     at javax.servlet.http.HttpFilter.doFilter(HttpFilter.java:127) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:199)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)

[jira] [Updated] (OFBIZ-10221) Improve layout and structure of forms

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-10221:
-
Fix Version/s: (was: 17.12.01)

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Attachments: OFBIZ-10221-product.template.Main.patch, 
> OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7473) Induce Model XML from Database throws exception

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-7473:

Affects Version/s: 17.12.01

> Induce Model XML from Database throws exception
> ---
>
> Key: OFBIZ-7473
> URL: https://issues.apache.org/jira/browse/OFBIZ-7473
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk, 17.12.01
>Reporter: Gopal Yadav
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-7473.patch
>
>
> Go to Webtools -> Import/Export -> Induce Model XML from Database 
> (https://localhost:8443/webtools/control/view/ModelInduceFromDb)
> An exception is thrown: javax.servlet.ServletException: File 
> [/entity/ModelInduceFromDb.jsp] not found.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-6723) With the introduction of jGrowl to show notifications the WebtoolsLayoutDemo screen is ambiguous

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-6723:

Fix Version/s: (was: 17.12.01)

> With the introduction of jGrowl to show notifications the WebtoolsLayoutDemo 
> screen is ambiguous
> 
>
> Key: OFBIZ-6723
> URL: https://issues.apache.org/jira/browse/OFBIZ-6723
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Trivial
> Attachments: Image 081.png
>
>
> Before it was less obvious because part of the screen but now it's annoying 
> since it seems to show errors when it's actually demonstrating features



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9241) Removes ecommerce links from applications

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-9241:

Fix Version/s: (was: 17.12.01)

> Removes ecommerce links from applications
> -
>
> Key: OFBIZ-9241
> URL: https://issues.apache.org/jira/browse/OFBIZ-9241
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-9241.patch, OFBIZ-9241.patch, OFBIZ-9241.patch
>
>
> While working on OFBIZ-9206 I remembered how the ecommerce webapp is deeply 
> entrenched in some applications components. This can at least be tested with 
> product and catalog webapp.
> # Get to catalog/control/EditProduct?productId=GZ-1000
> # Click on the "Product Page" button => ecommerce
> There are much more cases (96 occurrences actually) but most of them are not 
> hard dependencies. 
> Since the ecommerce component is now a plugin, we need to remove all 
> ecommerce links from applications, I even wonder if this issue is really an 
> improvement or should not be now considered a bug...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10134) [Refactoring] Package org.apache.ofbiz.product.category

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-10134:
-
Fix Version/s: (was: 17.12.01)

> [Refactoring] Package org.apache.ofbiz.product.category
> ---
>
> Key: OFBIZ-10134
> URL: https://issues.apache.org/jira/browse/OFBIZ-10134
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Priority: Minor
> Attachments: 
> OFBIZ-10134_org.apache.ofbiz.product.category.CatalogUrlDirective_refactoring.patch,
>  
> OFBIZ-10134_org.apache.ofbiz.product.category.CatalogUrlFilter_refactoring.patch,
>  
> OFBIZ-10134_org.apache.ofbiz.product.category.CatalogUrlServlet_refactoring.patch,
>  
> OFBIZ-10134_org.apache.ofbiz.product.category.CategoryContentWrapper_refactoring.patch,
>  
> OFBIZ-10134_org.apache.ofbiz.product.category.CategoryServices_refactoring.patch,
>  
> OFBIZ-10134_org.apache.ofbiz.product.category.CategoryWorker_refactoring.patch,
>  
> OFBIZ-10134_org.apache.ofbiz.product.category.SeoCatalogUrlServlet_refactoring.patch,
>  
> OFBIZ-10134_org.apache.ofbiz.product.category.SeoConfigUtil_refactoring.patch,
>  
> OFBIZ-10134_org.apache.ofbiz.product.category.SeoContextFilter_refactoring.patch,
>  
> OFBIZ-10134_org.apache.ofbiz.product.category.SeoControlServlet_refactoring.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9088) Unit test case for service - addProductCategoryToCategory

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-9088:

Fix Version/s: (was: 17.12.01)

> Unit test case for service - addProductCategoryToCategory
> -
>
> Key: OFBIZ-9088
> URL: https://issues.apache.org/jira/browse/OFBIZ-9088
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Attachments: OFBIZ-9088.patch
>
>
> Unit test case for service - addProductCategoryToCategory



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-8042) Clean up commented out code in Java source for Webapp component

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-8042:

Fix Version/s: (was: 17.12.01)

> Clean up commented out code in Java source for Webapp component
> ---
>
> Key: OFBIZ-8042
> URL: https://issues.apache.org/jira/browse/OFBIZ-8042
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Reporter: Harsh Vijaywargiya
>Assignee: Harsh Vijaywargiya
>Priority: Minor
>
> Clean up commented out code in Java source for Webapp component



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-6881) Rainbow Stone theme improvements

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-6881:

Fix Version/s: (was: 17.12.01)

> Rainbow Stone theme improvements
> 
>
> Key: OFBIZ-6881
> URL: https://issues.apache.org/jira/browse/OFBIZ-6881
> Project: OFBiz
>  Issue Type: Improvement
>  Components: themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Attachments: MenuFirstProposal.png, OFBIZ-6881.patch
>
>
> These are some points I think are worth to be reported even if they will not 
> all  be taken in account.
> # Theme colorization to avoid themes duplication (this also applies to 
> Bootstrap themes)
> # Where are shown the "Last system notes"?
> # -Remove Julien's avatar from the theme images provided (in the list of 
> themes to choose).-
> # Is there a way for users to set their own avatar?
> #  how can contributors from countries with missing flags propose their 
> countries flag? Note: for some languages nothing appears (like ES or NL).
> # I like how menus are handled in Boostrap theme, could we use the same in  
> Rainbow?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-8043) Clean up commented out code in Java source for Webtools component

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-8043:

Fix Version/s: (was: 17.12.01)

> Clean up commented out code in Java source for Webtools component
> -
>
> Key: OFBIZ-8043
> URL: https://issues.apache.org/jira/browse/OFBIZ-8043
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Reporter: Harsh Vijaywargiya
>Assignee: Harsh Vijaywargiya
>Priority: Minor
>
> Clean up commented out code in Java source for Webtools component



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-8041) Clean up commented out code in Java source for Security component

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-8041:

Fix Version/s: (was: 17.12.01)

> Clean up commented out code in Java source for Security component
> -
>
> Key: OFBIZ-8041
> URL: https://issues.apache.org/jira/browse/OFBIZ-8041
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Reporter: Harsh Vijaywargiya
>Assignee: Harsh Vijaywargiya
>Priority: Minor
>
> Clean up commented out code in Java source for Security component



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7217) Filter ProductFeatureAndAppl by date

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-7217:

Fix Version/s: (was: 17.12.01)

> Filter ProductFeatureAndAppl by date
> 
>
> Key: OFBIZ-7217
> URL: https://issues.apache.org/jira/browse/OFBIZ-7217
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12
>Reporter: Anurag Chandak
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7775) Cleanup JavaDocs to be standards compliant

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-7775:

Fix Version/s: (was: 17.12.01)

> Cleanup JavaDocs to be standards compliant
> --
>
> Key: OFBIZ-7775
> URL: https://issues.apache.org/jira/browse/OFBIZ-7775
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Major
> Attachments: 
> OFBIZ-7775_Remove-useless-overidden-JavaMailContainer-jav.patch
>
>
> To check what to fix simply run gradlew javadoc



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7927) Separate the CountryAddressFormat from the general GeoData.xml file

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-7927:

Fix Version/s: (was: 17.12.01)

> Separate the CountryAddressFormat from the general GeoData.xml file
> ---
>
> Key: OFBIZ-7927
> URL: https://issues.apache.org/jira/browse/OFBIZ-7927
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Major
>
> At OFBIZ-6476, [~pfm.smits] suggested:
> bq. Shouldn't it be better to have that in a country specific GeoData xml 
> file? That way people can opt to include or not...
> I agreed but did not went further. This issue to not forget and do the job 
> when possible...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10595) The query iCalendar/CALENDAR_PUB_DEMO/ no longer works

2019-02-03 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759360#comment-16759360
 ] 

Jacques Le Roux commented on OFBIZ-10595:
-

Hi Jyri,

Could you please confirm 1st that it works on a trunk instance?
If it does I'll need more help (exact steps to follow). I'm not used to 
iCalendar usage and I think I miss something. It will also help possible users 
refering to this Jira to follow the right steps (for now you have to use the 
user ML thread referenced in desctiption).
Note that the demo calendar appears in the trunk demo.

After creating a new iCalendar, putting a related recurrent event in OFBiz, 
publishing in Thunderbir and syncing the calendar I was asked for a credential 
(or was it when publishing?). But I don't see the events appear in Thunderbird. 
There are no errors in code, and debugging seems to work fine.

When you say
bq. Try to create new calendar event and you will receive the error An error 
occurred when writing to the calendar (it will not even ask username and 
password).
It's in OFBiz right?

> The query iCalendar/CALENDAR_PUB_DEMO/ no longer works
> --
>
> Key: OFBIZ-10595
> URL: https://issues.apache.org/jira/browse/OFBIZ-10595
> Project: OFBiz
>  Issue Type: Bug
>  Components: workeffort
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 16.11.06
>
> Attachments: iCalendar.patch, iCalendar.patch
>
>
> ControlFilter does not allow the untypical iCalendar/CALENDAR_PUB_DEMO/ query 
> to pass.
> This feature works in the stable version. So it's a change since then
> Thanks to Jyri Sillanpaa for the detailled report: 
> https://markmail.org/message/pfd62nom3ftnpgll



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10156) Fix issues related to images paths

2019-02-03 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759361#comment-16759361
 ] 

Deepak Dixit commented on OFBIZ-10156:
--

Hi [~jacques.le.roux],

>>Also not sure why FOP complains (both locally and on trunk demo) about 
>>table-layout="auto", it's not used in any files, creasy stuff!

If you are using fo:table without specifying table-layout it will be conder as 
"auto"

There is an issue with table-layout="auto".
This is know issue https://xmlgraphics.apache.org/fop/knownissues.html
Here is the reference link for the same 
https://issues.apache.org/jira/browse/FOP-2469

>>|E| Image not found. URI: /images/ofbiz_logo.png. (See position 37:54)
This is not an issue, CompanyHeader.fo.ftl using ofbizContentUrl to prepare the 
image url. We need to set the content.url.prefix.secure in url.properties to 
work in properly. 

I think we can close this issue. 

> Fix issues related to images paths
> --
>
> Key: OFBIZ-10156
> URL: https://issues.apache.org/jira/browse/OFBIZ-10156
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01
>
>
> While working on OFBIZ-10128 I stumbled upon this issue  found on trunk demo
> {code}
> 2018-01-11 09:35:08,370 |ajp-nio-8009-exec-8  |FOUserAgent   
> |E| Image not found. URI: /images/ofbiz_logo.png. (See position 37:54)
> 2018-01-11 09:35:08,603 |ajp-nio-8009-exec-8  |FOUserAgent   
> |E| Image not found. URI: /images/ofbiz_logo.png. (No context info available)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9090) Unit test case for service - createProductConfigOption

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-9090:

Fix Version/s: (was: 17.12.01)

> Unit test case for service - createProductConfigOption
> --
>
> Key: OFBIZ-9090
> URL: https://issues.apache.org/jira/browse/OFBIZ-9090
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Attachments: OFBIZ-9090.patch
>
>
> Unit test case for service - createProductConfigOption



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9283) Remove code dependencies from application (at least product) to plugins (at least ecommerce)

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-9283:

Fix Version/s: (was: 17.12.01)

> Remove code dependencies from application (at least product) to plugins (at 
> least ecommerce)
> 
>
> Key: OFBIZ-9283
> URL: https://issues.apache.org/jira/browse/OFBIZ-9283
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ecommerce, product
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Major
>
> Some applications have still references in code to plugins. I think it's only 
> product to ecommerce but could be more...
> I did not try but I guess if you use only the framework (w/o plugins) and try 
> the link in the catalog/control/EditProduct screen which leads to ecommerce 
> ("Product Page") you will get an error, so it's a bug!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-6986) Simplify getChildHRCategoryTree

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-6986:

Fix Version/s: (was: 17.12.01)

> Simplify getChildHRCategoryTree
> ---
>
> Key: OFBIZ-6986
> URL: https://issues.apache.org/jira/browse/OFBIZ-6986
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, humanres
>Reporter: Kulwant
>Priority: Major
> Attachments: OFBIZ-6986.patch, OFBIZ-6986.patch, OFBIZ-6986.patch
>
>
> breaking the single long method to multiple private functions with improved 
> exception handling.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-6874) Move all crud service definitions from the applications components into a separate one

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-6874:

Fix Version/s: (was: 17.12.01)

> Move all crud service definitions from the applications components into a 
> separate one
> --
>
> Key: OFBIZ-6874
> URL: https://issues.apache.org/jira/browse/OFBIZ-6874
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Major
>  Labels: crud
>
> Related to issue OFBIZ-6760, we need move all crud services present on 
> application to the data-model component.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10814) Error parsing JWT

2019-02-03 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759368#comment-16759368
 ] 

Jacques Le Roux commented on OFBIZ-10814:
-

Michael,

Right, after finishing my review, I stumbled upon this line
bq. -String authorizationHeader = request.getHeader("Authorization");
Too fast, did not see it was removed :/

For "a new line at the end of security.properties" here a screen copy (maybe 
it's because I use a dark theme?) !Image 002.png! 

> Error parsing JWT
> -
>
> Key: OFBIZ-10814
> URL: https://issues.apache.org/jira/browse/OFBIZ-10814
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Major
> Attachments: Apache OFBiz JWT Test.postman_collection.json, Image 
> 002.png, OFBIZ-10814_JWT_parsing_error_and_refactoring.patch, 
> OFBIZ-10814_JWT_parsing_error_examples.patch
>
>
> I have problems using the Authorization: Bearer header value for requests 
> towards OFBiz. OFBiz has problems parsing externally generated JSON Web 
> Tokens.
> I have generated them using both [1] and [2] using HS512 and the default 
> secret.
> The JWT check fails because of a parsing error:
> {noformat}
> 2019-01-17 16:48:36,233 |jsse-nio-8443-exec-7 |JavaEventHandler  
> |E| Problems Processing Event
> io.jsonwebtoken.MalformedJwtException: Unable to read JSON value: 
> �z��'G�#�$�uB"�&�r#�$�3S"
>     at 
> io.jsonwebtoken.impl.DefaultJwtParser.readValue(DefaultJwtParser.java:554) 
> ~[jjwt-0.9.1.jar:0.9.1]
>     at io.jsonwebtoken.impl.DefaultJwtParser.parse(DefaultJwtParser.java:252) 
> ~[jjwt-0.9.1.jar:0.9.1]
>     at io.jsonwebtoken.impl.DefaultJwtParser.parse(DefaultJwtParser.java:481) 
> ~[jjwt-0.9.1.jar:0.9.1]
>     at 
> io.jsonwebtoken.impl.DefaultJwtParser.parseClaimsJws(DefaultJwtParser.java:541)
>  ~[jjwt-0.9.1.jar:0.9.1]
>     at 
> org.apache.ofbiz.webapp.control.JWTManager.validateToken(JWTManager.java:124) 
> ~[ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.ExternalLoginKeysManager.jwtValidation(ExternalLoginKeysManager.java:292)
>  ~[ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.ExternalLoginKeysManager.checkJWTLogin(ExternalLoginKeysManager.java:196)
>  ~[ofbiz.jar:?]
>     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[?:1.8.0_152]
>     at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> ~[?:1.8.0_152]
>     at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_152]
>     at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_152]
>     at 
> org.apache.ofbiz.webapp.event.JavaEventHandler.invoke(JavaEventHandler.java:86)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:774)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:407)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:208) 
> [ofbiz.jar:?]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:645) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:750) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:191)
>  [ofbiz.jar:?]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156)
>  [ofbiz.jar:?]
>     at javax.servlet.http.HttpFilter.doFilter(HttpFilter.java:127) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:199)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> 

[jira] [Updated] (OFBIZ-10814) Error parsing JWT

2019-02-03 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10814:

Attachment: Image 002.png

> Error parsing JWT
> -
>
> Key: OFBIZ-10814
> URL: https://issues.apache.org/jira/browse/OFBIZ-10814
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Major
> Attachments: Apache OFBiz JWT Test.postman_collection.json, Image 
> 002.png, OFBIZ-10814_JWT_parsing_error_and_refactoring.patch, 
> OFBIZ-10814_JWT_parsing_error_examples.patch
>
>
> I have problems using the Authorization: Bearer header value for requests 
> towards OFBiz. OFBiz has problems parsing externally generated JSON Web 
> Tokens.
> I have generated them using both [1] and [2] using HS512 and the default 
> secret.
> The JWT check fails because of a parsing error:
> {noformat}
> 2019-01-17 16:48:36,233 |jsse-nio-8443-exec-7 |JavaEventHandler  
> |E| Problems Processing Event
> io.jsonwebtoken.MalformedJwtException: Unable to read JSON value: 
> �z��'G�#�$�uB"�&�r#�$�3S"
>     at 
> io.jsonwebtoken.impl.DefaultJwtParser.readValue(DefaultJwtParser.java:554) 
> ~[jjwt-0.9.1.jar:0.9.1]
>     at io.jsonwebtoken.impl.DefaultJwtParser.parse(DefaultJwtParser.java:252) 
> ~[jjwt-0.9.1.jar:0.9.1]
>     at io.jsonwebtoken.impl.DefaultJwtParser.parse(DefaultJwtParser.java:481) 
> ~[jjwt-0.9.1.jar:0.9.1]
>     at 
> io.jsonwebtoken.impl.DefaultJwtParser.parseClaimsJws(DefaultJwtParser.java:541)
>  ~[jjwt-0.9.1.jar:0.9.1]
>     at 
> org.apache.ofbiz.webapp.control.JWTManager.validateToken(JWTManager.java:124) 
> ~[ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.ExternalLoginKeysManager.jwtValidation(ExternalLoginKeysManager.java:292)
>  ~[ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.ExternalLoginKeysManager.checkJWTLogin(ExternalLoginKeysManager.java:196)
>  ~[ofbiz.jar:?]
>     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[?:1.8.0_152]
>     at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> ~[?:1.8.0_152]
>     at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_152]
>     at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_152]
>     at 
> org.apache.ofbiz.webapp.event.JavaEventHandler.invoke(JavaEventHandler.java:86)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:774)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:407)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:208) 
> [ofbiz.jar:?]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:645) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:750) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:191)
>  [ofbiz.jar:?]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156)
>  [ofbiz.jar:?]
>     at javax.servlet.http.HttpFilter.doFilter(HttpFilter.java:127) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:199)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:490)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:139) 
> [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> 

[jira] [Commented] (OFBIZ-9461) Alignment issue at Catalog Manager page

2019-02-03 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759369#comment-16759369
 ] 

Deepak Dixit commented on OFBIZ-9461:
-

Backported to R16.11 at r#1852824

> Alignment issue at Catalog Manager page 
> 
>
> Key: OFBIZ-9461
> URL: https://issues.apache.org/jira/browse/OFBIZ-9461
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Sanjay Yadav
>Assignee: Arun Patidar
>Priority: Minor
>  Labels: backport-needed, catalog
> Fix For: 17.12.01
>
> Attachments: AlignmentAfterAddingConditionAndAction.png, 
> AlignmentBugAtCatalogPriceRuleSection.png, AlignmentWithRemoveButton.png, 
> OFBIZ-9461.patch
>
>
> Go to:
> Application -> Catalog Manager -> Price Rule
> Actual - From Date, Through Date and Update section is not properly aligned. 
> Also due this horizontal scroll appearing at page.
> Expected - Fix this alignment issue and Horizontal scroll should not be 
> appear.
> Please refer attached screen shot.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7775) Cleanup JavaDocs to be standards compliant

2019-02-03 Thread Mathieu Lirzin (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759378#comment-16759378
 ] 

Mathieu Lirzin commented on OFBIZ-7775:
---

 Hello [~deepak.dixit],

[^OFBIZ-7775_Remove-useless-overidden-JavaMailContainer-jav.patch] looks good 
to me.

> Cleanup JavaDocs to be standards compliant
> --
>
> Key: OFBIZ-7775
> URL: https://issues.apache.org/jira/browse/OFBIZ-7775
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Major
> Attachments: 
> OFBIZ-7775_Remove-useless-overidden-JavaMailContainer-jav.patch
>
>
> To check what to fix simply run gradlew javadoc



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10755) Use the fop.xconf.*.patches in each demo

2019-02-03 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759376#comment-16759376
 ] 

Jacques Le Roux commented on OFBIZ-10755:
-

For easier reviews, here is a link to one of the files: 
https://svn.apache.org/repos/asf/ofbiz/tools/demo-backup/fop.xconf.trunk.patch

> Use the fop.xconf.*.patches in each demo
> 
>
> Key: OFBIZ-10755
> URL: https://issues.apache.org/jira/browse/OFBIZ-10755
> Project: OFBiz
>  Issue Type: Improvement
>  Components: Demo
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> In demos we need to set the fop base as explained in 
> https://xmlgraphics.apache.org/fop/2.1/configuration.html
> bq. base1 URL or directorySpecifies the base URL based on which 
> relative URL will be resolved.
> bq. Relative URIs for [some] properties are evaluated relative to the base 
> URI of the configuration file. If the configuration is provided 
> programmatically, the base URI can be set with 
> FopFactory.setUserConfigBaseURI ; default is the current working directory.
> The fop.xconf.*.patches are waiting to be applied on each demo



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-6072) Improves parties assignments to production run tasks

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-6072:

Fix Version/s: (was: 17.12.01)

> Improves parties assignments to production run tasks
> 
>
> Key: OFBIZ-6072
> URL: https://issues.apache.org/jira/browse/OFBIZ-6072
> Project: OFBiz
>  Issue Type: Improvement
>  Components: manufacturing
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> After OFBIZ-5706 parties can be assigned to production run tasks. But we can 
> improve how it's managed:
> * Be able to set the life span of an assignment (start and through date) upon 
> creation of an assignment
> * Being able to expire a party assignment by setting the through date (when 
> none is set)
> * Show the parties in the EditProductionRun and ShowProductionRun screen



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10156) Fix issues related to images paths

2019-02-03 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759380#comment-16759380
 ] 

Jacques Le Roux commented on OFBIZ-10156:
-

Thanks Deepak,

OFBIZ-10755 is related, so we need to enhance the patches there, closing here :)

> Fix issues related to images paths
> --
>
> Key: OFBIZ-10156
> URL: https://issues.apache.org/jira/browse/OFBIZ-10156
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01
>
>
> While working on OFBIZ-10128 I stumbled upon this issue  found on trunk demo
> {code}
> 2018-01-11 09:35:08,370 |ajp-nio-8009-exec-8  |FOUserAgent   
> |E| Image not found. URI: /images/ofbiz_logo.png. (See position 37:54)
> 2018-01-11 09:35:08,603 |ajp-nio-8009-exec-8  |FOUserAgent   
> |E| Image not found. URI: /images/ofbiz_logo.png. (No context info available)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10755) Use the fop.xconf.*.patches in each demo

2019-02-03 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759379#comment-16759379
 ] 

Jacques Le Roux commented on OFBIZ-10755:
-

As Deepak reported at OFBIZ-10156
bq. We need to set the content.url.prefix.secure/content.url.prefix.standard in 
url.properties to work in properly.

TBD also...

> Use the fop.xconf.*.patches in each demo
> 
>
> Key: OFBIZ-10755
> URL: https://issues.apache.org/jira/browse/OFBIZ-10755
> Project: OFBiz
>  Issue Type: Improvement
>  Components: Demo
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> In demos we need to set the fop base as explained in 
> https://xmlgraphics.apache.org/fop/2.1/configuration.html
> bq. base1 URL or directorySpecifies the base URL based on which 
> relative URL will be resolved.
> bq. Relative URIs for [some] properties are evaluated relative to the base 
> URI of the configuration file. If the configuration is provided 
> programmatically, the base URI can be set with 
> FopFactory.setUserConfigBaseURI ; default is the current working directory.
> The fop.xconf.*.patches are waiting to be applied on each demo



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9322) Remove all dependencies from OFBiz framework to plugins

2019-02-03 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-9322:
---
Fix Version/s: (was: 17.12.01)

> Remove all dependencies from OFBiz framework to plugins
> ---
>
> Key: OFBIZ-9322
> URL: https://issues.apache.org/jira/browse/OFBIZ-9322
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: 17.12.01
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-9322.patch
>
>
> The OFBiz [framework 
> repository|http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk] fails 
> to build and run tests unless the [plugins 
> repository|http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk] is 
> added first.
> The reason for this failure is mostly due to dependencies of some tests 
> defined in the framework on data that is defined in the ecommerce plugin.
> The purpose of this JIRA is to completely remove all these dependencies and 
> achieve a successful build of the framework using the command "./gradlew 
> cleanAll loadAll testIntegration"
> This task requires multiple different approaches including:
> - Moving some demo data from ecommerce to framework
> - Moving some tests where relevant from framework to ecommerce
> - Refactoring and/or removing some tests to disentangle the dependencies



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-10145:
-
Fix Version/s: 17.12.01

> Remove the Gradle wrapper from our release packages and add a step to our 
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: init-gradle-wrapper.sh
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, 
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to 
> remove the gradle-wrapper.jar file from the next packaged releases and  use 
> [~jacopoc]'s related proposition to document how to have Gradle working in 
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the 
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the 
> gradle-wrapper.jar. This might change in the future (versions, etc.), so 
> indeed maybe simply asking to download is enough, cf  
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in 
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes

2019-02-03 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759370#comment-16759370
 ] 

Deepak Dixit commented on OFBIZ-10145:
--

Can we conclude this ticket?
It solution looks good we can commit it. 

> Remove the Gradle wrapper from our release packages and add a step to our 
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: init-gradle-wrapper.sh
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, 
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to 
> remove the gradle-wrapper.jar file from the next packaged releases and  use 
> [~jacopoc]'s related proposition to document how to have Gradle working in 
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the 
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the 
> gradle-wrapper.jar. This might change in the future (versions, etc.), so 
> indeed maybe simply asking to download is enough, cf  
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in 
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-10145:
-
Fix Version/s: (was: 17.12.01)

> Remove the Gradle wrapper from our release packages and add a step to our 
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
> Attachments: init-gradle-wrapper.sh
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, 
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to 
> remove the gradle-wrapper.jar file from the next packaged releases and  use 
> [~jacopoc]'s related proposition to document how to have Gradle working in 
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the 
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the 
> gradle-wrapper.jar. This might change in the future (versions, etc.), so 
> indeed maybe simply asking to download is enough, cf  
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in 
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-8842) Search operation on 'AssocRevisionItemView' entity causing exception.

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit closed OFBIZ-8842.
---
   Resolution: Fixed
Fix Version/s: (was: 17.12.01)

> Search operation on 'AssocRevisionItemView' entity causing exception.
> -
>
> Key: OFBIZ-8842
> URL: https://issues.apache.org/jira/browse/OFBIZ-8842
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Humera Khan
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: 16.11.06
>
> Attachments: Assoc_Actual.png, Assoc_Expected.png, OFBIZ-8842.patch
>
>
> Steps to regenerate : 
> 1. Go to Entity Data Maintenance in webtools.
> 2. Search entity 'AssocRevisionItemView'. Click on it and go to the overview 
> page.
> 3. Click on the Find button.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-8842) Search operation on 'AssocRevisionItemView' entity causing exception.

2019-02-03 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759373#comment-16759373
 ] 

Deepak Dixit commented on OFBIZ-8842:
-

Thanks Humera, Now we can close this issue. 

> Search operation on 'AssocRevisionItemView' entity causing exception.
> -
>
> Key: OFBIZ-8842
> URL: https://issues.apache.org/jira/browse/OFBIZ-8842
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Humera Khan
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: 17.12.01, 16.11.06
>
> Attachments: Assoc_Actual.png, Assoc_Expected.png, OFBIZ-8842.patch
>
>
> Steps to regenerate : 
> 1. Go to Entity Data Maintenance in webtools.
> 2. Search entity 'AssocRevisionItemView'. Click on it and go to the overview 
> page.
> 3. Click on the Find button.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-6653) Upgrade our jQuery version

2019-02-03 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-6653.
--
Resolution: Delivered

Indeed, thanks Deepak!

> Upgrade our jQuery version
> --
>
> Key: OFBIZ-6653
> URL: https://issues.apache.org/jira/browse/OFBIZ-6653
> Project: OFBiz
>  Issue Type: Task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> We currently use jquery-1.11.0.js and with jquery-migrate-1.2.1.js and 
> jquery-ui-1.10.3.js. 
> We should update to jQuery 2 but wer have to agree to let's go the  Internet 
> Explorer 6, 7, or 8 suport. I believe it's now safe to do so.
> Please read https://jquery.com/download/ to know more
> We should also decide if we want to get rid of jquery-migrate-1.2.1.js, which 
> can be used with version 2
> http://blog.jquery.com/2013/05/08/jquery-migrate-1-2-1-released/
> but has a medium vulnerability: selector interpreted as HTML 
> http://bugs.jquery.com/ticket/11290 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Issue Comment Deleted] (OFBIZ-7775) Cleanup JavaDocs to be standards compliant

2019-02-03 Thread Mathieu Lirzin (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mathieu Lirzin updated OFBIZ-7775:
--
Comment: was deleted

(was:  Hello [~deepak.dixit],

[^OFBIZ-7775_Remove-useless-overidden-JavaMailContainer-jav.patch] looks good 
to me.)

> Cleanup JavaDocs to be standards compliant
> --
>
> Key: OFBIZ-7775
> URL: https://issues.apache.org/jira/browse/OFBIZ-7775
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Major
> Attachments: 
> OFBIZ-7775_Remove-useless-overidden-JavaMailContainer-jav.patch
>
>
> To check what to fix simply run gradlew javadoc



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-6110) Move as much as possible demo data from ecommerce to product or order components

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-6110:

Fix Version/s: (was: 17.12.01)

> Move as much as possible demo data from ecommerce to product or order 
> components
> 
>
> Key: OFBIZ-6110
> URL: https://issues.apache.org/jira/browse/OFBIZ-6110
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ecommerce, order, product
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> It would be better if we have most of the demo product data in product or 
> maybe in order component. Because almost all what can be done concerning 
> ordering in ecommerce can also be done in order manager from which anyway 
> ecommerce depends on
> More generally each component should have the data to be able to work as much 
> on its own as possible. Even if that means redundancy of some sorts. Most of 
> the time, we can avoid redudancy when there are components dependencies and 
> the component data are loaded after the main one.
> This is when 
> https://cwiki.apache.org/confluence/display/OFBIZ/Component+and+Component+Set+Dependencies
>  helps and shows why it should be actively maintained! For instance I'm not 
> sure we show data loading order there...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10156) Fix issues related to images paths

2019-02-03 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-10156.
---
   Resolution: Information Provided
Fix Version/s: (was: 17.12.01)

> Fix issues related to images paths
> --
>
> Key: OFBIZ-10156
> URL: https://issues.apache.org/jira/browse/OFBIZ-10156
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> While working on OFBIZ-10128 I stumbled upon this issue  found on trunk demo
> {code}
> 2018-01-11 09:35:08,370 |ajp-nio-8009-exec-8  |FOUserAgent   
> |E| Image not found. URI: /images/ofbiz_logo.png. (See position 37:54)
> 2018-01-11 09:35:08,603 |ajp-nio-8009-exec-8  |FOUserAgent   
> |E| Image not found. URI: /images/ofbiz_logo.png. (No context info available)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9221) Refactor FinAccount services after unexpected Deadlocks

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-9221:

Fix Version/s: (was: 17.12.01)

> Refactor FinAccount services after unexpected Deadlocks
> ---
>
> Key: OFBIZ-9221
> URL: https://issues.apache.org/jira/browse/OFBIZ-9221
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> Unexpected Deadlocks  were reported in this user ML thread 
> https://s.apache.org/CHT8
> Scott suggested we should refactor the FinAccount services. Most of them  are 
> in Minilang.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-9461) Alignment issue at Catalog Manager page

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit closed OFBIZ-9461.
---
   Resolution: Fixed
Fix Version/s: (was: 17.12.01)
   16.11.06

> Alignment issue at Catalog Manager page 
> 
>
> Key: OFBIZ-9461
> URL: https://issues.apache.org/jira/browse/OFBIZ-9461
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Sanjay Yadav
>Assignee: Arun Patidar
>Priority: Minor
>  Labels: backport-needed, catalog
> Fix For: 16.11.06
>
> Attachments: AlignmentAfterAddingConditionAndAction.png, 
> AlignmentBugAtCatalogPriceRuleSection.png, AlignmentWithRemoveButton.png, 
> OFBIZ-9461.patch
>
>
> Go to:
> Application -> Catalog Manager -> Price Rule
> Actual - From Date, Through Date and Update section is not properly aligned. 
> Also due this horizontal scroll appearing at page.
> Expected - Fix this alignment issue and Horizontal scroll should not be 
> appear.
> Please refer attached screen shot.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10818) Fix the EntitySync Push and Pull functionality

2019-02-03 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759375#comment-16759375
 ] 

Deepak Dixit commented on OFBIZ-10818:
--

[~arunpati], I think we can close this issue?

> Fix the EntitySync Push and Pull functionality
> --
>
> Key: OFBIZ-10818
> URL: https://issues.apache.org/jira/browse/OFBIZ-10818
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, 16.11.05
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Major
> Fix For: 16.11.06
>
>
> Pull and Push functionality of EntitySync is breaking on various places. Need 
> to test and fix the work flow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-10145:
-
Affects Version/s: (was: Trunk)
   17.12.01

> Remove the Gradle wrapper from our release packages and add a step to our 
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: init-gradle-wrapper.sh
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, 
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to 
> remove the gradle-wrapper.jar file from the next packaged releases and  use 
> [~jacopoc]'s related proposition to document how to have Gradle working in 
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the 
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the 
> gradle-wrapper.jar. This might change in the future (versions, etc.), so 
> indeed maybe simply asking to download is enough, cf  
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in 
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9308) CMS shows error screen on Product Search

2019-02-03 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-9308:

Fix Version/s: (was: 17.12.01)

> CMS shows error screen on Product Search
> 
>
> Key: OFBIZ-9308
> URL: https://issues.apache.org/jira/browse/OFBIZ-9308
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Reporter: Aditya Sharma
>Priority: Major
> Attachments: OFBIZ-9308.patch, screenshot-1.png
>
>
> Steps to regenerate:
> 1. Go to Content component (https://localhost:8443/content/control/main)
> 2. Click on CMS tab (directing to 
> https://localhost:8443/content/control/CMSContentFind)
> 3. Click on Search Products subtab (directing to 
> https://localhost:8443/content/control/ProductSearch)
> 4. Provide a Lucene Query and Click submit.
> 5. Screen renders with ScreenRenderingException



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-7775) Cleanup JavaDocs to be standards compliant

2019-02-03 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-7775.
--
   Resolution: Implemented
Fix Version/s: Upcoming Branch

> Cleanup JavaDocs to be standards compliant
> --
>
> Key: OFBIZ-7775
> URL: https://issues.apache.org/jira/browse/OFBIZ-7775
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: 
> OFBIZ-7775_Remove-useless-overidden-JavaMailContainer-jav.patch
>
>
> To check what to fix simply run gradlew javadoc



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)