[jira] [Comment Edited] (OFBIZ-11040) Manage EECAs on delegator.removeBy
[
https://issues.apache.org/jira/browse/OFBIZ-11040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845607#comment-16845607
]
Nicolas Malin edited comment on OFBIZ-11040 at 5/22/19 7:26 AM:
{quote}Hè Leila are you really too shy to not provide it yourself, or do you
prefer to not be too much involved in contributions? {quote}
:) I destack from nereide pool correction
https://labs.nereide.fr/10031/Communautaire/issues and most of them are
realized by her
{quote}BTW should this not be considered a bug? What could be the reasons it
was not implemented before, any ideas?{quote}
I hesitated, missing functionnality or bug process, if you think it's more a
bug I can backport it
[~mthl] I corrected the patch [^OFBIZ-11040.patch] with your remarks
was (Author: soledad):
{quote}Hè Leila are you really too shy to not provide it yourself, or do you
prefer to not be too much involved in contributions? {quote}
:) I destack from nereide pool correction
https://labs.nereide.fr/10031/Communautaire/issues and most of them a realize
by her
{quote}BTW should this not be considered a bug? What could be the reasons it
was not implemented before, any ideas?{quote}
I hesitated, missing functionnality or bug process, if you think it's more a
bug I can backport it
[~mthl] I corrected the patch [^OFBIZ-11040.patch] with your remarks
> Manage EECAs on delegator.removeBy
> --
>
> Key: OFBIZ-11040
> URL: https://issues.apache.org/jira/browse/OFBIZ-11040
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-11040.patch, OFBIZ-11040.patch
>
>
> Currently, when you delete some entities through removeByAnd or
> removeByCondition, eeca aren't enable and the remove is quite as regard
> implemented rules.
> With
> {code:java}
> event="return">
>
>
> {code}
> And
> {code:java}
> delegator.removeByAnd('GoodIdentification', [productId: 'WG-'])
> {code}
> The service indexProduct wasn't call for the productId WG-
> To solve this situation, the idea would be delegator.removeValue for each
> element to delete when an eeca is present otherwise call the standard
> helper.removeByCondition.
> This patch [^OFBIZ-11040.patch] provided by [~mleila]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-9997) Replace request-redirect w/ no redirect-param attribute by request-redirect-noparam
[ https://issues.apache.org/jira/browse/OFBIZ-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845657#comment-16845657 ] Jacques Le Roux commented on OFBIZ-9997: Mmm, reverted in trunk r1859698 R18 r1859699 R17 r18596100 The ProductManufacturingRules screen is a mess > Replace request-redirect w/ no redirect-param attribute by > request-redirect-noparam > --- > > Key: OFBIZ-9997 > URL: https://issues.apache.org/jira/browse/OFBIZ-9997 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Release Branch 16.11, Release Branch 17.12, Release > Branch 18.12 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-9997.patch > > > This follows the discussion at http://markmail.org/message/sbfdlhntdzziqeyz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-11047) It's impossible to create more than 1 ProductManufacturingRule
Jacques Le Roux created OFBIZ-11047: --- Summary: It's impossible to create more than 1 ProductManufacturingRule Key: OFBIZ-11047 URL: https://issues.apache.org/jira/browse/OFBIZ-11047 Project: OFBiz Issue Type: Bug Components: manufacturing Affects Versions: Release Branch 16.11, Trunk, Release Branch 17.12, Release Branch 18.12 Reporter: Jacques Le Roux Assignee: Jacques Le Roux While working on OFBIZ-9997 I noticed it's impossible to create more than 1 ProductManufacturingRule. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-11047) It's impossible to create more than 1 ProductManufacturingRule
[
https://issues.apache.org/jira/browse/OFBIZ-11047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-11047.
---
Resolution: Fixed
Fix Version/s: 18.12.01
16.11.06
17.12.01
Fixed in
trunk r1859691
R18 r1859692
R17 r1859693
R16 r1859695
> It's impossible to create more than 1 ProductManufacturingRule
> --
>
> Key: OFBIZ-11047
> URL: https://issues.apache.org/jira/browse/OFBIZ-11047
> Project: OFBiz
> Issue Type: Bug
> Components: manufacturing
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12,
> Release Branch 18.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
>
> While working on OFBIZ-9997 I noticed it's impossible to create more than 1
> ProductManufacturingRule.
> It also shows ManufacturingMachineGroupIdAlreadyExist ("Fixed Asset Group ID
> doesn't exist") when you try to create one using manually the
> AddProductManufacturingRule service which makes no sense.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-11040) Manage EECAs on delegator.removeBy
[
https://issues.apache.org/jira/browse/OFBIZ-11040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845650#comment-16845650
]
Jacques Le Roux commented on OFBIZ-11040:
-
If nobody is against I think we can backport it if it's easy to do so. Maybe a
proper discussion on dev ML is required, not sure...
> Manage EECAs on delegator.removeBy
> --
>
> Key: OFBIZ-11040
> URL: https://issues.apache.org/jira/browse/OFBIZ-11040
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-11040.patch, OFBIZ-11040.patch
>
>
> Currently, when you delete some entities through removeByAnd or
> removeByCondition, eeca aren't enable and the remove is quite as regard
> implemented rules.
> With
> {code:java}
> event="return">
>
>
> {code}
> And
> {code:java}
> delegator.removeByAnd('GoodIdentification', [productId: 'WG-'])
> {code}
> The service indexProduct wasn't call for the productId WG-
> To solve this situation, the idea would be delegator.removeValue for each
> element to delete when an eeca is present otherwise call the standard
> helper.removeByCondition.
> This patch [^OFBIZ-11040.patch] provided by [~mleila]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-11047) It's impossible to create more than 1 ProductManufacturingRule
[
https://issues.apache.org/jira/browse/OFBIZ-11047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-11047:
Description:
While working on OFBIZ-9997 I noticed it's impossible to create more than 1
ProductManufacturingRule.
It also shows ManufacturingMachineGroupIdAlreadyExist ("Fixed Asset Group ID
doesn't exist") when you try to create one using manually the
AddProductManufacturingRule service which makes no sense.
was:While working on OFBIZ-9997 I noticed it's impossible to create more than
1 ProductManufacturingRule.
> It's impossible to create more than 1 ProductManufacturingRule
> --
>
> Key: OFBIZ-11047
> URL: https://issues.apache.org/jira/browse/OFBIZ-11047
> Project: OFBiz
> Issue Type: Bug
> Components: manufacturing
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12,
> Release Branch 18.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> While working on OFBIZ-9997 I noticed it's impossible to create more than 1
> ProductManufacturingRule.
> It also shows ManufacturingMachineGroupIdAlreadyExist ("Fixed Asset Group ID
> doesn't exist") when you try to create one using manually the
> AddProductManufacturingRule service which makes no sense.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-11048) When you select a ProductManufacturingRule if several exist only the one selected will show multiple times in the list
Jacques Le Roux created OFBIZ-11048: --- Summary: When you select a ProductManufacturingRule if several exist only the one selected will show multiple times in the list Key: OFBIZ-11048 URL: https://issues.apache.org/jira/browse/OFBIZ-11048 Project: OFBiz Issue Type: Bug Reporter: Jacques Le Roux Actually as much as existing ProductManufacturingRules -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9997) Replace request-redirect w/ no redirect-param attribute by request-redirect-noparam
[ https://issues.apache.org/jira/browse/OFBIZ-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845642#comment-16845642 ] Jacques Le Roux commented on OFBIZ-9997: In trunk r1859694 R18 r1859696 R17 r1859697 I used view instead of request-redirect-noparam for EditProductManufacturingRules > Replace request-redirect w/ no redirect-param attribute by > request-redirect-noparam > --- > > Key: OFBIZ-9997 > URL: https://issues.apache.org/jira/browse/OFBIZ-9997 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Release Branch 16.11, Release Branch 17.12, Release > Branch 18.12 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-9997.patch > > > This follows the discussion at http://markmail.org/message/sbfdlhntdzziqeyz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-7963) Create a Gradle Sonar task
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-7963: Attachment: OFBIZ-7963-sonar.patch > Create a Gradle Sonar task > -- > > Key: OFBIZ-7963 > URL: https://issues.apache.org/jira/browse/OFBIZ-7963 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch > > > As ever the devil is in details. There is no longer a Sonar plugin available > https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should > rather refer to > http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle > Anyway the most important part is to revivify INFRA-3590 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-11048) When you select a ProductManufacturingRule if several exist only the one selected will show multiple times in the list
[ https://issues.apache.org/jira/browse/OFBIZ-11048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-11048: --- Assignee: Jacques Le Roux > When you select a ProductManufacturingRule if several exist only the one > selected will show multiple times in the list > -- > > Key: OFBIZ-11048 > URL: https://issues.apache.org/jira/browse/OFBIZ-11048 > Project: OFBiz > Issue Type: Bug >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > > Actually as much as existing ProductManufacturingRules -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-11049) massPrintOrders does not work
[
https://issues.apache.org/jira/browse/OFBIZ-11049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-11049.
---
Resolution: Not A Problem
My bad forgot to check to create the list of order to print :/ Actually
confused with another issue I got before
> massPrintOrders does not work
> -
>
> Key: OFBIZ-11049
> URL: https://issues.apache.org/jira/browse/OFBIZ-11049
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> When you try to print a list of orders you get:
> {noformat}
> 2019-05-22 12:18:00,274 |sse-nio-8443-exec-10 |ModelService
> |E| [ModelService.validate] : {massPrintOrders} : (IN) Required test error:
> org.apache.ofbiz.service.ServiceValidationException: The following required
> paramete
> r is missing: [IN] [massPrintOrders.orderIdList]
> 2019-05-22 12:18:00,274 |sse-nio-8443-exec-10 |ServiceDispatcher
> |E| Incoming context (in runSync : massPrintOrders) does not match expected
> requirements
> org.apache.ofbiz.service.ServiceValidationException: The following required
> parameter is missing: [IN] [massPrintOrders.orderIdList]
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-11007) REST: adding segmented URI support
[
https://issues.apache.org/jira/browse/OFBIZ-11007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits updated OFBIZ-11007:
-
Labels: URI rest rest_api (was: URI rest_api)
> REST: adding segmented URI support
> --
>
> Key: OFBIZ-11007
> URL: https://issues.apache.org/jira/browse/OFBIZ-11007
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
> Environment:
>Reporter: Artemiy Rozovyk
>Priority: Minor
> Labels: URI, rest, rest_api
> Fix For: Upcoming Branch
>
> Attachments: entitymaint_example.patch, restful_URIs.patch
>
>
> Following the discussion on making OFBiz RESTful OFBIZ-4274 i implemented the
> support of segmented URIs without interfering with current mechanisms of URI
> resolution nor with _overrideView()_ feature.
> Combined with work on associating URIs and HTTP methods done by [~mthl] in
> OFBIZ-10438 , we are now able to provide RESTful APIs as follows:
> {code:java}
>
> ...
>
> ...
>
> ...
> {code}
> After we matched a request-map having parametrized URI as in
> {code:java}
> uri="foo/bar/{baz}"
> {code}
> the value is available inside the request attributes with the corresponding
> key (here _"baz"_)
> The *restful_URIs.patch* allows segmented URI support.
> The *entitymaint_example.patch* is a modified _entitymaint_ part that serves
> as an example of possible application of new system.
> Any questions or comments are welcomed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits updated OFBIZ-10438:
-
Labels: rest (was: )
> Add method attribute to request-map to controll a uri can be called GET or
> POST only
>
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Jacques Le Roux
>Priority: Minor
> Labels: rest
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-10438_0001-Add-optional-method-attribute-in-request.patch,
> OFBIZ-10438_0002-Parse-controller-config-in-one-place.patch,
> OFBIZ-10438_0003-Handle-multiple-request-methods.patch,
> OFBIZ-10438_Fix-resolveURI.patch, URL-Error-SelectShipping.png,
> URL-Error-additem.png
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map
> element, it's almost the same as we implemented in our openapi:
> {code:java}
>
>
>
>
>
>
> {code}
> The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-4274) Implement a REST Servlet
[ https://issues.apache.org/jira/browse/OFBIZ-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-4274: Labels: REST rest (was: REST) > Implement a REST Servlet > > > Key: OFBIZ-4274 > URL: https://issues.apache.org/jira/browse/OFBIZ-4274 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: Adrian Crum >Priority: Major > Labels: REST, rest > Attachments: RestExampleSchema.xsd, RestXmlRepresentation.xml, > rest-conf.xml, swagger-pos-openapi.png > > > Implement a REST servlet that will map REST requests to OFBiz services. > Details are in the comments. > [here is the discussion which took place on the dev > ML|http://markmail.org/message/ai6q2fbksowaayn4] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-7963) Create a Gradle Sonar task
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-7963: Attachment: OFBIZ-7963-sonar.patch > Create a Gradle Sonar task > -- > > Key: OFBIZ-7963 > URL: https://issues.apache.org/jira/browse/OFBIZ-7963 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch, > OFBIZ-7963-sonar.patch > > > As ever the devil is in details. There is no longer a Sonar plugin available > https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should > rather refer to > http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle > Anyway the most important part is to revivify INFRA-3590 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-11048) When you select a ProductManufacturingRule if several exist only the one selected will show multiple times in the list
[ https://issues.apache.org/jira/browse/OFBIZ-11048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11048. --- Resolution: Fixed Fix Version/s: 18.12.01 16.11.06 17.12.01 Fixed in trunk r1859704 R18 r1859705 R17 r1859706 R16 r1859707 > When you select a ProductManufacturingRule if several exist only the one > selected will show multiple times in the list > -- > > Key: OFBIZ-11048 > URL: https://issues.apache.org/jira/browse/OFBIZ-11048 > Project: OFBiz > Issue Type: Bug >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01, 16.11.06, 18.12.01 > > > Actually as much as existing ProductManufacturingRules -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits updated OFBIZ-10438:
-
Labels: REST rest (was: rest)
> Add method attribute to request-map to controll a uri can be called GET or
> POST only
>
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Jacques Le Roux
>Priority: Minor
> Labels: REST, rest
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-10438_0001-Add-optional-method-attribute-in-request.patch,
> OFBIZ-10438_0002-Parse-controller-config-in-one-place.patch,
> OFBIZ-10438_0003-Handle-multiple-request-methods.patch,
> OFBIZ-10438_Fix-resolveURI.patch, URL-Error-SelectShipping.png,
> URL-Error-additem.png
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map
> element, it's almost the same as we implemented in our openapi:
> {code:java}
>
>
>
>
>
>
> {code}
> The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-11048) When you select a ProductManufacturingRule if several exist only the one selected will show multiple times in the list
[ https://issues.apache.org/jira/browse/OFBIZ-11048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11048: Component/s: manufacturing > When you select a ProductManufacturingRule if several exist only the one > selected will show multiple times in the list > -- > > Key: OFBIZ-11048 > URL: https://issues.apache.org/jira/browse/OFBIZ-11048 > Project: OFBiz > Issue Type: Bug > Components: manufacturing >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01, 16.11.06, 18.12.01 > > > Actually as much as existing ProductManufacturingRules -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-9997) Replace request-redirect w/ no redirect-param attribute by request-redirect-noparam
[ https://issues.apache.org/jira/browse/OFBIZ-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845710#comment-16845710 ] Jacques Le Roux edited comment on OFBIZ-9997 at 5/22/19 9:38 AM: - In trunk r1859708 R18 r1859709 R17 r1859710 I used view instead of request-redirect-noparam for updateDocumentTree, removeDocumentFromTree, addDocumentToTree. The rendering is far better, you get back to where intuitively you would like was (Author: jacques.le.roux): In trunk r1859708 R18 r1859709 R17 r1859710 I used view instead of request-redirect-noparam for updateDocumentTree, removeDocumentFromTree, addDocumentToTree. The rendering is far better, you get back to where you intuitively you would like > Replace request-redirect w/ no redirect-param attribute by > request-redirect-noparam > --- > > Key: OFBIZ-9997 > URL: https://issues.apache.org/jira/browse/OFBIZ-9997 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Release Branch 16.11, Release Branch 17.12, Release > Branch 18.12 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-9997.patch > > > This follows the discussion at http://markmail.org/message/sbfdlhntdzziqeyz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9997) Replace request-redirect w/ no redirect-param attribute by request-redirect-noparam
[ https://issues.apache.org/jira/browse/OFBIZ-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845710#comment-16845710 ] Jacques Le Roux commented on OFBIZ-9997: In trunk r1859708 R18 r1859709 R17 r1859710 I used view instead of request-redirect-noparam for updateDocumentTree, removeDocumentFromTree, addDocumentToTree. The rendering is far better, you get back to where you intuitively you would like > Replace request-redirect w/ no redirect-param attribute by > request-redirect-noparam > --- > > Key: OFBIZ-9997 > URL: https://issues.apache.org/jira/browse/OFBIZ-9997 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Release Branch 16.11, Release Branch 17.12, Release > Branch 18.12 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-9997.patch > > > This follows the discussion at http://markmail.org/message/sbfdlhntdzziqeyz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-11049) massPrintOrders does not work
Jacques Le Roux created OFBIZ-11049:
---
Summary: massPrintOrders does not work
Key: OFBIZ-11049
URL: https://issues.apache.org/jira/browse/OFBIZ-11049
Project: OFBiz
Issue Type: Bug
Components: order
Affects Versions: Trunk
Reporter: Jacques Le Roux
Assignee: Jacques Le Roux
When you try to print a list of orders you get:
{noformat}
2019-05-22 12:18:00,274 |sse-nio-8443-exec-10 |ModelService
|E| [ModelService.validate] : {massPrintOrders} : (IN) Required test error:
org.apache.ofbiz.service.ServiceValidationException: The following required
paramete
r is missing: [IN] [massPrintOrders.orderIdList]
2019-05-22 12:18:00,274 |sse-nio-8443-exec-10 |ServiceDispatcher
|E| Incoming context (in runSync : massPrintOrders) does not match expected
requirements
org.apache.ofbiz.service.ServiceValidationException: The following required
parameter is missing: [IN] [massPrintOrders.orderIdList]
{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-11007) REST: adding segmented URI support
[
https://issues.apache.org/jira/browse/OFBIZ-11007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits updated OFBIZ-11007:
-
Labels: REST URI (was: URI rest rest_api)
> REST: adding segmented URI support
> --
>
> Key: OFBIZ-11007
> URL: https://issues.apache.org/jira/browse/OFBIZ-11007
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
> Environment:
>Reporter: Artemiy Rozovyk
>Priority: Minor
> Labels: REST, URI
> Fix For: Upcoming Branch
>
> Attachments: entitymaint_example.patch, restful_URIs.patch
>
>
> Following the discussion on making OFBiz RESTful OFBIZ-4274 i implemented the
> support of segmented URIs without interfering with current mechanisms of URI
> resolution nor with _overrideView()_ feature.
> Combined with work on associating URIs and HTTP methods done by [~mthl] in
> OFBIZ-10438 , we are now able to provide RESTful APIs as follows:
> {code:java}
>
> ...
>
> ...
>
> ...
> {code}
> After we matched a request-map having parametrized URI as in
> {code:java}
> uri="foo/bar/{baz}"
> {code}
> the value is available inside the request attributes with the corresponding
> key (here _"baz"_)
> The *restful_URIs.patch* allows segmented URI support.
> The *entitymaint_example.patch* is a modified _entitymaint_ part that serves
> as an example of possible application of new system.
> Any questions or comments are welcomed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-4274) Implement a REST Servlet
[ https://issues.apache.org/jira/browse/OFBIZ-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-4274: Labels: REST URI (was: REST rest) > Implement a REST Servlet > > > Key: OFBIZ-4274 > URL: https://issues.apache.org/jira/browse/OFBIZ-4274 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: Adrian Crum >Priority: Major > Labels: REST, URI > Attachments: RestExampleSchema.xsd, RestXmlRepresentation.xml, > rest-conf.xml, swagger-pos-openapi.png > > > Implement a REST servlet that will map REST requests to OFBiz services. > Details are in the comments. > [here is the discussion which took place on the dev > ML|http://markmail.org/message/ai6q2fbksowaayn4] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits updated OFBIZ-10438:
-
Labels: REST URI (was: REST rest)
> Add method attribute to request-map to controll a uri can be called GET or
> POST only
>
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Jacques Le Roux
>Priority: Minor
> Labels: REST, URI
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-10438_0001-Add-optional-method-attribute-in-request.patch,
> OFBIZ-10438_0002-Parse-controller-config-in-one-place.patch,
> OFBIZ-10438_0003-Handle-multiple-request-methods.patch,
> OFBIZ-10438_Fix-resolveURI.patch, URL-Error-SelectShipping.png,
> URL-Error-additem.png
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map
> element, it's almost the same as we implemented in our openapi:
> {code:java}
>
>
>
>
>
>
> {code}
> The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Reopened] (OFBIZ-11049) massPrintOrders does not work
[
https://issues.apache.org/jira/browse/OFBIZ-11049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux reopened OFBIZ-11049:
-
> massPrintOrders does not work
> -
>
> Key: OFBIZ-11049
> URL: https://issues.apache.org/jira/browse/OFBIZ-11049
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> When you try to print a list of orders you get:
> {noformat}
> 2019-05-22 12:18:00,274 |sse-nio-8443-exec-10 |ModelService
> |E| [ModelService.validate] : {massPrintOrders} : (IN) Required test error:
> org.apache.ofbiz.service.ServiceValidationException: The following required
> paramete
> r is missing: [IN] [massPrintOrders.orderIdList]
> 2019-05-22 12:18:00,274 |sse-nio-8443-exec-10 |ServiceDispatcher
> |E| Incoming context (in runSync : massPrintOrders) does not match expected
> requirements
> org.apache.ofbiz.service.ServiceValidationException: The following required
> parameter is missing: [IN] [massPrintOrders.orderIdList]
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10848) XML import fails when xml data contains special symbols
[
https://issues.apache.org/jira/browse/OFBIZ-10848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845865#comment-16845865
]
Pawan Verma commented on OFBIZ-10848:
-
Before r1847478 flow was, modelParam used to get from multiPartMap and if it is
empty(which we found) and if the service modelParam has allow-html="any" then
get this directly from the request otherwise get it from parameters Map.
After the r1847478 flow is, we got modelParam from parameters Map and if it is
empty(which is not) and if the service modelParam has allow-html="any" then get
this from the request. The issue here is the case of allow-html="any" never
gets executed that's why we get reported issue.
My suggestion would be if we have allow-html="any" for modelParam we should get
if from request otherwise from parameters Map.
Attached patch. Thanks!
> XML import fails when xml data contains special symbols
> ---
>
> Key: OFBIZ-10848
> URL: https://issues.apache.org/jira/browse/OFBIZ-10848
> Project: OFBiz
> Issue Type: Bug
> Components: framework/webtools
>Reporter: Lalit Dashora
>Assignee: Pawan Verma
>Priority: Major
> Attachments: OFBIZ-10848.patch
>
>
> Instance: https://demo-trunk.ofbiz.apache.org/webtools/control/entityImport
> Not able to import data which contains special symbols like & ().
> {code:java}
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10848) XML import fails when xml data contains special symbols
[
https://issues.apache.org/jira/browse/OFBIZ-10848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pawan Verma updated OFBIZ-10848:
Attachment: OFBIZ-10848.patch
> XML import fails when xml data contains special symbols
> ---
>
> Key: OFBIZ-10848
> URL: https://issues.apache.org/jira/browse/OFBIZ-10848
> Project: OFBiz
> Issue Type: Bug
> Components: framework/webtools
>Reporter: Lalit Dashora
>Assignee: Pawan Verma
>Priority: Major
> Attachments: OFBIZ-10848.patch
>
>
> Instance: https://demo-trunk.ofbiz.apache.org/webtools/control/entityImport
> Not able to import data which contains special symbols like & ().
> {code:java}
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-11040) Manage EECAs on delegator.removeBy
[
https://issues.apache.org/jira/browse/OFBIZ-11040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845607#comment-16845607
]
Nicolas Malin commented on OFBIZ-11040:
---
{quote}Hè Leila are you really too shy to not provide it yourself, or do you
prefer to not be too much involved in contributions? {quote}
:) I destack from nereide pool correction
https://labs.nereide.fr/10031/Communautaire/issues and most of them a realize
by her
{quote}BTW should this not be considered a bug? What could be the reasons it
was not implemented before, any ideas?{quote}
I hesitated, missing functionnality or bug process, if you think it's more a
bug I can backport it
[~mthl] I corrected the patch [^OFBIZ-11040.patch] with your remarks
> Manage EECAs on delegator.removeBy
> --
>
> Key: OFBIZ-11040
> URL: https://issues.apache.org/jira/browse/OFBIZ-11040
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-11040.patch, OFBIZ-11040.patch
>
>
> Currently, when you delete some entities through removeByAnd or
> removeByCondition, eeca aren't enable and the remove is quite as regard
> implemented rules.
> With
> {code:java}
> event="return">
>
>
> {code}
> And
> {code:java}
> delegator.removeByAnd('GoodIdentification', [productId: 'WG-'])
> {code}
> The service indexProduct wasn't call for the productId WG-
> To solve this situation, the idea would be delegator.removeValue for each
> element to delete when an eeca is present otherwise call the standard
> helper.removeByCondition.
> This patch [^OFBIZ-11040.patch] provided by [~mleila]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-11040) Manage EECAs on delegator.removeBy
[
https://issues.apache.org/jira/browse/OFBIZ-11040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin updated OFBIZ-11040:
--
Attachment: OFBIZ-11040.patch
> Manage EECAs on delegator.removeBy
> --
>
> Key: OFBIZ-11040
> URL: https://issues.apache.org/jira/browse/OFBIZ-11040
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-11040.patch, OFBIZ-11040.patch
>
>
> Currently, when you delete some entities through removeByAnd or
> removeByCondition, eeca aren't enable and the remove is quite as regard
> implemented rules.
> With
> {code:java}
> event="return">
>
>
> {code}
> And
> {code:java}
> delegator.removeByAnd('GoodIdentification', [productId: 'WG-'])
> {code}
> The service indexProduct wasn't call for the productId WG-
> To solve this situation, the idea would be delegator.removeValue for each
> element to delete when an eeca is present otherwise call the standard
> helper.removeByCondition.
> This patch [^OFBIZ-11040.patch] provided by [~mleila]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (OFBIZ-11049) massPrintOrders does not work
[
https://issues.apache.org/jira/browse/OFBIZ-11049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-11049.
---
Resolution: Fixed
Fix Version/s: 18.12.01
16.11.06
17.12.01
Fixed in
trunk r1859735
R18 r1859736+1859737
R17 r1859738+1859739
R16 is not concerned (common theme did not exist then)
This fixes it by using the same solution than in r1806237. If the visual theme
is unknown in the the service context get the default theme from
general.properties using ThemeFactory::resolveTheme.
sendPrintFromScreen, createFileFromScreen, sendBirtMail, getXslFo and
printReportPdf (in example) were concerned
> massPrintOrders does not work
> -
>
> Key: OFBIZ-11049
> URL: https://issues.apache.org/jira/browse/OFBIZ-11049
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
>
> When you try to print a list of orders you get:
> {noformat}
> 2019-05-22 12:26:10,366 |OFBiz-JobQueue-0 |GenericServiceJob
> |E| Async-Service failed.
> org.apache.ofbiz.service.GenericServiceException: Service
> [sendPrintFromScreen] target threw an unexpected exception (null)
> at
> org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:115)
> ~[ofbiz.jar:?]
> at
> org.apache.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
> ~[ofbiz.jar:?]
> at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:415)
> ~[ofbiz.jar:?]
> at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:240)
> ~[ofbiz.jar:?]
> at
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
> ~[ofbiz.jar:?]
> at
> org.apache.ofbiz.service.job.GenericServiceJob.exec(GenericServiceJob.java:70)
> [ofbiz.jar:?]
> at org.apache.ofbiz.service.job.AbstractJob.run(AbstractJob.java:87)
> [ofbiz.jar:?]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> [?:1.8.0_202]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> [?:1.8.0_202]
> at java.lang.Thread.run(Thread.java:748) [?:1.8.0_202]
> Caused by: java.lang.NullPointerException
> at
> org.apache.ofbiz.content.output.OutputServices.sendPrintFromScreen(OutputServices.java:115)
> ~[ofbiz.jar:?]
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> ~[?:1.8.0_202]
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> ~[?:1.8.0_202]
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> ~[?:1.8.0_202]
> at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_202]
> at
> org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:100)
> ~[ofbiz.jar:?]
> ... 9 more
> {noformat}
> The problem is similar to what was resolved by
> [r1806237|http://svn.apache.org/viewvc?view=revision=1806237] for
> OFBIZ-9138
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-11049) massPrintOrders does not work
[
https://issues.apache.org/jira/browse/OFBIZ-11049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846013#comment-16846013
]
Jacques Le Roux commented on OFBIZ-11049:
-
Reopening, actually there was a problem similar to what was resolved by
[r1806237|http://svn.apache.org/viewvc?view=revision=1806237] for
OFBIZ-9138
> massPrintOrders does not work
> -
>
> Key: OFBIZ-11049
> URL: https://issues.apache.org/jira/browse/OFBIZ-11049
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> When you try to print a list of orders you get:
> {noformat}
> 2019-05-22 12:18:00,274 |sse-nio-8443-exec-10 |ModelService
> |E| [ModelService.validate] : {massPrintOrders} : (IN) Required test error:
> org.apache.ofbiz.service.ServiceValidationException: The following required
> paramete
> r is missing: [IN] [massPrintOrders.orderIdList]
> 2019-05-22 12:18:00,274 |sse-nio-8443-exec-10 |ServiceDispatcher
> |E| Incoming context (in runSync : massPrintOrders) does not match expected
> requirements
> org.apache.ofbiz.service.ServiceValidationException: The following required
> parameter is missing: [IN] [massPrintOrders.orderIdList]
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-5254) Services allow arbitrary HTML for parameters with allow-html set to "safe"
[
https://issues.apache.org/jira/browse/OFBIZ-5254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846046#comment-16846046
]
Jacques Le Roux commented on OFBIZ-5254:
A change in ebaystore plugin was missing, last [^OFBIZ-5254.patch] contains it
> Services allow arbitrary HTML for parameters with allow-html set to "safe"
> --
>
> Key: OFBIZ-5254
> URL: https://issues.apache.org/jira/browse/OFBIZ-5254
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Christoph Neuroth
>Assignee: Jacques Le Roux
>Priority: Critical
> Labels: security
> Attachments: OFBIZ-5254.patch, OFBIZ-5254.patch, OFBIZ-5254.patch,
> OFBIZ-5254.patch, OFBIZ-5254.patch, OFBIZ-5254.patch, UtilCodec.java
>
>
> For any given service with allow-html=safe parameters, the parameter data is
> not properly validated. See Model.Service.java:588:
> {code}
>
> StringUtil.checkStringForHtmlSafeOnly(modelParam.name, value,
> errorMessageList);
> {code}
> Looking at that method:
> {code}
> public static String checkStringForHtmlSafeOnly(String valueName, String
> value, List errorMessageList) {
> ValidationErrorList vel = new ValidationErrorList();
> value = defaultWebValidator.getValidSafeHTML(valueName, value,
> Integer.MAX_VALUE, true, vel);
> errorMessageList.addAll(UtilGenerics.checkList(vel.errors(),
> String.class));
> return value;
> }
> {code}
> you can see that it expects the defaultWebValidator.getValidSafeHTML would
> add all validation errors to the given ValidationErrorList, but if you look
> at the implementation of ESAPI that is not the case. First, consider the
> overloaded getValidSafeHTML that takes the ValidationErrorList:
> {code}public String getValidSafeHTML(String context, String input,
> int maxLength, boolean allowNull, ValidationErrorList errors) throws
> IntrusionException {
> try {
> return getValidSafeHTML(context, input, maxLength,
> allowNull);
> } catch (ValidationException e) {
> errors.addError(context, e);
> }
> return input;
> }
> {code}
> Then, step into that method to see that ValidationExceptions are only thrown
> for things like exceeding the maximum length - not for policy violations that
> can be "cleaned", such as tags that are not allowed by the policy:
> {code}
> AntiSamy as = new AntiSamy();
> CleanResults test = as.scan(input, antiSamyPolicy);
> List errors = test.getErrorMessages();
> if ( errors.size() > 0 ) {
> // just create new exception to get it logged
> and intrusion detected
> new ValidationException( "Invalid HTML input:
> context=" + context, "Invalid HTML input: context=" + context + ", errors=" +
> errors, context );
> }
> {code}
> I guess that is an expected, although maybe not clearly documented behavior
> of ESAPI: Non-cleanable violations throw the exception and therefore will
> fail the ofbiz service, while non-allowed tags are cleaned. However, if you
> consider ModelService:588 and following lines again:
> {code}
> StringUtil.checkStringForHtmlSafeOnly(modelParam.name, value,
> errorMessageList);
> //(...)
> if (errorMessageList.size() > 0) {
> throw new ServiceValidationException(errorMessageList, this,
> mode);
> }
> {code}
> the cleaned return value is ignored. Therefore, you will see an
> "IntrusionDetection" in the logs, giving you a false sense of security but
> the unfiltered HTML will still go into the service. So, if you want the
> service to fail if non-allowed HTML is encountered, you should use
> isValidSafeHTML instead. If you want the incoming HTML to be filtered, you
> should use the return value of getValidSafeHTML.
> Some additional notes on this:
> * When changing this, it should be properly documented as users may well be
> relying on this behavior - for example, we send full HTML mails to our
> customers for their ecommerce purchases and require HTML to go through - so
> maybe for services like the communicationEvents allowing only safe HTML might
> not be desired.
> * The ESAPI code samples above are from version 1.4.4. I was really surprised
> to find a JAR that is not only outdated, but patched and built by a third
> party, without even indicating that in the filename in OfBiz trunk. This has
> been there for years (see OFBIZ-3135) and should really be replaced with an
> official, up to date version since that
[jira] [Updated] (OFBIZ-5254) Services allow arbitrary HTML for parameters with allow-html set to "safe"
[
https://issues.apache.org/jira/browse/OFBIZ-5254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-5254:
---
Attachment: OFBIZ-5254.patch
> Services allow arbitrary HTML for parameters with allow-html set to "safe"
> --
>
> Key: OFBIZ-5254
> URL: https://issues.apache.org/jira/browse/OFBIZ-5254
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Christoph Neuroth
>Assignee: Jacques Le Roux
>Priority: Critical
> Labels: security
> Attachments: OFBIZ-5254.patch, OFBIZ-5254.patch, OFBIZ-5254.patch,
> OFBIZ-5254.patch, OFBIZ-5254.patch, OFBIZ-5254.patch, UtilCodec.java
>
>
> For any given service with allow-html=safe parameters, the parameter data is
> not properly validated. See Model.Service.java:588:
> {code}
>
> StringUtil.checkStringForHtmlSafeOnly(modelParam.name, value,
> errorMessageList);
> {code}
> Looking at that method:
> {code}
> public static String checkStringForHtmlSafeOnly(String valueName, String
> value, List errorMessageList) {
> ValidationErrorList vel = new ValidationErrorList();
> value = defaultWebValidator.getValidSafeHTML(valueName, value,
> Integer.MAX_VALUE, true, vel);
> errorMessageList.addAll(UtilGenerics.checkList(vel.errors(),
> String.class));
> return value;
> }
> {code}
> you can see that it expects the defaultWebValidator.getValidSafeHTML would
> add all validation errors to the given ValidationErrorList, but if you look
> at the implementation of ESAPI that is not the case. First, consider the
> overloaded getValidSafeHTML that takes the ValidationErrorList:
> {code}public String getValidSafeHTML(String context, String input,
> int maxLength, boolean allowNull, ValidationErrorList errors) throws
> IntrusionException {
> try {
> return getValidSafeHTML(context, input, maxLength,
> allowNull);
> } catch (ValidationException e) {
> errors.addError(context, e);
> }
> return input;
> }
> {code}
> Then, step into that method to see that ValidationExceptions are only thrown
> for things like exceeding the maximum length - not for policy violations that
> can be "cleaned", such as tags that are not allowed by the policy:
> {code}
> AntiSamy as = new AntiSamy();
> CleanResults test = as.scan(input, antiSamyPolicy);
> List errors = test.getErrorMessages();
> if ( errors.size() > 0 ) {
> // just create new exception to get it logged
> and intrusion detected
> new ValidationException( "Invalid HTML input:
> context=" + context, "Invalid HTML input: context=" + context + ", errors=" +
> errors, context );
> }
> {code}
> I guess that is an expected, although maybe not clearly documented behavior
> of ESAPI: Non-cleanable violations throw the exception and therefore will
> fail the ofbiz service, while non-allowed tags are cleaned. However, if you
> consider ModelService:588 and following lines again:
> {code}
> StringUtil.checkStringForHtmlSafeOnly(modelParam.name, value,
> errorMessageList);
> //(...)
> if (errorMessageList.size() > 0) {
> throw new ServiceValidationException(errorMessageList, this,
> mode);
> }
> {code}
> the cleaned return value is ignored. Therefore, you will see an
> "IntrusionDetection" in the logs, giving you a false sense of security but
> the unfiltered HTML will still go into the service. So, if you want the
> service to fail if non-allowed HTML is encountered, you should use
> isValidSafeHTML instead. If you want the incoming HTML to be filtered, you
> should use the return value of getValidSafeHTML.
> Some additional notes on this:
> * When changing this, it should be properly documented as users may well be
> relying on this behavior - for example, we send full HTML mails to our
> customers for their ecommerce purchases and require HTML to go through - so
> maybe for services like the communicationEvents allowing only safe HTML might
> not be desired.
> * The ESAPI code samples above are from version 1.4.4. I was really surprised
> to find a JAR that is not only outdated, but patched and built by a third
> party, without even indicating that in the filename in OfBiz trunk. This has
> been there for years (see OFBIZ-3135) and should really be replaced with an
> official, up to date version since that issue was fixed upstream years ago.
--
This message was sent by Atlassian JIRA
[jira] [Updated] (OFBIZ-11049) massPrintOrders does not work
[
https://issues.apache.org/jira/browse/OFBIZ-11049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-11049:
Description:
When you try to print a list of orders you get:
{noformat}
2019-05-22 12:26:10,366 |OFBiz-JobQueue-0 |GenericServiceJob
|E| Async-Service failed.
org.apache.ofbiz.service.GenericServiceException: Service [sendPrintFromScreen]
target threw an unexpected exception (null)
at
org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:115)
~[ofbiz.jar:?]
at
org.apache.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
~[ofbiz.jar:?]
at
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:415)
~[ofbiz.jar:?]
at
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:240)
~[ofbiz.jar:?]
at
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
~[ofbiz.jar:?]
at
org.apache.ofbiz.service.job.GenericServiceJob.exec(GenericServiceJob.java:70)
[ofbiz.jar:?]
at org.apache.ofbiz.service.job.AbstractJob.run(AbstractJob.java:87)
[ofbiz.jar:?]
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[?:1.8.0_202]
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[?:1.8.0_202]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_202]
Caused by: java.lang.NullPointerException
at
org.apache.ofbiz.content.output.OutputServices.sendPrintFromScreen(OutputServices.java:115)
~[ofbiz.jar:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
~[?:1.8.0_202]
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
~[?:1.8.0_202]
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
~[?:1.8.0_202]
at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_202]
at
org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:100)
~[ofbiz.jar:?]
... 9 more
{noformat}
The problem is similar to what was resolved by
[r1806237|http://svn.apache.org/viewvc?view=revision=1806237] for
OFBIZ-9138
was:
When you try to print a list of orders you get:
{noformat}
2019-05-22 12:26:10,366 |OFBiz-JobQueue-0 |GenericServiceJob
|E| Async-Service failed.
org.apache.ofbiz.service.GenericServiceException: Service [sendPrintFromScreen]
target threw an unexpected exception (null)
at
org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:115)
~[ofbiz.jar:?]
at
org.apache.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
~[ofbiz.jar:?]
at
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:415)
~[ofbiz.jar:?]
at
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:240)
~[ofbiz.jar:?]
at
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
~[ofbiz.jar:?]
at
org.apache.ofbiz.service.job.GenericServiceJob.exec(GenericServiceJob.java:70)
[ofbiz.jar:?]
at org.apache.ofbiz.service.job.AbstractJob.run(AbstractJob.java:87)
[ofbiz.jar:?]
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[?:1.8.0_202]
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[?:1.8.0_202]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_202]
Caused by: java.lang.NullPointerException
at
org.apache.ofbiz.content.output.OutputServices.sendPrintFromScreen(OutputServices.java:115)
~[ofbiz.jar:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
~[?:1.8.0_202]
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
~[?:1.8.0_202]
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
~[?:1.8.0_202]
at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_202]
at
org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:100)
~[ofbiz.jar:?]
... 9 more
{noformat}
> massPrintOrders does not work
> -
>
> Key: OFBIZ-11049
> URL: https://issues.apache.org/jira/browse/OFBIZ-11049
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> When you try to print a list of orders you get:
> {noformat}
> 2019-05-22 12:26:10,366 |OFBiz-JobQueue-0 |GenericServiceJob
[jira] [Updated] (OFBIZ-11049) massPrintOrders does not work
[
https://issues.apache.org/jira/browse/OFBIZ-11049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-11049:
Description:
When you try to print a list of orders you get:
{noformat}
2019-05-22 12:26:10,366 |OFBiz-JobQueue-0 |GenericServiceJob
|E| Async-Service failed.
org.apache.ofbiz.service.GenericServiceException: Service [sendPrintFromScreen]
target threw an unexpected exception (null)
at
org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:115)
~[ofbiz.jar:?]
at
org.apache.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
~[ofbiz.jar:?]
at
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:415)
~[ofbiz.jar:?]
at
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:240)
~[ofbiz.jar:?]
at
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
~[ofbiz.jar:?]
at
org.apache.ofbiz.service.job.GenericServiceJob.exec(GenericServiceJob.java:70)
[ofbiz.jar:?]
at org.apache.ofbiz.service.job.AbstractJob.run(AbstractJob.java:87)
[ofbiz.jar:?]
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[?:1.8.0_202]
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[?:1.8.0_202]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_202]
Caused by: java.lang.NullPointerException
at
org.apache.ofbiz.content.output.OutputServices.sendPrintFromScreen(OutputServices.java:115)
~[ofbiz.jar:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
~[?:1.8.0_202]
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
~[?:1.8.0_202]
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
~[?:1.8.0_202]
at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_202]
at
org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:100)
~[ofbiz.jar:?]
... 9 more
{noformat}
was:
When you try to print a list of orders you get:
{noformat}
2019-05-22 12:18:00,274 |sse-nio-8443-exec-10 |ModelService
|E| [ModelService.validate] : {massPrintOrders} : (IN) Required test error:
org.apache.ofbiz.service.ServiceValidationException: The following required
paramete
r is missing: [IN] [massPrintOrders.orderIdList]
2019-05-22 12:18:00,274 |sse-nio-8443-exec-10 |ServiceDispatcher
|E| Incoming context (in runSync : massPrintOrders) does not match expected
requirements
org.apache.ofbiz.service.ServiceValidationException: The following required
parameter is missing: [IN] [massPrintOrders.orderIdList]
{noformat}
> massPrintOrders does not work
> -
>
> Key: OFBIZ-11049
> URL: https://issues.apache.org/jira/browse/OFBIZ-11049
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> When you try to print a list of orders you get:
> {noformat}
> 2019-05-22 12:26:10,366 |OFBiz-JobQueue-0 |GenericServiceJob
> |E| Async-Service failed.
> org.apache.ofbiz.service.GenericServiceException: Service
> [sendPrintFromScreen] target threw an unexpected exception (null)
> at
> org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:115)
> ~[ofbiz.jar:?]
> at
> org.apache.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
> ~[ofbiz.jar:?]
> at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:415)
> ~[ofbiz.jar:?]
> at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:240)
> ~[ofbiz.jar:?]
> at
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
> ~[ofbiz.jar:?]
> at
> org.apache.ofbiz.service.job.GenericServiceJob.exec(GenericServiceJob.java:70)
> [ofbiz.jar:?]
> at org.apache.ofbiz.service.job.AbstractJob.run(AbstractJob.java:87)
> [ofbiz.jar:?]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> [?:1.8.0_202]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> [?:1.8.0_202]
> at java.lang.Thread.run(Thread.java:748) [?:1.8.0_202]
> Caused by: java.lang.NullPointerException
> at
> org.apache.ofbiz.content.output.OutputServices.sendPrintFromScreen(OutputServices.java:115)
> ~[ofbiz.jar:?]
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
[jira] [Issue Comment Deleted] (OFBIZ-11049) massPrintOrders does not work
[
https://issues.apache.org/jira/browse/OFBIZ-11049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-11049:
Comment: was deleted
(was: My bad forgot to check to create the list of order to print :/ Actually
confused with another issue I got before)
> massPrintOrders does not work
> -
>
> Key: OFBIZ-11049
> URL: https://issues.apache.org/jira/browse/OFBIZ-11049
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> When you try to print a list of orders you get:
> {noformat}
> 2019-05-22 12:26:10,366 |OFBiz-JobQueue-0 |GenericServiceJob
> |E| Async-Service failed.
> org.apache.ofbiz.service.GenericServiceException: Service
> [sendPrintFromScreen] target threw an unexpected exception (null)
> at
> org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:115)
> ~[ofbiz.jar:?]
> at
> org.apache.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
> ~[ofbiz.jar:?]
> at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:415)
> ~[ofbiz.jar:?]
> at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:240)
> ~[ofbiz.jar:?]
> at
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
> ~[ofbiz.jar:?]
> at
> org.apache.ofbiz.service.job.GenericServiceJob.exec(GenericServiceJob.java:70)
> [ofbiz.jar:?]
> at org.apache.ofbiz.service.job.AbstractJob.run(AbstractJob.java:87)
> [ofbiz.jar:?]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> [?:1.8.0_202]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> [?:1.8.0_202]
> at java.lang.Thread.run(Thread.java:748) [?:1.8.0_202]
> Caused by: java.lang.NullPointerException
> at
> org.apache.ofbiz.content.output.OutputServices.sendPrintFromScreen(OutputServices.java:115)
> ~[ofbiz.jar:?]
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> ~[?:1.8.0_202]
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> ~[?:1.8.0_202]
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> ~[?:1.8.0_202]
> at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_202]
> at
> org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:100)
> ~[ofbiz.jar:?]
> ... 9 more
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Issue Comment Deleted] (OFBIZ-11049) massPrintOrders does not work
[
https://issues.apache.org/jira/browse/OFBIZ-11049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-11049:
Comment: was deleted
(was: Reopening, actually there was a problem similar to what was resolved by
[r1806237|http://svn.apache.org/viewvc?view=revision=1806237] for
OFBIZ-9138)
> massPrintOrders does not work
> -
>
> Key: OFBIZ-11049
> URL: https://issues.apache.org/jira/browse/OFBIZ-11049
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> When you try to print a list of orders you get:
> {noformat}
> 2019-05-22 12:26:10,366 |OFBiz-JobQueue-0 |GenericServiceJob
> |E| Async-Service failed.
> org.apache.ofbiz.service.GenericServiceException: Service
> [sendPrintFromScreen] target threw an unexpected exception (null)
> at
> org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:115)
> ~[ofbiz.jar:?]
> at
> org.apache.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
> ~[ofbiz.jar:?]
> at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:415)
> ~[ofbiz.jar:?]
> at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:240)
> ~[ofbiz.jar:?]
> at
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
> ~[ofbiz.jar:?]
> at
> org.apache.ofbiz.service.job.GenericServiceJob.exec(GenericServiceJob.java:70)
> [ofbiz.jar:?]
> at org.apache.ofbiz.service.job.AbstractJob.run(AbstractJob.java:87)
> [ofbiz.jar:?]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> [?:1.8.0_202]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> [?:1.8.0_202]
> at java.lang.Thread.run(Thread.java:748) [?:1.8.0_202]
> Caused by: java.lang.NullPointerException
> at
> org.apache.ofbiz.content.output.OutputServices.sendPrintFromScreen(OutputServices.java:115)
> ~[ofbiz.jar:?]
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> ~[?:1.8.0_202]
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> ~[?:1.8.0_202]
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> ~[?:1.8.0_202]
> at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_202]
> at
> org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:100)
> ~[ofbiz.jar:?]
> ... 9 more
> {noformat}
> The problem is similar to what was resolved by
> [r1806237|http://svn.apache.org/viewvc?view=revision=1806237] for
> OFBIZ-9138
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
