[jira] [Assigned] (OFBIZ-7735) OFBIZ-7471: Improve all the service level error messages for missing required field for party component
[ https://issues.apache.org/jira/browse/OFBIZ-7735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirti Arora reassigned OFBIZ-7735: -- Assignee: Kirti Arora (was: Suraj Khurana) > OFBIZ-7471: Improve all the service level error messages for missing required > field for party component > --- > > Key: OFBIZ-7735 > URL: https://issues.apache.org/jira/browse/OFBIZ-7735 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: 16.11.01 >Reporter: Ratnesh Upadhyay >Assignee: Kirti Arora >Priority: Minor > Attachments: OFBIZ-7735.patch > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (OFBIZ-11127) Code improvement in ShoppingCartEvents.java
[ https://issues.apache.org/jira/browse/OFBIZ-11127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-11127: - Attachment: (was: OFBIZ-11127.patch) > Code improvement in ShoppingCartEvents.java > --- > > Key: OFBIZ-11127 > URL: https://issues.apache.org/jira/browse/OFBIZ-11127 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-11127.patch > > > Method 'getCartObject' of ShoppingCartEvents class accessed incorrectly at > some places in ShoppingCartEvents class. > It should be called by following below syntax: > getCartObject(parameters); > > But, at some places, it is called incorrectly like this: > ShoppingCartEvents.getCartObject(parameters) > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (OFBIZ-11127) Code improvement in ShoppingCartEvents.java
[ https://issues.apache.org/jira/browse/OFBIZ-11127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-11127: - Attachment: OFBIZ-11127.patch > Code improvement in ShoppingCartEvents.java > --- > > Key: OFBIZ-11127 > URL: https://issues.apache.org/jira/browse/OFBIZ-11127 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-11127.patch > > > Method 'getCartObject' of ShoppingCartEvents class accessed incorrectly at > some places in ShoppingCartEvents class. > It should be called by following below syntax: > getCartObject(parameters); > > But, at some places, it is called incorrectly like this: > ShoppingCartEvents.getCartObject(parameters) > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-11127) Code improvement in ShoppingCartEvents.java
[ https://issues.apache.org/jira/browse/OFBIZ-11127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16894286#comment-16894286 ] Amit Gadaley commented on OFBIZ-11127: -- Provided updated patch. Thanks [~pawan.verma] for your inputs. > Code improvement in ShoppingCartEvents.java > --- > > Key: OFBIZ-11127 > URL: https://issues.apache.org/jira/browse/OFBIZ-11127 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-11127.patch > > > Method 'getCartObject' of ShoppingCartEvents class accessed incorrectly at > some places in ShoppingCartEvents class. > It should be called by following below syntax: > getCartObject(parameters); > > But, at some places, it is called incorrectly like this: > ShoppingCartEvents.getCartObject(parameters) > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-10971) Use ReturnContactMech entity
[ https://issues.apache.org/jira/browse/OFBIZ-10971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16894289#comment-16894289 ] Devanshu Vyas commented on OFBIZ-10971: --- Hello [~vaibhav.jain], I have reviewed the return flow and I agree with you to firstly save information in ReturnContactMech entity and then if necessary can be used later. I think we can simply create ReturnContactMech entity records from OrderContactMech records at the time of return items are added in the return. I am working on a patch and will soon upload it here. > Use ReturnContactMech entity > > > Key: OFBIZ-10971 > URL: https://issues.apache.org/jira/browse/OFBIZ-10971 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Vaibhav Jain >Assignee: Devanshu Vyas >Priority: Major > > Use ReturnContactMech entity to capture the contactMech information of > parties involved in a return like OrderContactMech is used of orders -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Assigned] (OFBIZ-7377) Introduce the option for specifying Check (Reference) Number upon using Check as payment method during ordering
[ https://issues.apache.org/jira/browse/OFBIZ-7377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley reassigned OFBIZ-7377: --- Assignee: Amit Gadaley > Introduce the option for specifying Check (Reference) Number upon using Check > as payment method during ordering > --- > > Key: OFBIZ-7377 > URL: https://issues.apache.org/jira/browse/OFBIZ-7377 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Swapnil Shah >Assignee: Amit Gadaley >Priority: Major > Attachments: OrdPmt.png > > > Currently there is no option during ordering to specify the actual Check > Number that could be used for making payment upon selecting Check as payment > method. > We could provide a text entry box for recording check number and same could > be set as Payment.PaymentRefNumber upon order creation. > Please refer to attached screenshot -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Assigned] (OFBIZ-9163) Purchase Invoice - Sales Tax & Accounting transaction
[ https://issues.apache.org/jira/browse/OFBIZ-9163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley reassigned OFBIZ-9163: --- Assignee: Amit Gadaley > Purchase Invoice - Sales Tax & Accounting transaction > -- > > Key: OFBIZ-9163 > URL: https://issues.apache.org/jira/browse/OFBIZ-9163 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk, Release Branch 16.11 > Environment: Windows 10, demo data >Reporter: Tyrone Winn >Assignee: Amit Gadaley >Priority: Minor > > When posting the accounting transactions for purchase invoices with tax the > journal is suspended as does not balance. (using demo data) > The process is: > 1. Create new invoice from "BigSupplier" > 2. Choose product "GZ-1006-1" and add a quantity and amount > 3. Click "Add Tax" > 4. Status to Approved > 5. Status to Ready > It would seem the creditors amount does not increase with the value of the > tax. > In looking at the service "createAcctgTransForPurchaseInvoice" in the > following file: > applications\accounting\minilang\ledger\GeneralLedgerServices.xml > it seems to be missing a call to the method "getInvoiceTaxTotal" when > compared to the "createAcctgTransForSalesInvoice" service. > When adding this to the "createAcctgTransForPurchaseInvoice" it works as > expected. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (OFBIZ-11127) Code improvement in ShoppingCartEvents.java
[ https://issues.apache.org/jira/browse/OFBIZ-11127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11127: Description: Method 'getCartObject' and 'destroyCart'of ShoppingCartEvents class accessed incorrectly at some places in ShoppingCartEvents class. It should be called by following below syntax: getCartObject(parameters); destroyCart(request, response); But, at some places, it is called incorrectly like this: ShoppingCartEvents.getCartObject(parameters) ShoppingCartEvents.destroyCart(request, response); was: Method 'getCartObject' of ShoppingCartEvents class accessed incorrectly at some places in ShoppingCartEvents class. It should be called by following below syntax: getCartObject(parameters); But, at some places, it is called incorrectly like this: ShoppingCartEvents.getCartObject(parameters) > Code improvement in ShoppingCartEvents.java > --- > > Key: OFBIZ-11127 > URL: https://issues.apache.org/jira/browse/OFBIZ-11127 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-11127.patch > > > Method 'getCartObject' and 'destroyCart'of ShoppingCartEvents class accessed > incorrectly at some places in ShoppingCartEvents class. > It should be called by following below syntax: > getCartObject(parameters); > destroyCart(request, response); > > But, at some places, it is called incorrectly like this: > ShoppingCartEvents.getCartObject(parameters) > ShoppingCartEvents.destroyCart(request, response); > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (OFBIZ-11144) Create Exchange Order button on Return screen is distorted
Devanshu Vyas created OFBIZ-11144: - Summary: Create Exchange Order button on Return screen is distorted Key: OFBIZ-11144 URL: https://issues.apache.org/jira/browse/OFBIZ-11144 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Trunk Reporter: Devanshu Vyas Steps to regenerate: # Go to return menu in [ordermgr|[https://demo-trunk.ofbiz.apache.org/ordermgr/control/findreturn]]. # Click on '*Create new return'* button. # Enter customer and company ID information and create the return. # On successful creation of return, click on Return Items menu item. # On the bottom of screen, click on "load order items for return" button. # Select items to return and then click on Return Selected Item(s) button at the bottom-right corner of the screen. The button alignment is not correct, and the screen UI looks distorted. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Closed] (OFBIZ-11127) Code improvement in ShoppingCartEvents.java
[ https://issues.apache.org/jira/browse/OFBIZ-11127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-11127. --- Thanks, [~amit.gadaley] for your contribution. > Code improvement in ShoppingCartEvents.java > --- > > Key: OFBIZ-11127 > URL: https://issues.apache.org/jira/browse/OFBIZ-11127 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Pawan Verma >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-11127.patch > > > Method 'getCartObject' and 'destroyCart'of ShoppingCartEvents class accessed > incorrectly at some places in ShoppingCartEvents class. > It should be called by following below syntax: > getCartObject(parameters); > destroyCart(request, response); > > But, at some places, it is called incorrectly like this: > ShoppingCartEvents.getCartObject(parameters) > ShoppingCartEvents.destroyCart(request, response); > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (OFBIZ-11121) Order status history should show party id instead of login id .
[ https://issues.apache.org/jira/browse/OFBIZ-11121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Kumar Pandey updated OFBIZ-11121: Attachment: orderStatus.diff > Order status history should show party id instead of login id . > > > Key: OFBIZ-11121 > URL: https://issues.apache.org/jira/browse/OFBIZ-11121 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 16.11, Release Branch 17.12 >Reporter: Ashish Kumar Pandey >Assignee: Ashish Kumar Pandey >Priority: Minor > Attachments: orderStatus.diff, orderStatus.png > > > Order status history is showing login id which is not correct instead it > should show the partyId -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Assigned] (OFBIZ-7377) Introduce the option for specifying Check (Reference) Number upon using Check as payment method during ordering
[ https://issues.apache.org/jira/browse/OFBIZ-7377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aishwary Shrivastava reassigned OFBIZ-7377: --- Assignee: Aishwary Shrivastava (was: Amit Gadaley) > Introduce the option for specifying Check (Reference) Number upon using Check > as payment method during ordering > --- > > Key: OFBIZ-7377 > URL: https://issues.apache.org/jira/browse/OFBIZ-7377 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Swapnil Shah >Assignee: Aishwary Shrivastava >Priority: Major > Attachments: OrdPmt.png > > > Currently there is no option during ordering to specify the actual Check > Number that could be used for making payment upon selecting Check as payment > method. > We could provide a text entry box for recording check number and same could > be set as Payment.PaymentRefNumber upon order creation. > Please refer to attached screenshot -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Assigned] (OFBIZ-11121) Order status history should show party id instead of login id .
[ https://issues.apache.org/jira/browse/OFBIZ-11121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Kumar Pandey reassigned OFBIZ-11121: --- Assignee: Pawan Verma (was: Ashish Kumar Pandey) > Order status history should show party id instead of login id . > > > Key: OFBIZ-11121 > URL: https://issues.apache.org/jira/browse/OFBIZ-11121 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 16.11, Release Branch 17.12 >Reporter: Ashish Kumar Pandey >Assignee: Pawan Verma >Priority: Minor > Attachments: orderStatus.diff, orderStatus.png > > > Order status history is showing login id which is not correct instead it > should show the partyId -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (OFBIZ-11121) Order status history should show party id instead of login id .
[ https://issues.apache.org/jira/browse/OFBIZ-11121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11121: Affects Version/s: Release Branch 18.12 Trunk > Order status history should show party id instead of login id . > > > Key: OFBIZ-11121 > URL: https://issues.apache.org/jira/browse/OFBIZ-11121 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Ashish Kumar Pandey >Assignee: Pawan Verma >Priority: Minor > Attachments: orderStatus.diff, orderStatus.png > > > Order status history is showing login id which is not correct instead it > should show the partyId -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-9199) Order stores UnitListPrice with tax
[ https://issues.apache.org/jira/browse/OFBIZ-9199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16894297#comment-16894297 ] Rohit Hukkeri commented on OFBIZ-9199: -- Hello Ingo Wolfmayr, Can you please elaborate more on the issue as it is not getting clear with the screenshot attached Thanks! > Order stores UnitListPrice with tax > --- > > Key: OFBIZ-9199 > URL: https://issues.apache.org/jira/browse/OFBIZ-9199 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Ingo Wolfmayr >Priority: Minor > Attachments: lp.jpg > > > When creating an order, the orderitem stores as follows: > UnitPrice = 10 > UnitListPrice = 12 > ProductStore: showPriceWithTax=Y > Tax: SALES_TAX > Example: > Net price: 10 > Tax 20% > Gross price: 12 > Tax amout: 2 > Both prices should be stored without tax. This would be helpful when > calculating price savings. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Assigned] (OFBIZ-11038) Unable to view a PartyContent on view profile page of a party
[ https://issues.apache.org/jira/browse/OFBIZ-11038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Humera Khan reassigned OFBIZ-11038: --- Assignee: Humera Khan > Unable to view a PartyContent on view profile page of a party > - > > Key: OFBIZ-11038 > URL: https://issues.apache.org/jira/browse/OFBIZ-11038 > Project: OFBiz > Issue Type: Bug > Components: party >Reporter: Devanshu Vyas >Assignee: Humera Khan >Priority: Minor > Attachments: Error_message.png, PartyContent_View.png > > > * Go to [partymgr|https://demo-trunk.ofbiz.apache.org/partymgr/control/main] > * Search any party(e.g. DemoCustomer) > * Go to the [party > profile|https://demo-trunk.ofbiz.apache.org/partymgr/control/viewprofile?partyId=DemoCustomer] > page > * Go to Party Content section on the page and upload a file > * Select a purpose(Logo Image Url) and click on the Upload button > * On page refresh, click on the view button to view the image uploaded. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-9163) Purchase Invoice - Sales Tax & Accounting transaction
[ https://issues.apache.org/jira/browse/OFBIZ-9163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16894304#comment-16894304 ] Amit Gadaley commented on OFBIZ-9163: - Closing this bug as it has been fixed. > Purchase Invoice - Sales Tax & Accounting transaction > -- > > Key: OFBIZ-9163 > URL: https://issues.apache.org/jira/browse/OFBIZ-9163 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk, Release Branch 16.11 > Environment: Windows 10, demo data >Reporter: Tyrone Winn >Assignee: Amit Gadaley >Priority: Minor > > When posting the accounting transactions for purchase invoices with tax the > journal is suspended as does not balance. (using demo data) > The process is: > 1. Create new invoice from "BigSupplier" > 2. Choose product "GZ-1006-1" and add a quantity and amount > 3. Click "Add Tax" > 4. Status to Approved > 5. Status to Ready > It would seem the creditors amount does not increase with the value of the > tax. > In looking at the service "createAcctgTransForPurchaseInvoice" in the > following file: > applications\accounting\minilang\ledger\GeneralLedgerServices.xml > it seems to be missing a call to the method "getInvoiceTaxTotal" when > compared to the "createAcctgTransForSalesInvoice" service. > When adding this to the "createAcctgTransForPurchaseInvoice" it works as > expected. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Closed] (OFBIZ-9163) Purchase Invoice - Sales Tax & Accounting transaction
[ https://issues.apache.org/jira/browse/OFBIZ-9163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley closed OFBIZ-9163. --- Resolution: Fixed Fix Version/s: Trunk > Purchase Invoice - Sales Tax & Accounting transaction > -- > > Key: OFBIZ-9163 > URL: https://issues.apache.org/jira/browse/OFBIZ-9163 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk, Release Branch 16.11 > Environment: Windows 10, demo data >Reporter: Tyrone Winn >Assignee: Amit Gadaley >Priority: Minor > Fix For: Trunk > > > When posting the accounting transactions for purchase invoices with tax the > journal is suspended as does not balance. (using demo data) > The process is: > 1. Create new invoice from "BigSupplier" > 2. Choose product "GZ-1006-1" and add a quantity and amount > 3. Click "Add Tax" > 4. Status to Approved > 5. Status to Ready > It would seem the creditors amount does not increase with the value of the > tax. > In looking at the service "createAcctgTransForPurchaseInvoice" in the > following file: > applications\accounting\minilang\ledger\GeneralLedgerServices.xml > it seems to be missing a call to the method "getInvoiceTaxTotal" when > compared to the "createAcctgTransForSalesInvoice" service. > When adding this to the "createAcctgTransForPurchaseInvoice" it works as > expected. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
