[jira] [Commented] (OFBIZ-9988) Remove unused services from party/services_view.xml and PartyServices.java/.xml

[ https://issues.apache.org/jira/browse/OFBIZ-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033163#comment-17033163 ] Pierre Smits commented on OFBIZ-9988: - I agree with the latest from Michael. Moreover, the ticket

[jira] [Assigned] (OFBIZ-9988) Remove unused services from party/services_view.xml and PartyServices.java/.xml

[ https://issues.apache.org/jira/browse/OFBIZ-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-9988: Assignee: Michael Brohl (was: Jacques Le Roux) > Remove unused services from

[jira] [Commented] (OFBIZ-9988) Remove unused services from party/services_view.xml and PartyServices.java/.xml

[ https://issues.apache.org/jira/browse/OFBIZ-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033168#comment-17033168 ] Michael Brohl commented on OFBIZ-9988: -- I can do the revert, yes. For the refactoring part I leave

[jira] [Commented] (OFBIZ-9988) Remove unused services from party/services_view.xml and PartyServices.java/.xml

[ https://issues.apache.org/jira/browse/OFBIZ-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033154#comment-17033154 ] Michael Brohl commented on OFBIZ-9988: -- I think this should not be a blocker for the 17.12.01

[jira] [Commented] (OFBIZ-9988) Remove unused services from party/services_view.xml and PartyServices.java/.xml

[ https://issues.apache.org/jira/browse/OFBIZ-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033166#comment-17033166 ] Jacques Le Roux commented on OFBIZ-9988: +1, will you do it Michael? > Remove unused services

[jira] [Commented] (OFBIZ-9988) Remove unused services from party/services_view.xml and PartyServices.java/.xml

[ https://issues.apache.org/jira/browse/OFBIZ-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033170#comment-17033170 ] Michael Brohl commented on OFBIZ-9988: -- Ah, wait, OFBIZ-9982 indicates that this is done already?

[jira] [Commented] (OFBIZ-11306) POC for CSRF Token

[ https://issues.apache.org/jira/browse/OFBIZ-11306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033172#comment-17033172 ] Pierre Smits commented on OFBIZ-11306: -- I wonder why the priority of this ticket is set to

[jira] [Commented] (OFBIZ-11306) POC for CSRF Token

[ https://issues.apache.org/jira/browse/OFBIZ-11306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033173#comment-17033173 ] Michael Brohl commented on OFBIZ-11306: --- It's an improvement, not a security fix. The priority

[jira] [Updated] (OFBIZ-1525) Issue to group security concerns

[ https://issues.apache.org/jira/browse/OFBIZ-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-1525: Priority: Critical (was: Major) > Issue to group security concerns >

[jira] [Commented] (OFBIZ-11306) POC for CSRF Token

[ https://issues.apache.org/jira/browse/OFBIZ-11306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033185#comment-17033185 ] Jacques Le Roux commented on OFBIZ-11306: - Yes, though it's easy to point that a CSRF

[jira] [Commented] (OFBIZ-11306) POC for CSRF Token

[ https://issues.apache.org/jira/browse/OFBIZ-11306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033186#comment-17033186 ] Jacques Le Roux commented on OFBIZ-11306: - Please find attached an alternative patch which is

[jira] [Updated] (OFBIZ-11306) POC for CSRF Token

[ https://issues.apache.org/jira/browse/OFBIZ-11306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong updated OFBIZ-11306: --- Attachment: OFBIZ-11306-alternative.patch > POC for CSRF Token > -- > >

[jira] [Commented] (OFBIZ-11306) POC for CSRF Token

[ https://issues.apache.org/jira/browse/OFBIZ-11306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033203#comment-17033203 ] Jacques Le Roux commented on OFBIZ-11306: - Something annoying when you lose your session

[jira] [Commented] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0

[ https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033245#comment-17033245 ] Gareth Carter commented on OFBIZ-6705: -- However you wish. For consistency it would make sense to

[jira] [Updated] (OFBIZ-11306) POC for CSRF Token

[ https://issues.apache.org/jira/browse/OFBIZ-11306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11306: Attachment: OFBIZ-11306-alternative.patch > POC for CSRF Token > -- > >

[jira] [Commented] (OFBIZ-9988) Remove unused services from party/services_view.xml and PartyServices.java/.xml

[ https://issues.apache.org/jira/browse/OFBIZ-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033222#comment-17033222 ] ASF subversion and git services commented on OFBIZ-9988: Commit

[jira] [Commented] (OFBIZ-9988) Remove unused services from party/services_view.xml and PartyServices.java/.xml

[ https://issues.apache.org/jira/browse/OFBIZ-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033275#comment-17033275 ] Jacques Le Roux commented on OFBIZ-9988: Thanks Michael > Remove unused services from

[jira] [Commented] (OFBIZ-11306) POC for CSRF Token

[ https://issues.apache.org/jira/browse/OFBIZ-11306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033206#comment-17033206 ] Jacques Le Roux commented on OFBIZ-11306: - Note that you can't not use brower history either

[jira] [Closed] (OFBIZ-9988) Remove unused services from party/services_view.xml and PartyServices.java/.xml

[ https://issues.apache.org/jira/browse/OFBIZ-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-9988. Fix Version/s: (was: 17.12.01) Resolution: Won't Do Ok, the commit r1819138 is reverted

[jira] [Commented] (OFBIZ-5409) JSON Response does not set http status on error

[ https://issues.apache.org/jira/browse/OFBIZ-5409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033241#comment-17033241 ] Gareth Carter commented on OFBIZ-5409: -- Good work Jacques, would it not be better to overhaul how

[jira] [Assigned] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0

[ https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-6705: Assignee: Michael Brohl (was: Gareth Carter) > some files set viewIndex to 1 by default

[jira] [Commented] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0

[ https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033247#comment-17033247 ] Michael Brohl commented on OFBIZ-6705: -- Thanks, [~gareth.carter] , I repeated the grep command on

[jira] [Commented] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0

[ https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033263#comment-17033263 ] Michael Brohl commented on OFBIZ-6705: -- This is a first (untested) patch for the remaining

[jira] [Updated] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0

[ https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-6705: - Attachment: OFBIZ-6705_2020.patch > some files set viewIndex to 1 by default rather than 0 >

[jira] [Comment Edited] (OFBIZ-9988) Remove unused services from party/services_view.xml and PartyServices.java/.xml

[ https://issues.apache.org/jira/browse/OFBIZ-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033199#comment-17033199 ] Jacques Le Roux edited comment on OFBIZ-9988 at 2/9/20 1:31 PM: Michael,

[jira] [Commented] (OFBIZ-9988) Remove unused services from party/services_view.xml and PartyServices.java/.xml

[ https://issues.apache.org/jira/browse/OFBIZ-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033199#comment-17033199 ] Jacques Le Roux commented on OFBIZ-9988: Michael, As their numbers show, the removing (r1819138)

[jira] [Commented] (OFBIZ-9988) Remove unused services from party/services_view.xml and PartyServices.java/.xml

[ https://issues.apache.org/jira/browse/OFBIZ-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033223#comment-17033223 ] ASF subversion and git services commented on OFBIZ-9988: Commit

[jira] [Commented] (OFBIZ-9988) Remove unused services from party/services_view.xml and PartyServices.java/.xml

[ https://issues.apache.org/jira/browse/OFBIZ-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033226#comment-17033226 ] ASF subversion and git services commented on OFBIZ-9988: Commit

[jira] [Commented] (OFBIZ-5409) JSON Response does not set http status on error

[ https://issues.apache.org/jira/browse/OFBIZ-5409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033276#comment-17033276 ] Jacques Le Roux commented on OFBIZ-5409: Yes maybe indeed. Correctly focused on OFBIZ-11306, that

[jira] [Commented] (OFBIZ-11306) POC for CSRF Token

[ https://issues.apache.org/jira/browse/OFBIZ-11306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033243#comment-17033243 ] James Yong commented on OFBIZ-11306: Hi Jacques, I am fine with not using UtilCache for storing the

[jira] [Commented] (OFBIZ-11333) Cookie Consent In E-Commerce

[ https://issues.apache.org/jira/browse/OFBIZ-11333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033404#comment-17033404 ] Michael Brohl commented on OFBIZ-11333: --- Hi [~adityasharma] , thanks for your work so far!

[jira] [Comment Edited] (OFBIZ-11333) Cookie Consent In E-Commerce

[ https://issues.apache.org/jira/browse/OFBIZ-11333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033398#comment-17033398 ] Aditya Sharma edited comment on OFBIZ-11333 at 2/10/20 6:48 AM: Thanks

[jira] [Commented] (OFBIZ-11333) Cookie Consent In E-Commerce

[ https://issues.apache.org/jira/browse/OFBIZ-11333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033410#comment-17033410 ] Aditya Sharma commented on OFBIZ-11333: --- {quote}Does this mean that it does not support

[jira] [Commented] (OFBIZ-11333) Cookie Consent In E-Commerce

[ https://issues.apache.org/jira/browse/OFBIZ-11333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033398#comment-17033398 ] Aditya Sharma commented on OFBIZ-11333: --- Thanks [~mbrohl] :) Here is the PR that implements it

[jira] [Comment Edited] (OFBIZ-11333) Cookie Consent In E-Commerce

[ https://issues.apache.org/jira/browse/OFBIZ-11333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033410#comment-17033410 ] Aditya Sharma edited comment on OFBIZ-11333 at 2/10/20 7:28 AM:

[jira] [Comment Edited] (OFBIZ-5409) JSON Response does not set http status on error

[ https://issues.apache.org/jira/browse/OFBIZ-5409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033276#comment-17033276 ] Jacques Le Roux edited comment on OFBIZ-5409 at 2/9/20 10:08 PM: - Yes

[jira] [Commented] (OFBIZ-11306) POC for CSRF Token

[ https://issues.apache.org/jira/browse/OFBIZ-11306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033305#comment-17033305 ] Jacques Le Roux commented on OFBIZ-11306: - Thanks James, {noformat} I get this (despite a