[jira] [Created] (OFBIZ-11755) Cleanup Party profile menu

2020-05-29 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-11755:


 Summary: Cleanup Party profile menu
 Key: OFBIZ-11755
 URL: https://issues.apache.org/jira/browse/OFBIZ-11755
 Project: OFBiz
  Issue Type: Improvement
  Components: party
Affects Versions: Trunk
Reporter: Pierre Smits
Assignee: Pierre Smits
 Attachments: Screen Shot 2020-05-29 at 11.26.07.png

See attached image.

Over the years the party component has grown in a kind of catch all for various 
overviews and links to other (dependent) webapp widgets and templates.

The component and it functions should be used for user management functions, 
not for enabling to create/edit/delete any other record where a partyId is used 
that is part of another (dependent) component.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11708) sort-order (field) not works in CompoundWidgets file

2020-05-29 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119451#comment-17119451
 ] 

ASF subversion and git services commented on OFBIZ-11708:
-

Commit 88f87f27f06a6dcba3f44f6e4dda272fcc032d95 in ofbiz-framework's branch 
refs/heads/release18.12 from Olivier Heintz
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=88f87f2 ]

fixed: sort-order (field) not works in CompoundWidgets file (OFBIZ-11708)

In a form, when  sort-order (field) not works in CompoundWidgets file
> 
>
> Key: OFBIZ-11708
> URL: https://issues.apache.org/jira/browse/OFBIZ-11708
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/widget
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Olivier Heintz
>Priority: Minor
>  Labels: framework, widget
> Fix For: Trunk
>
> Attachments: 
> OFBIZ-11708_0001-fixed-sort-order-field-not-works-in-CompoundWidgets.patch
>
>
> In a form, when  because, getTagName() is used not the getLocalName()
> getTagName() retun "wf:sort-field" when getLocalName return "sort-field"
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11708) sort-order (field) not works in CompoundWidgets file

2020-05-29 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz updated OFBIZ-11708:
---
Fix Version/s: Release Branch 18.12

> sort-order (field) not works in CompoundWidgets file
> 
>
> Key: OFBIZ-11708
> URL: https://issues.apache.org/jira/browse/OFBIZ-11708
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/widget
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Olivier Heintz
>Priority: Minor
>  Labels: framework, widget
> Fix For: Release Branch 18.12, Trunk
>
> Attachments: 
> OFBIZ-11708_0001-fixed-sort-order-field-not-works-in-CompoundWidgets.patch
>
>
> In a form, when  because, getTagName() is used not the getLocalName()
> getTagName() retun "wf:sort-field" when getLocalName return "sort-field"
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11645) Simple-methods optional in compound file (mini-langue is deprecated)

2020-05-29 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz closed OFBIZ-11645.
--
Fix Version/s: Trunk
 Assignee: Olivier Heintz
   Resolution: Implemented

> Simple-methods optional in compound file (mini-langue is deprecated)
> 
>
> Key: OFBIZ-11645
> URL: https://issues.apache.org/jira/browse/OFBIZ-11645
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Olivier Heintz
>Priority: Minor
>  Labels: widget
> Fix For: Trunk
>
> Attachments: 
> OFBIZ-11645_0001-simple-methods-optional-in-compound-file.patch
>
>
> As mini-langue is deprecated,  files



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-11754) Create Payment service throws exception when receiving payment on order

2020-05-29 Thread Priya Sharma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119464#comment-17119464
 ] 

Priya Sharma edited comment on OFBIZ-11754 at 5/29/20, 10:11 AM:
-

Thanks for your inputs, [~surajk].

I have tried to fix it in a similar way.
 I have instead used the logInfo method directly, which is defined in 
org/apache/ofbiz/service/engine/GroovyBaseScript.groovy
 and does not require module to be passed explicitly. 

Please let me know if this approach looks good to you or we can do something 
better.

And for a similar change in other services, we could plan a separate ticket, 
WDYT?


was (Author: priya.sharma.9362):
Yes [~surajk], Thanks for your inputs.

I have tried to fix it in a similar way.
I have instead used the logInfo method directly, which is defined in 
org/apache/ofbiz/service/engine/GroovyBaseScript.groovy
and does not require module to be passed explicitly. 

Please let me know if this approach looks good to you or we can do something 
better.

And for a similar change in other services, we could plan a separate ticket, 
WDYT?

> Create Payment service throws exception when receiving payment on order
> ---
>
> Key: OFBIZ-11754
> URL: https://issues.apache.org/jira/browse/OFBIZ-11754
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Priya Sharma
>Assignee: Priya Sharma
>Priority: Minor
> Attachments: Screenshot from 2020-05-29 14-00-57.png
>
>
> Steps to regenerate -
>  # Create a fresh order with COD payment mode
>  # Try to receive payment as PETTY_CASH payment method
> Please refer the screenshot for more details.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Reopened] (OFBIZ-8014) Introduce the "Product" Screen under Party app to manage the products supplied by any supplier

2020-05-29 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl reopened OFBIZ-8014:
--
  Assignee: Chinmay Patidar  (was: Pierre Smits)

Reopening and issigning back to [~chinmay.patidar] to give him a chance to 
start a discussion on the mailinglist as proposed by [~pawan] .

> Introduce the "Product" Screen under Party app to manage the products 
> supplied by any supplier
> --
>
> Key: OFBIZ-8014
> URL: https://issues.apache.org/jira/browse/OFBIZ-8014
> Project: OFBiz
>  Issue Type: New Feature
>  Components: party
>Affects Versions: Release Branch 14.12, 16.11.01, Release Branch 15.12
>Reporter: Swapnil Shah
>Assignee: Chinmay Patidar
>Priority: Major
> Attachments: OFBIZ-8014.patch, OFBIZ-8014.patch, SupplierProduct.png
>
>
> Currently, upon logging into the Party application (or login as supplier 
> itself) and go to any specific supplier view then there is no way to manage 
> the list of supplied products. 
> # We can try introducing the "Product" tab/screen along with other tabs. (to 
> begin with we can simply mimic the Supplier screen from Catalog app e.g., 
> https://ofbiz-vm.apache.org:8443/catalog/control/EditProductSuppliers?productId=MAT_A_COST)
>  
> # We can also choose to show the "Products" tab for only Parties in supplier 
> role and later can try to extend for other roles with further needed 
> refinements. 
> Please refer to attached screenshot for the same.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11754) Create Payment service throws exception when receiving payment on order

2020-05-29 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-11754:
-

Assignee: Suraj Khurana  (was: Priya Sharma)

> Create Payment service throws exception when receiving payment on order
> ---
>
> Key: OFBIZ-11754
> URL: https://issues.apache.org/jira/browse/OFBIZ-11754
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Priya Sharma
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: Screenshot from 2020-05-29 14-00-57.png
>
>
> Steps to regenerate -
>  # Create a fresh order with COD payment mode
>  # Try to receive payment as PETTY_CASH payment method
> Please refer the screenshot for more details.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11676) drop-down field not work when in a compound-widget file

2020-05-29 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz updated OFBIZ-11676:
---
Fix Version/s: Release Branch 18.12

> drop-down field not work when in a compound-widget file
> ---
>
> Key: OFBIZ-11676
> URL: https://issues.apache.org/jira/browse/OFBIZ-11676
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/widget
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Olivier Heintz
>Priority: Minor
>  Labels: framework, widget
> Fix For: Release Branch 18.12, Trunk
>
> Attachments: ModelFormField.java.patch
>
>
> When, in ModelFormField, FieldInfoWithOptions (which read xml file ) is call, 
> test on tag name is done with getName() and not getLocalName() so none 
> "option" is recognize when field is declare on a compound-widget file,
> This patch change getName to getLocalName
> [^ModelFormField.java.patch]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11708) sort-order (field) not works in CompoundWidgets file

2020-05-29 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119447#comment-17119447
 ] 

ASF subversion and git services commented on OFBIZ-11708:
-

Commit 097db39ee03905fe502180d9a0dc3bf635b546e6 in ofbiz-framework's branch 
refs/heads/trunk from Olivier Heintz
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=097db39 ]

fixed: sort-order (field) not works in CompoundWidgets file (OFBIZ-11708)

In a form, when  sort-order (field) not works in CompoundWidgets file
> 
>
> Key: OFBIZ-11708
> URL: https://issues.apache.org/jira/browse/OFBIZ-11708
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/widget
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Minor
>  Labels: framework, widget
> Fix For: Trunk
>
> Attachments: 
> OFBIZ-11708_0001-fixed-sort-order-field-not-works-in-CompoundWidgets.patch
>
>
> In a form, when  because, getTagName() is used not the getLocalName()
> getTagName() retun "wf:sort-field" when getLocalName return "sort-field"
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11708) sort-order (field) not works in CompoundWidgets file

2020-05-29 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz closed OFBIZ-11708.
--
  Assignee: Olivier Heintz
Resolution: Fixed

> sort-order (field) not works in CompoundWidgets file
> 
>
> Key: OFBIZ-11708
> URL: https://issues.apache.org/jira/browse/OFBIZ-11708
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/widget
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Olivier Heintz
>Priority: Minor
>  Labels: framework, widget
> Fix For: Trunk
>
> Attachments: 
> OFBIZ-11708_0001-fixed-sort-order-field-not-works-in-CompoundWidgets.patch
>
>
> In a form, when  because, getTagName() is used not the getLocalName()
> getTagName() retun "wf:sort-field" when getLocalName return "sort-field"
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #166: [Fixed]: Create Payment service throws an exception when receiving payment on order (OFBIZ-11754)

2020-05-29 Thread GitBox


sonarcloud[bot] commented on pull request #166:
URL: https://github.com/apache/ofbiz-framework/pull/166#issuecomment-635888789


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=166)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=166=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=166=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-11645) Simple-methods optional in compound file (mini-langue is deprecated)

2020-05-29 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119457#comment-17119457
 ] 

ASF subversion and git services commented on OFBIZ-11645:
-

Commit 1f673804a41dde2a938f76a9f49fd783074fd7d5 in ofbiz-framework's branch 
refs/heads/trunk from Olivier Heintz
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=1f67380 ]

Improved: put simple-method optional for compound file (OFBIZ-11645)


> Simple-methods optional in compound file (mini-langue is deprecated)
> 
>
> Key: OFBIZ-11645
> URL: https://issues.apache.org/jira/browse/OFBIZ-11645
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Minor
>  Labels: widget
> Attachments: 
> OFBIZ-11645_0001-simple-methods-optional-in-compound-file.patch
>
>
> As mini-langue is deprecated,  files



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] priyasharma1 opened a new pull request #166: [Fixed]: Create Payment service throws an exception when receiving payment on order

2020-05-29 Thread GitBox


priyasharma1 opened a new pull request #166:
URL: https://github.com/apache/ofbiz-framework/pull/166


   
   (OFBIZ-11754)
   
   - Since the MODULE variable could not be found, the service was throwing 
error, thus removed the variable
   - Instead used the groovy "logInfo" method directly to print the log, which 
has access to the module variable implicitly.
   - Removed the unused import, as Debug class is no longer needed here.
   
   Thanks: Pawan Verma for the guidance and discussion
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (OFBIZ-11754) Create Payment service throws exception when receiving payment on order

2020-05-29 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-11754:
--
Component/s: accounting

> Create Payment service throws exception when receiving payment on order
> ---
>
> Key: OFBIZ-11754
> URL: https://issues.apache.org/jira/browse/OFBIZ-11754
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, order
>Affects Versions: Trunk
>Reporter: Priya Sharma
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: Screenshot from 2020-05-29 14-00-57.png
>
>
> Steps to regenerate -
>  # Create a fresh order with COD payment mode
>  # Try to receive payment as PETTY_CASH payment method
> Please refer the screenshot for more details.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11754) Create Payment service throws exception when receiving payment on order

2020-05-29 Thread Suraj Khurana (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119537#comment-17119537
 ] 

Suraj Khurana commented on OFBIZ-11754:
---

Thanks for the PR. Looks good to me (y)

> Create Payment service throws exception when receiving payment on order
> ---
>
> Key: OFBIZ-11754
> URL: https://issues.apache.org/jira/browse/OFBIZ-11754
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, order
>Affects Versions: Trunk
>Reporter: Priya Sharma
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: Screenshot from 2020-05-29 14-00-57.png
>
>
> Steps to regenerate -
>  # Create a fresh order with COD payment mode
>  # Try to receive payment as PETTY_CASH payment method
> Please refer the screenshot for more details.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11676) drop-down field not work when in a compound-widget file

2020-05-29 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119442#comment-17119442
 ] 

ASF subversion and git services commented on OFBIZ-11676:
-

Commit 6e845ccfc4fe056e4e8cf2e54af9d47478d54ffa in ofbiz-framework's branch 
refs/heads/release18.12 from Olivier Heintz
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=6e845cc ]

Fixed: drop-down field not work when in a compound-widget file (OFBIZ-11676)

When, in ModelFormField, FieldInfoWithOptions (which read xml file ) is
call, test on tag name is done with getName() and not getLocalName() so
none "option" is recognize when field is declare on a compound-widget
file. getName() is change to getLocalName()


> drop-down field not work when in a compound-widget file
> ---
>
> Key: OFBIZ-11676
> URL: https://issues.apache.org/jira/browse/OFBIZ-11676
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/widget
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Olivier Heintz
>Priority: Minor
>  Labels: framework, widget
> Fix For: Trunk
>
> Attachments: ModelFormField.java.patch
>
>
> When, in ModelFormField, FieldInfoWithOptions (which read xml file ) is call, 
> test on tag name is done with getName() and not getLocalName() so none 
> "option" is recognize when field is declare on a compound-widget file,
> This patch change getName to getLocalName
> [^ModelFormField.java.patch]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11754) Create Payment service throws exception when receiving payment on order

2020-05-29 Thread Priya Sharma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119464#comment-17119464
 ] 

Priya Sharma commented on OFBIZ-11754:
--

Yes [~surajk], Thanks for your inputs.

I have tried to fix it in a similar way.
I have instead used the logInfo method directly, which is defined in 
org/apache/ofbiz/service/engine/GroovyBaseScript.groovy
and does not require module to be passed explicitly. 

Please let me know if this approach looks good to you or we can do something 
better.

And for a similar change in other services, we could plan a separate ticket, 
WDYT?

> Create Payment service throws exception when receiving payment on order
> ---
>
> Key: OFBIZ-11754
> URL: https://issues.apache.org/jira/browse/OFBIZ-11754
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Priya Sharma
>Assignee: Priya Sharma
>Priority: Minor
> Attachments: Screenshot from 2020-05-29 14-00-57.png
>
>
> Steps to regenerate -
>  # Create a fresh order with COD payment mode
>  # Try to receive payment as PETTY_CASH payment method
> Please refer the screenshot for more details.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #166: Fixed: Create Payment service throws an exception when receiving payment on order (OFBIZ-11754)

2020-05-29 Thread GitBox


sonarcloud[bot] removed a comment on pull request #166:
URL: https://github.com/apache/ofbiz-framework/pull/166#issuecomment-635888789


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=166)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=166=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=166=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-11754) Create Payment service throws exception when receiving payment on order

2020-05-29 Thread Priya Sharma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119533#comment-17119533
 ] 

Priya Sharma commented on OFBIZ-11754:
--

Hello Suraj,

I have added these changes in the ContentServices.groovy as well.
Please have look and let me know in case I have missed anything.

Thanks!

> Create Payment service throws exception when receiving payment on order
> ---
>
> Key: OFBIZ-11754
> URL: https://issues.apache.org/jira/browse/OFBIZ-11754
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, order
>Affects Versions: Trunk
>Reporter: Priya Sharma
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: Screenshot from 2020-05-29 14-00-57.png
>
>
> Steps to regenerate -
>  # Create a fresh order with COD payment mode
>  # Try to receive payment as PETTY_CASH payment method
> Please refer the screenshot for more details.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #166: Fixed: Create Payment service throws an exception when receiving payment on order (OFBIZ-11754)

2020-05-29 Thread GitBox


sonarcloud[bot] commented on pull request #166:
URL: https://github.com/apache/ofbiz-framework/pull/166#issuecomment-635936986


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=166)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=166=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=166=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Closed] (OFBIZ-11739) Change resource with RESOURCE in all application components

2020-05-29 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-11739.
-
Fix Version/s: Upcoming Branch
   Resolution: Implemented

I checked with ./gradlew check and ./gradlew testIntegration.

Everything seems fine on my local.

Thanks Jacques for also checking it at you end.

> Change resource with RESOURCE in all application components
> ---
>
> Key: OFBIZ-11739
> URL: https://issues.apache.org/jira/browse/OFBIZ-11739
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11739.patch, OFBIZ-11739_plugins.patch
>
>
> As we have done it for modules, it is better to get this done for all 
> resource variables as well.
>  Also, we should make module and resource variables as private instead of 
> public



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11468) Convert ShipmentReceiptServices.xml mini lang to groovy

2020-05-29 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119375#comment-17119375
 ] 

Jacques Le Roux commented on OFBIZ-11468:
-

Hi Wiebke,

I'm slowly reviewning (1 method by day) by using GH review feature as a test...

> Convert ShipmentReceiptServices.xml mini lang to groovy
> ---
>
> Key: OFBIZ-11468
> URL: https://issues.apache.org/jira/browse/OFBIZ-11468
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Wiebke Pätzold
>Assignee: Wiebke Pätzold
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11754) Create Payment service throws exception when receiving payment on order

2020-05-29 Thread Priya Sharma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Priya Sharma updated OFBIZ-11754:
-
Priority: Minor  (was: Major)

> Create Payment service throws exception when receiving payment on order
> ---
>
> Key: OFBIZ-11754
> URL: https://issues.apache.org/jira/browse/OFBIZ-11754
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Priya Sharma
>Priority: Minor
> Attachments: Screenshot from 2020-05-29 14-00-57.png
>
>
> Steps to regenerate -
>  # Create a fresh order with COD payment mode
>  # Try to receive payment as PETTY_CASH payment method
> Please refer the screenshot for more details.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11754) Create Payment service throws exception when receiving payment on order

2020-05-29 Thread Priya Sharma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Priya Sharma updated OFBIZ-11754:
-
Component/s: order

> Create Payment service throws exception when receiving payment on order
> ---
>
> Key: OFBIZ-11754
> URL: https://issues.apache.org/jira/browse/OFBIZ-11754
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Reporter: Priya Sharma
>Priority: Major
> Attachments: Screenshot from 2020-05-29 14-00-57.png
>
>
> Steps to regenerate -
>  # Create a fresh order with COD payment mode
>  # Try to receive payment as PETTY_CASH payment method
> Please refer the screenshot for more details.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11754) Create Payment service throws exception when receiving payment on order

2020-05-29 Thread Priya Sharma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Priya Sharma updated OFBIZ-11754:
-
Affects Version/s: Trunk

> Create Payment service throws exception when receiving payment on order
> ---
>
> Key: OFBIZ-11754
> URL: https://issues.apache.org/jira/browse/OFBIZ-11754
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Priya Sharma
>Priority: Major
> Attachments: Screenshot from 2020-05-29 14-00-57.png
>
>
> Steps to regenerate -
>  # Create a fresh order with COD payment mode
>  # Try to receive payment as PETTY_CASH payment method
> Please refer the screenshot for more details.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11754) Create Payment service throws exception when receiving payment on order

2020-05-29 Thread Priya Sharma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Priya Sharma reassigned OFBIZ-11754:


Assignee: Priya Sharma

> Create Payment service throws exception when receiving payment on order
> ---
>
> Key: OFBIZ-11754
> URL: https://issues.apache.org/jira/browse/OFBIZ-11754
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Priya Sharma
>Assignee: Priya Sharma
>Priority: Minor
> Attachments: Screenshot from 2020-05-29 14-00-57.png
>
>
> Steps to regenerate -
>  # Create a fresh order with COD payment mode
>  # Try to receive payment as PETTY_CASH payment method
> Please refer the screenshot for more details.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11754) Create Payment service throws exception when receiving payment on order

2020-05-29 Thread Priya Sharma (Jira)
Priya Sharma created OFBIZ-11754:


 Summary: Create Payment service throws exception when receiving 
payment on order
 Key: OFBIZ-11754
 URL: https://issues.apache.org/jira/browse/OFBIZ-11754
 Project: OFBiz
  Issue Type: Bug
Reporter: Priya Sharma
 Attachments: Screenshot from 2020-05-29 14-00-57.png

Steps to regenerate -
 # Create a fresh order with COD payment mode
 # Try to receive payment as PETTY_CASH payment method

Please refer the screenshot for more details.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11739) Change resource with RESOURCE in all application components

2020-05-29 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119366#comment-17119366
 ] 

ASF subversion and git services commented on OFBIZ-11739:
-

Commit ae31c01fa7ee32dc3048dfd3332b0fb208511936 in ofbiz-plugins's branch 
refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=ae31c01 ]

Improved: Change resources with proper naming convention in all plugin 
components.
(OFBIZ-11739)
Also, made MODULE as private data member of class instead of public. Thanks 
Jacques for review.


> Change resource with RESOURCE in all application components
> ---
>
> Key: OFBIZ-11739
> URL: https://issues.apache.org/jira/browse/OFBIZ-11739
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11739.patch, OFBIZ-11739_plugins.patch
>
>
> As we have done it for modules, it is better to get this done for all 
> resource variables as well.
>  Also, we should make module and resource variables as private instead of 
> public



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11754) Create Payment service throws exception when receiving payment on order

2020-05-29 Thread Suraj Khurana (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119403#comment-17119403
 ] 

Suraj Khurana commented on OFBIZ-11754:
---

Thanks Priya,

It should be changed in two files 
applications/content/groovyScripts/content/ContentServices.groovy and 
applications/accounting/groovyScripts/payment/PaymentServices.groovy.

Just a suggestion to remove it from file level as already defined in 
org/apache/ofbiz/service/engine/GroovyBaseScript.groovy

HTH.

> Create Payment service throws exception when receiving payment on order
> ---
>
> Key: OFBIZ-11754
> URL: https://issues.apache.org/jira/browse/OFBIZ-11754
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Priya Sharma
>Assignee: Priya Sharma
>Priority: Minor
> Attachments: Screenshot from 2020-05-29 14-00-57.png
>
>
> Steps to regenerate -
>  # Create a fresh order with COD payment mode
>  # Try to receive payment as PETTY_CASH payment method
> Please refer the screenshot for more details.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11676) drop-down field not work when in a compound-widget file

2020-05-29 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119439#comment-17119439
 ] 

ASF subversion and git services commented on OFBIZ-11676:
-

Commit e4ee439e27e505d2ea32641e06b2fa4fa24a442e in ofbiz-framework's branch 
refs/heads/trunk from Olivier Heintz
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e4ee439 ]

Fixed: drop-down field not work when in a compound-widget file (OFBIZ-11676)

When, in ModelFormField, FieldInfoWithOptions (which read xml file ) is
call, test on tag name is done with getName() and not getLocalName() so
none "option" is recognize when field is declare on a compound-widget
file. getName() is change to getLocalName()


> drop-down field not work when in a compound-widget file
> ---
>
> Key: OFBIZ-11676
> URL: https://issues.apache.org/jira/browse/OFBIZ-11676
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/widget
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Minor
>  Labels: framework, widget
> Fix For: Trunk
>
> Attachments: ModelFormField.java.patch
>
>
> When, in ModelFormField, FieldInfoWithOptions (which read xml file ) is call, 
> test on tag name is done with getName() and not getLocalName() so none 
> "option" is recognize when field is declare on a compound-widget file,
> This patch change getName to getLocalName
> [^ModelFormField.java.patch]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11676) drop-down field not work when in a compound-widget file

2020-05-29 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz closed OFBIZ-11676.
--
  Assignee: Olivier Heintz
Resolution: Fixed

> drop-down field not work when in a compound-widget file
> ---
>
> Key: OFBIZ-11676
> URL: https://issues.apache.org/jira/browse/OFBIZ-11676
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/widget
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Olivier Heintz
>Priority: Minor
>  Labels: framework, widget
> Fix For: Trunk
>
> Attachments: ModelFormField.java.patch
>
>
> When, in ModelFormField, FieldInfoWithOptions (which read xml file ) is call, 
> test on tag name is done with getName() and not getLocalName() so none 
> "option" is recognize when field is declare on a compound-widget file,
> This patch change getName to getLocalName
> [^ModelFormField.java.patch]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11739) Change resource with RESOURCE in all application components

2020-05-29 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119371#comment-17119371
 ] 

ASF subversion and git services commented on OFBIZ-11739:
-

Commit abc7836ddeb45c54c92b2ec59589f6a79590ebb4 in ofbiz-framework's branch 
refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=abc7836 ]

Improved: Made MODULE as private data member of class instead of public in all 
framework components.
(OFBIZ-11739)
This will reduce checkstlye issues. Thanks Jacques for review.


> Change resource with RESOURCE in all application components
> ---
>
> Key: OFBIZ-11739
> URL: https://issues.apache.org/jira/browse/OFBIZ-11739
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11739.patch, OFBIZ-11739_plugins.patch
>
>
> As we have done it for modules, it is better to get this done for all 
> resource variables as well.
>  Also, we should make module and resource variables as private instead of 
> public



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11753) Add names to BuildBot builds

2020-05-29 Thread Jacques Le Roux (Jira)
Jacques Le Roux created OFBIZ-11753:
---

 Summary: Add names to BuildBot builds 
 Key: OFBIZ-11753
 URL: https://issues.apache.org/jira/browse/OFBIZ-11753
 Project: OFBiz
  Issue Type: Improvement
  Components: BuildBot
Reporter: Jacques Le Roux


It's more and more difficult to see what's going on in BuildBot status display. 
Adding names to builds will help.




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-8014) Introduce the "Product" Screen under Party app to manage the products supplied by any supplier

2020-05-29 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits closed OFBIZ-8014.
---
Resolution: Not A Problem

Closing as not a problem, due to lack of follow-up and consensus expressed in 
this ticket.

> Introduce the "Product" Screen under Party app to manage the products 
> supplied by any supplier
> --
>
> Key: OFBIZ-8014
> URL: https://issues.apache.org/jira/browse/OFBIZ-8014
> Project: OFBiz
>  Issue Type: New Feature
>  Components: party
>Affects Versions: Release Branch 14.12, 16.11.01, Release Branch 15.12
>Reporter: Swapnil Shah
>Assignee: Pierre Smits
>Priority: Major
> Attachments: OFBIZ-8014.patch, OFBIZ-8014.patch, SupplierProduct.png
>
>
> Currently, upon logging into the Party application (or login as supplier 
> itself) and go to any specific supplier view then there is no way to manage 
> the list of supplied products. 
> # We can try introducing the "Product" tab/screen along with other tabs. (to 
> begin with we can simply mimic the Supplier screen from Catalog app e.g., 
> https://ofbiz-vm.apache.org:8443/catalog/control/EditProductSuppliers?productId=MAT_A_COST)
>  
> # We can also choose to show the "Products" tab for only Parties in supplier 
> role and later can try to extend for other roles with further needed 
> refinements. 
> Please refer to attached screenshot for the same.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-8014) Introduce the "Product" Screen under Party app to manage the products supplied by any supplier

2020-05-29 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-8014:
---

Assignee: Pierre Smits  (was: Chinmay Patidar)

> Introduce the "Product" Screen under Party app to manage the products 
> supplied by any supplier
> --
>
> Key: OFBIZ-8014
> URL: https://issues.apache.org/jira/browse/OFBIZ-8014
> Project: OFBiz
>  Issue Type: New Feature
>  Components: party
>Affects Versions: Release Branch 14.12, 16.11.01, Release Branch 15.12
>Reporter: Swapnil Shah
>Assignee: Pierre Smits
>Priority: Major
> Attachments: OFBIZ-8014.patch, OFBIZ-8014.patch, SupplierProduct.png
>
>
> Currently, upon logging into the Party application (or login as supplier 
> itself) and go to any specific supplier view then there is no way to manage 
> the list of supplied products. 
> # We can try introducing the "Product" tab/screen along with other tabs. (to 
> begin with we can simply mimic the Supplier screen from Catalog app e.g., 
> https://ofbiz-vm.apache.org:8443/catalog/control/EditProductSuppliers?productId=MAT_A_COST)
>  
> # We can also choose to show the "Products" tab for only Parties in supplier 
> role and later can try to extend for other roles with further needed 
> refinements. 
> Please refer to attached screenshot for the same.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11752) CLONE - Check embedded Javascript libs vulnerabilities using retire.js

2020-05-29 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119329#comment-17119329
 ] 

Jacques Le Roux commented on OFBIZ-11752:
-

Thanks Aditya, +1

> CLONE - Check embedded Javascript libs vulnerabilities using retire.js
> --
>
> Key: OFBIZ-11752
> URL: https://issues.apache.org/jira/browse/OFBIZ-11752
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Major
>  Labels: Javascript, retire.js, vulnerabilities
>
> Trunk 
> {code:java}
> /ofbiz-framework/plugins/solr/webapp/solr/js/require.js
>  ↳ jquery 1.7.1
> jquery 1.7.1 has known vulnerabilities: severity: medium; CVE: CVE-2012-6708, 
> bug: 11290, summary: Selector interpreted as HTML; 
> http://bugs.jquery.com/ticket/11290 
> https://nvd.nist.gov/vuln/detail/CVE-2012-6708 
> http://research.insecurelabs.org/jquery/test/ severity: medium; issue: 2432, 
> summary: 3rd party CORS request may execute, CVE: CVE-2015-9251; 
> https://github.com/jquery/jquery/issues/2432 
> http://blog.jquery.com/2016/01/08/jquery-2-2-and-1-12-released/ 
> https://nvd.nist.gov/vuln/detail/CVE-2015-9251 
> http://research.insecurelabs.org/jquery/test/ severity: low; CVE: 
> CVE-2019-11358, summary: jQuery before 3.4.0, as used in Drupal, Backdrop 
> CMS, and other products, mishandles jQuery.extend(true, {}, ...) because of 
> Object.prototype pollution; 
> https://blog.jquery.com/2019/04/10/jquery-3-4-0-released/ 
> https://nvd.nist.gov/vuln/detail/CVE-2019-11358 
> https://github.com/jquery/jquery/commit/753d591aea698e57d6db58c9f722cd0808619b1b
>  severity: medium; summary: Regex in its jQuery.htmlPrefilter  sometimes may 
> introduce XSS; https://blog.jquery.com/2020/04/10/jquery-3-5-0-released/
> /ofbiz-framework/plugins/solr/webapp/solr/libs/angular-cookies.min.js
>  ↳ angularjs 1.3.8
> angularjs 1.3.8 has known vulnerabilities: severity: medium; summary: 
> Prototype pollution; 
> https://github.com/angular/angular.js/commit/726f49dcf6c23106ddaf5cfd5e2e592841db743a
>  
> https://github.com/angular/angular.js/blob/master/CHANGELOG.md#179-pollution-eradication-2019-11-19
>  severity: medium; summary: The attribute usemap can be used as a security 
> exploit; 
> https://github.com/angular/angular.js/blob/master/CHANGELOG.md#1230-patronal-resurrection-2016-07-21
>  severity: medium; summary: Universal CSP bypass via add-on in Firefox; 
> https://github.com/mozilla/addons-linter/issues/1000#issuecomment-282083435 
> http://pastebin.com/raw/kGrdaypP severity: medium; summary: DOS in $sanitize; 
> https://github.com/angular/angular.js/blob/master/CHANGELOG.md 
> https://github.com/angular/angular.js/pull/15699 severity: low; summary: XSS 
> in $sanitize in Safari/Firefox; 
> https://github.com/angular/angular.js/commit/8f31f1ff43b673a24f84422d5c13d6312b2c4d94
> /ofbiz-framework/plugins/solr/webapp/solr/libs/angular-resource.min.js
>  ↳ angularjs 1.3.8
> angularjs 1.3.8 has known vulnerabilities: severity: medium; summary: 
> Prototype pollution; 
> https://github.com/angular/angular.js/commit/726f49dcf6c23106ddaf5cfd5e2e592841db743a
>  
> https://github.com/angular/angular.js/blob/master/CHANGELOG.md#179-pollution-eradication-2019-11-19
>  severity: medium; summary: The attribute usemap can be used as a security 
> exploit; 
> https://github.com/angular/angular.js/blob/master/CHANGELOG.md#1230-patronal-resurrection-2016-07-21
>  severity: medium; summary: Universal CSP bypass via add-on in Firefox; 
> https://github.com/mozilla/addons-linter/issues/1000#issuecomment-282083435 
> http://pastebin.com/raw/kGrdaypP severity: medium; summary: DOS in $sanitize; 
> https://github.com/angular/angular.js/blob/master/CHANGELOG.md 
> https://github.com/angular/angular.js/pull/15699 severity: low; summary: XSS 
> in $sanitize in Safari/Firefox; 
> https://github.com/angular/angular.js/commit/8f31f1ff43b673a24f84422d5c13d6312b2c4d94
> /ofbiz-framework/plugins/solr/webapp/solr/libs/angular-route.min.js
>  ↳ angularjs 1.3.8
> angularjs 1.3.8 has known vulnerabilities: severity: medium; summary: 
> Prototype pollution; 
> https://github.com/angular/angular.js/commit/726f49dcf6c23106ddaf5cfd5e2e592841db743a
>  
> https://github.com/angular/angular.js/blob/master/CHANGELOG.md#179-pollution-eradication-2019-11-19
>  severity: medium; summary: The attribute usemap can be used as a security 
> exploit; 
> https://github.com/angular/angular.js/blob/master/CHANGELOG.md#1230-patronal-resurrection-2016-07-21
>  severity: medium; summary: Universal CSP bypass via add-on in Firefox; 
> https://github.com/mozilla/addons-linter/issues/1000#issuecomment-282083435 
> http://pastebin.com/raw/kGrdaypP severity: 

[jira] [Commented] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git

2020-05-29 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119336#comment-17119336
 ] 

Jacques Le Roux commented on OFBIZ-11745:
-

The only minor issue with  plugins/* vs  plugins/ is that when you embedd the 
plugins repo in the framework repo then you see it in git status, not a big 
deal.

> plugins in common-theme/webapp/common/js is not monitored by git
> 
>
> Key: OFBIZ-11745
> URL: https://issues.apache.org/jira/browse/OFBIZ-11745
> Project: OFBiz
>  Issue Type: Bug
>  Components: git
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Olivier Heintz
>Priority: Major
> Fix For: Trunk
>
>
> in .gitignore in root ofbiz directory there is plugins/
> so all directory plugins are ignored
> if the line is replace by plugins/* only root directory plugins is ignored



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11739) Change resource with RESOURCE in all application components

2020-05-29 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119369#comment-17119369
 ] 

ASF subversion and git services commented on OFBIZ-11739:
-

Commit 5e7193f5a87ff39ade3e1aa90f5a571556f8d4ab in ofbiz-framework's branch 
refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=5e7193f ]

Improved: Changed resources with proper naming convention in all application 
components.
(OFBIZ-11739)
Also, made MODULE as private data member of class instead of public. This will 
reduce checkstlye issues. Thanks Jacques for review.


> Change resource with RESOURCE in all application components
> ---
>
> Key: OFBIZ-11739
> URL: https://issues.apache.org/jira/browse/OFBIZ-11739
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11739.patch, OFBIZ-11739_plugins.patch
>
>
> As we have done it for modules, it is better to get this done for all 
> resource variables as well.
>  Also, we should make module and resource variables as private instead of 
> public



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11756) Vue.Js renderer

2020-05-29 Thread Olivier Heintz (Jira)
Olivier Heintz created OFBIZ-11756:
--

 Summary: Vue.Js renderer
 Key: OFBIZ-11756
 URL: https://issues.apache.org/jira/browse/OFBIZ-11756
 Project: OFBiz
  Issue Type: New Feature
  Components: framework/widget
Affects Versions: Trunk
Reporter: Olivier Heintz
Assignee: Olivier Heintz


This task is an umbrella task for a new ofbiz plugin for having a new renderer 
using Vue.Js

Umbrella to group all related tasks, not necessarily subtasks (on a 
functional/technical point of view).
 * group one: ofbiz enhancement in widget usefull, not only for the new renderer
 * group two:  ofbiz enhancement in widget specifics for vuejs renderer
 * group three: ofbiz enhancement in widget specifics for REST format uri
 * group four: new ofbiz-plugins for the solution and for example using it

To help test, a PR is created for this task, with all commit of all sub-task, 
but sub-task is created to be able to validate point by point. In each sub-task 
there is the associated patch (git format-patch format)

new plugins created which use this vuejs renderer (in group 4 of sub-task) use 
only uri in REST format, to be able to use them with other new renderers (using 
js framework ) or dedicated specifics front.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11754) Create Payment service throws exception when receiving payment on order

2020-05-29 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119551#comment-17119551
 ] 

Jacques Le Roux commented on OFBIZ-11754:
-

+1 Jacques

> Create Payment service throws exception when receiving payment on order
> ---
>
> Key: OFBIZ-11754
> URL: https://issues.apache.org/jira/browse/OFBIZ-11754
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, order
>Affects Versions: Trunk
>Reporter: Priya Sharma
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: Screenshot from 2020-05-29 14-00-57.png
>
>
> Steps to regenerate -
>  # Create a fresh order with COD payment mode
>  # Try to receive payment as PETTY_CASH payment method
> Please refer the screenshot for more details.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11591) Convert InventoryIssueServices minilang to groovy

2020-05-29 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119667#comment-17119667
 ] 

ASF subversion and git services commented on OFBIZ-11591:
-

Commit b862632a9496b9d0c64ec2f5a3f410e178709bf0 in ofbiz-framework's branch 
refs/heads/trunk from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b862632 ]

Fixed: Convert InventoryIssueServices.xml mini lang to groovy
(OFBIZ-11591)

Side effect: Inventory Issuance use generic shipment service to control the 
authorization
but without a shipment, checkCanChangeShipmentStatusGeneral failed with NPE.

I complete the function to escape if a shipment isn't present and only valid 
with facility permission


> Convert InventoryIssueServices minilang to groovy
> -
>
> Key: OFBIZ-11591
> URL: https://issues.apache.org/jira/browse/OFBIZ-11591
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Sebastian Berg
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: Upcoming Branch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11591) Convert InventoryIssueServices minilang to groovy

2020-05-29 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119665#comment-17119665
 ] 

ASF subversion and git services commented on OFBIZ-11591:
-

Commit 7968f62e51b9f710eec880c490cd4e3339f027b1 in ofbiz-framework's branch 
refs/heads/trunk from Sebastian Berg
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7968f62 ]

Improved: Convert InventoryIssueServices.xml mini lang to groovy

(OFBIZ-11591)


> Convert InventoryIssueServices minilang to groovy
> -
>
> Key: OFBIZ-11591
> URL: https://issues.apache.org/jira/browse/OFBIZ-11591
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Sebastian Berg
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: Upcoming Branch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #166: Fixed: Create Payment service throws an exception when receiving payment on order (OFBIZ-11754)

2020-05-29 Thread GitBox


sonarcloud[bot] removed a comment on pull request #166:
URL: https://github.com/apache/ofbiz-framework/pull/166#issuecomment-635936986


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=166)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=166=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=166=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #166: Fixed: Create Payment service throws an exception when receiving payment on order (OFBIZ-11754)

2020-05-29 Thread GitBox


sonarcloud[bot] commented on pull request #166:
URL: https://github.com/apache/ofbiz-framework/pull/166#issuecomment-635971576


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=166=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=166)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=166=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=166=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Closed] (OFBIZ-11591) Convert InventoryIssueServices minilang to groovy

2020-05-29 Thread Nicolas Malin (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin closed OFBIZ-11591.
-
Resolution: Done

Thanks [~sberg], your PR is merged

> Convert InventoryIssueServices minilang to groovy
> -
>
> Key: OFBIZ-11591
> URL: https://issues.apache.org/jira/browse/OFBIZ-11591
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Sebastian Berg
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: Upcoming Branch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] nmalin commented on pull request #72: OFBIZ-11591 Improved: Convert InventoryIssueServices.xml mini lang to groovy

2020-05-29 Thread GitBox


nmalin commented on pull request #72:
URL: https://github.com/apache/ofbiz-framework/pull/72#issuecomment-636006393


   merged



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] nmalin closed pull request #72: OFBIZ-11591 Improved: Convert InventoryIssueServices.xml mini lang to groovy

2020-05-29 Thread GitBox


nmalin closed pull request #72:
URL: https://github.com/apache/ofbiz-framework/pull/72


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (OFBIZ-11310) JSON renderer for screen/menu/form

2020-05-29 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz updated OFBIZ-11310:
---
Parent: OFBIZ-11756
Issue Type: Sub-task  (was: New Feature)

> JSON renderer for screen/menu/form 
> ---
>
> Key: OFBIZ-11310
> URL: https://issues.apache.org/jira/browse/OFBIZ-11310
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Olivier Heintz
>Priority: Minor
> Attachments: FrontJsFormRenderer.java, FrontJsMenuRenderer.java, 
> FrontJsOutput.java, FrontJsScreenRenderer.java, 
> FrontJsScreenViewHandler.java, FrontJsTreeRenderer.java, OFBIZ-11310.patch
>
>
> In a POC approach for using a SPA framework for GUI in OFBiz, json renderer 
> have been developed.
> This Jira could be used to do code review on these renderer.
> Currently, these renderer are on a V0 situation, it's a work in process 
> situation. After mailing-list discussion with mathieu we decide to go to a 
> V0.1 by 2-3 tasks
>  * add some javadoc each time it's necessary or needed
>  * remove all comment code or explain the decision waiting to activate or 
> remove the code
>  * do checkstyle
> On first step, code will be with only what is used in a use case (no code for 
> tag not currently manage).
> Json renderer are part of vuejs-portal plugin, in ofbizextra gitlab 
> (https://gitlab.ofbizextra.org/ofbizextra/ofbizplugins/vuejsPortal), so 
> commit are done on it, and mailing-list with these commit [are 
> ofbizextra-com...@lists.sourceforge.net.|mailto:are%c2%a0ofbizextra-com...@lists.sourceforge.net.]
>  But we will publish an update on this Jira each week there are some 
> modifications on renderer files
> This task will take some time because it will used to do a complete code 
> review, not only in renderer but in vuejs component too, and so complete 
> documentation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal

2020-05-29 Thread Nicolas Malin (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119696#comment-17119696
 ] 

Nicolas Malin commented on OFBIZ-11743:
---

[~uHeidfeld], I tried to reproduce and understand to find the root, but 
unsuccessfully.

I applied : 
{code:patch}
diff --git a/framework/webtools/widget/ServiceScreens.xml 
b/framework/webtools/widget/ServiceScreens.xml
index a3545e1305..962b3a75b6 100644
--- a/framework/webtools/widget/ServiceScreens.xml
+++ b/framework/webtools/widget/ServiceScreens.xml
@@ -238,7 +238,10 @@ under the License.
 
 
 
- 
+ 
+ 
+ 
+ 
 
 
 
@@ -263,6 +266,8 @@ under the License.
 
 
 
+
+
 
 
 
{code}

But when I call the modal, the result is good.

This generate a link 

{code:java}

   Add
{code}

And in the modal my values are as attendee
 !Capture d’écran de 2020-05-29 17-11-58.png! 

Can you help me to spot the problem raise in this issue ?


> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/widget
>Affects Versions: Release Branch 18.12, 17.12.03, Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
>  Labels: Modal, link, menu, menu-item
> Attachments: Capture d’écran de 2020-05-29 17-11-58.png
>
>
> I got problems by opening a modal via menu link with two parameters. Only the 
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline 
> JS-Code get created with defined action-String. This String is used to set 
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded 
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>  
> My solution for this problem was to extend MacroMenuRenderer#renderLink by 
> replacing 
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between 
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within 
> action-String, we have to submit parameters.
>   



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11757) Improvement, grp1: area-id in event-update-area should be stringExpander

2020-05-29 Thread Olivier Heintz (Jira)
Olivier Heintz created OFBIZ-11757:
--

 Summary: Improvement, grp1: area-id in event-update-area should be 
stringExpander
 Key: OFBIZ-11757
 URL: https://issues.apache.org/jira/browse/OFBIZ-11757
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework/widget
Affects Versions: Trunk
Reporter: Olivier Heintz


With this patch It's now possible to use $\{ for area-id in event-update-area, 
for field or form level (field-on-event-update-area or on-even-update-area)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11758) Improvement, grp1: add use-when for xxx-event-update-area

2020-05-29 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz updated OFBIZ-11758:
---
Attachment: 
OFBIZ-11758_0001-Improvement-add-use-when-for-xxx-event-update-area.patch

> Improvement, grp1: add use-when for xxx-event-update-area
> -
>
> Key: OFBIZ-11758
> URL: https://issues.apache.org/jira/browse/OFBIZ-11758
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework/widget
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Minor
>  Labels: widget
> Attachments: 
> OFBIZ-11758_0001-Improvement-add-use-when-for-xxx-event-update-area.patch
>
>
> 1. add "use-when" management in the xsd and in the modelForm.UpdateArea,
> 2. add in modelForm a static method to return a valid list of updateArea
> from a list of updateArea and context
> 3. duplicate all methods returning a list of updateArea, by same name
> but with context as parameters which return *only valid* updateArea list
> (ex: in formFieldBuilder for getOnClickUpdateAreas and
> getOnChangeUpdateAreas)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11758) Improvement, grp1: add use-when for xxx-event-update-area

2020-05-29 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz updated OFBIZ-11758:
---
Description: 
1. add "use-when" management in the xsd and in the modelForm.UpdateArea,
 2. add in modelForm a static method to return a valid list of updateArea from 
a list of updateArea and context
 3. duplicate all methods returning a list of updateArea, by same name but with 
context as parameters which return *only valid* updateArea list (ex: in 
formFieldBuilder for getOnClickUpdateAreas and getOnChangeUpdateAreas)

  was:
1. add "use-when" management in the xsd and in the modelForm.UpdateArea,
2. add in modelForm a static method to return a valid list of updateArea
from a list of updateArea and context
3. duplicate all methods returning a list of updateArea, by same name
but with context as parameters which return *only valid* updateArea list
(ex: in formFieldBuilder for getOnClickUpdateAreas and
getOnChangeUpdateAreas)


> Improvement, grp1: add use-when for xxx-event-update-area
> -
>
> Key: OFBIZ-11758
> URL: https://issues.apache.org/jira/browse/OFBIZ-11758
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework/widget
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Minor
>  Labels: widget
> Attachments: 
> OFBIZ-11758_0001-Improvement-add-use-when-for-xxx-event-update-area.patch
>
>
> 1. add "use-when" management in the xsd and in the modelForm.UpdateArea,
>  2. add in modelForm a static method to return a valid list of updateArea 
> from a list of updateArea and context
>  3. duplicate all methods returning a list of updateArea, by same name but 
> with context as parameters which return *only valid* updateArea list (ex: in 
> formFieldBuilder for getOnClickUpdateAreas and getOnChangeUpdateAreas)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11759) Improvement, grp2: add toMap() method in updateArea class, it's needed to send a updateArea list in json format

2020-05-29 Thread Olivier Heintz (Jira)
Olivier Heintz created OFBIZ-11759:
--

 Summary: Improvement, grp2: add toMap() method in updateArea 
class, it's needed to send a updateArea list in json format
 Key: OFBIZ-11759
 URL: https://issues.apache.org/jira/browse/OFBIZ-11759
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework/widget
Affects Versions: Trunk
Reporter: Olivier Heintz


Just send a list of map with one per update-area with properties as keys and 
parameter as value of parametersMap key so keys in map are
 * areaId,
 * eventType,
 * areaTarget
 * parametersMap



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11760) New Feature, grp3: Manage http method in link and on-field-event-update-area

2020-05-29 Thread Olivier Heintz (Jira)
Olivier Heintz created OFBIZ-11760:
--

 Summary: New Feature, grp3: Manage http method in link and 
on-field-event-update-area
 Key: OFBIZ-11760
 URL: https://issues.apache.org/jira/browse/OFBIZ-11760
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework/widget
Affects Versions: Trunk
Reporter: Olivier Heintz


Manage http method in link via added in url-mode and in 
on-field-event-update-area via added in event-type. Add post,put, delete (get 
is the default)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal

2020-05-29 Thread Nicolas Malin (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin updated OFBIZ-11743:
--
Attachment: Capture d’écran de 2020-05-29 17-11-58.png

> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/widget
>Affects Versions: Release Branch 18.12, 17.12.03, Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
>  Labels: Modal, link, menu, menu-item
> Attachments: Capture d’écran de 2020-05-29 17-11-58.png
>
>
> I got problems by opening a modal via menu link with two parameters. Only the 
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline 
> JS-Code get created with defined action-String. This String is used to set 
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded 
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>  
> My solution for this problem was to extend MacroMenuRenderer#renderLink by 
> replacing 
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between 
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within 
> action-String, we have to submit parameters.
>   



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11757) Improvement, grp1: area-id in event-update-area should be stringExpander

2020-05-29 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz updated OFBIZ-11757:
---
Attachment: 
OFBIZ-11757_0001-area-id-in-event-update-area-is-now-a-stringExpander.patch

> Improvement, grp1: area-id in event-update-area should be stringExpander
> 
>
> Key: OFBIZ-11757
> URL: https://issues.apache.org/jira/browse/OFBIZ-11757
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework/widget
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Minor
>  Labels: widget
> Attachments: 
> OFBIZ-11757_0001-area-id-in-event-update-area-is-now-a-stringExpander.patch
>
>
> With this patch It's now possible to use $\{ for area-id in 
> event-update-area, for field or form level (field-on-event-update-area or 
> on-even-update-area)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11741) Headerize external script in multi-block html template

2020-05-29 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119744#comment-17119744
 ] 

Jacques Le Roux commented on OFBIZ-11741:
-

Hi James,

Just one thing before committing: with this code you are adding  27025-26985=40 
checkstyle issues. Also there is one file more with issue/s.

> Headerize external script in multi-block html template
> --
>
> Key: OFBIZ-11741
> URL: https://issues.apache.org/jira/browse/OFBIZ-11741
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: HtmlWidget.java.rej, OFBIZ-11741.patch, OFBIZ-11741.patch
>
>
> Allow external scripts within the multi-block html template, to be rendered 
> within the html head tag, when a new attribute data-import is set to “head” 
> e.g.
> {code:xml}
>  type="application/javascript" data-import="head">
> {code}
> With the new feature we can define external scripts in the multi-block html 
> template that is using the library, instead of setting in 
> layoutSetting.javaScripts.
> This new feature helps with dependency management of Javascript and also 
> reduce CSP errors.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11760) New Feature, grp3: Manage http method in link and on-field-event-update-area

2020-05-29 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz updated OFBIZ-11760:
---
Attachment: 
OFBIZ-11760_0001-Improved-Manage-http-method-in-link-and-in-on-field-.patch

> New Feature, grp3: Manage http method in link and on-field-event-update-area
> 
>
> Key: OFBIZ-11760
> URL: https://issues.apache.org/jira/browse/OFBIZ-11760
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework/widget
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Minor
>  Labels: REST, widget
> Attachments: 
> OFBIZ-11760_0001-Improved-Manage-http-method-in-link-and-in-on-field-.patch
>
>
> Manage http method in link via added in url-mode and in 
> on-field-event-update-area via added in event-type. Add post,put, delete (get 
> is the default)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11758) Improvement, grp1: add use-when for xxx-event-update-area

2020-05-29 Thread Olivier Heintz (Jira)
Olivier Heintz created OFBIZ-11758:
--

 Summary: Improvement, grp1: add use-when for xxx-event-update-area
 Key: OFBIZ-11758
 URL: https://issues.apache.org/jira/browse/OFBIZ-11758
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework/widget
Affects Versions: Trunk
Reporter: Olivier Heintz


1. add "use-when" management in the xsd and in the modelForm.UpdateArea,
2. add in modelForm a static method to return a valid list of updateArea
from a list of updateArea and context
3. duplicate all methods returning a list of updateArea, by same name
but with context as parameters which return *only valid* updateArea list
(ex: in formFieldBuilder for getOnClickUpdateAreas and
getOnChangeUpdateAreas)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11759) Improvement, grp2: add toMap() method in updateArea class, it's needed to send a updateArea list in json format

2020-05-29 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz updated OFBIZ-11759:
---
Attachment: 
OFBIZ-11759_0001-add-toMap-method-in-updateArea-class-it-s-needed-to-.patch

> Improvement, grp2: add toMap() method in updateArea class, it's needed to 
> send a updateArea list in json format
> ---
>
> Key: OFBIZ-11759
> URL: https://issues.apache.org/jira/browse/OFBIZ-11759
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework/widget
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Minor
> Attachments: 
> OFBIZ-11759_0001-add-toMap-method-in-updateArea-class-it-s-needed-to-.patch
>
>
> Just send a list of map with one per update-area with properties as keys and 
> parameter as value of parametersMap key so keys in map are
>  * areaId,
>  * eventType,
>  * areaTarget
>  * parametersMap



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11761) Improvement, grp1: add parameters as children of on-field-event-update-area, same as for on-event-update-area

2020-05-29 Thread Olivier Heintz (Jira)
Olivier Heintz created OFBIZ-11761:
--

 Summary: Improvement, grp1: add parameters as children of 
on-field-event-update-area, same as for on-event-update-area
 Key: OFBIZ-11761
 URL: https://issues.apache.org/jira/browse/OFBIZ-11761
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework/widget
Affects Versions: Trunk
Reporter: Olivier Heintz


add parameters as children of on-field-event-update-area, same as for
on-event-update-area

Not necessary to modify model*.java because it's manage by update-area
object in the two case



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11761) Improvement, grp1: add parameters as children of on-field-event-update-area, same as for on-event-update-area

2020-05-29 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz updated OFBIZ-11761:
---
Attachment: 
OFBIZ-11761_0001-Improved-add-parameters-as-children-of-on-field-even.patch

> Improvement, grp1: add parameters as children of on-field-event-update-area, 
> same as for on-event-update-area
> -
>
> Key: OFBIZ-11761
> URL: https://issues.apache.org/jira/browse/OFBIZ-11761
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework/widget
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Minor
>  Labels: widget
> Attachments: 
> OFBIZ-11761_0001-Improved-add-parameters-as-children-of-on-field-even.patch
>
>
> add parameters as children of on-field-event-update-area, same as for
> on-event-update-area
> Not necessary to modify model*.java because it's manage by update-area
> object in the two case



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] verma-pawan commented on a change in pull request #166: Fixed: Create Payment service throws an exception when receiving payment on order (OFBIZ-11754)

2020-05-29 Thread GitBox


verma-pawan commented on a change in pull request #166:
URL: https://github.com/apache/ofbiz-framework/pull/166#discussion_r432636054



##
File path: applications/content/groovyScripts/content/ContentServices.groovy
##
@@ -115,7 +113,7 @@ def createContentAlternativeUrl() {
 dataResourceId = serviceResult.dataResourceId
 }
 } catch (GenericServiceException e) {
-Debug.logInfo(e, MODULE)

Review comment:
   Hi @priyasharma1 
   
   As we are logging exception here, Shouldn't it be converted to logError()? 
WDYT? 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-11754) Create Payment service throws exception when receiving payment on order

2020-05-29 Thread Pawan Verma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119787#comment-17119787
 ] 

Pawan Verma commented on OFBIZ-11754:
-

Thanks, Priya,

I've reviewed the PR and it looks good, just one comment, added on PR. Please 
have a look.

[~surajk], All,

Priya and I discussed that as we have logInfo, logError methods in 
GroovyBaseScript, we should use it in all groovy files instead of defining 
modules everywhere. I am planning to create a separate ticket for the 
improvement. 

> Create Payment service throws exception when receiving payment on order
> ---
>
> Key: OFBIZ-11754
> URL: https://issues.apache.org/jira/browse/OFBIZ-11754
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, order
>Affects Versions: Trunk
>Reporter: Priya Sharma
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: Screenshot from 2020-05-29 14-00-57.png
>
>
> Steps to regenerate -
>  # Create a fresh order with COD payment mode
>  # Try to receive payment as PETTY_CASH payment method
> Please refer the screenshot for more details.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11754) Create Payment service throws exception when receiving payment on order

2020-05-29 Thread Pawan Verma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119798#comment-17119798
 ] 

Pawan Verma commented on OFBIZ-11754:
-

Created OFBIZ-11762 for that improvement.

> Create Payment service throws exception when receiving payment on order
> ---
>
> Key: OFBIZ-11754
> URL: https://issues.apache.org/jira/browse/OFBIZ-11754
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, order
>Affects Versions: Trunk
>Reporter: Priya Sharma
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: Screenshot from 2020-05-29 14-00-57.png
>
>
> Steps to regenerate -
>  # Create a fresh order with COD payment mode
>  # Try to receive payment as PETTY_CASH payment method
> Please refer the screenshot for more details.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11762) Use GroovyBaseScript's logging utility methods instead of using Debug in each Groovy files

2020-05-29 Thread Pawan Verma (Jira)
Pawan Verma created OFBIZ-11762:
---

 Summary: Use GroovyBaseScript's logging utility methods instead of 
using Debug in each Groovy files
 Key: OFBIZ-11762
 URL: https://issues.apache.org/jira/browse/OFBIZ-11762
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Affects Versions: Trunk
Reporter: Pawan Verma


Use GroovyBaseScript's logging utility methods instead of using Debug in each 
Groovy files

*Currently used:* Debug.logError(MESSAGE)
*Proposed Use:* logError(MESSAGE)

 

It will benefit us to remove the module from each groovy file as it is already 
handled in GroovyBaseScript. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11741) Headerize external script in multi-block html template

2020-05-29 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120101#comment-17120101
 ] 

ASF subversion and git services commented on OFBIZ-11741:
-

Commit c0e527efb2bc63803298138a415699dee507ee02 in ofbiz-framework's branch 
refs/heads/trunk from James Yong
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=c0e527e ]

Improved: Headerize external script in multi-block html template (OFBIZ-11741)

Allow external scripts within the multi-block html template, to be rendered
within the html head tag, when a new attribute data-import is set to “head”

Thanks: Jacques for review


> Headerize external script in multi-block html template
> --
>
> Key: OFBIZ-11741
> URL: https://issues.apache.org/jira/browse/OFBIZ-11741
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: HtmlWidget.java.rej, OFBIZ-11741.patch, 
> OFBIZ-11741.patch, OFBIZ-11741.patch
>
>
> Allow external scripts within the multi-block html template, to be rendered 
> within the html head tag, when a new attribute data-import is set to “head” 
> e.g.
> {code:xml}
>  type="application/javascript" data-import="head">
> {code}
> With the new feature we can define external scripts in the multi-block html 
> template that is using the library, instead of setting in 
> layoutSetting.javaScripts.
> This new feature helps with dependency management of Javascript and also 
> reduce CSP errors.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11741) Headerize external script in multi-block html template

2020-05-29 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong updated OFBIZ-11741:
---
Attachment: OFBIZ-11741.patch

> Headerize external script in multi-block html template
> --
>
> Key: OFBIZ-11741
> URL: https://issues.apache.org/jira/browse/OFBIZ-11741
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: HtmlWidget.java.rej, OFBIZ-11741.patch, 
> OFBIZ-11741.patch, OFBIZ-11741.patch
>
>
> Allow external scripts within the multi-block html template, to be rendered 
> within the html head tag, when a new attribute data-import is set to “head” 
> e.g.
> {code:xml}
>  type="application/javascript" data-import="head">
> {code}
> With the new feature we can define external scripts in the multi-block html 
> template that is using the library, instead of setting in 
> layoutSetting.javaScripts.
> This new feature helps with dependency management of Javascript and also 
> reduce CSP errors.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11741) Headerize external script in multi-block html template

2020-05-29 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120100#comment-17120100
 ] 

James Yong commented on OFBIZ-11741:


Updated the patch before commit. 
Corrected several checkstyle errors.

> Headerize external script in multi-block html template
> --
>
> Key: OFBIZ-11741
> URL: https://issues.apache.org/jira/browse/OFBIZ-11741
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: HtmlWidget.java.rej, OFBIZ-11741.patch, 
> OFBIZ-11741.patch, OFBIZ-11741.patch
>
>
> Allow external scripts within the multi-block html template, to be rendered 
> within the html head tag, when a new attribute data-import is set to “head” 
> e.g.
> {code:xml}
>  type="application/javascript" data-import="head">
> {code}
> With the new feature we can define external scripts in the multi-block html 
> template that is using the library, instead of setting in 
> layoutSetting.javaScripts.
> This new feature helps with dependency management of Javascript and also 
> reduce CSP errors.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11769) Improvement, grp1: Add icon management, name and tooltips abstraction

2020-05-29 Thread Olivier Heintz (Jira)
Olivier Heintz created OFBIZ-11769:
--

 Summary: Improvement, grp1: Add icon management, name and tooltips 
abstraction
 Key: OFBIZ-11769
 URL: https://issues.apache.org/jira/browse/OFBIZ-11769
 Project: OFBiz
  Issue Type: Sub-task
  Components: themes
Affects Versions: Trunk
Reporter: Olivier Heintz


Add icon management, name and tooltips abstraction

two properties files, to be able to use a logical name not a "path" in link, 
hyperlink ...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11766) Improvement, grp2: event-update-area (field and form level), add collapse as event-type

2020-05-29 Thread Olivier Heintz (Jira)
Olivier Heintz created OFBIZ-11766:
--

 Summary: Improvement, grp2: event-update-area (field and form 
level), add collapse as event-type
 Key: OFBIZ-11766
 URL: https://issues.apache.org/jira/browse/OFBIZ-11766
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework/widget
Affects Versions: Trunk
Reporter: Olivier Heintz


event-update-area (field and form level): add collapse as event-type

it's a click event, when click all the screenlet with the areaId are collapse

No modification in renderer in this commit
area-target can be used to detail action to do toggle, collapse or expand



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11769) Improvement, grp1: Add icon management, name and tooltips abstraction

2020-05-29 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz updated OFBIZ-11769:
---
Attachment: 
OFBIZ-11769_0001-Add-icon-management-name-and-tooltips-abstraction.patch

> Improvement, grp1: Add icon management, name and tooltips abstraction
> -
>
> Key: OFBIZ-11769
> URL: https://issues.apache.org/jira/browse/OFBIZ-11769
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: themes
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Minor
> Attachments: 
> OFBIZ-11769_0001-Add-icon-management-name-and-tooltips-abstraction.patch
>
>
> Add icon management, name and tooltips abstraction
> two properties files, to be able to use a logical name not a "path" in link, 
> hyperlink ...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11763) New Feature, grp2: Add set-area and set-watcher for container level

2020-05-29 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz updated OFBIZ-11763:
---
Attachment: 
OFBIZ-11763_0001-Add-set-area-and-set-watcher-for-container-level.patch

> New Feature, grp2: Add set-area and set-watcher for container level
> ---
>
> Key: OFBIZ-11763
> URL: https://issues.apache.org/jira/browse/OFBIZ-11763
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework/widget
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Minor
>  Labels: widget
> Attachments: 
> OFBIZ-11763_0001-Add-set-area-and-set-watcher-for-container-level.patch
>
>
> * add attribute watcher-name for tag container
> * add in link-type enum set-area, refresh-area and set-watcher,
> refresh-watcher
> * add in xxx-event-update-area, in event-type enum set-area,
> refresh-area and set-watcher, refresh-watcher
> Concept is:
> 1. container is the main piece of dynamics screen (update a part of
> screen on event), a new attribute is added watcher-name, and existing
> one auto-update-target is using as target
> 2. There are two/four new "action" usable by link - hyperlink
>  * set-area (and refresh-area)
>  * set-watcher (and refresh-watcher)
> 3. set-area is used to update a containerId, and, most of the time, uses
> only for included containerId
> set-watcher put some "parameters" in a watcher-name
> 4. when the content of a whatcher-name change, all containerId which
> watch it, use their auto-update-target as target and watcher-name
> content as parameters to update the container content.
> 5. refresh-area is similar with set-area but target used will be the
> auto-update-target define at the container level and, if a watcher-name
> is define for this container, it's content will be used as parameters
> (for solving {} in target or as parameters if no {} in target.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11765) Improvement, grp2: on-field-event-update-area, add set-field-in-form as event-type

2020-05-29 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz updated OFBIZ-11765:
---
Attachment: 
OFBIZ-11765_0001-on-field-event-update-area-add-set-field-in-form-as-.patch

> Improvement, grp2: on-field-event-update-area, add set-field-in-form as 
> event-type
> --
>
> Key: OFBIZ-11765
> URL: https://issues.apache.org/jira/browse/OFBIZ-11765
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework/widget
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Minor
>  Labels: widget
> Attachments: 
> OFBIZ-11765_0001-on-field-event-update-area-add-set-field-in-form-as-.patch
>
>
> on-field-event-update-area: add set-field-in-form as event-type
> it's a click event, when click the field is update, it's useful in
> lookup form to update field from which the lookup has been call
> No modification in renderer in this commit



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11767) Improvement, grp2: event-update-area (field and form level), add close-modal as event-type

2020-05-29 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz updated OFBIZ-11767:
---
Attachment: 
OFBIZ-11767_0001-event-update-area-field-and-form-level-add-close-mod.patch

> Improvement, grp2: event-update-area (field and form level), add close-modal 
> as event-type
> --
>
> Key: OFBIZ-11767
> URL: https://issues.apache.org/jira/browse/OFBIZ-11767
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework/widget
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Minor
>  Labels: widget
> Attachments: 
> OFBIZ-11767_0001-event-update-area-field-and-form-level-add-close-mod.patch
>
>
> event-update-area (field and form level): add close-modal as event-type
> it's a click event, when click one or all open modal area closed.
> it's use for lookup and for modal created with link with layered-modal
> No modification in renderer in this commit



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11766) Improvement, grp2: event-update-area (field and form level), add collapse as event-type

2020-05-29 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz updated OFBIZ-11766:
---
Attachment: 
OFBIZ-11766_0001-event-update-area-field-and-form-level-add-collapse-.patch

> Improvement, grp2: event-update-area (field and form level), add collapse as 
> event-type
> ---
>
> Key: OFBIZ-11766
> URL: https://issues.apache.org/jira/browse/OFBIZ-11766
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework/widget
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Minor
>  Labels: widget
> Attachments: 
> OFBIZ-11766_0001-event-update-area-field-and-form-level-add-collapse-.patch
>
>
> event-update-area (field and form level): add collapse as event-type
> it's a click event, when click all the screenlet with the areaId are collapse
> No modification in renderer in this commit
> area-target can be used to detail action to do toggle, collapse or expand



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11764) Improvement, grp1: on-field-event-update-area, add commit as event-type

2020-05-29 Thread Olivier Heintz (Jira)
Olivier Heintz created OFBIZ-11764:
--

 Summary: Improvement, grp1: on-field-event-update-area, add commit 
as event-type
 Key: OFBIZ-11764
 URL: https://issues.apache.org/jira/browse/OFBIZ-11764
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework/widget
Affects Versions: Trunk
Reporter: Olivier Heintz


on-field-event-update-area: add commit as event-type

it's a click event, when click the form is submitted



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11765) Improvement, grp1: on-field-event-update-area, add set-field-in-form as event-type

2020-05-29 Thread Olivier Heintz (Jira)
Olivier Heintz created OFBIZ-11765:
--

 Summary: Improvement, grp1: on-field-event-update-area, add 
set-field-in-form as event-type
 Key: OFBIZ-11765
 URL: https://issues.apache.org/jira/browse/OFBIZ-11765
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework/widget
Affects Versions: Trunk
Reporter: Olivier Heintz


on-field-event-update-area: add set-field-in-form as event-type

it's a click event, when click the field is update, it's useful in
lookup form to update field from which the lookup has been call

No modification in renderer in this commit



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11768) New Feature, grp2: add vuejs as children tag of html tag in screen

2020-05-29 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz updated OFBIZ-11768:
---
Attachment: 
OFBIZ-11768_0001-add-vuejs-as-children-tag-of-html-tag-in-screen.patch

> New Feature, grp2: add vuejs as children tag of html tag in screen
> --
>
> Key: OFBIZ-11768
> URL: https://issues.apache.org/jira/browse/OFBIZ-11768
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework/widget
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Minor
>  Labels: widget
> Attachments: 
> OFBIZ-11768_0001-add-vuejs-as-children-tag-of-html-tag-in-screen.patch
>
>
> this tag is used to call vuejs specifics component in the standard vuejs 
> application (the vuejs renderer).
> vuejs specifics components are similar to ftl files in html standard renderer.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11765) Improvement, grp2: on-field-event-update-area, add set-field-in-form as event-type

2020-05-29 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz updated OFBIZ-11765:
---
Summary: Improvement, grp2: on-field-event-update-area, add 
set-field-in-form as event-type  (was: Improvement, grp1: 
on-field-event-update-area, add set-field-in-form as event-type)

> Improvement, grp2: on-field-event-update-area, add set-field-in-form as 
> event-type
> --
>
> Key: OFBIZ-11765
> URL: https://issues.apache.org/jira/browse/OFBIZ-11765
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework/widget
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Minor
>  Labels: widget
>
> on-field-event-update-area: add set-field-in-form as event-type
> it's a click event, when click the field is update, it's useful in
> lookup form to update field from which the lookup has been call
> No modification in renderer in this commit



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11768) New Feature, grp2: add vuejs as children tag of html tag in screen

2020-05-29 Thread Olivier Heintz (Jira)
Olivier Heintz created OFBIZ-11768:
--

 Summary: New Feature, grp2: add vuejs as children tag of html tag 
in screen
 Key: OFBIZ-11768
 URL: https://issues.apache.org/jira/browse/OFBIZ-11768
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework/widget
Affects Versions: Trunk
Reporter: Olivier Heintz


this tag is used to call vuejs specifics component in the standard vuejs 
application (the vuejs renderer).
vuejs specifics components are similar to ftl files in html standard renderer.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11764) Improvement, grp1: on-field-event-update-area, add commit as event-type

2020-05-29 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz updated OFBIZ-11764:
---
Attachment: 
OFBIZ-11764_0001-on-field-event-update-area-add-commit-as-event-type.patch

> Improvement, grp1: on-field-event-update-area, add commit as event-type
> ---
>
> Key: OFBIZ-11764
> URL: https://issues.apache.org/jira/browse/OFBIZ-11764
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework/widget
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Minor
>  Labels: widget
> Attachments: 
> OFBIZ-11764_0001-on-field-event-update-area-add-commit-as-event-type.patch
>
>
> on-field-event-update-area: add commit as event-type
> it's a click event, when click the form is submitted



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11763) New Feature, grp2: Add set-area and set-watcher for container level

2020-05-29 Thread Olivier Heintz (Jira)
Olivier Heintz created OFBIZ-11763:
--

 Summary: New Feature, grp2: Add set-area and set-watcher for 
container level
 Key: OFBIZ-11763
 URL: https://issues.apache.org/jira/browse/OFBIZ-11763
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework/widget
Affects Versions: Trunk
Reporter: Olivier Heintz


* add attribute watcher-name for tag container
* add in link-type enum set-area, refresh-area and set-watcher,
refresh-watcher
* add in xxx-event-update-area, in event-type enum set-area,
refresh-area and set-watcher, refresh-watcher

Concept is:
1. container is the main piece of dynamics screen (update a part of
screen on event), a new attribute is added watcher-name, and existing
one auto-update-target is using as target

2. There are two/four new "action" usable by link - hyperlink
 * set-area (and refresh-area)
 * set-watcher (and refresh-watcher)

3. set-area is used to update a containerId, and, most of the time, uses
only for included containerId
set-watcher put some "parameters" in a watcher-name

4. when the content of a whatcher-name change, all containerId which
watch it, use their auto-update-target as target and watcher-name
content as parameters to update the container content.

5. refresh-area is similar with set-area but target used will be the
auto-update-target define at the container level and, if a watcher-name
is define for this container, it's content will be used as parameters
(for solving {} in target or as parameters if no {} in target.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)