[
https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128415#comment-17128415
]
Jacques Le Roux commented on OFBIZ-11745:
-
Thanks OLivier,
Works for me, +1 for commit
>
[
https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128394#comment-17128394
]
Jacques Le Roux commented on OFBIZ-11304:
-
Hi Aditya,
Works for me! Sounds like we are ready
[
https://issues.apache.org/jira/browse/OFBIZ-11752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128391#comment-17128391
]
Jacques Le Roux commented on OFBIZ-11752:
-
Thanks Aditya,
At 1st glance all is OK with me, + 1
[
https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128384#comment-17128384
]
Olivier Heintz commented on OFBIZ-11745:
Thanks Jacques, corrections done in my comment (a lot
[
https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128086#comment-17128086
]
Olivier Heintz edited comment on OFBIZ-11745 at 6/8/20, 3:25 PM:
-
hi
[
https://issues.apache.org/jira/browse/OFBIZ-11752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128325#comment-17128325
]
Aditya Sharma commented on OFBIZ-11752:
---
Thanks Jacques for the review and reminder about the
[
https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128304#comment-17128304
]
Jacques Le Roux commented on OFBIZ-11745:
-
Thanks Olivier,
Still wondering, /plugin/ or
[
https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128304#comment-17128304
]
Jacques Le Roux edited comment on OFBIZ-11745 at 6/8/20, 1:37 PM:
--
[
https://issues.apache.org/jira/browse/OFBIZ-11752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128275#comment-17128275
]
Jacques Le Roux commented on OFBIZ-11752:
-
Hi Aditya,
The PR is OK with me. Did you finally
[
https://issues.apache.org/jira/browse/OFBIZ-11796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Suraj Khurana closed OFBIZ-11796.
-
Fix Version/s: 17.12.04
18.12.01
Resolution: Fixed
Thanks everyone
[
https://issues.apache.org/jira/browse/OFBIZ-11796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128255#comment-17128255
]
ASF subversion and git services commented on OFBIZ-11796:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-11796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128256#comment-17128256
]
ASF subversion and git services commented on OFBIZ-11796:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-11796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128252#comment-17128252
]
ASF subversion and git services commented on OFBIZ-11796:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-11796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128210#comment-17128210
]
Arun Patidar commented on OFBIZ-11796:
--
Good catch Suraj !!!
> Unnecessary iterations for all
[
https://issues.apache.org/jira/browse/OFBIZ-11762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128205#comment-17128205
]
ASF subversion and git services commented on OFBIZ-11762:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-11762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128206#comment-17128206
]
ASF subversion and git services commented on OFBIZ-11762:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-11762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128204#comment-17128204
]
ASF subversion and git services commented on OFBIZ-11762:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128202#comment-17128202
]
Priya Sharma commented on OFBIZ-10791:
--
Hello Pierre and All,
As per my exploration, this issue
[
https://issues.apache.org/jira/browse/OFBIZ-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Priya Sharma updated OFBIZ-10791:
-
Attachment: asset-addtocart.png
> Unable to add product (of ASSET_USAGE type) in order
>
[
https://issues.apache.org/jira/browse/OFBIZ-11762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128199#comment-17128199
]
ASF subversion and git services commented on OFBIZ-11762:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-11762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128200#comment-17128200
]
Jacques Le Roux commented on OFBIZ-11762:
-
Thanks Priya
> Use GroovyBaseScript's logging
[
https://issues.apache.org/jira/browse/OFBIZ-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Priya Sharma updated OFBIZ-10791:
-
Attachment: OFBIZ-10791.patch
> Unable to add product (of ASSET_USAGE type) in order
>
[
https://issues.apache.org/jira/browse/OFBIZ-11762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128187#comment-17128187
]
Priya Sharma commented on OFBIZ-11762:
--
Hi [~jleroux]
I have updated the PR for plugins and I did
JacquesLeRoux commented on pull request #117:
URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-640248142
Hi Pierre,
Maybe because they improved the rules
This is an automated message from the
[
https://issues.apache.org/jira/browse/OFBIZ-11752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128142#comment-17128142
]
Aditya Sharma commented on OFBIZ-11752:
---
Hi [~jleroux],
Should I proceed with merging the PR?
>
priyasharma1 opened a new pull request #194:
URL: https://github.com/apache/ofbiz-framework/pull/194
(OFBIZ-11762)
This will help us log errors even without passing a custom error message.
Please refer PR https://github.com/apache/ofbiz-plugins/pull/24
Thanks: Jacques
[
https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128133#comment-17128133
]
Aditya Sharma commented on OFBIZ-11304:
---
Thanks [~jleroux] for trying out the solution!
>> Allows
sonarcloud[bot] commented on pull request #24:
URL: https://github.com/apache/ofbiz-plugins/pull/24#issuecomment-640490624
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=24=false=BUG)
sonarcloud[bot] removed a comment on pull request #24:
URL: https://github.com/apache/ofbiz-plugins/pull/24#issuecomment-637986063
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=24=false=BUG)
[
https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128086#comment-17128086
]
Olivier Heintz commented on OFBIZ-11745:
hi Jacques,
I mean /plugin/
after previous commit
[
https://issues.apache.org/jira/browse/OFBIZ-11796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128075#comment-17128075
]
Pawan Verma commented on OFBIZ-11796:
-
+1 Suraj, looks good.
> Unnecessary iterations for all
[
https://issues.apache.org/jira/browse/OFBIZ-11806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128065#comment-17128065
]
Pierre Smits commented on OFBIZ-11806:
--
Hey Jacques,,
Works for me. IMO such place holders should
[
https://issues.apache.org/jira/browse/OFBIZ-11796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128060#comment-17128060
]
Pierre Smits commented on OFBIZ-11796:
--
Wel done, Suraj,
I guess there may a lot more of these
[
https://issues.apache.org/jira/browse/OFBIZ-11809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128035#comment-17128035
]
Nicolas Malin commented on OFBIZ-11809:
---
This patch [^OFBIZ-11808-OFBIZ-11809.patch] load the new
[
https://issues.apache.org/jira/browse/OFBIZ-11809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin updated OFBIZ-11809:
--
Attachment: OFBIZ-11808-OFBIZ-11809.patch
> Access to the current screen from any widget
JacquesLeRoux commented on pull request #150:
URL: https://github.com/apache/ofbiz-framework/pull/150#issuecomment-640464452
Hi Wiebke,
After a break, I'll continue to review, sorry for the delay. I agree with
Pierre. It does not make sense to have directories with a single file
[
https://issues.apache.org/jira/browse/OFBIZ-11762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127992#comment-17127992
]
Jacques Le Roux commented on OFBIZ-11762:
-
Yes please Priya, for logError too.
> Use
[
https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128006#comment-17128006
]
Jacques Le Roux commented on OFBIZ-11745:
-
Hi Olivier,
You say:
bq. the correct value seem to
[
https://issues.apache.org/jira/browse/OFBIZ-11806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-11806.
---
Resolution: Done
Hi Pierre,
I did not create contentimage. It's mainly a placeholder,
[
https://issues.apache.org/jira/browse/OFBIZ-11762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127955#comment-17127955
]
Priya Sharma commented on OFBIZ-11762:
--
Sure, Jacques.
Please confirm, do we want to overload one
[
https://issues.apache.org/jira/browse/OFBIZ-11796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127952#comment-17127952
]
Jacques Le Roux commented on OFBIZ-11796:
-
Hi Suraj,
Weird that nobody thought about that
[
https://issues.apache.org/jira/browse/OFBIZ-11762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127942#comment-17127942
]
Jacques Le Roux commented on OFBIZ-11762:
-
Hi Priya,
Yes indeed forgot the plugins. Could you
[
https://issues.apache.org/jira/browse/OFBIZ-8459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127920#comment-17127920
]
Pawan Verma commented on OFBIZ-8459:
Thanks, Jacques.
It got messy and I tried to revert it, Idk
43 matches
Mail list logo