[jira] [Commented] (OFBIZ-11350) Checkstyle improvements
[ https://issues.apache.org/jira/browse/OFBIZ-11350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140736#comment-17140736 ] Jacques Le Roux commented on OFBIZ-11350: - Hi Eugen, This has not been discussed yet and think it's worth adding a message to the thread! > Checkstyle improvements > --- > > Key: OFBIZ-11350 > URL: https://issues.apache.org/jira/browse/OFBIZ-11350 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > > This is an umbrella task for checkstyle improvements. > See related discussion on the dev mailinglist: > https://lists.apache.org/thread.html/rf417d7b136eda217916483592f7e072184a0687babfe7f0b74bf820e%40%3Cdev.ofbiz.apache.org%3E -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11706) Apply multi-block attr to each application
[ https://issues.apache.org/jira/browse/OFBIZ-11706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11706. --- Fix Version/s: (was: Trunk) Upcoming Branch Resolution: Fixed Yes it does, thanks James! > Apply multi-block attr to each application > -- > > Key: OFBIZ-11706 > URL: https://issues.apache.org/jira/browse/OFBIZ-11706 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS, ALL PLUGINS >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > > For tracking commits related to multi-block attribute in html-template tag. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11587) Migration all docbook file to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140646#comment-17140646 ] ASF subversion and git services commented on OFBIZ-11587: - Commit a65c000a07e5328088c23949581aef96431c9172 in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a65c000 ] Documented: remove docbook help files for content (OFBIZ-11587) All files have been migrated to asciidoc format and help link now point to the html file generated from the asciidoc files In the global Help Docbook index tree, remove all points about content and add a short page with a link to the new help > Migration all docbook file to asciidoc > -- > > Key: OFBIZ-11587 > URL: https://issues.apache.org/jira/browse/OFBIZ-11587 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS, ALL PLUGINS >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 40m > Remaining Estimate: 0h > > Umbrella task, for all components migration tasks. > Idea is to have only one branch/PR for all tasks, with one commit per > component / sub-component migration, it will be more easy to merge it when it > will be finish -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11587) Migration all docbook file to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140647#comment-17140647 ] ASF subversion and git services commented on OFBIZ-11587: - Commit 21077ac056674fec7610b49bb1125d6bf9289522 in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=21077ac ] Documented: remove docbook help files for humanres (OFBIZ-11587) All files have been migrated to asciidoc format and help link now point to the html file generated from the asciidoc files In the global Help Docbook index tree, remove all points about humanres and add a short page with a link to the new help > Migration all docbook file to asciidoc > -- > > Key: OFBIZ-11587 > URL: https://issues.apache.org/jira/browse/OFBIZ-11587 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS, ALL PLUGINS >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 40m > Remaining Estimate: 0h > > Umbrella task, for all components migration tasks. > Idea is to have only one branch/PR for all tasks, with one commit per > component / sub-component migration, it will be more easy to merge it when it > will be finish -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11808) Improve screen engine with decrease technology dependence
[ https://issues.apache.org/jira/browse/OFBIZ-11808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140621#comment-17140621 ] Nicolas Malin commented on OFBIZ-11808: --- I tried to separate the code for OFBIZ-11811 and OFBIZ-11810 but the code it's too crossed, I will open a PR with chained commits > Improve screen engine with decrease technology dependence > - > > Key: OFBIZ-11808 > URL: https://issues.apache.org/jira/browse/OFBIZ-11808 > Project: OFBiz > Issue Type: Improvement > Components: framework, framework/widget >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Major > Labels: screen, widget > > After different presentation on thinking about how improve the end user > experience on back office screen, we start a list of issues that cover the > minimum need. > [chapter > 1|https://lists.apache.org/thread.html/5dcc8cff9b5413070079d22833b6a10abee55bcfbfb0233019ed09b1%40%3Cdev.ofbiz.apache.org%3E] > > [chapter > 2|https://lists.apache.org/thread.html/r146f2814691e98e2cfc308ed3ac1db77fb6a356a2b73215517d300aa%40%3Cdev.ofbiz.apache.org%3E] > [chapter > 3|https://lists.apache.org/thread.html/ra5ed191eecbaf8096ddcdcf98048e70ea8c139fcab75c734ff30b6c0%40%3Cdev.ofbiz.apache.org%3E] > Each improvement is designed to decrease the xml form definition, based on > functional concept out any technology (relaying to theme). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11706) Apply multi-block attr to each application
[ https://issues.apache.org/jira/browse/OFBIZ-11706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140619#comment-17140619 ] James Yong commented on OFBIZ-11706: Hi Jacques, Please check if the fix works. Thanks. > Apply multi-block attr to each application > -- > > Key: OFBIZ-11706 > URL: https://issues.apache.org/jira/browse/OFBIZ-11706 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS, ALL PLUGINS >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > > For tracking commits related to multi-block attribute in html-template tag. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11813) Add sub-screen decorator DetailScreenDecorator and EmbeddedDecorator
[ https://issues.apache.org/jira/browse/OFBIZ-11813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-11813: -- Attachment: OFBIZ-11813.patch > Add sub-screen decorator DetailScreenDecorator and EmbeddedDecorator > > > Key: OFBIZ-11813 > URL: https://issues.apache.org/jira/browse/OFBIZ-11813 > Project: OFBiz > Issue Type: Sub-task > Components: framework/widget >Affects Versions: Trunk >Reporter: Nicolas Malin >Priority: Major > Labels: decorator, screen, theme, widget > Attachments: OFBIZ-11813.patch > > > To homogenize and help each theme to implement correctly the screen engine > concept. We adding 2 sub-decorators like 'FindScreenDecorator' > DetailScreenDecorator: to display a functional element > EmbeddedDecorator: to help technology implementation to prepare include and > embedded screen -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11706) Apply multi-block attr to each application
[ https://issues.apache.org/jira/browse/OFBIZ-11706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140617#comment-17140617 ] ASF subversion and git services commented on OFBIZ-11706: - Commit 4dbdf720c5bfc349e8efd9aea2e9102548388b46 in ofbiz-framework's branch refs/heads/trunk from James Yong [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=4dbdf72 ] Fixed: Apply multi-block attr to each application (OFBIZ-11706) Rendering screen within freemarker template not done correctly when multi-block=true Thanks: Jacques for reporting > Apply multi-block attr to each application > -- > > Key: OFBIZ-11706 > URL: https://issues.apache.org/jira/browse/OFBIZ-11706 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS, ALL PLUGINS >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > > For tracking commits related to multi-block attribute in html-template tag. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11813) Add sub-screen decorator DetailScreenDecorator and EmbeddedDecorator
[ https://issues.apache.org/jira/browse/OFBIZ-11813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-11813: -- Summary: Add sub-screen decorator DetailScreenDecorator and EmbeddedDecorator (was: Add sub-screen decorator DetailDecorator and EmbeddedDecorator) > Add sub-screen decorator DetailScreenDecorator and EmbeddedDecorator > > > Key: OFBIZ-11813 > URL: https://issues.apache.org/jira/browse/OFBIZ-11813 > Project: OFBiz > Issue Type: Sub-task > Components: framework/widget >Affects Versions: Trunk >Reporter: Nicolas Malin >Priority: Major > Labels: decorator, screen, theme, widget > > To homogenize and help each theme to implement correctly the screen engine > concept. We adding 2 sub-decorators like 'FindScreenDecorator' > DetailScreenDecorator: to display a functional element > EmbeddedDecorator: to help technology implementation to prepare include and > embedded screen -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11813) Add sub-screen decorator DetailDecorator and EmbeddedDecorator
[ https://issues.apache.org/jira/browse/OFBIZ-11813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-11813: -- Description: To homogenize and help each theme to implement correctly the screen engine concept. We adding 2 sub-decorators like 'FindScreenDecorator' DetailScreenDecorator: to display a functional element EmbeddedDecorator: to help technology implementation to prepare include and embedded screen was: To homogenize and help each theme to implement correctly the screen engine concept. We adding 2 sub-decorators like 'FindDecorator' DetailDecorator: to display a functional element EmbeddedDecorator: to help technology implementation to prepare include and embedded screen > Add sub-screen decorator DetailDecorator and EmbeddedDecorator > -- > > Key: OFBIZ-11813 > URL: https://issues.apache.org/jira/browse/OFBIZ-11813 > Project: OFBiz > Issue Type: Sub-task > Components: framework/widget >Affects Versions: Trunk >Reporter: Nicolas Malin >Priority: Major > Labels: decorator, screen, theme, widget > > To homogenize and help each theme to implement correctly the screen engine > concept. We adding 2 sub-decorators like 'FindScreenDecorator' > DetailScreenDecorator: to display a functional element > EmbeddedDecorator: to help technology implementation to prepare include and > embedded screen -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9984) Convert OrderServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-9984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140613#comment-17140613 ] ASF subversion and git services commented on OFBIZ-9984: Commit 7c8aab3d9d92fb3d52661ef436f767516609cad0 in ofbiz-framework's branch refs/heads/trunk from Gil Portenseigne [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7c8aab3 ] Improved: Migrate checkCreateOrderRequirement service to groovy (OFBIZ-9984) This commit migrate also dependent method and remove createRequirementFromItemATP service > Convert OrderServices.xml mini-lang to groovyDSL > > > Key: OFBIZ-9984 > URL: https://issues.apache.org/jira/browse/OFBIZ-9984 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Julien NICOLAS >Assignee: Gil Portenseigne >Priority: Minor > Labels: groovy, mini-lang > Attachments: OFBIZ-9984-v1.patch, OFBIZ-9984.patch > > > With the purpose to deprecate mini-lang OFBIZ-9350, I tried to convert some > mini-lang service to groovy script. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)
[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140612#comment-17140612 ] Jacques Le Roux commented on OFBIZ-11304: - Hi Aditya, Yes, I started the "Check Style on release branches?" thread on dev ML 2 days ago. I'd wait the weekend and go ahead as a lazy consensus... > Install a Checkstyle pre-push (on every committer machine?) > --- > > Key: OFBIZ-11304 > URL: https://issues.apache.org/jira/browse/OFBIZ-11304 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Aditya Sharma >Priority: Minor > Fix For: Upcoming Branch > > > The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by > the check gradle task. It's "hard" to exactly know from where lint errors > come among all still present. > I think we should rely on a Checkstyle pre-commit hook like > https://gist.github.com/davetron5000/37350 to complement > tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when > a lint error is present in the commit. > Every committer would have it installed locally and the problem would be gone > with some committers good will. I started a discussion about it at > https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same > proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11350) Checkstyle improvements
[ https://issues.apache.org/jira/browse/OFBIZ-11350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140587#comment-17140587 ] Ioan Eugen Stan commented on OFBIZ-11350: - Haven't read the full discussion. Are you aware of https://github.com/openrewrite/rewrite-gradle-plugin and https://github.com/diffplug/spotless ? They can provide IDE independent formatting and checking . > Checkstyle improvements > --- > > Key: OFBIZ-11350 > URL: https://issues.apache.org/jira/browse/OFBIZ-11350 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > > This is an umbrella task for checkstyle improvements. > See related discussion on the dev mailinglist: > https://lists.apache.org/thread.html/rf417d7b136eda217916483592f7e072184a0687babfe7f0b74bf820e%40%3Cdev.ofbiz.apache.org%3E -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)
[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140490#comment-17140490 ] Aditya Sharma commented on OFBIZ-11304: --- Hi Jacques, I think we still have to handle the release branches. We can use the same ticket to backport checkstyle plugin and add the pre-push hook after consensus. Wdyt? > Install a Checkstyle pre-push (on every committer machine?) > --- > > Key: OFBIZ-11304 > URL: https://issues.apache.org/jira/browse/OFBIZ-11304 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Aditya Sharma >Priority: Minor > Fix For: Upcoming Branch > > > The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by > the check gradle task. It's "hard" to exactly know from where lint errors > come among all still present. > I think we should rely on a Checkstyle pre-commit hook like > https://gist.github.com/davetron5000/37350 to complement > tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when > a lint error is present in the commit. > Every committer would have it installed locally and the problem would be gone > with some committers good will. I started a discussion about it at > https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same > proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)
[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140456#comment-17140456 ] Jacques Le Roux commented on OFBIZ-11304: - Hi Suraj, It's a bit early to say. If a Gradle task is created that would be possible. I wonder though why a Gradle would be created. It seems more a human process to me, where committers decide to put information in the CHANGELOG.adoc file, wait and see... > Install a Checkstyle pre-push (on every committer machine?) > --- > > Key: OFBIZ-11304 > URL: https://issues.apache.org/jira/browse/OFBIZ-11304 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Aditya Sharma >Priority: Minor > Fix For: Upcoming Branch > > > The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by > the check gradle task. It's "hard" to exactly know from where lint errors > come among all still present. > I think we should rely on a Checkstyle pre-commit hook like > https://gist.github.com/davetron5000/37350 to complement > tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when > a lint error is present in the commit. > Every committer would have it installed locally and the problem would be gone > with some committers good will. I started a discussion about it at > https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same > proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] dixitdeepak opened a new pull request #206: Added Changelog.adoc file
dixitdeepak opened a new pull request #206: URL: https://github.com/apache/ofbiz-framework/pull/206 Improved: Added CHANGELOG.adoc file. (OFBIZ-11839) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-11837) First Data Payment Gateway Integration
[ https://issues.apache.org/jira/browse/OFBIZ-11837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140447#comment-17140447 ] Pritam Kute commented on OFBIZ-11837: - Thanks [~jleroux] for this. We will use this ticket for moving custom gateway code from the framework to plugins. > First Data Payment Gateway Integration > -- > > Key: OFBIZ-11837 > URL: https://issues.apache.org/jira/browse/OFBIZ-11837 > Project: OFBiz > Issue Type: New Feature >Affects Versions: Trunk >Reporter: Pritam Kute >Assignee: Pritam Kute >Priority: Major > > Dev Thread Link: [https://markmail.org/thread/2p5top4idkeiwlih] > Apache OFBiz has OOTB integrations for most of the widely used payment > gateways around the world. > We are working on integrating First Data Payment Gateway for one of the > websites. The First Data payment gateway is quite popular and comes in the > list of top payment gateways around the globe. We would like to contribute > the basic payment gateway integration of First Data into Apache OFBiz. > Also as discussed over the DEV list, we will be contributing gateway as a > separate plugin. > We will create the subtasks under this main task to deliver different payment > gateway methods. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11837) First Data Payment Gateway Integration
[ https://issues.apache.org/jira/browse/OFBIZ-11837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11837: Description: Dev Thread Link: [https://markmail.org/thread/2p5top4idkeiwlih] Apache OFBiz has OOTB integrations for most of the widely used payment gateways around the world. We are working on integrating First Data Payment Gateway for one of the websites. The First Data payment gateway is quite popular and comes in the list of top payment gateways around the globe. We would like to contribute the basic payment gateway integration of First Data into Apache OFBiz. Also as discussed over the DEV list, we will be contributing gateway as a separate plugin. We will create the subtasks under this main task to deliver different payment gateway methods. was: Apache OFBiz has OOTB integrations for most of the widely used payment gateways around the world. We are working on integrating First Data Payment Gateway for one of the websites. The First Data payment gateway is quite popular and comes in the list of top payment gateways around the globe. We would like to contribute the basic payment gateway integration of First Data into Apache OFBiz. Also as discussed over the DEV list, we will be contributing gateway as a separate plugin. We will create the subtasks under this main task to deliver different payment gateway methods. > First Data Payment Gateway Integration > -- > > Key: OFBIZ-11837 > URL: https://issues.apache.org/jira/browse/OFBIZ-11837 > Project: OFBiz > Issue Type: New Feature >Affects Versions: Trunk >Reporter: Pritam Kute >Assignee: Pritam Kute >Priority: Major > > Dev Thread Link: [https://markmail.org/thread/2p5top4idkeiwlih] > Apache OFBiz has OOTB integrations for most of the widely used payment > gateways around the world. > We are working on integrating First Data Payment Gateway for one of the > websites. The First Data payment gateway is quite popular and comes in the > list of top payment gateways around the globe. We would like to contribute > the basic payment gateway integration of First Data into Apache OFBiz. > Also as discussed over the DEV list, we will be contributing gateway as a > separate plugin. > We will create the subtasks under this main task to deliver different payment > gateway methods. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-7529) Delete stale java files from applications and framework
[ https://issues.apache.org/jira/browse/OFBIZ-7529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140428#comment-17140428 ] Mridul Pathak commented on OFBIZ-7529: -- Hi Jacques, I believe attic isn't updated, I'll review and update the attic. And yes I think we could close this ticket once the attic is updated as this ticket was specific to deleting the referenced files which is already complete. > Delete stale java files from applications and framework > --- > > Key: OFBIZ-7529 > URL: https://issues.apache.org/jira/browse/OFBIZ-7529 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Mridul Pathak >Assignee: Mridul Pathak >Priority: Major > > As per the discussions on the thread - > http://ofbiz.135035.n4.nabble.com/Proposal-to-delete-stale-java-files-tt4683855.html, > following files and their references needs to be deleted from applications > and framework, > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteArrayInputStream.java > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteArrayOutputStream.java > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeServices.java > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeWorker.java > applications/content/src/org/ofbiz/content/report > applications/content/src/org/ofbiz/content/report/JREntityListIteratorDataSource.java > applications/content/src/org/ofbiz/content/report/JRMapCollectionDataSource.java > applications/product/src/ShipmentScaleApplet.java > applications/securityext/src/org/ofbiz/securityext/thirdparty/truition/TruitionCoReg.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsJXlsViewHandler.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPdfViewHandler.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPoiXlsViewHandler.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsXmlViewHandler.java -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)
[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140422#comment-17140422 ] Suraj Khurana commented on OFBIZ-11304: --- Hello team, Should we consider OFBIZ-11839 as part of this pre-hook. Thoughts !! > Install a Checkstyle pre-push (on every committer machine?) > --- > > Key: OFBIZ-11304 > URL: https://issues.apache.org/jira/browse/OFBIZ-11304 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Aditya Sharma >Priority: Minor > Fix For: Upcoming Branch > > > The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by > the check gradle task. It's "hard" to exactly know from where lint errors > come among all still present. > I think we should rely on a Checkstyle pre-commit hook like > https://gist.github.com/davetron5000/37350 to complement > tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when > a lint error is present in the commit. > Every committer would have it installed locally and the problem would be gone > with some committers good will. I started a discussion about it at > https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same > proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11839) Add CHANGELOG.adoc file
Deepak Dixit created OFBIZ-11839: Summary: Add CHANGELOG.adoc file Key: OFBIZ-11839 URL: https://issues.apache.org/jira/browse/OFBIZ-11839 Project: OFBiz Issue Type: Improvement Affects Versions: Trunk, Release Branch 18.12, Release Branch 17.12 Reporter: Deepak Dixit Assignee: Deepak Dixit Add new changelog.adoc file to maintain the changelog *What is a changelog?* A changelog is a file which contains a curated, chronologically ordered list of notable changes for each version of a project. ** *Why keep a changelog?* To make it easier for users and contributors to see precisely what notable changes have been made between each release (or version) of the project. ** *Who needs a changelog?* People do. Whether consumers or developers, the end users of software are human beings who care about what's in the software. When the software changes, people want to know why and how. [https://keepachangelog.com/en/1.0.0/] [Here|https://s.apache.org/7klg3] is the link for Dev list discussion. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11838) One page checkout is broken because of ordermgr::getAssociatedStateList
Jacques Le Roux created OFBIZ-11838: --- Summary: One page checkout is broken because of ordermgr::getAssociatedStateList Key: OFBIZ-11838 URL: https://issues.apache.org/jira/browse/OFBIZ-11838 Project: OFBiz Issue Type: Bug Components: ecommerce Affects Versions: Trunk Reporter: Jacques Le Roux It works in example/control/FormWidgetExamples so it's an ecommerce issue. It also works at https://demo-stable.ofbiz.apache.org/ecomseo/onePageCheckout so it's something "recent" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11821) Use Compound Widget on rest of the project
[
https://issues.apache.org/jira/browse/OFBIZ-11821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140362#comment-17140362
]
Jacques Le Roux commented on OFBIZ-11821:
-
Actually after reverting remains this:
bq. 2020-06-19 11:22:08,020 |jsse-nio-8443-exec-9 |UtilXml
|E| XmlFileLoader: File
file:/C:/projectsASF/Git/ofbiz-framework/applications/order/widget/ordermgr/FindRequestCompound.xml
process error. Line: 72. Error message: cvc-complex-type.2.4.a: Invalid
content was found starting with element 'html'. One of
'{"http://ofbiz.apache.org/Widget-Screen":html,
"http://ofbiz.apache.org/Widget-Screen":swing,
"http://ofbiz.apache.org/Widget-Screen":xsl-fo,
"http://ofbiz.apache.org/Widget-Screen":xml,
"http://ofbiz.apache.org/Widget-Screen":text,
"http://ofbiz.apache.org/Widget-Screen":csv,
"http://ofbiz.apache.org/Widget-Screen":xls}' is expected.
I stopped there...
> Use Compound Widget on rest of the project
> --
>
> Key: OFBIZ-11821
> URL: https://issues.apache.org/jira/browse/OFBIZ-11821
> Project: OFBiz
> Issue Type: Improvement
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
>
> Currently, compound widget tag is only used in Examples application.
> Propose to convert rest of the project to use compound widget, so that
> dependencies are grouped together.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11821) Use Compound Widget on rest of the project
[
https://issues.apache.org/jira/browse/OFBIZ-11821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140354#comment-17140354
]
Jacques Le Roux commented on OFBIZ-11821:
-
Hi James,
While using one page checkout in ecommerce I found this in log:
bq. 2020-06-19 11:11:01,619 |jsse-nio-8443-exec-2 |UtilXml
|E| XmlFileLoader: File
file:/C:/projectsASF/Git/ofbiz-framework/applications/order/widget/ordermgr/FindRequestCompound.xml
process error. Line: 22. Error message: cvc-complex-type.2.4.a: Invalid
content was found starting with element 'site-conf'. One of
'{"http://ofbiz.apache.org/Site-Conf":site-conf,
"http://ofbiz.apache.org/Widget-Menu":menus,
"http://ofbiz.apache.org/Widget-Screen":screens,
"http://ofbiz.apache.org/Widget-Tree":trees,
"http://ofbiz.apache.org/Widget-Form":forms,
"http://ofbiz.apache.org/Simple-Method":simple-methods}' is expected.
Reverting da3473b1833ab498675d66cc5caab13f1df29d50 fixes it
> Use Compound Widget on rest of the project
> --
>
> Key: OFBIZ-11821
> URL: https://issues.apache.org/jira/browse/OFBIZ-11821
> Project: OFBiz
> Issue Type: Improvement
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
>
> Currently, compound widget tag is only used in Examples application.
> Propose to convert rest of the project to use compound widget, so that
> dependencies are grouped together.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Reopened] (OFBIZ-11706) Apply multi-block attr to each application
[ https://issues.apache.org/jira/browse/OFBIZ-11706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-11706: - Hi James, Reopening because at least a802ae0a021650fe41d830a55957fdec4bac6324 commit had a negative impact on ecommerce main page which is now "distorted" (only 1 colum) as you can see at https://demo-trunk.ofbiz.apache.org/ecomseo. If you revert locally it's OK. BTW https://demo-stable.ofbiz.apache.org/ecomseo does not look very good too, but that's another issue. I did not check R18, anyway not your problem... TIA for taking care > Apply multi-block attr to each application > -- > > Key: OFBIZ-11706 > URL: https://issues.apache.org/jira/browse/OFBIZ-11706 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS, ALL PLUGINS >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > > For tracking commits related to multi-block attribute in html-template tag. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-7529) Delete stale java files from applications and framework
[ https://issues.apache.org/jira/browse/OFBIZ-7529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140330#comment-17140330 ] Jacques Le Roux commented on OFBIZ-7529: Hi Mridul, Taher, I get here by chance (actually related to OFBIZ-7415 and OFBIZ-11837. Taher, I don't know which dev ML thread is related, should we not close, was Attic updated? TIA > Delete stale java files from applications and framework > --- > > Key: OFBIZ-7529 > URL: https://issues.apache.org/jira/browse/OFBIZ-7529 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Mridul Pathak >Assignee: Mridul Pathak >Priority: Major > > As per the discussions on the thread - > http://ofbiz.135035.n4.nabble.com/Proposal-to-delete-stale-java-files-tt4683855.html, > following files and their references needs to be deleted from applications > and framework, > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteArrayInputStream.java > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteArrayOutputStream.java > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeServices.java > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeWorker.java > applications/content/src/org/ofbiz/content/report > applications/content/src/org/ofbiz/content/report/JREntityListIteratorDataSource.java > applications/content/src/org/ofbiz/content/report/JRMapCollectionDataSource.java > applications/product/src/ShipmentScaleApplet.java > applications/securityext/src/org/ofbiz/securityext/thirdparty/truition/TruitionCoReg.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsJXlsViewHandler.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPdfViewHandler.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPoiXlsViewHandler.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsXmlViewHandler.java -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11837) First Data Payment Gateway Integration
[ https://issues.apache.org/jira/browse/OFBIZ-11837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140327#comment-17140327 ] Jacques Le Roux commented on OFBIZ-11837: - Hi Pritam, Some times a go [~pierresmits] created OFBIZ-7415 for "Moving 3rd party payment integrations from accounting application to plugins" I trust it helps to refer to it here. > First Data Payment Gateway Integration > -- > > Key: OFBIZ-11837 > URL: https://issues.apache.org/jira/browse/OFBIZ-11837 > Project: OFBiz > Issue Type: New Feature >Affects Versions: Trunk >Reporter: Pritam Kute >Assignee: Pritam Kute >Priority: Major > > Apache OFBiz has OOTB integrations for most of the widely used payment > gateways around the world. > We are working on integrating First Data Payment Gateway for one of the > websites. The First Data payment gateway is quite popular and comes in the > list of top payment gateways around the globe. We would like to contribute > the basic payment gateway integration of First Data into Apache OFBiz. > Also as discussed over the DEV list, we will be contributing gateway as a > separate plugin. > We will create the subtasks under this main task to deliver different payment > gateway methods. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11837) First Data Payment Gateway Integration
Pritam Kute created OFBIZ-11837: --- Summary: First Data Payment Gateway Integration Key: OFBIZ-11837 URL: https://issues.apache.org/jira/browse/OFBIZ-11837 Project: OFBiz Issue Type: New Feature Affects Versions: Trunk Reporter: Pritam Kute Assignee: Pritam Kute Apache OFBiz has OOTB integrations for most of the widely used payment gateways around the world. We are working on integrating First Data Payment Gateway for one of the websites. The First Data payment gateway is quite popular and comes in the list of top payment gateways around the globe. We would like to contribute the basic payment gateway integration of First Data into Apache OFBiz. Also as discussed over the DEV list, we will be contributing gateway as a separate plugin. We will create the subtasks under this main task to deliver different payment gateway methods. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #32: Release17.12
sonarcloud[bot] commented on pull request #32: URL: https://github.com/apache/ofbiz-plugins/pull/32#issuecomment-646483298 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=32) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=32=duplicated_lines_density=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-plugins] alexbodn opened a new pull request #32: Release17.12
alexbodn opened a new pull request #32: URL: https://github.com/apache/ofbiz-plugins/pull/32 a handful of bug fixes explained in each commit (OFBIZ-11817, OFBIZ-11818) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)
[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140285#comment-17140285 ] Jacques Le Roux commented on OFBIZ-11304: - Hi Aditya, bq. We can make it part of Committers Roles and Responsibilities You are right, and that should be enough. I checked, even old PRs like https://github.com/apache/ofbiz-framework/pull/158 run the check action. So committers are able to decide if they should or not merge. I think it's enough and we don't need to get in the CI server rabbit hole ;) I believe we can close here, if you like... > Install a Checkstyle pre-push (on every committer machine?) > --- > > Key: OFBIZ-11304 > URL: https://issues.apache.org/jira/browse/OFBIZ-11304 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Aditya Sharma >Priority: Minor > Fix For: Upcoming Branch > > > The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by > the check gradle task. It's "hard" to exactly know from where lint errors > come among all still present. > I think we should rely on a Checkstyle pre-commit hook like > https://gist.github.com/davetron5000/37350 to complement > tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when > a lint error is present in the commit. > Every committer would have it installed locally and the problem would be gone > with some committers good will. I started a discussion about it at > https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same > proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11803) showHelp not working
[ https://issues.apache.org/jira/browse/OFBIZ-11803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz closed OFBIZ-11803. -- Resolution: Fixed Thank you James, it works it help me to continue migration to new help system > showHelp not working > > > Key: OFBIZ-11803 > URL: https://issues.apache.org/jira/browse/OFBIZ-11803 > Project: OFBiz > Issue Type: Bug > Components: framework/common >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > > Navigation tree is not displayed in showHelp -- This message was sent by Atlassian Jira (v8.3.4#803005)
