[jira] [Commented] (OFBIZ-11862) BigDecimal casting in Groovy

2020-07-02 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17150343#comment-17150343
 ] 

Jacques Le Roux commented on OFBIZ-11862:
-

Hi Pawan,

That sounds indeed better, please feel free to do so.

> BigDecimal casting in Groovy
> 
>
> Key: OFBIZ-11862
> URL: https://issues.apache.org/jira/browse/OFBIZ-11862
> Project: OFBiz
>  Issue Type: Bug
>  Components: bi, order, product
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01
>
>
> [Pritam Kute 
> noticed|https://issues.apache.org/jira/browse/OFBIZ-11843?focusedCommentId=17146911=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17146911]
>  in OFBIZ-11843 that we sometimes use wrong type castings for BigDecimal:
> {quote}
> I have observed that for typecasting in groovy, we have used the wrong coding 
> pattern like
> {code:java}
> (BigDecimal) -0.01
> {code}
> It should be like
> {code:java}
> -0.01 as BigDecimal
> {code}
> {quote}
> Actually in this case we don't need to cast, [because in case of decimal, the 
> default type is always 
> BigDecimal|https://www.logicbig.com/tutorials/misc/groovy/numbers-types-suffix.html].
>  
> But there are Integers in trunk (mostly 0) and 2 cases where it's useless to 
> cast in R18, nothing in R17



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11862) BigDecimal casting in Groovy

2020-07-02 Thread Pawan Verma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17150294#comment-17150294
 ] 

Pawan Verma commented on OFBIZ-11862:
-

Hi [~jleroux]

I'm sorry for the late review. Shouldn't we consider BigDecimal.ZERO instead?

> BigDecimal casting in Groovy
> 
>
> Key: OFBIZ-11862
> URL: https://issues.apache.org/jira/browse/OFBIZ-11862
> Project: OFBiz
>  Issue Type: Bug
>  Components: bi, order, product
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01
>
>
> [Pritam Kute 
> noticed|https://issues.apache.org/jira/browse/OFBIZ-11843?focusedCommentId=17146911=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17146911]
>  in OFBIZ-11843 that we sometimes use wrong type castings for BigDecimal:
> {quote}
> I have observed that for typecasting in groovy, we have used the wrong coding 
> pattern like
> {code:java}
> (BigDecimal) -0.01
> {code}
> It should be like
> {code:java}
> -0.01 as BigDecimal
> {code}
> {quote}
> Actually in this case we don't need to cast, [because in case of decimal, the 
> default type is always 
> BigDecimal|https://www.logicbig.com/tutorials/misc/groovy/numbers-types-suffix.html].
>  
> But there are Integers in trunk (mostly 0) and 2 cases where it's useless to 
> cast in R18, nothing in R17



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11862) BigDecimal casting in Groovy

2020-07-02 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-11862:
---

Assignee: Jacques Le Roux  (was: Pawan Verma)

> BigDecimal casting in Groovy
> 
>
> Key: OFBIZ-11862
> URL: https://issues.apache.org/jira/browse/OFBIZ-11862
> Project: OFBiz
>  Issue Type: Bug
>  Components: bi, order, product
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01
>
>
> [Pritam Kute 
> noticed|https://issues.apache.org/jira/browse/OFBIZ-11843?focusedCommentId=17146911=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17146911]
>  in OFBIZ-11843 that we sometimes use wrong type castings for BigDecimal:
> {quote}
> I have observed that for typecasting in groovy, we have used the wrong coding 
> pattern like
> {code:java}
> (BigDecimal) -0.01
> {code}
> It should be like
> {code:java}
> -0.01 as BigDecimal
> {code}
> {quote}
> Actually in this case we don't need to cast, [because in case of decimal, the 
> default type is always 
> BigDecimal|https://www.logicbig.com/tutorials/misc/groovy/numbers-types-suffix.html].
>  
> But there are Integers in trunk (mostly 0) and 2 cases where it's useless to 
> cast in R18, nothing in R17



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11862) BigDecimal casting in Groovy

2020-07-02 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-11862:
---

Assignee: Pawan Verma  (was: Jacques Le Roux)

> BigDecimal casting in Groovy
> 
>
> Key: OFBIZ-11862
> URL: https://issues.apache.org/jira/browse/OFBIZ-11862
> Project: OFBiz
>  Issue Type: Bug
>  Components: bi, order, product
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Pawan Verma
>Priority: Major
> Fix For: 18.12.01
>
>
> [Pritam Kute 
> noticed|https://issues.apache.org/jira/browse/OFBIZ-11843?focusedCommentId=17146911=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17146911]
>  in OFBIZ-11843 that we sometimes use wrong type castings for BigDecimal:
> {quote}
> I have observed that for typecasting in groovy, we have used the wrong coding 
> pattern like
> {code:java}
> (BigDecimal) -0.01
> {code}
> It should be like
> {code:java}
> -0.01 as BigDecimal
> {code}
> {quote}
> Actually in this case we don't need to cast, [because in case of decimal, the 
> default type is always 
> BigDecimal|https://www.logicbig.com/tutorials/misc/groovy/numbers-types-suffix.html].
>  
> But there are Integers in trunk (mostly 0) and 2 cases where it's useless to 
> cast in R18, nothing in R17



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11867) Convert ShoppingCartTests.xml to Groovy

2020-07-02 Thread Akash Jain (Jira)
Akash Jain created OFBIZ-11867:
--

 Summary: Convert ShoppingCartTests.xml to Groovy
 Key: OFBIZ-11867
 URL: https://issues.apache.org/jira/browse/OFBIZ-11867
 Project: OFBiz
  Issue Type: Sub-task
  Components: order
Affects Versions: Trunk
Reporter: Akash Jain
Assignee: Akash Jain


Convert ShoppingCartTests XML file to Groovy



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11753) Add names to BuildBot steps

2020-07-02 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-11753.
---
Resolution: Implemented

I'll see later if I need it for next and stable builders

> Add names to BuildBot steps
> ---
>
> Key: OFBIZ-11753
> URL: https://issues.apache.org/jira/browse/OFBIZ-11753
> Project: OFBiz
>  Issue Type: Improvement
>  Components: BuildBot
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
>
> It's more and more difficult to see what's going on in BuildBot status 
> display. Adding names to builds will help.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #66: OFBIZ-11587 docbook to asciidoc, delete docbook files

2020-07-02 Thread GitBox


sonarcloud[bot] removed a comment on pull request #66:
URL: https://github.com/apache/ofbiz-framework/pull/66#issuecomment-640052446


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=66=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=66=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=66=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=66=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=66=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=66=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=66=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=66=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=66=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=66=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=66=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=66)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=66=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=66=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #66: OFBIZ-11587 docbook to asciidoc, delete docbook files

2020-07-02 Thread GitBox


sonarcloud[bot] commented on pull request #66:
URL: https://github.com/apache/ofbiz-framework/pull/66#issuecomment-652939189


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=66=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=66=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=66=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=66=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=66=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=66=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=66=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=66=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=66=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=66=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=66=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=66)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=66=duplicated_lines_density=list)
 No Duplication information
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #65: OFBIZ-11587 docbook to asciidoc

2020-07-02 Thread GitBox


sonarcloud[bot] removed a comment on pull request #65:
URL: https://github.com/apache/ofbiz-framework/pull/65#issuecomment-647001696


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=65)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=65=duplicated_lines_density=list)
 No Duplication information
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #65: OFBIZ-11587 docbook to asciidoc

2020-07-02 Thread GitBox


sonarcloud[bot] commented on pull request #65:
URL: https://github.com/apache/ofbiz-framework/pull/65#issuecomment-652928652


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=65)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=65=duplicated_lines_density=list)
 No Duplication information
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Closed] (OFBIZ-11581) Party Docbook help file migration to asciidoc format

2020-07-02 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz closed OFBIZ-11581.
--
Resolution: Fixed

> Party Docbook help file migration to asciidoc format
> 
>
> Key: OFBIZ-11581
> URL: https://issues.apache.org/jira/browse/OFBIZ-11581
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: party
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Olivier Heintz
>Priority: Minor
>  Labels: documentation
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Migrate all Help files in docbook format to asciidoc format and include them 
> in a global party.adoc document.
> party.adoc follow  the template describe in Example structure for adoc files 
> in the wiki 
> [https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Documentation+Team]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11581) Party Docbook help file migration to asciidoc format

2020-07-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17150164#comment-17150164
 ] 

ASF subversion and git services commented on OFBIZ-11581:
-

Commit ef58d647b66bb3b63dc462642cf90652189cf2a7 in ofbiz-framework's branch 
refs/heads/trunk from Olivier Heintz
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ef58d64 ]

Documented: migrate help link to asciidoc user manual for Party
(OFBIZ-11581)

All files have been migrated to asciidoc format and help link now point
to the html file generated from the asciidoc files

In the global Help Docbook index tree, remove all points about
Party and add a short page with a link to the new help

Remove docbook help files for Party

> Party Docbook help file migration to asciidoc format
> 
>
> Key: OFBIZ-11581
> URL: https://issues.apache.org/jira/browse/OFBIZ-11581
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: party
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Olivier Heintz
>Priority: Minor
>  Labels: documentation
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Migrate all Help files in docbook format to asciidoc format and include them 
> in a global party.adoc document.
> party.adoc follow  the template describe in Example structure for adoc files 
> in the wiki 
> [https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Documentation+Team]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11581) Party Docbook help file migration to asciidoc format

2020-07-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17150163#comment-17150163
 ] 

ASF subversion and git services commented on OFBIZ-11581:
-

Commit 34291541a00fa75119311ba510b2b962e331d8f2 in ofbiz-framework's branch 
refs/heads/trunk from Olivier Heintz
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3429154 ]

Documented: Party migration to asciidoc
(OFBIZ-11581)

For all of HELP_Party files content has been directly put in
party.adoc

user-manual is updated to include it in.


> Party Docbook help file migration to asciidoc format
> 
>
> Key: OFBIZ-11581
> URL: https://issues.apache.org/jira/browse/OFBIZ-11581
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: party
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Olivier Heintz
>Priority: Minor
>  Labels: documentation
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Migrate all Help files in docbook format to asciidoc format and include them 
> in a global party.adoc document.
> party.adoc follow  the template describe in Example structure for adoc files 
> in the wiki 
> [https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Documentation+Team]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11580) Order Docbook help file migration to asciidoc format

2020-07-02 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz closed OFBIZ-11580.
--
Resolution: Fixed

> Order Docbook help file migration to asciidoc format
> 
>
> Key: OFBIZ-11580
> URL: https://issues.apache.org/jira/browse/OFBIZ-11580
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Olivier Heintz
>Priority: Minor
>  Labels: documentation
>
> Migrate all Help files in docbook format to asciidoc format and include them 
> in a global order.adoc document.
> order.adoc follow  the template describe in Example structure for adoc files 
> in the wiki 
> [https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Documentation+Team]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11580) Order Docbook help file migration to asciidoc format

2020-07-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17150151#comment-17150151
 ] 

ASF subversion and git services commented on OFBIZ-11580:
-

Commit 00176a26c225a7d08f3b6762813a04cfa9931706 in ofbiz-framework's branch 
refs/heads/trunk from Olivier Heintz
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=00176a2 ]

Documented: Order migration to asciidoc
(OFBIZ-11580)

For all of HELP_Order files content has been directly put in
order.adoc except for order_report which has its own file

user-manual is updated to include it in.


> Order Docbook help file migration to asciidoc format
> 
>
> Key: OFBIZ-11580
> URL: https://issues.apache.org/jira/browse/OFBIZ-11580
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Olivier Heintz
>Priority: Minor
>  Labels: documentation
>
> Migrate all Help files in docbook format to asciidoc format and include them 
> in a global order.adoc document.
> order.adoc follow  the template describe in Example structure for adoc files 
> in the wiki 
> [https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Documentation+Team]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11580) Order Docbook help file migration to asciidoc format

2020-07-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17150152#comment-17150152
 ] 

ASF subversion and git services commented on OFBIZ-11580:
-

Commit 56f164d3a819e54f0053f957b021ce56dcf141e0 in ofbiz-framework's branch 
refs/heads/trunk from Olivier Heintz
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=56f164d ]

Documented: migrate help link to asciidoc user manual for Order
(OFBIZ-11580)

All files have been migrated to asciidoc format and help link now point
to the html file generated from the asciidoc files

In the global Help Docbook index tree, remove all points about
Order and add a short page with a link to the new help

Remove docbook help files for Order

> Order Docbook help file migration to asciidoc format
> 
>
> Key: OFBIZ-11580
> URL: https://issues.apache.org/jira/browse/OFBIZ-11580
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Olivier Heintz
>Priority: Minor
>  Labels: documentation
>
> Migrate all Help files in docbook format to asciidoc format and include them 
> in a global order.adoc document.
> order.adoc follow  the template describe in Example structure for adoc files 
> in the wiki 
> [https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Documentation+Team]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11866) Convert InventoryReserveServices.xml mini lang to groovy

2020-07-02 Thread Jira


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wiebke Pätzold reassigned OFBIZ-11866:
--

Assignee: Wiebke Pätzold

> Convert InventoryReserveServices.xml mini lang to groovy
> 
>
> Key: OFBIZ-11866
> URL: https://issues.apache.org/jira/browse/OFBIZ-11866
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Wiebke Pätzold
>Assignee: Wiebke Pätzold
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11866) Convert InventoryReserveServices.xml mini lang to groovy

2020-07-02 Thread Jira
Wiebke Pätzold created OFBIZ-11866:
--

 Summary: Convert InventoryReserveServices.xml mini lang to groovy
 Key: OFBIZ-11866
 URL: https://issues.apache.org/jira/browse/OFBIZ-11866
 Project: OFBiz
  Issue Type: Sub-task
Reporter: Wiebke Pätzold






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11577) Marketink Docbook help file migration to asciidoc format

2020-07-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17150124#comment-17150124
 ] 

ASF subversion and git services commented on OFBIZ-11577:
-

Commit 51ff39c68a9d52f377bf7f72fb50a431f899543a in ofbiz-framework's branch 
refs/heads/trunk from Olivier Heintz
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=51ff39c ]

Documented: migrate help link to asciidoc user manual for SFA
(OFBIZ-11577)

All files have been migrated to asciidoc format and help link now point
to the html file generated from the asciidoc files

In the global Help Docbook index tree, remove all points about
SFA and add a short page with a link to the new help

Remove docbook help files for SFA

> Marketink Docbook help file migration to asciidoc format
> 
>
> Key: OFBIZ-11577
> URL: https://issues.apache.org/jira/browse/OFBIZ-11577
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Olivier Heintz
>Priority: Minor
>  Labels: documentation
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Migrate all Help files in docbook format to asciidoc format and include them 
> in a global marketing.adoc document.
> marketing.adoc follow  the template describe in Example structure for adoc 
> files in the wiki 
> [https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Documentation+Team]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11577) Marketink Docbook help file migration to asciidoc format

2020-07-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17150123#comment-17150123
 ] 

ASF subversion and git services commented on OFBIZ-11577:
-

Commit 49de6efaf2880c8db2cf66dcc422bb0136ca44e7 in ofbiz-framework's branch 
refs/heads/trunk from Olivier Heintz
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=49de6ef ]

Documented: SFA migration to asciidoc
(OFBIZ-11577)

For all of HELP_SFA files content has been directly put in
sfa.adoc


> Marketink Docbook help file migration to asciidoc format
> 
>
> Key: OFBIZ-11577
> URL: https://issues.apache.org/jira/browse/OFBIZ-11577
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Olivier Heintz
>Priority: Minor
>  Labels: documentation
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Migrate all Help files in docbook format to asciidoc format and include them 
> in a global marketing.adoc document.
> marketing.adoc follow  the template describe in Example structure for adoc 
> files in the wiki 
> [https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Documentation+Team]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11577) Marketink Docbook help file migration to asciidoc format

2020-07-02 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz closed OFBIZ-11577.
--
Resolution: Fixed

> Marketink Docbook help file migration to asciidoc format
> 
>
> Key: OFBIZ-11577
> URL: https://issues.apache.org/jira/browse/OFBIZ-11577
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Olivier Heintz
>Priority: Minor
>  Labels: documentation
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Migrate all Help files in docbook format to asciidoc format and include them 
> in a global marketing.adoc document.
> marketing.adoc follow  the template describe in Example structure for adoc 
> files in the wiki 
> [https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Documentation+Team]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11577) Marketink Docbook help file migration to asciidoc format

2020-07-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17150104#comment-17150104
 ] 

ASF subversion and git services commented on OFBIZ-11577:
-

Commit 2f7aa0423651995da8db5903386ee3971e25f494 in ofbiz-framework's branch 
refs/heads/trunk from Olivier Heintz
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=2f7aa04 ]

Documented: Marketing migration to asciidoc and new documentation
organization
(OFBIZ-11577)

Main files and ContactList


> Marketink Docbook help file migration to asciidoc format
> 
>
> Key: OFBIZ-11577
> URL: https://issues.apache.org/jira/browse/OFBIZ-11577
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Olivier Heintz
>Priority: Minor
>  Labels: documentation
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Migrate all Help files in docbook format to asciidoc format and include them 
> in a global marketing.adoc document.
> marketing.adoc follow  the template describe in Example structure for adoc 
> files in the wiki 
> [https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Documentation+Team]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11577) Marketink Docbook help file migration to asciidoc format

2020-07-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17150105#comment-17150105
 ] 

ASF subversion and git services commented on OFBIZ-11577:
-

Commit 19f10cc24bb88896fbcb9112529d5910d78d9d54 in ofbiz-framework's branch 
refs/heads/trunk from Olivier Heintz
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=19f10cc ]

Documented: migrate help link to asciidoc user manual for marketing
(OFBIZ-11577)

All files have been migrated to asciidoc format and help link now point
to the html file generated from the asciidoc files

In the global Help Docbook index tree, remove all points about
marketing and add a short page with a link to the new help

Remove docbook help files for marketing

> Marketink Docbook help file migration to asciidoc format
> 
>
> Key: OFBIZ-11577
> URL: https://issues.apache.org/jira/browse/OFBIZ-11577
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Olivier Heintz
>Priority: Minor
>  Labels: documentation
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Migrate all Help files in docbook format to asciidoc format and include them 
> in a global marketing.adoc document.
> marketing.adoc follow  the template describe in Example structure for adoc 
> files in the wiki 
> [https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Documentation+Team]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] dixitdeepak merged pull request #206: OFBIZ-11839: Added Changelog.adoc file

2020-07-02 Thread GitBox


dixitdeepak merged pull request #206:
URL: https://github.com/apache/ofbiz-framework/pull/206


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #169: OFBIZ-11756 vue js renderer

2020-07-02 Thread GitBox


sonarcloud[bot] commented on pull request #169:
URL: https://github.com/apache/ofbiz-framework/pull/169#issuecomment-652874990


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=169=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=169=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=169=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=169=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=169=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=169=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=169=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=169=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=169=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=169=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=169=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=169)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=169=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=169=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #27: OFBIZ-11756 vue js renderer

2020-07-02 Thread GitBox


sonarcloud[bot] removed a comment on pull request #27:
URL: https://github.com/apache/ofbiz-plugins/pull/27#issuecomment-646968003


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=BUG)
 [10 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=SECURITY_HOTSPOT)
 [7 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=CODE_SMELL)
 [216 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=27)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=27=new_duplicated_lines_density=list)
 [3.2% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=27=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #27: OFBIZ-11756 vue js renderer

2020-07-02 Thread GitBox


sonarcloud[bot] commented on pull request #27:
URL: https://github.com/apache/ofbiz-plugins/pull/27#issuecomment-652869648


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=BUG)
 [10 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=SECURITY_HOTSPOT)
 [7 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=CODE_SMELL)
 [216 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=27)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=27=new_duplicated_lines_density=list)
 [3.2% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=27=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (OFBIZ-11456) MacroFormRenderer refactoring

2020-07-02 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-11456:

Description: 
Class MacroFormRender is 3400 lines long and performs the following:
 * Renders the various form structure parts and field widgets to FTL macros 
calls.
 * Configures the FTL environment.
 * Executes the FTL macro calls to generate HTML and write it to a caller 
provided Appendable.

Implementing the above means that MacroFormRenderer does not meet the Single 
Responsibility Principle. The current implementation of multiple 
responsibilities makes unit testing difficult.

As discussed on the dev mailing list 
https://markmail.org/message/adtkk6cb6o7mmy7f it is proposed that 
MacroFormRenderer is refactored.

Refactoring should separate the rendering of form structure parts and field 
widgets to FTL macro calls from the execution of those macros.

To support the refactoring effort JMockit is being introduced (OFBIZ-4035) to 
allow test creation against the current implementation of MacroFormRenderer, 
helping to ensure functionality is preserved once refactoring is complete.

  was:
Class MacroFormRender is 3400 lines long and performs the following:
 * Renders the various form structure parts and field widgets to FTL macros 
calls.
 * Configures the FTL environment.
 * Executes the FTL macro calls to generate HTML and write it to a caller 
provided Appendable.

Implementing the above means that MacroFormRenderer does not meet the Single 
Responsibility Principle. The current implementation of multiple 
responsibilities makes unit testing difficult.

As discussed on the dev mailing list 
https://lists.apache.org/list.html?d...@ofbiz.apache.org:lte=1M:ofbiz-4035 it 
is proposed that MacroFormRenderer is refactored.

Refactoring should separate the rendering of form structure parts and field 
widgets to FTL macro calls from the execution of those macros.

To support the refactoring effort JMockit is being introduced (OFBIZ-4035) to 
allow test creation against the current implementation of MacroFormRenderer, 
helping to ensure functionality is preserved once refactoring is complete.


> MacroFormRenderer refactoring
> -
>
> Key: OFBIZ-11456
> URL: https://issues.apache.org/jira/browse/OFBIZ-11456
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: Trunk
>Reporter: Daniel Watford
>Assignee: Daniel Watford
>Priority: Minor
>
> Class MacroFormRender is 3400 lines long and performs the following:
>  * Renders the various form structure parts and field widgets to FTL macros 
> calls.
>  * Configures the FTL environment.
>  * Executes the FTL macro calls to generate HTML and write it to a caller 
> provided Appendable.
> Implementing the above means that MacroFormRenderer does not meet the Single 
> Responsibility Principle. The current implementation of multiple 
> responsibilities makes unit testing difficult.
> As discussed on the dev mailing list 
> https://markmail.org/message/adtkk6cb6o7mmy7f it is proposed that 
> MacroFormRenderer is refactored.
> Refactoring should separate the rendering of form structure parts and field 
> widgets to FTL macro calls from the execution of those macros.
> To support the refactoring effort JMockit is being introduced (OFBIZ-4035) to 
> allow test creation against the current implementation of MacroFormRenderer, 
> helping to ensure functionality is preserved once refactoring is complete.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11456) MacroFormRenderer refactoring

2020-07-02 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-11456:

Description: 
Class MacroFormRender is 3400 lines long and performs the following:
 * Renders the various form structure parts and field widgets to FTL macros 
calls.
 * Configures the FTL environment.
 * Executes the FTL macro calls to generate HTML and write it to a caller 
provided Appendable.

Implementing the above means that MacroFormRenderer does not meet the Single 
Responsibility Principle. The current implementation of multiple 
responsibilities makes unit testing difficult.

As discussed on the dev mailing list 
https://lists.apache.org/list.html?d...@ofbiz.apache.org:lte=1M:ofbiz-4035 it 
is proposed that MacroFormRenderer is refactored.

Refactoring should separate the rendering of form structure parts and field 
widgets to FTL macro calls from the execution of those macros.

To support the refactoring effort JMockit is being introduced (OFBIZ-4035) to 
allow test creation against the current implementation of MacroFormRenderer, 
helping to ensure functionality is preserved once refactoring is complete.

  was:
Class MacroFormRender is 3400 lines long and performs the following:
 * Renders the various form structure parts and field widgets to FTL macros 
calls.
 * Configures the FTL environment.
 * Executes the FTL macro calls to generate HTML and write it to a caller 
provided Appendable.

Implementing the above means that MacroFormRenderer does not meet the Single 
Responsibility Principle. The current implementation of multiple 
responsibilities makes unit testing difficult.

As discussed on the dev mailing list 
([[https://lists.apache.org/list.html?d...@ofbiz.apache.org:lte=1M:ofbiz-4035|http://example.com]|https://lists.apache.org/list.html?d...@ofbiz.apache.org:lte=1M:ofbiz-4035])
 it is proposed that MacroFormRenderer is refactored.

Refactoring should separate the rendering of form structure parts and field 
widgets to FTL macro calls from the execution of those macros.

To support the refactoring effort JMockit is being introduced (OFBIZ-4035) to 
allow test creation against the current implementation of MacroFormRenderer, 
helping to ensure functionality is preserved once refactoring is complete.


> MacroFormRenderer refactoring
> -
>
> Key: OFBIZ-11456
> URL: https://issues.apache.org/jira/browse/OFBIZ-11456
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: Trunk
>Reporter: Daniel Watford
>Assignee: Daniel Watford
>Priority: Minor
>
> Class MacroFormRender is 3400 lines long and performs the following:
>  * Renders the various form structure parts and field widgets to FTL macros 
> calls.
>  * Configures the FTL environment.
>  * Executes the FTL macro calls to generate HTML and write it to a caller 
> provided Appendable.
> Implementing the above means that MacroFormRenderer does not meet the Single 
> Responsibility Principle. The current implementation of multiple 
> responsibilities makes unit testing difficult.
> As discussed on the dev mailing list 
> https://lists.apache.org/list.html?d...@ofbiz.apache.org:lte=1M:ofbiz-4035 it 
> is proposed that MacroFormRenderer is refactored.
> Refactoring should separate the rendering of form structure parts and field 
> widgets to FTL macro calls from the execution of those macros.
> To support the refactoring effort JMockit is being introduced (OFBIZ-4035) to 
> allow test creation against the current implementation of MacroFormRenderer, 
> helping to ensure functionality is preserved once refactoring is complete.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11532) Convert testGlPostingOnCancelInvoice test from XML to Groovy

2020-07-02 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-11532.
--
Fix Version/s: (was: Trunk)
   Upcoming Branch
   Resolution: Implemented

This has been handled in OFBIZ-11531

Thanks, [~rohit.hukkeri]!

> Convert testGlPostingOnCancelInvoice test from XML to Groovy
> 
>
> Key: OFBIZ-11532
> URL: https://issues.apache.org/jira/browse/OFBIZ-11532
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Rohit Hukkeri
>Assignee: Akash Jain
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Convert testGlPostingOnCancelInvoice test from XML to Groovy



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11533) Convert testGlPostingOnCancelCheckRun test from XML to Groovy

2020-07-02 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-11533.
--
Fix Version/s: (was: Trunk)
   Upcoming Branch
   Resolution: Implemented

This has been handled in OFBIZ-11531

Thanks, [~rohit.hukkeri]!

> Convert testGlPostingOnCancelCheckRun test from XML to Groovy
> -
>
> Key: OFBIZ-11533
> URL: https://issues.apache.org/jira/browse/OFBIZ-11533
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Rohit Hukkeri
>Assignee: Akash Jain
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Convert testGlPostingOnCancelCheckRun test from XML to Groovy



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11531) Convert AutoInvoiceTests.xml to Groovy

2020-07-02 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-11531.
--
Fix Version/s: (was: Trunk)
   Upcoming Branch
   Resolution: Implemented

> Convert AutoInvoiceTests.xml to Groovy
> --
>
> Key: OFBIZ-11531
> URL: https://issues.apache.org/jira/browse/OFBIZ-11531
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Rohit Hukkeri
>Assignee: Akash Jain
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11531.patch
>
>
> Covert AutoInvoiceTests XML file to Groovy



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11531) Convert AutoInvoiceTests.xml to Groovy

2020-07-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149980#comment-17149980
 ] 

ASF subversion and git services commented on OFBIZ-11531:
-

Commit f764266d171a68968f73d2c8349c174b352b2af1 in ofbiz-framework's branch 
refs/heads/trunk from Akash Jain
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=f764266 ]

Improved: Convert AutoInvoiceTests.xml to Groovy (OFBIZ-11531)

Thanks, Rohit Hukkeri for the report.


> Convert AutoInvoiceTests.xml to Groovy
> --
>
> Key: OFBIZ-11531
> URL: https://issues.apache.org/jira/browse/OFBIZ-11531
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Rohit Hukkeri
>Assignee: Akash Jain
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11531.patch
>
>
> Covert AutoInvoiceTests XML file to Groovy



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11858) Console warning related to OrderHeader caching

2020-07-02 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-11858.
-
Fix Version/s: 17.12.04
   18.12.01
   Resolution: Fixed

> Console warning related to OrderHeader caching
> --
>
> Key: OFBIZ-11858
> URL: https://issues.apache.org/jira/browse/OFBIZ-11858
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: 18.12.01, 17.12.04
>
> Attachments: OFBIZ-11858.patch
>
>
> 2020-06-30 14:52:50,499 |OFBiz-JobQueue-0 |EntityListCache |W| Tried to put a 
> value of the OrderHeader entity in the cache but this entity has never-cache 
> set to true, not caching.
> As never-cache="true" is set on Order Header, it should never be cached.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11858) Console warning related to OrderHeader caching

2020-07-02 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-11858:
--
Affects Version/s: Release Branch 17.12
   Release Branch 18.12

> Console warning related to OrderHeader caching
> --
>
> Key: OFBIZ-11858
> URL: https://issues.apache.org/jira/browse/OFBIZ-11858
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: 18.12.01, 17.12.04
>
> Attachments: OFBIZ-11858.patch
>
>
> 2020-06-30 14:52:50,499 |OFBiz-JobQueue-0 |EntityListCache |W| Tried to put a 
> value of the OrderHeader entity in the cache but this entity has never-cache 
> set to true, not caching.
> As never-cache="true" is set on Order Header, it should never be cached.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)