[jira] [Updated] (OFBIZ-11877) Convert testCreateAndUpdateContactList test from XML to Groovy

2020-07-30 Thread Pawan Verma (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11877: Attachment: OFBIZ-11877.patch > Convert testCreateAndUpdateContactList test from XML to Groovy >

[jira] [Assigned] (OFBIZ-11877) Convert testCreateAndUpdateContactList test from XML to Groovy

2020-07-30 Thread Pawan Verma (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma reassigned OFBIZ-11877: --- Assignee: Pawan Verma > Convert testCreateAndUpdateContactList test from XML to Groovy >

[jira] [Assigned] (OFBIZ-11184) No option for passing rounding mode to the ofbizCurrency Macro

2020-07-30 Thread Priya Sharma (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priya Sharma reassigned OFBIZ-11184: Assignee: Priya Sharma > No option for passing rounding mode to the ofbizCurrency Macro

[jira] [Commented] (OFBIZ-11877) Convert testCreateAndUpdateContactList test from XML to Groovy

2020-07-30 Thread Pawan Verma (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167741#comment-17167741 ] Pawan Verma commented on OFBIZ-11877: - This can be tested using: ./gradlew "ofbiz --test

[jira] [Commented] (OFBIZ-11877) Convert testCreateAndUpdateContactList test from XML to Groovy

2020-07-30 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167832#comment-17167832 ] Jacques Le Roux commented on OFBIZ-11877: - Works for me, +1 fo commit > Convert

[jira] [Commented] (OFBIZ-9254) Inconsistent String Comparisons

2020-07-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167835#comment-17167835 ] ASF subversion and git services commented on OFBIZ-9254: Commit

[jira] [Commented] (OFBIZ-9254) Inconsistent String Comparisons

2020-07-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167836#comment-17167836 ] ASF subversion and git services commented on OFBIZ-9254: Commit

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #221: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-30 Thread GitBox
sonarcloud[bot] commented on pull request #221: URL: https://github.com/apache/ofbiz-framework/pull/221#issuecomment-666319404 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=221=false=BUG)

[jira] [Commented] (OFBIZ-9254) Inconsistent String Comparisons

2020-07-30 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167853#comment-17167853 ] Jacques Le Roux commented on OFBIZ-9254: bq. Jacques Le Roux Lets create a new ticket for the

[jira] [Closed] (OFBIZ-9254) Inconsistent String Comparisons

2020-07-30 Thread Pawan Verma (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-9254. -- Resolution: Fixed Thanks, Devanshu for your contribution. [~jleroux] Lets create a new ticket for the

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-30 Thread GitBox
JacquesLeRoux commented on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-666229891 HI Daniel, That would be perfect, working and updating from trunk HEAD should work, TIA This

[GitHub] [ofbiz-framework] JacquesLeRoux closed pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-30 Thread GitBox
JacquesLeRoux closed pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Assigned] (OFBIZ-9254) Inconsistent String Comparisons

2020-07-30 Thread Pawan Verma (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma reassigned OFBIZ-9254: -- Assignee: Pawan Verma > Inconsistent String Comparisons > --- > >

[jira] [Commented] (OFBIZ-11184) No option for passing rounding mode to the ofbizCurrency Macro

2020-07-30 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167827#comment-17167827 ] Jacques Le Roux commented on OFBIZ-11184: - Hi [~muruges] , please close if it's OK with you,

[jira] [Reopened] (OFBIZ-9254) Inconsistent String Comparisons

2020-07-30 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-9254: Assignee: (was: Jacques Le Roux) Thanks Guys,   Missed that, patches looks good to

[jira] [Commented] (OFBIZ-9254) Inconsistent String Comparisons

2020-07-30 Thread Pawan Verma (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167829#comment-17167829 ] Pawan Verma commented on OFBIZ-9254: Sure, [~jleroux] On it. > Inconsistent String Comparisons >

[GitHub] [ofbiz-framework] danwatford opened a new pull request #221: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-30 Thread GitBox
danwatford opened a new pull request #221: URL: https://github.com/apache/ofbiz-framework/pull/221 Refactoring of WidgetWorker so that it generates URI and JSoup Element objects to represent created URLs, hidden forms and anchor tags. This replaces the previous approach where

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #220: Make latitude and longitude numeric fields for correct comparisons

2020-07-30 Thread GitBox
JacquesLeRoux commented on pull request #220: URL: https://github.com/apache/ofbiz-framework/pull/220#issuecomment-666306192 Hi fehnomenal, Did you check the implications on the other locations in code where latitude and longitude are used? Thanks

[GitHub] [ofbiz-framework] danwatford commented on pull request #221: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-30 Thread GitBox
danwatford commented on pull request #221: URL: https://github.com/apache/ofbiz-framework/pull/221#issuecomment-666318149 @JacquesLeRoux New PR created after applying the code changes to trunk HEAD. Patching should be cleaner this time.

[jira] [Commented] (OFBIZ-11907) WidgetWorker should not write generated html to Appendable

2020-07-30 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167812#comment-17167812 ] Jacques Le Roux commented on OFBIZ-11907: - Thanks Daniel, I agree with your premise >

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #221: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-30 Thread GitBox
JacquesLeRoux commented on pull request #221: URL: https://github.com/apache/ofbiz-framework/pull/221#issuecomment-666498799 Thanks Daniel, The patch applies, I'll review ASAP... This is an automated message from the

[jira] [Commented] (OFBIZ-11910) product summary cards don't have uniform height

2020-07-30 Thread Alex Bodnaru (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168066#comment-17168066 ] Alex Bodnaru commented on OFBIZ-11910: -- great jacques, i'll use ecomseo too > product summary

[jira] [Commented] (OFBIZ-11328) Add JAX-RS capabilities (Jersey)

2020-07-30 Thread Girish Vasmatkar (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167885#comment-17167885 ] Girish Vasmatkar commented on OFBIZ-11328: -- Hi All : Here's the PR for new Jersey component : 

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #35: Implemented: (OFBIZ-11328) Added a new component to provide REST capabilities to OFBiz.

2020-07-30 Thread GitBox
sonarcloud[bot] commented on pull request #35: URL: https://github.com/apache/ofbiz-plugins/pull/35#issuecomment-666340394 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=35=false=BUG)

[jira] [Comment Edited] (OFBIZ-11328) Add JAX-RS capabilities (Jersey)

2020-07-30 Thread Girish Vasmatkar (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167885#comment-17167885 ] Girish Vasmatkar edited comment on OFBIZ-11328 at 7/30/20, 12:42 PM: -

[jira] [Created] (OFBIZ-11929) Fix Literals comparisons with variable to avoid NPE

2020-07-30 Thread Devanshu Vyas (Jira)
Devanshu Vyas created OFBIZ-11929: - Summary: Fix Literals comparisons with variable to avoid NPE Key: OFBIZ-11929 URL: https://issues.apache.org/jira/browse/OFBIZ-11929 Project: OFBiz Issue

[GitHub] [ofbiz-plugins] girishvasmatkar opened a new pull request #35: Implemented: (OFBIZ-11328) Added a new component to provide REST capabilities to OFBiz.

2020-07-30 Thread GitBox
girishvasmatkar opened a new pull request #35: URL: https://github.com/apache/ofbiz-plugins/pull/35 Implemented: (OFBIZ-11328) Added a new component to provide REST capabilities to OFBiz. Explanation : This initial implementation allows existing or new OFBiz services (export=true

[jira] [Updated] (OFBIZ-11929) Fix Literals comparisons with variable to avoid NPE

2020-07-30 Thread Pawan Verma (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11929: Issue Type: Improvement (was: Bug) > Fix Literals comparisons with variable to avoid NPE >

[jira] [Updated] (OFBIZ-11929) Fix Literals comparisons with variable to avoid NPE

2020-07-30 Thread Pawan Verma (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11929: Description: With respect to our previous effort to fix the inconsistent string

[jira] [Commented] (OFBIZ-11910) product summary cards don't have uniform height

2020-07-30 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168128#comment-17168128 ] Jacques Le Roux commented on OFBIZ-11910: - Hi Alex, Do you still intend to provide a patch? >