[jira] [Commented] (OFBIZ-9516) User should be notified with success message on Creating New Routing

2021-03-20 Thread Priya Sharma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17305323#comment-17305323
 ] 

Priya Sharma commented on OFBIZ-9516:
-

Hi Sourabh & All,
I tested the patch locally and it works fine.

Though I would like to suggest one improvement, to consider using the 
workeffort type description instead of the id, that would make more sense to 
the end-user.

The message would look like 
"Production Run Task : 10481 created successfully" instead of
 "PROD_ORDER_TASK: 10481 created successfully"
WDYT?

Else we can proceed with the current patch.
Thanks!

> User should be notified with success message on Creating New Routing
> 
>
> Key: OFBIZ-9516
> URL: https://issues.apache.org/jira/browse/OFBIZ-9516
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Sourabh Punyani
>Priority: Trivial
> Attachments: OFBIZ-9516.patch, OFBIZ-9516.patch
>
>
> Steps to regenerate:
> 1. Go to Manufacturing component 
> (https://localhost:8443/manufacturing/control/main)
> 2. Click on Routing sub menu 
> (https://localhost:8443/manufacturing/control/FindRouting)
> 3. Click on New Routing 
> button.(https://localhost:8443/manufacturing/control/EditRouting)
> 4. Fill required fields and Click Submit button.
> 7. On success, the user should be notified with success message.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-12064) Load language js for date.js only when required

2021-03-20 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304865#comment-17304865
 ] 

Jacques Le Roux edited comment on OFBIZ-12064 at 3/20/21, 8:51 AM:
---

Thanks James,

FYI, I think I'll start on OFBIZ-9976 because of OFBIZ-11684 and maybe 
OFBIZ-12201



was (Author: jacques.le.roux):
Thanks James,

I think I'll start on OFBIZ-9976 because of OFBIZ-11684 and maybe OFBIZ-12201


> Load language js for date.js only when required 
> 
>
> Key: OFBIZ-12064
> URL: https://issues.apache.org/jira/browse/OFBIZ-12064
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12064.patch
>
>
> Only load language js for Date.js when there is a date time picker in the 
> page. The library is located at 
> themes/common-themes/webapp/common/js/jquery/plugins/datejs.
> Discussion started at 
> https://lists.apache.org/thread.html/re9288f4d70f216677f08d859bba8d6fc195d0d2d754f0e93838d87f9%40%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-9516) User should be notified with success message on Creating New Routing

2021-03-20 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17305368#comment-17305368
 ] 

Jacques Le Roux commented on OFBIZ-9516:


Hi Priya,

Did not test nor review, but that sounds better to me, +1 for commit.

> User should be notified with success message on Creating New Routing
> 
>
> Key: OFBIZ-9516
> URL: https://issues.apache.org/jira/browse/OFBIZ-9516
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Sourabh Punyani
>Priority: Trivial
> Attachments: OFBIZ-9516.patch, OFBIZ-9516.patch
>
>
> Steps to regenerate:
> 1. Go to Manufacturing component 
> (https://localhost:8443/manufacturing/control/main)
> 2. Click on Routing sub menu 
> (https://localhost:8443/manufacturing/control/FindRouting)
> 3. Click on New Routing 
> button.(https://localhost:8443/manufacturing/control/EditRouting)
> 4. Fill required fields and Click Submit button.
> 7. On success, the user should be notified with success message.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)