[GitHub] [ofbiz-framework] danwatford commented on pull request #517: Codenarc integration

2023-04-06 Thread via GitHub
danwatford commented on PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#issuecomment-1498969006 Hi @gilPts , I just tried a `./gradlew build` with your branch and received a build failure: ``` > Task :codenarcGroovyScripts FAILED FAILURE: Build failed

[GitHub] [ofbiz-framework] gilPts commented on pull request #517: Codenarc integration

2023-04-06 Thread via GitHub
gilPts commented on PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#issuecomment-1499000941 I did not found yet a way to exclude plugins, if someone has a guess, it could be nice :) I'll check to have threshold configuration for plugins. -- This is an automated

[GitHub] [ofbiz-framework] gilPts commented on pull request #517: Codenarc integration

2023-04-06 Thread via GitHub
gilPts commented on PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#issuecomment-1498984746 Hello, Strange, i will check on my local to see what is happening... FYI i did not have plugins installed in that first step. That might explain why the build is success for

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #517: Codenarc integration

2023-04-06 Thread via GitHub
JacquesLeRoux commented on PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#issuecomment-1499010022 If we suppose it's (only) about integration (GH actions and BB) we could not load the plugins when checking? -- This is an automated message from the Apache Git Service. To

[GitHub] [ofbiz-framework] danwatford commented on pull request #517: Codenarc integration

2023-04-06 Thread via GitHub
danwatford commented on PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#issuecomment-1498998327 > > > > About BalanceSheet.groovy and others framework groovy file, I can rebase this branch onto trunk and process the files that are detected by codenarc, then push in

[GitHub] [ofbiz-framework] danwatford commented on pull request #517: Codenarc integration

2023-04-06 Thread via GitHub
danwatford commented on PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#issuecomment-1498997097 > Hello, Strange, i will check on my local to see what is happening... FYI i did not have plugins installed in that first step. That might explain why the build is success for

[GitHub] [ofbiz-framework] danwatford commented on pull request #517: Codenarc integration

2023-04-06 Thread via GitHub
danwatford commented on PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#issuecomment-1499032564 > If we suppose it's (only) about integration (GH actions and BB) we could not load the plugins when checking? I'm not sure. Even if we build ofbiz-framework without the

[GitHub] [ofbiz-framework] gilPts commented on pull request #517: Codenarc integration

2023-04-06 Thread via GitHub
gilPts commented on PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#issuecomment-1498992879 > About BalanceSheet.groovy and others framework groovy file, I can rebase this branch onto trunk and process the files that are detected by codenarc, then push in another

[jira] [Closed] (OFBIZ-12786) Use container image for demo-trunk site

2023-04-06 Thread Daniel Watford (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Watford closed OFBIZ-12786. -- Resolution: Implemented > Use container image for demo-trunk site >

[jira] [Commented] (OFBIZ-12786) Use container image for demo-trunk site

2023-04-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17709449#comment-17709449 ] ASF subversion and git services commented on OFBIZ-12786: - Commit

[jira] [Closed] (OFBIZ-12757) Experiment with deploying OFBiz containers to the demo sites server

2023-04-06 Thread Daniel Watford (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Watford closed OFBIZ-12757. -- Resolution: Done Experiments completed and resulted in the automatic build and publication of

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #517: Codenarc integration

2023-04-06 Thread via GitHub
JacquesLeRoux commented on PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#issuecomment-1499133509 I was actually wondering if Codenarc was providing threshold, according to* it is. * https://stackoverflow.com/questions/27949345/codenarc-priority-meanings -- This is

[GitHub] [ofbiz-framework] danwatford commented on pull request #517: Codenarc integration

2023-04-06 Thread via GitHub
danwatford commented on PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#issuecomment-1499142511 > I was actually wondering if Codenarc was providing threshold, according to* it is. > > * https://stackoverflow.com/questions/27949345/codenarc-priority-meanings