[jira] [Commented] (OFBIZ-12982) updateMyTimesheet throws an error

[ https://issues.apache.org/jira/browse/OFBIZ-12982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832127#comment-17832127 ] Jacques Le Roux commented on OFBIZ-12982: - This is due to OFBIZ-12968. There is maybe more with

[jira] [Commented] (OFBIZ-12982) updateMyTimesheet throws an error

[ https://issues.apache.org/jira/browse/OFBIZ-12982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832134#comment-17832134 ] Jacques Le Roux commented on OFBIZ-12982: - Those are concerned ofbiz plugins projectmgr

[jira] [Commented] (OFBIZ-12982) updateMyTimesheet throws an error

[ https://issues.apache.org/jira/browse/OFBIZ-12982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832140#comment-17832140 ] Jacques Le Roux commented on OFBIZ-12982: - OFBIZ-12968 reopened > updateMyTimesheet throws an

[jira] [Commented] (OFBIZ-12982) updateMyTimesheet throws an error

[ https://issues.apache.org/jira/browse/OFBIZ-12982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832135#comment-17832135 ] Pierre Smits commented on OFBIZ-12982: -- Thanks Jacques, I was already aware of that and others in

[jira] [Commented] (OFBIZ-12982) updateMyTimesheet throws an error

[ https://issues.apache.org/jira/browse/OFBIZ-12982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832142#comment-17832142 ] Jacques Le Roux commented on OFBIZ-12982: - bq. others in project do you have a list to help

[jira] [Reopened] (OFBIZ-12968) Convert WorkEffortServices.xml mini-lang to groovyDSL (partial)

[ https://issues.apache.org/jira/browse/OFBIZ-12968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-12968: - Hi Nicolas, I reopen because of OFBIZ-12982, TIA > Convert WorkEffortServices.xml

[jira] [Created] (OFBIZ-12982) updateMyTimesheet throws an error

Pierre Smits created OFBIZ-12982: Summary: updateMyTimesheet throws an error Key: OFBIZ-12982 URL: https://issues.apache.org/jira/browse/OFBIZ-12982 Project: OFBiz Issue Type: Bug

[jira] [Commented] (OFBIZ-12982) updateMyTimesheet throws an error

[ https://issues.apache.org/jira/browse/OFBIZ-12982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832182#comment-17832182 ] Jacques Le Roux commented on OFBIZ-12982: - There is no pb w/ OFBIZ-12962 > updateMyTimesheet

[jira] [Created] (OFBIZ-12983) convert createProject service

Pierre Smits created OFBIZ-12983: Summary: convert createProject service Key: OFBIZ-12983 URL: https://issues.apache.org/jira/browse/OFBIZ-12983 Project: OFBiz Issue Type: Sub-task

Re: [PR] Improved: convert createProject service (OFBIZ-12983) [ofbiz-plugins]

sonarcloud[bot] commented on PR #104: URL: https://github.com/apache/ofbiz-plugins/pull/104#issuecomment-2027186894 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[jira] [Commented] (OFBIZ-12982) updateMyTimesheet throws an error

[ https://issues.apache.org/jira/browse/OFBIZ-12982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832181#comment-17832181 ] Jacques Le Roux commented on OFBIZ-12982: - I checked, for OFBIZ-12968 assignPartyToWorkEffort is

[jira] [Created] (OFBIZ-12974) WEBPOS- Move from hard-coded menu location to parameterized

Pierre Smits created OFBIZ-12974: Summary: WEBPOS- Move from hard-coded menu location to parameterized Key: OFBIZ-12974 URL: https://issues.apache.org/jira/browse/OFBIZ-12974 Project: OFBiz

Re: [PR] Improved: WEBPOS- Move from hard-coded menu location to parameterized (OFBIZ-12974) [ofbiz-plugins]

sonarcloud[bot] commented on PR #103: URL: https://github.com/apache/ofbiz-plugins/pull/103#issuecomment-2026781458 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[jira] [Created] (OFBIZ-12975) PROJECTMGR- Move from hard-coded menu location to parameterized

Pierre Smits created OFBIZ-12975: Summary: PROJECTMGR- Move from hard-coded menu location to parameterized Key: OFBIZ-12975 URL: https://issues.apache.org/jira/browse/OFBIZ-12975 Project: OFBiz

[jira] [Created] (OFBIZ-12976) FACILITY- Move from hard-coded menu location to parameterized

Pierre Smits created OFBIZ-12976: Summary: FACILITY- Move from hard-coded menu location to parameterized Key: OFBIZ-12976 URL: https://issues.apache.org/jira/browse/OFBIZ-12976 Project: OFBiz

[jira] [Created] (OFBIZ-12980) MFG- Move from hard-coded menu location to parameterized

Pierre Smits created OFBIZ-12980: Summary: MFG- Move from hard-coded menu location to parameterized Key: OFBIZ-12980 URL: https://issues.apache.org/jira/browse/OFBIZ-12980 Project: OFBiz

[PR] Improved: WEBPOS- Move from hard-coded menu location to parameterized (OFBIZ-12974) [ofbiz-plugins]

PierreSmits opened a new pull request, #103: URL: https://github.com/apache/ofbiz-plugins/pull/103 Move the menu location in the various webs screens from hard-coded to parameterized. modified: CommonScreens.xml -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (OFBIZ-12974) WEBPOS- Move from hard-coded menu location to parameterized

[ https://issues.apache.org/jira/browse/OFBIZ-12974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832087#comment-17832087 ] Pierre Smits commented on OFBIZ-12974: -- Maybe have it in a separate ticket? > WEBPOS- Move from

[jira] [Created] (OFBIZ-12977) SCRUM- Move from hard-coded menu location to parameterized

Pierre Smits created OFBIZ-12977: Summary: SCRUM- Move from hard-coded menu location to parameterized Key: OFBIZ-12977 URL: https://issues.apache.org/jira/browse/OFBIZ-12977 Project: OFBiz

[jira] [Created] (OFBIZ-12979) getUiLabels missing in WebPos

Jacques Le Roux created OFBIZ-12979: --- Summary: getUiLabels missing in WebPos Key: OFBIZ-12979 URL: https://issues.apache.org/jira/browse/OFBIZ-12979 Project: OFBiz Issue Type: Bug

[jira] [Commented] (OFBIZ-12974) WEBPOS- Move from hard-coded menu location to parameterized

[ https://issues.apache.org/jira/browse/OFBIZ-12974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832082#comment-17832082 ] ASF subversion and git services commented on OFBIZ-12974: - Commit

Re: [PR] Improved: WEBPOS- Move from hard-coded menu location to parameterized (OFBIZ-12974) [ofbiz-plugins]

JacquesLeRoux merged PR #103: URL: https://github.com/apache/ofbiz-plugins/pull/103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (OFBIZ-12974) WEBPOS- Move from hard-coded menu location to parameterized

[ https://issues.apache.org/jira/browse/OFBIZ-12974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-12974. --- Fix Version/s: Upcoming Branch Assignee: Jacques Le Roux Resolution:

[jira] [Commented] (OFBIZ-12974) WEBPOS- Move from hard-coded menu location to parameterized

[ https://issues.apache.org/jira/browse/OFBIZ-12974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832083#comment-17832083 ] Jacques Le Roux commented on OFBIZ-12974: - I think it's unrelated, I got this: 2024-03-29

[jira] [Created] (OFBIZ-12978) CONTENT- Move from hard-coded menu location to parameterized

Pierre Smits created OFBIZ-12978: Summary: CONTENT- Move from hard-coded menu location to parameterized Key: OFBIZ-12978 URL: https://issues.apache.org/jira/browse/OFBIZ-12978 Project: OFBiz

[jira] [Updated] (OFBIZ-12979) getUiLabels missing in WebPos

[ https://issues.apache.org/jira/browse/OFBIZ-12979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-12979: Attachment: OFBIZ-12979.patch > getUiLabels missing in WebPos >

[jira] [Commented] (OFBIZ-12979) getUiLabels missing in WebPos

[ https://issues.apache.org/jira/browse/OFBIZ-12979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832095#comment-17832095 ] Jacques Le Roux commented on OFBIZ-12979: - I tried to add this patch (does not apply just for

[jira] [Created] (OFBIZ-12981) have profileMenuLocation

Pierre Smits created OFBIZ-12981: Summary: have profileMenuLocation Key: OFBIZ-12981 URL: https://issues.apache.org/jira/browse/OFBIZ-12981 Project: OFBiz Issue Type: Sub-task

Re: [PR] Improved: convert createProject service (OFBIZ-12983) [ofbiz-plugins]

JacquesLeRoux commented on PR #104: URL: https://github.com/apache/ofbiz-plugins/pull/104#issuecomment-2027354778 BTW Pierre you did not take into account Michael's remark. Note that we should not use UtilValidate.isNotEmpty() but rather

Re: [PR] Improved: convert createProject service (OFBIZ-12983) [ofbiz-plugins]

sonarcloud[bot] commented on PR #104: URL: https://github.com/apache/ofbiz-plugins/pull/104#issuecomment-2027357860 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[jira] [Commented] (OFBIZ-12982) updateMyTimesheet throws an error

[ https://issues.apache.org/jira/browse/OFBIZ-12982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832214#comment-17832214 ] Nicolas Malin commented on OFBIZ-12982: --- Thanks for the alert, I'll take care on >

Re: [PR] Improved: convert createProject service (OFBIZ-12983) [ofbiz-plugins]

mbrohl commented on PR #104: URL: https://github.com/apache/ofbiz-plugins/pull/104#issuecomment-2027247142 Please check parameter validation. Parameters should not only be checked for existence but also if the contain empty strings like it was done with if-not-empty checks before. --

Re: [PR] Improved: convert createProject service (OFBIZ-12983) [ofbiz-plugins]

sonarcloud[bot] commented on PR #104: URL: https://github.com/apache/ofbiz-plugins/pull/104#issuecomment-2027260756 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Improved: convert createProject service (OFBIZ-12983) [ofbiz-plugins]

PierreSmits commented on PR #104: URL: https://github.com/apache/ofbiz-plugins/pull/104#issuecomment-2027262198 > Please check parameter validation. Parameters should not only be checked for existence but also if the contain empty strings like it was done with if-not-empty checks before.

Re: [PR] Improved: convert createProject service (OFBIZ-12983) [ofbiz-plugins]

JacquesLeRoux commented on PR #104: URL: https://github.com/apache/ofbiz-plugins/pull/104#issuecomment-2027275533 The last changes look good, I guess inpired by previous migration work. I'll do a complete review later -- This is an automated message from the Apache Git Service. To