[jira] [Commented] (OFBIZ-7725) Document the rounting number fields in entities

2016-11-23 Thread Paul Foxworthy (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15691829#comment-15691829
 ] 

Paul Foxworthy commented on OFBIZ-7725:
---

Thanks Jacques,

What you've done in the descriptions is fine by me. It was "explanations" I 
didn't like. Knowledge of how to use the routingNumber is as important (maybe 
more so) for business analysts and owners as well as developers.

There is an internationalisation issue with descriptions too. It should be 
possible to see descriptions in the Web Tools in languages other than English.

Cheers

Paul

> Document the rounting number fields in entities
> ---
>
> Key: OFBIZ-7725
> URL: https://issues.apache.org/jira/browse/OFBIZ-7725
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Upcoming Branch
>Reporter: Swapnil Shah
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> Let's extend EftAccount by adding 'BranchCode' that could indicate the branch 
> code of the Bank through which Eft Account is linked, It could be allowed to 
> optionally set for any existing and new EftAccount in Ofbiz system.
> Let's ask for 'Branch Code' with other details while Eft Account is being 
> added/edited from UI (e..g Party >> Profile etc.).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7263) Price rule created with product specific quantity condition not applied to the order when adding the product to cart with less quantity than mentioned in condition

2016-11-23 Thread Paul Foxworthy (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15691777#comment-15691777
 ] 

Paul Foxworthy commented on OFBIZ-7263:
---

Hi Aditi,

Good work, I think you've found a bug.

Compare the code in ShoppingCartServices with the updateApprovedOrderItems 
method in OrderServices:

https://fisheye6.atlassian.com/browse/ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/order/OrderServices.java?r=1768192#to3712

in particular, lines 3712 and 3740.

If I understand the code correctly, isModified should say there has been human 
intervention to set a one-off price for this order that is different to the 
standard rules. Adjusting a quantity should *not* change the value of 
isModified.

Can you create a patch for your change?

Thanks

Paul



> Price rule created with product specific quantity condition not applied to 
> the order when adding the product to cart with less quantity than mentioned 
> in condition
> ---
>
> Key: OFBIZ-7263
> URL: https://issues.apache.org/jira/browse/OFBIZ-7263
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Aditi Patidar
>Assignee: Aditi Patidar
>
> Steps to regenerate the issue:
> 1. Create a price rule.
> 2. Add a condition, select input 'Quantity', operator 'Is' and add the value 
> '2' or any quantity more than 1.
> 3. Add an action, select action type 'Flat Amount Override'  and add it's 
> value.  
> 4. Create a sale order:
> i. Add product with quantity one to the order.
> ii. Update the quantity to 2 or to the value entered in condition for 
> quantity in price rule.
>iii. Recalculate the order.
> Expected result: Unit price should override to the amount added in action.
> Actual result: It's not getting overridden to the amount added in action.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-5761) Allow to edit ship groups contents after and order has been created

2016-11-23 Thread Paul Foxworthy (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15691484#comment-15691484
 ] 

Paul Foxworthy commented on OFBIZ-5761:
---

Wow. Sharad, a lightbulb moment. You are right.

As you know, it's rare to delete things in OFBiz. Rather, we expire them. For 
many entities, that means setting a thruDate.

It seems to me OISGA tracks the current live state of the association, e.g 
updateOrderItemShipGroupAssoc modifies OISGA records.

But OrderItemShipGroupAssoc has an attribute cancelQuantity. This seems strange 
if the entity is supposed to just hold the current live state of the 
association.

I wonder if the answer is to have a second entity that tracks the history of 
changes to an OISGA. The same model is used for inventory, where InventoryItem 
has the current live state, and InventoryItemDetail has the history of changes. 
So when you add inventory, there's a new IID created, and an II modified.

So a new "OISGA Detail" or "OISGA History" entity might solve the problem you 
describe. 

So if an order item is cancelled, the OISGA would be modified to quanity zero 
and a Cancelled status, but it would not be deleted. The new history entity 
would have a series of records for changes to the association. Typically, there 
would be a history record when the association to the ship group was defined, 
and a second when the order item was cancelled.

What do you think?

> Allow to edit ship groups contents after and order has been created
> ---
>
> Key: OFBIZ-5761
> URL: https://issues.apache.org/jira/browse/OFBIZ-5761
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
> Fix For: 14.12.01
>
> Attachments: OFBIZ-5761 - OISG Management.patch, OFBIZ-5761 - OISG 
> Management.patch, OFBIZ-5761 - OISG Management.patch, OFBIZ-5761 - OISG 
> Management.patch, OFBIZ-5761 - OISG Management.patch, OFBIZ-5761 - OISG 
> Management.patch, OFBIZ-5761 - OISG Management.patch.change, OFBIZ-5761 - 
> OISG Management.patch.diff, OFBIZ-5761 - OISG Management.patch.diff, 
> OFBIZ-5761.patch.diff
>
>
> Currently you can only move order items between ship groups while you create 
> an order. I needed to do it after order creation. When I met Olivier (Heintz) 
> at the RMLL 2014 in July, I found the Neogia team has developed a such 
> feature and had it as an addon (named oisg-management) for R12.04. Then 
> exchanging with Nicolas (Malin), and Pierre (Gaudin) I decided to give it a 
> go. I will quickly explain the following history, for the Neogia team to know 
> the current situation and what has changed. 
> After updating the code to work with current trunk (instead of R12.04) I 
> found it was working well but some minor issues. I then exchanged with Leila 
> (Mekika) from the Neogia team and we could quickly fix the minor issues:
> * text harcoded, no labels. I began to fix them, thanks to Leila who 
> completed the major part and explained me some tricks about the 
> oisg-management addon.
> * A redundant button associated with the new addOrderItemShipGroup service.  
> I removed it because the current button calls createOrderItemShipGroup which 
> is enough. We could BTW consider using addOrderItemShipGroup instead. It's 
> more complete (see below for instance) but that"s rather a matter of taste.
> There was a mechanism to merge sales taxes to get them grouped by ship groups 
> in order adjustments. I removed it because this can be done dynamically (see 
> invoice.pdf) and it was removing the shipGroupSeqId from the order 
> adjustments.
> I sorted (DESC) the OrderItemShipGroup in addOrderItemShipGroup in order to 
> use the 1st ship group when copying shipmentMethodTypeId, carrierPartyId, 
> carrierRoleTypeId, contactMechId when shipmentMethodTypeId and carrierPartyId 
> are not passed to the service.
> I later fixed a bug I found in loadCartForUpdate service when removing the 
> adjustments. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose

2016-11-23 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15690657#comment-15690657
 ] 

Jacques Le Roux commented on OFBIZ-9123:


Thanks for the tip Jinghai.

> Add a PriCat component under specialpurpose
> ---
>
> Key: OFBIZ-9123
> URL: https://issues.apache.org/jira/browse/OFBIZ-9123
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Trivial
> Fix For: Trunk
>
>
> Add a PriCat component to view excel import with html report and download 
> excel output with errors commented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-9125) Errormessage is displayed twice in LoginEvents.java

2016-11-23 Thread Heiko Elberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Heiko Elberg updated OFBIZ-9125:

Attachment: OFBIZ-9125_Errormessage is displayed twice in 
LoginEvents.java.patch

> Errormessage is displayed twice in LoginEvents.java
> ---
>
> Key: OFBIZ-9125
> URL: https://issues.apache.org/jira/browse/OFBIZ-9125
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 13.07, Trunk
>Reporter: Heiko Elberg
> Attachments: OFBIZ-9125_Errormessage is displayed twice in 
> LoginEvents.java.patch
>
>
> Issue:
> The errormessage "The password does not match the pattern" is called twice in 
> LoginServices.java.
> Fix:
> Delete second assignment for variable "errMsg".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-9125) Errormessage is displayed twice in LoginEvents.java

2016-11-23 Thread Heiko Elberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Heiko Elberg updated OFBIZ-9125:

Summary: Errormessage is displayed twice in LoginEvents.java  (was: 
Errormessage is shown twice in LoginEvents.java)

> Errormessage is displayed twice in LoginEvents.java
> ---
>
> Key: OFBIZ-9125
> URL: https://issues.apache.org/jira/browse/OFBIZ-9125
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 13.07, Trunk
>Reporter: Heiko Elberg
>
> Issue:
> The errormessage "The password does not match the pattern" is called twice in 
> LoginServices.java.
> Fix:
> Delete second assignment for variable "errMsg".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-9125) Errormessage is shown twice in LoginEvents.java

2016-11-23 Thread Heiko Elberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Heiko Elberg updated OFBIZ-9125:

Attachment: (was: OFBIZ-9125_Errormessage is shown twice in 
LoginEvents.java.patch)

> Errormessage is shown twice in LoginEvents.java
> ---
>
> Key: OFBIZ-9125
> URL: https://issues.apache.org/jira/browse/OFBIZ-9125
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 13.07, Trunk
>Reporter: Heiko Elberg
>
> Issue:
> The errormessage "The password does not match the pattern" is called twice in 
> LoginServices.java.
> Fix:
> Delete second assignment for variable "errMsg".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-9125) Errormessage is shown twice in LoginEvents.java

2016-11-23 Thread Heiko Elberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Heiko Elberg updated OFBIZ-9125:

Description: 
Issue:
The errormessage "The password does not match the pattern" is called twice in 
LoginServices.java.

Fix:
Delete second assignment for variable "errMsg".

  was:The errormessage "The password does not match the pattern" is called 
twice in LoginServices.java.


> Errormessage is shown twice in LoginEvents.java
> ---
>
> Key: OFBIZ-9125
> URL: https://issues.apache.org/jira/browse/OFBIZ-9125
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 13.07, Trunk
>Reporter: Heiko Elberg
> Attachments: OFBIZ-9125_Errormessage is shown twice in 
> LoginEvents.java.patch
>
>
> Issue:
> The errormessage "The password does not match the pattern" is called twice in 
> LoginServices.java.
> Fix:
> Delete second assignment for variable "errMsg".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-9125) Errormessage is shown twice in LoginEvents.java

2016-11-23 Thread Heiko Elberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Heiko Elberg updated OFBIZ-9125:

Attachment: OFBIZ-9125_Errormessage is shown twice in LoginEvents.java.patch

> Errormessage is shown twice in LoginEvents.java
> ---
>
> Key: OFBIZ-9125
> URL: https://issues.apache.org/jira/browse/OFBIZ-9125
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 13.07, Trunk
>Reporter: Heiko Elberg
> Attachments: OFBIZ-9125_Errormessage is shown twice in 
> LoginEvents.java.patch
>
>
> The errormessage "The password does not match the pattern" is called twice in 
> LoginServices.java.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-9125) Errormessage is shown twice in LoginEvents.java

2016-11-23 Thread Heiko Elberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Heiko Elberg updated OFBIZ-9125:

Affects Version/s: Trunk

> Errormessage is shown twice in LoginEvents.java
> ---
>
> Key: OFBIZ-9125
> URL: https://issues.apache.org/jira/browse/OFBIZ-9125
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 13.07, Trunk
>Reporter: Heiko Elberg
>
> The errormessage "The password does not match the pattern" is called twice in 
> LoginServices.java.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-9125) Errormessage is shown twice in LoginEvents.java

2016-11-23 Thread Heiko Elberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Heiko Elberg updated OFBIZ-9125:

Summary: Errormessage is shown twice in LoginEvents.java  (was: 
Errormessage is shown twice)

> Errormessage is shown twice in LoginEvents.java
> ---
>
> Key: OFBIZ-9125
> URL: https://issues.apache.org/jira/browse/OFBIZ-9125
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 13.07
>Reporter: Heiko Elberg
>
> The errormessage "The password does not match the pattern" is called twice in 
> LoginServices.java.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-9125) Errormessage is shown twice

2016-11-23 Thread Heiko Elberg (JIRA)
Heiko Elberg created OFBIZ-9125:
---

 Summary: Errormessage is shown twice
 Key: OFBIZ-9125
 URL: https://issues.apache.org/jira/browse/OFBIZ-9125
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Release Branch 13.07
Reporter: Heiko Elberg


The errormessage "The password does not match the pattern" is called twice in 
LoginServices.java.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-9124) Upgrade Tomcat to 8.0.39

2016-11-23 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-9124:
---
Summary: Upgrade Tomcat to 8.0.39  (was: Upgrade Tomcat to 8.5.3 (or 
8.0.36))

> Upgrade Tomcat to 8.0.39
> 
>
> Key: OFBIZ-9124
> URL: https://issues.apache.org/jira/browse/OFBIZ-9124
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12, Release Branch 16.11
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>
> Because of CVE-2016-6816 and CVE-2016-8735 (both are important) it's 
> necessary to update Tomcat to 8.0.39 ASAP 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose

2016-11-23 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15690317#comment-15690317
 ] 

Shi Jinghai commented on OFBIZ-9123:


Hi Jacques,

I submitted a simple readme and replaced some (many) tabs with spaces.

BTW, Apache Archiva is a good tool to build a maven repo.

> Add a PriCat component under specialpurpose
> ---
>
> Key: OFBIZ-9123
> URL: https://issues.apache.org/jira/browse/OFBIZ-9123
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Trivial
> Fix For: Trunk
>
>
> Add a PriCat component to view excel import with html report and download 
> excel output with errors commented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-9124) Upgrade Tomcat to 8.5.3 (or 8.0.36)

2016-11-23 Thread Jacques Le Roux (JIRA)
Jacques Le Roux created OFBIZ-9124:
--

 Summary: Upgrade Tomcat to 8.5.3 (or 8.0.36)
 Key: OFBIZ-9124
 URL: https://issues.apache.org/jira/browse/OFBIZ-9124
 Project: OFBiz
  Issue Type: Task
  Components: framework
Affects Versions: Release Branch 15.12, Trunk, Release Branch 14.12, 
Release Branch 13.07, Release Branch 16.11
Reporter: Jacques Le Roux
Assignee: Jacques Le Roux


Because of CVE-2016-6816 and CVE-2016-8735 (both are important) it's necessary 
to update Tomcat to 8.0.39 ASAP 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-7348) Upgrade Tomcat to 8.5.3 (or 8.0.36)

2016-11-23 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-7348.
--
   Resolution: Fixed
 Assignee: Jacques Le Roux
Fix Version/s: Release Branch 16.11

Note that I only updated the trunk (hence the 16.11 branch). Older are still 
using respectively 8.0.33 for R15/14 and 7.0.68 for R13

> Upgrade Tomcat to 8.5.3 (or 8.0.36)
> ---
>
> Key: OFBIZ-7348
> URL: https://issues.apache.org/jira/browse/OFBIZ-7348
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch, Release Branch 16.11
>
>
> Quoting announcement on annou...@apache.org and other channels:
> {quote}
> This is the first stable release of the 8.5.x branch. Tomcat 8.x users
> should now use 8.5.x releases in preference to 8.0.x releases.
> Apache Tomcat 8.5.x is intended to replace 8.0.x and includes new
> features pulled forward from the 9.0.x branch. The notable changes since
> 8.5.2 include:
> * Ensure error will not be thrown during deployment when scanning jar
>   files with no or invalid MANIFEST.MF files.
> * Improvements to memory leak detection and prevention
> * The HTTP Server header is no longer set by default
> Please refer to the change log for the complete list of changes:
> http://tomcat.apache.org/tomcat-8.5-doc/changelog.html
> Downloads:
> http://tomcat.apache.org/download-80.cgi
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7348) Upgrade Tomcat to 8.5.3 (or 8.0.36)

2016-11-23 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15690287#comment-15690287
 ] 

Jacques Le Roux commented on OFBIZ-7348:


I close here nothing left to do. We agreed and modidifed the license and notice 
files. They no longer contains references to Tomcat libs.

> Upgrade Tomcat to 8.5.3 (or 8.0.36)
> ---
>
> Key: OFBIZ-7348
> URL: https://issues.apache.org/jira/browse/OFBIZ-7348
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> Quoting announcement on annou...@apache.org and other channels:
> {quote}
> This is the first stable release of the 8.5.x branch. Tomcat 8.x users
> should now use 8.5.x releases in preference to 8.0.x releases.
> Apache Tomcat 8.5.x is intended to replace 8.0.x and includes new
> features pulled forward from the 9.0.x branch. The notable changes since
> 8.5.2 include:
> * Ensure error will not be thrown during deployment when scanning jar
>   files with no or invalid MANIFEST.MF files.
> * Improvements to memory leak detection and prevention
> * The HTTP Server header is no longer set by default
> Please refer to the change log for the complete list of changes:
> http://tomcat.apache.org/tomcat-8.5-doc/changelog.html
> Downloads:
> http://tomcat.apache.org/download-80.cgi
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7779) Update wiki Eclipse pages regarding Gradle

2016-11-23 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15690172#comment-15690172
 ] 

Jacques Le Roux commented on OFBIZ-7779:


For those who would come here: I must say I stopped to use the Gradle "Eclipse 
Buildship" months ago. In my experience, it's not yet ready and you get more 
issues than help so far...

> Update wiki Eclipse pages regarding Gradle
> --
>
> Key: OFBIZ-7779
> URL: https://issues.apache.org/jira/browse/OFBIZ-7779
> Project: OFBiz
>  Issue Type: Task
>  Components: Confluence
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
> Fix For: Upcoming Branch
>
> Attachments: Image 007.png, OFBIZ-7779.patch, OFBIZ-7779.patch, 
> compile.error, neon.error
>
>
> I wanted to update the 2 wiki Eclipse pages regarding Gradle. But so far got 
> some issues in my environment (still Windows 7).
> I use both Eclipse Luna and Mars (Mars at 98%).  Luna does not support Gradle.
> First I must say my Mars instance works perfectly, but for few months I'm 
> unable to update. I did not try yet to create another Mars instance because I 
> guess it will anyway screws its update mechanism later :/
> Mars comes with the embedded ["Gradle Buildship" 
> plugin|https://gradle.org/eclipse/], I have the 1.0.5 version from 
> 2015-09-22. I found this tuto 
> http://www.vogella.com/tutorials/EclipseGradle/article.html (with a 6/7 
> clone/redundant section).
> Few remarks: I see no Gradle context menu entrie, maybe due to my unability 
> to update Mars, so I'm unable to "add Gradle support to existing Eclipse 
> project ". So I created a Gradle "trunk" side project following , but, though 
> all work well in command line, in Eclipse building with Gradle does not work. 
> I always get (see compile.error)
> Of course I tried (4th) to install Eclipse Neon, to no avail, so far the best 
> I got (at least I eventually got something) is in neon.error
> I'll continue later...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-5761) Allow to edit ship groups contents after and order has been created

2016-11-23 Thread K Sharad Bhushan (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689768#comment-15689768
 ] 

K Sharad Bhushan commented on OFBIZ-5761:
-

Paul, You are right that cancelled item won't be shipped and i agree too. The 
concern i raised was in the following context:  assume for the audit (CS 
Quality and Technical) reasons one needs to know how many items were actually 
part of the ship group before packing or generating shipment. Removing an 
association would not allow one to validate what was the actual order placed to 
what changed over time

Thanks
Sharad

> Allow to edit ship groups contents after and order has been created
> ---
>
> Key: OFBIZ-5761
> URL: https://issues.apache.org/jira/browse/OFBIZ-5761
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
> Fix For: 14.12.01
>
> Attachments: OFBIZ-5761 - OISG Management.patch, OFBIZ-5761 - OISG 
> Management.patch, OFBIZ-5761 - OISG Management.patch, OFBIZ-5761 - OISG 
> Management.patch, OFBIZ-5761 - OISG Management.patch, OFBIZ-5761 - OISG 
> Management.patch, OFBIZ-5761 - OISG Management.patch.change, OFBIZ-5761 - 
> OISG Management.patch.diff, OFBIZ-5761 - OISG Management.patch.diff, 
> OFBIZ-5761.patch.diff
>
>
> Currently you can only move order items between ship groups while you create 
> an order. I needed to do it after order creation. When I met Olivier (Heintz) 
> at the RMLL 2014 in July, I found the Neogia team has developed a such 
> feature and had it as an addon (named oisg-management) for R12.04. Then 
> exchanging with Nicolas (Malin), and Pierre (Gaudin) I decided to give it a 
> go. I will quickly explain the following history, for the Neogia team to know 
> the current situation and what has changed. 
> After updating the code to work with current trunk (instead of R12.04) I 
> found it was working well but some minor issues. I then exchanged with Leila 
> (Mekika) from the Neogia team and we could quickly fix the minor issues:
> * text harcoded, no labels. I began to fix them, thanks to Leila who 
> completed the major part and explained me some tricks about the 
> oisg-management addon.
> * A redundant button associated with the new addOrderItemShipGroup service.  
> I removed it because the current button calls createOrderItemShipGroup which 
> is enough. We could BTW consider using addOrderItemShipGroup instead. It's 
> more complete (see below for instance) but that"s rather a matter of taste.
> There was a mechanism to merge sales taxes to get them grouped by ship groups 
> in order adjustments. I removed it because this can be done dynamically (see 
> invoice.pdf) and it was removing the shipGroupSeqId from the order 
> adjustments.
> I sorted (DESC) the OrderItemShipGroup in addOrderItemShipGroup in order to 
> use the 1st ship group when copying shipmentMethodTypeId, carrierPartyId, 
> carrierRoleTypeId, contactMechId when shipmentMethodTypeId and carrierPartyId 
> are not passed to the service.
> I later fixed a bug I found in loadCartForUpdate service when removing the 
> adjustments. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose

2016-11-23 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689339#comment-15689339
 ] 

Jacques Le Roux commented on OFBIZ-9123:


Hi Jinghai,

My proposition is to create a Maven repository in our demo server (ie at 
https://ofbiz-vm2.apache.org). We will certainly need to ask for more RAM (we 
run the 3 demos in 4GB) but I expect the infra to agree. The idea is to have 
something centralised that we can check, control and recommend.

I thought about my question to Pierre, maybe something like that is not needed 
(at least for now) and a simple page in wiki linked from main site would be 
enough. There we would list the available plugins with simple (and possibly 
more elaborate) explanations about what they add and on how to proceed to 
install them from the (hopefully to come) OFBiz Maven repo.

> Add a PriCat component under specialpurpose
> ---
>
> Key: OFBIZ-9123
> URL: https://issues.apache.org/jira/browse/OFBIZ-9123
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Trivial
> Fix For: Trunk
>
>
> Add a PriCat component to view excel import with html report and download 
> excel output with errors commented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)