[jira] [Closed] (OFBIZ-7129) Recognise "BASE TABLE" table type in metadata
[ https://issues.apache.org/jira/browse/OFBIZ-7129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Foxworthy closed OFBIZ-7129. - > Recognise "BASE TABLE" table type in metadata > - > > Key: OFBIZ-7129 > URL: https://issues.apache.org/jira/browse/OFBIZ-7129 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Paul Foxworthy >Assignee: Paul Foxworthy > Attachments: OFBIZ-7129_BaseTableMetadata.patch, > OFBIZ-7129_BaseTableMetadata.patch > > > In framework/entity/src/org/ofbiz/entity/jdbc/DatabaseUtil.java, the > getTableNames method looks for table types of "TABLE", "VIEW", "ALIAS" and > "SYNONYM" > (https://fisheye6.atlassian.com/browse/ofbiz/trunk/framework/entity/src/org/ofbiz/entity/jdbc/DatabaseUtil.java?r=1644354#to989). > MariaDB produces a table type of "BASE TABLE", so OFBiz didn't detect the > tables were there, and attempted to create them. In fact, the tables do exist > so the create failed. > The JDBC docs suggest that plain "TABLE" is a "typical" value for table type > (https://docs.oracle.com/javase/8/docs/api/java/sql/DatabaseMetaData.html#getTables-java.lang.String-java.lang.String-java.lang.String-java.lang.String:A-) > But it seems "BASE TABLE" is more standards compliant - see for example > http://www.contrib.andrew.cmu.edu/~shadow/sql/sql1992.txt page 576. I assume > some JDBC drivers transform "BASE TABLE" to plain "TABLE", but the MariaDB > one does not. > I've attached a patch so OFBiz will recognise "BASE TABLE" if that's what it > receives in the metadata. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-4427) Possible runtime errors with UtilValidate.isEmpty(Object) should be rather caught during compilation
[ https://issues.apache.org/jira/browse/OFBIZ-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15707418#comment-15707418 ] Paul Foxworthy commented on OFBIZ-4427: --- Hi Jacques, I think there's no need to be scared :-). I agree with your analysis: conversionRate will be null, so the inner if statement can be removed. I suggest: change the else part of the inner if to throw an exception, then create a unit test to verify the exception never happens. > Possible runtime errors with UtilValidate.isEmpty(Object) should be rather > caught during compilation > > > Key: OFBIZ-4427 > URL: https://issues.apache.org/jira/browse/OFBIZ-4427 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Labels: UtilValidate.isEmpty > Attachments: OFBIZ-4427.patch, OFBIZ-4427_isEmpty.patch > > > Hence we need to remove the UtilValidate.isEmpty(Object) method and provide > methods that accept explicit types. > Scripting languages should use a facade class that provides methods for > working with generic Objects or providing default behaviors. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-9135) popup info about image in ordermgr shows html markup
[ https://issues.apache.org/jira/browse/OFBIZ-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wai updated OFBIZ-9135: --- Summary: popup info about image in ordermgr shows html markup (was: popup info about image in order shows html markup) > popup info about image in ordermgr shows html markup > > > Key: OFBIZ-9135 > URL: https://issues.apache.org/jira/browse/OFBIZ-9135 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Wai > > -use https://localhost:8443/ordermgr/control/orderentry > -fill all necessary required order info > -select productId=WG-9943 > -click 'Add to Order' > -Notice the images in the 'You might be interested in these as well:' section. > -hover mouse over the image. > -the popup shows html markup -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-9135) popup info about image in order shows html markup
Wai created OFBIZ-9135: -- Summary: popup info about image in order shows html markup Key: OFBIZ-9135 URL: https://issues.apache.org/jira/browse/OFBIZ-9135 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Trunk Reporter: Wai -use https://localhost:8443/ordermgr/control/orderentry -fill all necessary required order info -select productId=WG-9943 -click 'Add to Order' -Notice the images in the 'You might be interested in these as well:' section. -hover mouse over the image. -the popup shows html markup -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-9134) Add required skills to Routing Tasks
[ https://issues.apache.org/jira/browse/OFBIZ-9134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Foxworthy updated OFBIZ-9134: -- Description: OFBIZ-5852 enables you to add a Party to a Routing Task (the WorkEffortPartyAssignment entity), to specify a person who is preferred to perform the task. If the person is on leave or unavailable, the production manager would have to manually specify a different person. It would be better to specify skill or skills required for the Routing Task. Then on each production run, any Party with the right skills could be scheduled to perform the task. There are already entities WorkEffortSkillStandard, PartySkill and SkillType which could be used to enable this. was: OFBIZ-5852 enables you to add a Party to a Routing Task (the WorkEffortPartyAssignment entity), to specify a person who is preferred to perform the task. If the person is on leave of unavailable, the production manager would have to manually specify a different person. It would be better to specify skill or skills required for the Routing Task. Then on each production run, any Party with the right skills could be scheduled to perform the task. There are already entities WorkEffortSkillStandard, PartySkill and SkillType which could be used to enable this. > Add required skills to Routing Tasks > > > Key: OFBIZ-9134 > URL: https://issues.apache.org/jira/browse/OFBIZ-9134 > Project: OFBiz > Issue Type: New Feature > Components: manufacturing >Affects Versions: Trunk >Reporter: Paul Foxworthy >Priority: Minor > > OFBIZ-5852 enables you to add a Party to a Routing Task (the > WorkEffortPartyAssignment entity), to specify a person who is preferred to > perform the task. > If the person is on leave or unavailable, the production manager would have > to manually specify a different person. > It would be better to specify skill or skills required for the Routing Task. > Then on each production run, any Party with the right skills could be > scheduled to perform the task. > There are already entities WorkEffortSkillStandard, PartySkill and SkillType > which could be used to enable this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-9134) Add required skills to Routing Tasks
[ https://issues.apache.org/jira/browse/OFBIZ-9134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Foxworthy updated OFBIZ-9134: -- Issue Type: New Feature (was: Improvement) > Add required skills to Routing Tasks > > > Key: OFBIZ-9134 > URL: https://issues.apache.org/jira/browse/OFBIZ-9134 > Project: OFBiz > Issue Type: New Feature > Components: manufacturing >Affects Versions: Trunk >Reporter: Paul Foxworthy >Priority: Minor > > OFBIZ-5852 enables you to add a Party to a Routing Task (the > WorkEffortPartyAssignment entity), to specify a person who is preferred to > perform the task. > If the person is on leave of unavailable, the production manager would have > to manually specify a different person. > It would be better to specify skill or skills required for the Routing Task. > Then on each production run, any Party with the right skills could be > scheduled to perform the task. > There are already entities WorkEffortSkillStandard, PartySkill and SkillType > which could be used to enable this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9124) Upgrade Tomcat to 8.0.39
[ https://issues.apache.org/jira/browse/OFBIZ-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15706062#comment-15706062 ] Deepak Dixit commented on OFBIZ-9124: - Upgraded Tomcat embed websocket jar for Trunk at r#1771935 16.11 at r#1771936 > Upgrade Tomcat to 8.0.39 > > > Key: OFBIZ-9124 > URL: https://issues.apache.org/jira/browse/OFBIZ-9124 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > 16.11.01, Release Branch 15.12 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux > Fix For: Upcoming Release > > > Because of CVE-2016-6816 and CVE-2016-8735 (both are important) it's > necessary to update Tomcat to 8.0.39 ASAP -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9134) Add required skills to Routing Tasks
[ https://issues.apache.org/jira/browse/OFBIZ-9134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15705119#comment-15705119 ] Pierre Smits commented on OFBIZ-9134: - Shouldn't we consider this as a new feature? > Add required skills to Routing Tasks > > > Key: OFBIZ-9134 > URL: https://issues.apache.org/jira/browse/OFBIZ-9134 > Project: OFBiz > Issue Type: Improvement > Components: manufacturing >Affects Versions: Trunk >Reporter: Paul Foxworthy >Priority: Minor > > OFBIZ-5852 enables you to add a Party to a Routing Task (the > WorkEffortPartyAssignment entity), to specify a person who is preferred to > perform the task. > If the person is on leave of unavailable, the production manager would have > to manually specify a different person. > It would be better to specify skill or skills required for the Routing Task. > Then on each production run, any Party with the right skills could be > scheduled to perform the task. > There are already entities WorkEffortSkillStandard, PartySkill and SkillType > which could be used to enable this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-9134) Add required skills to Routing Tasks
[ https://issues.apache.org/jira/browse/OFBIZ-9134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit updated OFBIZ-9134: Description: OFBIZ-5852 enables you to add a Party to a Routing Task (the WorkEffortPartyAssignment entity), to specify a person who is preferred to perform the task. If the person is on leave of unavailable, the production manager would have to manually specify a different person. It would be better to specify skill or skills required for the Routing Task. Then on each production run, any Party with the right skills could be scheduled to perform the task. There are already entities WorkEffortSkillStandard, PartySkill and SkillType which could be used to enable this. was: OFBIZ-5852 enables you to add a Party to a Routing Task (the WorkEffortFixedAssetStd entity), to specify a person who is preferred to perform the task. If the person is on leave of unavailable, the production manager would have to manually specify a different person. It would be better to specify skill or skills required for the Routing Task. Then on each production run, any Party with the right skills could be scheduled to perform the task. There are already entities WorkEffortSkillStandard, PartySkill and SkillType which could be used to enable this. > Add required skills to Routing Tasks > > > Key: OFBIZ-9134 > URL: https://issues.apache.org/jira/browse/OFBIZ-9134 > Project: OFBiz > Issue Type: Improvement > Components: manufacturing >Affects Versions: Trunk >Reporter: Paul Foxworthy >Priority: Minor > > OFBIZ-5852 enables you to add a Party to a Routing Task (the > WorkEffortPartyAssignment entity), to specify a person who is preferred to > perform the task. > If the person is on leave of unavailable, the production manager would have > to manually specify a different person. > It would be better to specify skill or skills required for the Routing Task. > Then on each production run, any Party with the right skills could be > scheduled to perform the task. > There are already entities WorkEffortSkillStandard, PartySkill and SkillType > which could be used to enable this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1
[ https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15704801#comment-15704801 ] Michael Brohl commented on OFBIZ-8316: -- [~caopengan], thanks for your patch. I will check with my open work on this and give feedback. > Update Apache Solr/Lucene to release 6.2.1 > -- > > Key: OFBIZ-8316 > URL: https://issues.apache.org/jira/browse/OFBIZ-8316 > Project: OFBiz > Issue Type: Improvement > Components: specialpurpose/lucene, specialpurpose/solr >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Attachments: ofbiz-truck-lucene-6.2.1.patch, > ofbiz-truck-solr-6.2.1.patch > > > According to the announcements in > https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E > and > https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E > there is a new Solr/Lucene release available. > This issue takes care of the update. -- This message was sent by Atlassian JIRA (v6.3.4#6332)