[jira] [Commented] (OFBIZ-9138) Create a common theme

2016-12-08 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15734393#comment-15734393
 ] 

Deepak Dixit commented on OFBIZ-9138:
-

Hi Nicolas,

Can we use framework/common to put common theme?

> Create a common theme
> -
>
> Key: OFBIZ-9138
> URL: https://issues.apache.org/jira/browse/OFBIZ-9138
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>
> A first task to UI Improvement would be create a common that receive the 
> existent code.
> The benefice would be have a framework/common who list all screens that 
> available for theme surcharge, so without technology information (css/html or 
> something like that)
> Different task to do :
> * move all ftl template from framework/common to themes/common
> * move framework/images to themes/common (this directory contains unlogical 
> element for theme but will be manage at a second time)
> * move default macro ftl template from framework/widget to themes/common 
> After the realization on this task, all current themes call theme/common for 
> html rendering instead of framework/common, framework/images and 
> framework/widget. Just pave the way for the next



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-9138) Create a common theme

2016-12-08 Thread Nicolas Malin (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732136#comment-15732136
 ] 

Nicolas Malin commented on OFBIZ-9138:
--

I continue the work with :
* with move macro ftl on common-theme
* move uneeded properties from widget.properties commonWidget.properties 
present on common-theme to keep on first properties file only property related 
to widget model and not widget rendering
* review some code on FindAutocompleteOptions.groovy and MacroFormRenderer.java 
to move rendering property use to FtlMacro or decorator screen

POC available on https://github.com/nmalin/ApacheOFBiz/tree/common-theme


> Create a common theme
> -
>
> Key: OFBIZ-9138
> URL: https://issues.apache.org/jira/browse/OFBIZ-9138
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>
> A first task to UI Improvement would be create a common that receive the 
> existent code.
> The benefice would be have a framework/common who list all screens that 
> available for theme surcharge, so without technology information (css/html or 
> something like that)
> Different task to do :
> * move all ftl template from framework/common to themes/common
> * move framework/images to themes/common (this directory contains unlogical 
> element for theme but will be manage at a second time)
> * move default macro ftl template from framework/widget to themes/common 
> After the realization on this task, all current themes call theme/common for 
> html rendering instead of framework/common, framework/images and 
> framework/widget. Just pave the way for the next



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose

2016-12-08 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732036#comment-15732036
 ] 

Jacques Le Roux commented on OFBIZ-9123:


Agreed Michael, this has already been started in the "[DISCUSSION] Defining an 
OFBiz Project Strategy" thread http://markmail.org/message/nc2sm7k5s3hlay33 but 
we need a new separate [DISCUSSION] thread to clarify the community's decision 
about it. 

> Add a PriCat component under specialpurpose
> ---
>
> Key: OFBIZ-9123
> URL: https://issues.apache.org/jira/browse/OFBIZ-9123
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Trivial
> Fix For: Trunk
>
>
> Add a PriCat component to view excel import with html report and download 
> excel output with errors commented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose

2016-12-08 Thread Michael Brohl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732012#comment-15732012
 ] 

Michael Brohl commented on OFBIZ-9123:
--

This discussion has nothing to do with the issue, please move it to the dev ML.

> Add a PriCat component under specialpurpose
> ---
>
> Key: OFBIZ-9123
> URL: https://issues.apache.org/jira/browse/OFBIZ-9123
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Trivial
> Fix For: Trunk
>
>
> Add a PriCat component to view excel import with html report and download 
> excel output with errors commented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose

2016-12-08 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732002#comment-15732002
 ] 

Jacques Le Roux commented on OFBIZ-9123:


Pierre, I guess they are updated regularly (automatically) from the official 
OFBiz GitHub repo?

BTW, what is the purpose? Does this not risk to introduce more entropy and 
confusion in the project? 

> Add a PriCat component under specialpurpose
> ---
>
> Key: OFBIZ-9123
> URL: https://issues.apache.org/jira/browse/OFBIZ-9123
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Trivial
> Fix For: Trunk
>
>
> Add a PriCat component to view excel import with html report and download 
> excel output with errors commented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OFBIZ-9123) Add a PriCat component under specialpurpose

2016-12-08 Thread Pierre Smits (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731949#comment-15731949
 ] 

Pierre Smits edited comment on OFBIZ-9123 at 12/8/16 11:48 AM:
---

Hi [~shi.jinghai],

I have already made the following components (and others) available on github:
* Solr - https://github.com/OFBizCI/solr
* LDAP - https://github.com/OFBizCI/ldap
* Passport - https://github.com/OFBizCI/passport

All straight from trunk.


was (Author: pfm.smits):
Hi [~shi.jinghai],

The following components are already available on github:
* Solr - https://github.com/OFBizCI/solr
* LDAP - https://github.com/OFBizCI/ldap
* Passport - https://github.com/OFBizCI/passport

All straight from trunk.

> Add a PriCat component under specialpurpose
> ---
>
> Key: OFBIZ-9123
> URL: https://issues.apache.org/jira/browse/OFBIZ-9123
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Trivial
> Fix For: Trunk
>
>
> Add a PriCat component to view excel import with html report and download 
> excel output with errors commented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose

2016-12-08 Thread Pierre Smits (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731949#comment-15731949
 ] 

Pierre Smits commented on OFBIZ-9123:
-

Hi [~shi.jinghai],

The following components are already available on github:
* Solr - https://github.com/OFBizCI/solr
* LDAP - https://github.com/OFBizCI/ldap
* Passport - https://github.com/OFBizCI/passport

All straight from trunk.

> Add a PriCat component under specialpurpose
> ---
>
> Key: OFBIZ-9123
> URL: https://issues.apache.org/jira/browse/OFBIZ-9123
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Trivial
> Fix For: Trunk
>
>
> Add a PriCat component to view excel import with html report and download 
> excel output with errors commented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose

2016-12-08 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731930#comment-15731930
 ] 

Shi Jinghai commented on OFBIZ-9123:


Ha, finally I got the feeling of what you are worrying about. When plugin done, 
I can take back the LDAP, Passport, Pricat and Solr components, move them to 
github. :)

> Add a PriCat component under specialpurpose
> ---
>
> Key: OFBIZ-9123
> URL: https://issues.apache.org/jira/browse/OFBIZ-9123
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Trivial
> Fix For: Trunk
>
>
> Add a PriCat component to view excel import with html report and download 
> excel output with errors commented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose

2016-12-08 Thread Pierre Smits (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731925#comment-15731925
 ] 

Pierre Smits commented on OFBIZ-9123:
-

Huh?

Committers are required to commit changes for the various OFBiz products

> Add a PriCat component under specialpurpose
> ---
>
> Key: OFBIZ-9123
> URL: https://issues.apache.org/jira/browse/OFBIZ-9123
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Trivial
> Fix For: Trunk
>
>
> Add a PriCat component to view excel import with html report and download 
> excel output with errors commented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose

2016-12-08 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731880#comment-15731880
 ] 

Jacques Le Roux commented on OFBIZ-9123:


Just for what is already OOTB, like pricat in specialpurpose. So would be all 
or most of specialpurpose components. They would be available as plugins and 
not in the svn repo. They would be maintained by their contributors. It opens 
more possibilities for contributors wanting to donate their code to OFBiz while 
not putting all the burden on the committers shoulders once donated. More an 
idea still needing discussion for now...

> Add a PriCat component under specialpurpose
> ---
>
> Key: OFBIZ-9123
> URL: https://issues.apache.org/jira/browse/OFBIZ-9123
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Trivial
> Fix For: Trunk
>
>
> Add a PriCat component to view excel import with html report and download 
> excel output with errors commented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose

2016-12-08 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731872#comment-15731872
 ] 

Jacques Le Roux commented on OFBIZ-9123:


Thanks for the explanation Jinghai. So let's wait Microsoft :)

> Add a PriCat component under specialpurpose
> ---
>
> Key: OFBIZ-9123
> URL: https://issues.apache.org/jira/browse/OFBIZ-9123
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Trivial
> Fix For: Trunk
>
>
> Add a PriCat component to view excel import with html report and download 
> excel output with errors commented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-7402) Catalog : Showing error when duplicating product

2016-12-08 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit closed OFBIZ-7402.
---
   Resolution: Fixed
Fix Version/s: (was: Trunk)
   Upcoming Release

> Catalog : Showing error when duplicating product
> 
>
> Key: OFBIZ-7402
> URL: https://issues.apache.org/jira/browse/OFBIZ-7402
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Padmavati Rawat
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: Error in Duplicate Product.png
>
>
> Steps: 
> 1. Navigate on Catalog, and Create New Product.
> 2. Fill all required details and click on update product.
> 3. Duplicate Product section will open with updated product.
> 4. Click on Duplicate button.
> Actual : Not able to duplicate product in Catalog. It generates a non user 
> friendly error message. 
> Expected : Error message should be user friendly, and should be fixed if 
> there is any issue. 
> {code}
> Error message : 
> The Following Errors Occurred:
> Exception thrown while creating the "newProduct" GenericValue: 
> org.ofbiz.entity.GenericEntityException: Error while inserting: 
> [GenericEntity:Product][amountUomTypeId,null()][autoCreateKeywords,null()][billOfMaterialLevel,0(java.lang.Long)][brandName,null()][chargeShipping,null()][comments,null()][configId,null()][createdByUserLogin,admin(java.lang.String)][createdDate,2016-06-18
>  16:44:17.857(java.sql.Timestamp)][createdStamp,2016-06-18 
> 16:48:03.861(java.sql.Timestamp)][createdTxStamp,2016-06-18 
> 16:48:03.718(java.sql.Timestamp)][defaultShipmentBoxTypeId,null()][depthUomId,null()][description,null()][detailImageUrl,null()][detailScreen,null()][diameterUomId,null()][facilityId,null()][fixedAmount,null()][heightUomId,null()][inShippingBox,N(java.lang.String)][includeInPromotions,null()][internalName,New
>  
> Product(java.lang.String)][introductionDate,null()][inventoryItemTypeId,NON_SERIAL_INV_ITEM(java.lang.String)][inventoryMessage,null()][isVariant,N(java.lang.String)][isVirtual,N(java.lang.String)][largeImageUrl,null()][lastModifiedByUserLogin,admin(java.lang.String)][lastModifiedDate,2016-06-18
>  16:44:17.857(java.sql.Timestamp)][lastUpdatedStamp,2016-06-18 
> 16:48:03.861(java.sql.Timestamp)][lastUpdatedTxStamp,2016-06-18 
> 16:48:03.718(java.sql.Timestamp)][longDescription,null()][lotIdFilledIn,Allowed(java.lang.String)][manufacturerPartyId,null()][mediumImageUrl,null()][orderDecimalQuantity,null()][originGeoId,null()][originalImageUrl,null()][piecesIncluded,null()][priceDetailText,null()][primaryProductCategoryId,null()][productDepth,null()][productDiameter,null()][productHeight,null()][productId,10005(java.lang.String)][productName,null()][productRating,null()][productTypeId,FINISHED_GOOD(java.lang.String)][productWeight,null()][productWidth,null()][quantityIncluded,null()][quantityUomId,null()][ratingTypeEnum,null()][releaseDate,null()][requireAmount,null()][requireInventory,null()][requirementMethodEnumId,null()][reserv2ndPPPerc,null()][reservMaxPersons,null()][reservNthPPPerc,null()][returnable,null()][salesDiscWhenNotAvail,null()][salesDiscontinuationDate,null()][shippingDepth,null()][shippingHeight,null()][shippingWeight,null()][shippingWidth,null()][smallImageUrl,null()][supportDiscontinuationDate,null()][taxable,null()][virtualVariantMethodEnum,null()][weightUomId,null()][widthUomId,null()]
>  (SQL Exception while executing the following:INSERT INTO OFBIZ.PRODUCT 
> (PRODUCT_ID, PRODUCT_TYPE_ID, PRIMARY_PRODUCT_CATEGORY_ID, 
> MANUFACTURER_PARTY_ID, FACILITY_ID, INTRODUCTION_DATE, RELEASE_DATE, 
> SUPPORT_DISCONTINUATION_DATE, SALES_DISCONTINUATION_DATE, 
> SALES_DISC_WHEN_NOT_AVAIL, INTERNAL_NAME, BRAND_NAME, COMMENTS, PRODUCT_NAME, 
> DESCRIPTION, LONG_DESCRIPTION, PRICE_DETAIL_TEXT, 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7402) Catalog : Showing error when duplicating product

2016-12-08 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731859#comment-15731859
 ] 

Deepak Dixit commented on OFBIZ-7402:
-

Converted ticket type from bug to improvement as its an improvement.

This has been committed at trunk at r#1773213

Thanks Arvind and Padma for your contribution 

> Catalog : Showing error when duplicating product
> 
>
> Key: OFBIZ-7402
> URL: https://issues.apache.org/jira/browse/OFBIZ-7402
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Padmavati Rawat
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: Trunk
>
> Attachments: Error in Duplicate Product.png
>
>
> Steps: 
> 1. Navigate on Catalog, and Create New Product.
> 2. Fill all required details and click on update product.
> 3. Duplicate Product section will open with updated product.
> 4. Click on Duplicate button.
> Actual : Not able to duplicate product in Catalog. It generates a non user 
> friendly error message. 
> Expected : Error message should be user friendly, and should be fixed if 
> there is any issue. 
> {code}
> Error message : 
> The Following Errors Occurred:
> Exception thrown while creating the "newProduct" GenericValue: 
> org.ofbiz.entity.GenericEntityException: Error while inserting: 
> [GenericEntity:Product][amountUomTypeId,null()][autoCreateKeywords,null()][billOfMaterialLevel,0(java.lang.Long)][brandName,null()][chargeShipping,null()][comments,null()][configId,null()][createdByUserLogin,admin(java.lang.String)][createdDate,2016-06-18
>  16:44:17.857(java.sql.Timestamp)][createdStamp,2016-06-18 
> 16:48:03.861(java.sql.Timestamp)][createdTxStamp,2016-06-18 
> 16:48:03.718(java.sql.Timestamp)][defaultShipmentBoxTypeId,null()][depthUomId,null()][description,null()][detailImageUrl,null()][detailScreen,null()][diameterUomId,null()][facilityId,null()][fixedAmount,null()][heightUomId,null()][inShippingBox,N(java.lang.String)][includeInPromotions,null()][internalName,New
>  
> Product(java.lang.String)][introductionDate,null()][inventoryItemTypeId,NON_SERIAL_INV_ITEM(java.lang.String)][inventoryMessage,null()][isVariant,N(java.lang.String)][isVirtual,N(java.lang.String)][largeImageUrl,null()][lastModifiedByUserLogin,admin(java.lang.String)][lastModifiedDate,2016-06-18
>  16:44:17.857(java.sql.Timestamp)][lastUpdatedStamp,2016-06-18 
> 16:48:03.861(java.sql.Timestamp)][lastUpdatedTxStamp,2016-06-18 
> 16:48:03.718(java.sql.Timestamp)][longDescription,null()][lotIdFilledIn,Allowed(java.lang.String)][manufacturerPartyId,null()][mediumImageUrl,null()][orderDecimalQuantity,null()][originGeoId,null()][originalImageUrl,null()][piecesIncluded,null()][priceDetailText,null()][primaryProductCategoryId,null()][productDepth,null()][productDiameter,null()][productHeight,null()][productId,10005(java.lang.String)][productName,null()][productRating,null()][productTypeId,FINISHED_GOOD(java.lang.String)][productWeight,null()][productWidth,null()][quantityIncluded,null()][quantityUomId,null()][ratingTypeEnum,null()][releaseDate,null()][requireAmount,null()][requireInventory,null()][requirementMethodEnumId,null()][reserv2ndPPPerc,null()][reservMaxPersons,null()][reservNthPPPerc,null()][returnable,null()][salesDiscWhenNotAvail,null()][salesDiscontinuationDate,null()][shippingDepth,null()][shippingHeight,null()][shippingWeight,null()][shippingWidth,null()][smallImageUrl,null()][supportDiscontinuationDate,null()][taxable,null()][virtualVariantMethodEnum,null()][weightUomId,null()][widthUomId,null()]
>  (SQL Exception while executing the following:INSERT INTO OFBIZ.PRODUCT 
> (PRODUCT_ID, PRODUCT_TYPE_ID, PRIMARY_PRODUCT_CATEGORY_ID, 
> MANUFACTURER_PARTY_ID, FACILITY_ID, INTRODUCTION_DATE, RELEASE_DATE, 
> SUPPORT_DISCONTINUATION_DATE, SALES_DISCONTINUATION_DATE, 
> SALES_DISC_WHEN_NOT_AVAIL, INTERNAL_NAME, BRAND_NAME, COMMENTS, PRODUCT_NAME, 
> DESCRIPTION, LONG_DESCRIPTION, PRICE_DETAIL_TEXT, 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7402) Catalog : Showing error when duplicating product

2016-12-08 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-7402:

Issue Type: Improvement  (was: Bug)

> Catalog : Showing error when duplicating product
> 
>
> Key: OFBIZ-7402
> URL: https://issues.apache.org/jira/browse/OFBIZ-7402
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Padmavati Rawat
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: Trunk
>
> Attachments: Error in Duplicate Product.png
>
>
> Steps: 
> 1. Navigate on Catalog, and Create New Product.
> 2. Fill all required details and click on update product.
> 3. Duplicate Product section will open with updated product.
> 4. Click on Duplicate button.
> Actual : Not able to duplicate product in Catalog. It generates a non user 
> friendly error message. 
> Expected : Error message should be user friendly, and should be fixed if 
> there is any issue. 
> {code}
> Error message : 
> The Following Errors Occurred:
> Exception thrown while creating the "newProduct" GenericValue: 
> org.ofbiz.entity.GenericEntityException: Error while inserting: 
> [GenericEntity:Product][amountUomTypeId,null()][autoCreateKeywords,null()][billOfMaterialLevel,0(java.lang.Long)][brandName,null()][chargeShipping,null()][comments,null()][configId,null()][createdByUserLogin,admin(java.lang.String)][createdDate,2016-06-18
>  16:44:17.857(java.sql.Timestamp)][createdStamp,2016-06-18 
> 16:48:03.861(java.sql.Timestamp)][createdTxStamp,2016-06-18 
> 16:48:03.718(java.sql.Timestamp)][defaultShipmentBoxTypeId,null()][depthUomId,null()][description,null()][detailImageUrl,null()][detailScreen,null()][diameterUomId,null()][facilityId,null()][fixedAmount,null()][heightUomId,null()][inShippingBox,N(java.lang.String)][includeInPromotions,null()][internalName,New
>  
> Product(java.lang.String)][introductionDate,null()][inventoryItemTypeId,NON_SERIAL_INV_ITEM(java.lang.String)][inventoryMessage,null()][isVariant,N(java.lang.String)][isVirtual,N(java.lang.String)][largeImageUrl,null()][lastModifiedByUserLogin,admin(java.lang.String)][lastModifiedDate,2016-06-18
>  16:44:17.857(java.sql.Timestamp)][lastUpdatedStamp,2016-06-18 
> 16:48:03.861(java.sql.Timestamp)][lastUpdatedTxStamp,2016-06-18 
> 16:48:03.718(java.sql.Timestamp)][longDescription,null()][lotIdFilledIn,Allowed(java.lang.String)][manufacturerPartyId,null()][mediumImageUrl,null()][orderDecimalQuantity,null()][originGeoId,null()][originalImageUrl,null()][piecesIncluded,null()][priceDetailText,null()][primaryProductCategoryId,null()][productDepth,null()][productDiameter,null()][productHeight,null()][productId,10005(java.lang.String)][productName,null()][productRating,null()][productTypeId,FINISHED_GOOD(java.lang.String)][productWeight,null()][productWidth,null()][quantityIncluded,null()][quantityUomId,null()][ratingTypeEnum,null()][releaseDate,null()][requireAmount,null()][requireInventory,null()][requirementMethodEnumId,null()][reserv2ndPPPerc,null()][reservMaxPersons,null()][reservNthPPPerc,null()][returnable,null()][salesDiscWhenNotAvail,null()][salesDiscontinuationDate,null()][shippingDepth,null()][shippingHeight,null()][shippingWeight,null()][shippingWidth,null()][smallImageUrl,null()][supportDiscontinuationDate,null()][taxable,null()][virtualVariantMethodEnum,null()][weightUomId,null()][widthUomId,null()]
>  (SQL Exception while executing the following:INSERT INTO OFBIZ.PRODUCT 
> (PRODUCT_ID, PRODUCT_TYPE_ID, PRIMARY_PRODUCT_CATEGORY_ID, 
> MANUFACTURER_PARTY_ID, FACILITY_ID, INTRODUCTION_DATE, RELEASE_DATE, 
> SUPPORT_DISCONTINUATION_DATE, SALES_DISCONTINUATION_DATE, 
> SALES_DISC_WHEN_NOT_AVAIL, INTERNAL_NAME, BRAND_NAME, COMMENTS, PRODUCT_NAME, 
> DESCRIPTION, LONG_DESCRIPTION, PRICE_DETAIL_TEXT, 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7402) Catalog : Showing error when duplicating product

2016-12-08 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-7402:

Priority: Minor  (was: Major)

> Catalog : Showing error when duplicating product
> 
>
> Key: OFBIZ-7402
> URL: https://issues.apache.org/jira/browse/OFBIZ-7402
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Padmavati Rawat
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: Trunk
>
> Attachments: Error in Duplicate Product.png
>
>
> Steps: 
> 1. Navigate on Catalog, and Create New Product.
> 2. Fill all required details and click on update product.
> 3. Duplicate Product section will open with updated product.
> 4. Click on Duplicate button.
> Actual : Not able to duplicate product in Catalog. It generates a non user 
> friendly error message. 
> Expected : Error message should be user friendly, and should be fixed if 
> there is any issue. 
> {code}
> Error message : 
> The Following Errors Occurred:
> Exception thrown while creating the "newProduct" GenericValue: 
> org.ofbiz.entity.GenericEntityException: Error while inserting: 
> [GenericEntity:Product][amountUomTypeId,null()][autoCreateKeywords,null()][billOfMaterialLevel,0(java.lang.Long)][brandName,null()][chargeShipping,null()][comments,null()][configId,null()][createdByUserLogin,admin(java.lang.String)][createdDate,2016-06-18
>  16:44:17.857(java.sql.Timestamp)][createdStamp,2016-06-18 
> 16:48:03.861(java.sql.Timestamp)][createdTxStamp,2016-06-18 
> 16:48:03.718(java.sql.Timestamp)][defaultShipmentBoxTypeId,null()][depthUomId,null()][description,null()][detailImageUrl,null()][detailScreen,null()][diameterUomId,null()][facilityId,null()][fixedAmount,null()][heightUomId,null()][inShippingBox,N(java.lang.String)][includeInPromotions,null()][internalName,New
>  
> Product(java.lang.String)][introductionDate,null()][inventoryItemTypeId,NON_SERIAL_INV_ITEM(java.lang.String)][inventoryMessage,null()][isVariant,N(java.lang.String)][isVirtual,N(java.lang.String)][largeImageUrl,null()][lastModifiedByUserLogin,admin(java.lang.String)][lastModifiedDate,2016-06-18
>  16:44:17.857(java.sql.Timestamp)][lastUpdatedStamp,2016-06-18 
> 16:48:03.861(java.sql.Timestamp)][lastUpdatedTxStamp,2016-06-18 
> 16:48:03.718(java.sql.Timestamp)][longDescription,null()][lotIdFilledIn,Allowed(java.lang.String)][manufacturerPartyId,null()][mediumImageUrl,null()][orderDecimalQuantity,null()][originGeoId,null()][originalImageUrl,null()][piecesIncluded,null()][priceDetailText,null()][primaryProductCategoryId,null()][productDepth,null()][productDiameter,null()][productHeight,null()][productId,10005(java.lang.String)][productName,null()][productRating,null()][productTypeId,FINISHED_GOOD(java.lang.String)][productWeight,null()][productWidth,null()][quantityIncluded,null()][quantityUomId,null()][ratingTypeEnum,null()][releaseDate,null()][requireAmount,null()][requireInventory,null()][requirementMethodEnumId,null()][reserv2ndPPPerc,null()][reservMaxPersons,null()][reservNthPPPerc,null()][returnable,null()][salesDiscWhenNotAvail,null()][salesDiscontinuationDate,null()][shippingDepth,null()][shippingHeight,null()][shippingWeight,null()][shippingWidth,null()][smallImageUrl,null()][supportDiscontinuationDate,null()][taxable,null()][virtualVariantMethodEnum,null()][weightUomId,null()][widthUomId,null()]
>  (SQL Exception while executing the following:INSERT INTO OFBIZ.PRODUCT 
> (PRODUCT_ID, PRODUCT_TYPE_ID, PRIMARY_PRODUCT_CATEGORY_ID, 
> MANUFACTURER_PARTY_ID, FACILITY_ID, INTRODUCTION_DATE, RELEASE_DATE, 
> SUPPORT_DISCONTINUATION_DATE, SALES_DISCONTINUATION_DATE, 
> SALES_DISC_WHEN_NOT_AVAIL, INTERNAL_NAME, BRAND_NAME, COMMENTS, PRODUCT_NAME, 
> DESCRIPTION, LONG_DESCRIPTION, PRICE_DETAIL_TEXT, 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-7402) Catalog : Showing error when duplicating product

2016-12-08 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit reassigned OFBIZ-7402:
---

Assignee: Deepak Dixit  (was: Arvind Singh Tomar)

> Catalog : Showing error when duplicating product
> 
>
> Key: OFBIZ-7402
> URL: https://issues.apache.org/jira/browse/OFBIZ-7402
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Padmavati Rawat
>Assignee: Deepak Dixit
> Fix For: Trunk
>
> Attachments: Error in Duplicate Product.png
>
>
> Steps: 
> 1. Navigate on Catalog, and Create New Product.
> 2. Fill all required details and click on update product.
> 3. Duplicate Product section will open with updated product.
> 4. Click on Duplicate button.
> Actual : Not able to duplicate product in Catalog. It generates a non user 
> friendly error message. 
> Expected : Error message should be user friendly, and should be fixed if 
> there is any issue. 
> {code}
> Error message : 
> The Following Errors Occurred:
> Exception thrown while creating the "newProduct" GenericValue: 
> org.ofbiz.entity.GenericEntityException: Error while inserting: 
> [GenericEntity:Product][amountUomTypeId,null()][autoCreateKeywords,null()][billOfMaterialLevel,0(java.lang.Long)][brandName,null()][chargeShipping,null()][comments,null()][configId,null()][createdByUserLogin,admin(java.lang.String)][createdDate,2016-06-18
>  16:44:17.857(java.sql.Timestamp)][createdStamp,2016-06-18 
> 16:48:03.861(java.sql.Timestamp)][createdTxStamp,2016-06-18 
> 16:48:03.718(java.sql.Timestamp)][defaultShipmentBoxTypeId,null()][depthUomId,null()][description,null()][detailImageUrl,null()][detailScreen,null()][diameterUomId,null()][facilityId,null()][fixedAmount,null()][heightUomId,null()][inShippingBox,N(java.lang.String)][includeInPromotions,null()][internalName,New
>  
> Product(java.lang.String)][introductionDate,null()][inventoryItemTypeId,NON_SERIAL_INV_ITEM(java.lang.String)][inventoryMessage,null()][isVariant,N(java.lang.String)][isVirtual,N(java.lang.String)][largeImageUrl,null()][lastModifiedByUserLogin,admin(java.lang.String)][lastModifiedDate,2016-06-18
>  16:44:17.857(java.sql.Timestamp)][lastUpdatedStamp,2016-06-18 
> 16:48:03.861(java.sql.Timestamp)][lastUpdatedTxStamp,2016-06-18 
> 16:48:03.718(java.sql.Timestamp)][longDescription,null()][lotIdFilledIn,Allowed(java.lang.String)][manufacturerPartyId,null()][mediumImageUrl,null()][orderDecimalQuantity,null()][originGeoId,null()][originalImageUrl,null()][piecesIncluded,null()][priceDetailText,null()][primaryProductCategoryId,null()][productDepth,null()][productDiameter,null()][productHeight,null()][productId,10005(java.lang.String)][productName,null()][productRating,null()][productTypeId,FINISHED_GOOD(java.lang.String)][productWeight,null()][productWidth,null()][quantityIncluded,null()][quantityUomId,null()][ratingTypeEnum,null()][releaseDate,null()][requireAmount,null()][requireInventory,null()][requirementMethodEnumId,null()][reserv2ndPPPerc,null()][reservMaxPersons,null()][reservNthPPPerc,null()][returnable,null()][salesDiscWhenNotAvail,null()][salesDiscontinuationDate,null()][shippingDepth,null()][shippingHeight,null()][shippingWeight,null()][shippingWidth,null()][smallImageUrl,null()][supportDiscontinuationDate,null()][taxable,null()][virtualVariantMethodEnum,null()][weightUomId,null()][widthUomId,null()]
>  (SQL Exception while executing the following:INSERT INTO OFBIZ.PRODUCT 
> (PRODUCT_ID, PRODUCT_TYPE_ID, PRIMARY_PRODUCT_CATEGORY_ID, 
> MANUFACTURER_PARTY_ID, FACILITY_ID, INTRODUCTION_DATE, RELEASE_DATE, 
> SUPPORT_DISCONTINUATION_DATE, SALES_DISCONTINUATION_DATE, 
> SALES_DISC_WHEN_NOT_AVAIL, INTERNAL_NAME, BRAND_NAME, COMMENTS, PRODUCT_NAME, 
> DESCRIPTION, LONG_DESCRIPTION, PRICE_DETAIL_TEXT, 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7161) set field not correct, when it type is BigDecimal and value is minus, in simple-method cancelReceivedItems (ShipmentReceiptServices.xml)

2016-12-08 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731824#comment-15731824
 ] 

Deepak Dixit commented on OFBIZ-7161:
-

Closing this issue as this has been fixed under OFBIZ-7943

> set field  not correct, when it type is BigDecimal and value is minus, in 
> simple-method cancelReceivedItems  (ShipmentReceiptServices.xml)
> --
>
> Key: OFBIZ-7161
> URL: https://issues.apache.org/jira/browse/OFBIZ-7161
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07
> Environment: Debian(testing) + oracleJDK(v1.8.0_92)
>Reporter: dalater
>
> ..
> 
>  value="${-1 * inventoryItem.availableToPromiseTotal}" type="BigDecimal"/>
>  in-map-name="inventoryItemDetailMap"/>
> ..
> when serialized item be  canceled, set field result is always  1,  not -1
> simple-method cancelReceivedItems  in file ShipmentReceiptServices.xml



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-7161) set field not correct, when it type is BigDecimal and value is minus, in simple-method cancelReceivedItems (ShipmentReceiptServices.xml)

2016-12-08 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit closed OFBIZ-7161.
---
Resolution: Duplicate

> set field  not correct, when it type is BigDecimal and value is minus, in 
> simple-method cancelReceivedItems  (ShipmentReceiptServices.xml)
> --
>
> Key: OFBIZ-7161
> URL: https://issues.apache.org/jira/browse/OFBIZ-7161
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07
> Environment: Debian(testing) + oracleJDK(v1.8.0_92)
>Reporter: dalater
>
> ..
> 
>  value="${-1 * inventoryItem.availableToPromiseTotal}" type="BigDecimal"/>
>  in-map-name="inventoryItemDetailMap"/>
> ..
> when serialized item be  canceled, set field result is always  1,  not -1
> simple-method cancelReceivedItems  in file ShipmentReceiptServices.xml



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose

2016-12-08 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731687#comment-15731687
 ] 

Shi Jinghai commented on OFBIZ-9123:


Hi Jacques,

Here's the test case on OFBizPricatUtil:
1. Import the sample pricat file and download it;
2. Comment out the OFBizPricatUtil.formatCommentShape method used in pricat;
3. Rebuild and import the sample pricat file;
4. Download the commented pricat file;
5. Open it in Microsoft Excel, the style of comments is not readable.
6. Open it in OpenOffice or WPS, the style of comments is correct.

Unzip the commented pricat file (.xlsx), compare the files with/without running 
OFBizPricatUtil.formatCommentShape, the difference is in 
xl/drawings/vmlDrawing1.vml file. According to POI document:

In Excel 2007 VML drawings are used to describe properties of cell comments, 
although the spec says that VML is deprecated:
The VML format is a legacy format originally introduced with Office 2000 and is 
included and fully defined in this Standard for backwards compatibility 
reasons. The DrawingML format is a newer and richer format created with the 
goal of eventually replacing any uses of VML in the Office Open XML formats. 
VML should be considered a deprecated format included in Office Open XML for 
legacy reasons only and new applications that need a file format for drawings 
are strongly encouraged to use preferentially DrawingML

Warning - Excel is known to put invalid XML into these files! For example, >br< 
without being closed or escaped crops up.
See 6.4 VML - SpreadsheetML Drawing in Office Open XML Part 4 - Markup Language 
Reference.pdf


By putting OFBizPricatUtil under POI path, I can call the protected method 
XSSFVMLDrawing.findCommentShape and build the comments look right in Microsoft 
Excel.

This is the reason. I'm sure there's a better way to do this.

Kind Regards,

> Add a PriCat component under specialpurpose
> ---
>
> Key: OFBIZ-9123
> URL: https://issues.apache.org/jira/browse/OFBIZ-9123
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Trivial
> Fix For: Trunk
>
>
> Add a PriCat component to view excel import with html report and download 
> excel output with errors commented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8343) Make data type field length of id fields accept guid ids

2016-12-08 Thread Pierre Smits (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731613#comment-15731613
 ] 

Pierre Smits commented on OFBIZ-8343:
-

Ping?!

> Make data type field length of id fields accept guid ids
> 
>
> Key: OFBIZ-8343
> URL: https://issues.apache.org/jira/browse/OFBIZ-8343
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
> Attachments: OFBIZ-8343-fieldtype-36.patch, OFBIZ-8343-fieldtype.patch
>
>
> Currently the length of id fields is limited to 20 characters. In order for 
> these fields to accept GUIIDs the length should be increased to 32 characters.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OFBIZ-9123) Add a PriCat component under specialpurpose

2016-12-08 Thread Pierre Smits (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731577#comment-15731577
 ] 

Pierre Smits edited comment on OFBIZ-9123 at 12/8/16 8:53 AM:
--

Jacques,

I wonder what it is that you want to have the project having control over.




was (Author: pfm.smits):
Jacques,

I wonder where you want to have the project having control over.



> Add a PriCat component under specialpurpose
> ---
>
> Key: OFBIZ-9123
> URL: https://issues.apache.org/jira/browse/OFBIZ-9123
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Trivial
> Fix For: Trunk
>
>
> Add a PriCat component to view excel import with html report and download 
> excel output with errors commented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose

2016-12-08 Thread Pierre Smits (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731581#comment-15731581
 ] 

Pierre Smits commented on OFBIZ-9123:
-

Following up on this the freemarker templates are not in the correct place. As 
per recently revisited best practices these should not reside in the WEB-INF 
sub folder.

> Add a PriCat component under specialpurpose
> ---
>
> Key: OFBIZ-9123
> URL: https://issues.apache.org/jira/browse/OFBIZ-9123
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Trivial
> Fix For: Trunk
>
>
> Add a PriCat component to view excel import with html report and download 
> excel output with errors commented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose

2016-12-08 Thread Pierre Smits (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731577#comment-15731577
 ] 

Pierre Smits commented on OFBIZ-9123:
-

Jacques,

I wonder where you want to have the project having control over.



> Add a PriCat component under specialpurpose
> ---
>
> Key: OFBIZ-9123
> URL: https://issues.apache.org/jira/browse/OFBIZ-9123
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Trivial
> Fix For: Trunk
>
>
> Add a PriCat component to view excel import with html report and download 
> excel output with errors commented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose

2016-12-08 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731560#comment-15731560
 ] 

Jacques Le Roux commented on OFBIZ-9123:


Hi Jinghai,

IIRW it has been already discussed but I can't find where (maybe in HipChat 
where history is not the best part). Could you please refresh my mind about why 
OFBizPricatUtil class must be in org.apache.poi.xssf.usermodel package? Thanks 
:)

> Add a PriCat component under specialpurpose
> ---
>
> Key: OFBIZ-9123
> URL: https://issues.apache.org/jira/browse/OFBIZ-9123
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Trivial
> Fix For: Trunk
>
>
> Add a PriCat component to view excel import with html report and download 
> excel output with errors commented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)