[jira] [Commented] (OFBIZ-8343) Make data type field length of id fields accept guid ids

2017-01-09 Thread Scott Gray (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15812828#comment-15812828
 ] 

Scott Gray commented on OFBIZ-8343:
---

Hi Pierre,

If you get an opportunity could you please respond to the doubts I posted 
above?  Alternatively if you're no longer interested in this topic please let 
us know so we can close the ticket.

Many thanks
Scott

> Make data type field length of id fields accept guid ids
> 
>
> Key: OFBIZ-8343
> URL: https://issues.apache.org/jira/browse/OFBIZ-8343
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
> Attachments: OFBIZ-8343-fieldtype-36.patch, OFBIZ-8343-fieldtype.patch
>
>
> Currently the length of id fields is limited to 20 characters. In order for 
> these fields to accept GUIIDs the length should be increased to 32 characters.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1

2017-01-09 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15811952#comment-15811952
 ] 

Shi Jinghai commented on OFBIZ-8316:


Hi Jacques,

On the errors you found, I tested locally and checked our production system, an 
absolute path configed in dataDir of solrconfig.xml would work fine, i.e.

for Windows:
D:/workspaces/OFBiz/ofbiz/runtime/indexes/

for Linux:
/opt/ofbiz/runtime/indexes/

The product index can be loaded correctly and the tlog folder will be under 
runtime/indexes/ as expected.

Kind Regards,

> Update Apache Solr/Lucene to release 6.2.1
> --
>
> Key: OFBIZ-8316
> URL: https://issues.apache.org/jira/browse/OFBIZ-8316
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/lucene, specialpurpose/solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-8316_corrected.patch, 
> ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch
>
>
> According to the announcements in 
> https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E
>  and 
> https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E
>  there is a new Solr/Lucene release available.
> This issue takes care of the update.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1

2017-01-09 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15811930#comment-15811930
 ] 

Shi Jinghai commented on OFBIZ-8316:


Unfortunately, I'm a human and programmer, I write codes everyday, and bugs 
everyday.

> Update Apache Solr/Lucene to release 6.2.1
> --
>
> Key: OFBIZ-8316
> URL: https://issues.apache.org/jira/browse/OFBIZ-8316
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/lucene, specialpurpose/solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-8316_corrected.patch, 
> ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch
>
>
> According to the announcements in 
> https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E
>  and 
> https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E
>  there is a new Solr/Lucene release available.
> This issue takes care of the update.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1

2017-01-09 Thread Michael Brohl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15811792#comment-15811792
 ] 

Michael Brohl commented on OFBIZ-8316:
--

Hi [~shi.jinghai],

thanks for your response.

What I was trying to say is that we should, at least for the future, prepare 
and check everything before committing to the codebase. 
Every contribution is much appreciated but even if trunk is not stable, we 
should avoid any inconsistencies or half done code going into the codebase.

Thanks and regards,

Michael

> Update Apache Solr/Lucene to release 6.2.1
> --
>
> Key: OFBIZ-8316
> URL: https://issues.apache.org/jira/browse/OFBIZ-8316
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/lucene, specialpurpose/solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-8316_corrected.patch, 
> ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch
>
>
> According to the announcements in 
> https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E
>  and 
> https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E
>  there is a new Solr/Lucene release available.
> This issue takes care of the update.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1

2017-01-09 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15811768#comment-15811768
 ] 

Shi Jinghai commented on OFBIZ-8316:


Hi Michael,

Thanks for the reminding! Really appreciate it.

I didn't notice the errors Jacques found, now I find it while visiting 
https://ofbiz-vm2.apache.org:8443/solr/, I'm sure it's a problem of dataDir in 
solrconfig.xml. I'm fixing it.

I have asked PengAn to submit a patch to remove the deprecated UI files 
tomorrow, and he promised me OK. If the patch come, we can keep . :)

Kind Regards,

> Update Apache Solr/Lucene to release 6.2.1
> --
>
> Key: OFBIZ-8316
> URL: https://issues.apache.org/jira/browse/OFBIZ-8316
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/lucene, specialpurpose/solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-8316_corrected.patch, 
> ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch
>
>
> According to the announcements in 
> https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E
>  and 
> https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E
>  there is a new Solr/Lucene release available.
> This issue takes care of the update.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-9169) Make xssi prefix configurable

2017-01-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15811226#comment-15811226
 ] 

Jacques Le Roux commented on OFBIZ-9169:


Pierre, I see no reasons to make this issue a subtask of OFBIZ-6164. 

The main change here is not "configurability of OFBiz regarding multi-tenancy" 
it's only a by product. If we do so with similar issues we will end with a lot 
of issues under OFBIZ-6164 which are not primarily related to OFBIZ-6164. So 
please revert to an improvment. Else I'll ask on dev ML what others think, 
thanks.

BTW in 1st place you should have asked Chris and I about what we thought about 
a such change!


> Make xssi prefix configurable
> -
>
> Key: OFBIZ-9169
> URL: https://issues.apache.org/jira/browse/OFBIZ-9169
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Chris Howe
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: xssiPrefix.patch
>
>
> In OFBIZ-5409 a prefix was added for GET ajax requests.  
> It would be beneficial if the prefix could be configured instead of hard coded



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-9169) Make xssi prefix configurable

2017-01-09 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-9169:

Issue Type: Sub-task  (was: Improvement)
Parent: OFBIZ-6164

> Make xssi prefix configurable
> -
>
> Key: OFBIZ-9169
> URL: https://issues.apache.org/jira/browse/OFBIZ-9169
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Chris Howe
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: xssiPrefix.patch
>
>
> In OFBIZ-5409 a prefix was added for GET ajax requests.  
> It would be beneficial if the prefix could be configured instead of hard coded



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-9169) Make xssi prefix configurable

2017-01-09 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-9169.
--
   Resolution: Implemented
Fix Version/s: Upcoming Release

Thanks Chris, Pierre,

Chris your modified patch on Pierre's suggestion is done at r1777942. I made 
signature and calls changes.

> Make xssi prefix configurable
> -
>
> Key: OFBIZ-9169
> URL: https://issues.apache.org/jira/browse/OFBIZ-9169
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Chris Howe
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: xssiPrefix.patch
>
>
> In OFBIZ-5409 a prefix was added for GET ajax requests.  
> It would be beneficial if the prefix could be configured instead of hard coded



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-9169) Make xssi prefix configurable

2017-01-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15811101#comment-15811101
 ] 

Jacques Le Roux commented on OFBIZ-9169:


Hi Chris, Pierre,
Chris, I'm taking care of Pierre's request...

> Make xssi prefix configurable
> -
>
> Key: OFBIZ-9169
> URL: https://issues.apache.org/jira/browse/OFBIZ-9169
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Chris Howe
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: xssiPrefix.patch
>
>
> In OFBIZ-5409 a prefix was added for GET ajax requests.  
> It would be beneficial if the prefix could be configured instead of hard coded



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1

2017-01-09 Thread Michael Brohl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15811052#comment-15811052
 ] 

Michael Brohl commented on OFBIZ-8316:
--

[~shi.jinghai],

I would prefer that you revert the commit until all issues are resolved (the 
errors Jacques reported, missing removal of obsolete UI files). In this way, 
you and other fellow contributors have time to work on them and we stay with a 
consistent codebase until we have a complete patch.

What do you think?



> Update Apache Solr/Lucene to release 6.2.1
> --
>
> Key: OFBIZ-8316
> URL: https://issues.apache.org/jira/browse/OFBIZ-8316
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/lucene, specialpurpose/solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-8316_corrected.patch, 
> ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch
>
>
> According to the announcements in 
> https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E
>  and 
> https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E
>  there is a new Solr/Lucene release available.
> This issue takes care of the update.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-9169) Make xssi prefix configurable

2017-01-09 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-9169:
--

Assignee: Jacques Le Roux

> Make xssi prefix configurable
> -
>
> Key: OFBIZ-9169
> URL: https://issues.apache.org/jira/browse/OFBIZ-9169
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Chris Howe
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: xssiPrefix.patch
>
>
> In OFBIZ-5409 a prefix was added for GET ajax requests.  
> It would be beneficial if the prefix could be configured instead of hard coded



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-9169) Make xssi prefix configurable

2017-01-09 Thread Pierre Smits (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15811010#comment-15811010
 ] 

Pierre Smits commented on OFBIZ-9169:
-

Please convert the following string
{code}String xssiPrefix = UtilProperties.getPropertyValue("general", 
"http.json.xssi.prefix", "");{code}
into
{code}String xssiPrefix =EntityUtilProperties.getPropertyValue("general", 
"http.json.xssi.prefix", delegator);{code}
to make the improvement multi-tenant aware.

> Make xssi prefix configurable
> -
>
> Key: OFBIZ-9169
> URL: https://issues.apache.org/jira/browse/OFBIZ-9169
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Chris Howe
>Priority: Minor
> Attachments: xssiPrefix.patch
>
>
> In OFBIZ-5409 a prefix was added for GET ajax requests.  
> It would be beneficial if the prefix could be configured instead of hard coded



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)